feat: Initial clean release of CHM

packages/app-desktop/integration-tests/noteList.spec.ts

@@ -0,0 +1,170 @@
+import { test, expect } from './util/test';
+import MainScreen from './models/MainScreen';
+import setMessageBoxResponse from './util/setMessageBoxResponse';
+
+test.describe('noteList', () => {
+	test('should be possible to edit notes in a different notebook when searching', async ({ mainWindow, electronApp }) => {
+		const mainScreen = await new MainScreen(mainWindow).setup();
+		const sidebar = mainScreen.sidebar;
+
+		const folderAHeader = await sidebar.createNewFolder('Folder A');
+		await expect(folderAHeader).toBeVisible();
+
+		const folderBHeader = await sidebar.createNewFolder('Folder B');
+		await expect(folderBHeader).toBeVisible();
+		await folderBHeader.click();
+
+		await mainScreen.createNewNote('note-1');
+
+		await folderAHeader.click();
+		await mainScreen.createNewNote('note-2');
+
+		// Search for and focus a note different from the folder we were in before searching.
+		await mainScreen.search('/note-1');
+		await mainScreen.noteList.focusContent(electronApp);
+		const note1Result = mainScreen.noteList.getNoteItemByTitle('note-1');
+		await expect(note1Result).toBeAttached();
+		await note1Result.click();
+
+		// Typing should not cause the note to disappear
+		const editor = mainScreen.noteEditor;
+		const markdownEditor = await editor.showMarkdownEditor();
+		await markdownEditor.typeText('[Testing...](http://example.com/)');
+
+		// Wait to render
+		const noteViewer = await editor.showNoteViewer();
+		await expect(noteViewer.content.locator('a', { hasText: 'Testing...' })).toBeVisible();
+
+		// Updating the title should force the sidebar to update sooner
+		await expect(editor.noteTitleInput).toHaveValue('note-1');
+	});
+
+	test('shift-delete should ask to permanently delete notes, but only when the note list is focused', async ({ electronApp, mainWindow }) => {
+		const mainScreen = await new MainScreen(mainWindow).setup();
+		const sidebar = mainScreen.sidebar;
+
+		const folderBHeader = await sidebar.createNewFolder('Folder B');
+		const folderAHeader = await sidebar.createNewFolder('Folder A');
+		await expect(folderAHeader).toBeVisible();
+
+		await mainScreen.createNewNote('test note 1');
+		await mainScreen.createNewNote('test note 2');
+
+		const noteList = mainScreen.noteList;
+		await noteList.focusContent(electronApp);
+		await expect(noteList.getNoteItemByTitle('test note 1')).toBeVisible();
+		await expect(noteList.getNoteItemByTitle('test note 2')).toBeVisible();
+
+		await setMessageBoxResponse(electronApp, /^Delete/i);
+
+		const pressShiftDelete = async () => {
+			await mainWindow.keyboard.press('Shift');
+			await mainWindow.keyboard.press('Delete');
+			await mainWindow.keyboard.up('Delete');
+			await mainWindow.keyboard.up('Shift');
+		};
+		await pressShiftDelete();
+		await expect(noteList.getNoteItemByTitle('test note 2')).not.toBeVisible();
+
+		// Should not delete when the editor is focused
+		const markdownEditor = await mainScreen.noteEditor.showMarkdownEditor();
+		await markdownEditor.typeText('test');
+		await pressShiftDelete();
+
+		await folderBHeader.click();
+		await folderAHeader.click();
+		await expect(noteList.getNoteItemByTitle('test note 1')).toBeVisible();
+	});
+
+	test('deleting a note to the trash should show a notification', async ({ electronApp, mainWindow }) => {
+		const mainScreen = await new MainScreen(mainWindow).setup();
+		await mainScreen.createNewNote('test note 1');
+
+		const noteList = mainScreen.noteList;
+		await noteList.focusContent(electronApp);
+		const testNoteItem = noteList.getNoteItemByTitle('test note 1');
+		await expect(testNoteItem).toBeVisible();
+
+		// Should be removed after deleting
+		await testNoteItem.press('Delete');
+		await expect(testNoteItem).not.toBeVisible();
+
+		// Should show a deleted notification
+		const notification = mainWindow.locator('[role=alert]', {
+			hasText: /The note was successfully moved to the trash./i,
+		});
+		await expect(notification).toBeVisible();
+
+		// Should be possible to un-delete
+		const undeleteButton = notification.getByRole('button', { name: 'Cancel' });
+		await undeleteButton.click();
+
+		await expect(testNoteItem).toBeVisible();
+	});
+
+	test('should remain focused after deleting a note to the trash', async ({ electronApp, mainWindow }) => {
+		const mainScreen = await new MainScreen(mainWindow).setup();
+		await mainScreen.createNewNote('test note 1');
+		await mainScreen.createNewNote('test note 2');
+		await mainScreen.createNewNote('test note 3');
+
+		const noteList = mainScreen.noteList;
+		await noteList.sortByTitle(electronApp);
+		await noteList.focusContent(electronApp);
+
+		// The most-recently created note should be selected
+		await noteList.expectNoteToBeSelected('test note 3');
+
+		// All three notes should be visible
+		const getNote = (i: number) => noteList.getNoteItemByTitle(`test note ${i}`);
+		await expect(getNote(1)).toBeVisible();
+		await expect(getNote(2)).toBeVisible();
+		await expect(getNote(3)).toBeVisible();
+
+		await getNote(3).press('Delete');
+		await expect(getNote(3)).not.toBeVisible();
+
+		// Pressing the up arrow should change the selection
+		// (Regression test for https://github.com/laurent22/joplin/issues/10753)
+		await noteList.expectNoteToBeSelected('test note 2');
+		await noteList.container.press('ArrowUp');
+		await noteList.expectNoteToBeSelected('test note 1');
+	});
+
+	test('arrow keys should navigate the note list', async ({ electronApp, mainWindow }) => {
+		const mainScreen = await new MainScreen(mainWindow).setup();
+		const sidebar = mainScreen.sidebar;
+
+		await sidebar.createNewFolder('Folder');
+
+		await mainScreen.createNewNote('note_1');
+		await mainScreen.createNewNote('note_2');
+		await mainScreen.createNewNote('note_3');
+		await mainScreen.createNewNote('note_4');
+
+		const noteList = mainScreen.noteList;
+		await noteList.sortByTitle(electronApp);
+		await noteList.focusContent(electronApp);
+
+		// The most recently-created note should be visible
+		const note4Item = noteList.getNoteItemByTitle('note_4');
+		const note3Item = noteList.getNoteItemByTitle('note_3');
+		const note2Item = noteList.getNoteItemByTitle('note_2');
+		const note1Item = noteList.getNoteItemByTitle('note_1');
+		await expect(note4Item).toBeVisible();
+		await expect(note3Item).toBeVisible();
+		await expect(note2Item).toBeVisible();
+		await expect(note1Item).toBeVisible();
+
+		await noteList.expectNoteToBeSelected('note_4');
+
+		await noteList.container.press('ArrowUp');
+		await noteList.expectNoteToBeSelected('note_3');
+
+		await noteList.container.press('ArrowUp');
+		await noteList.expectNoteToBeSelected('note_2');
+
+		await noteList.container.press('ArrowDown');
+		await noteList.expectNoteToBeSelected('note_3');
+	});
+});