{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10128", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/10128/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/10128/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/10128/events", "html_url": "https://github.com/laurent22/joplin/pull/10128", "id": 2188330656, "node_id": "PR_kwDOBLftOs5pvISc", "number": 10128, "title": "Desktop: Fixes #5943: Export Pdf shouldn't include data-urls.", "user": { "login": "7adidaz", "id": 86894852, "node_id": "MDQ6VXNlcjg2ODk0ODUy", "avatar_url": "https://avatars.githubusercontent.com/u/86894852?v=4", "gravatar_id": "", "url": "https://api.github.com/users/7adidaz", "html_url": "https://github.com/7adidaz", "followers_url": "https://api.github.com/users/7adidaz/followers", "following_url": "https://api.github.com/users/7adidaz/following{/other_user}", "gists_url": "https://api.github.com/users/7adidaz/gists{/gist_id}", "starred_url": "https://api.github.com/users/7adidaz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/7adidaz/subscriptions", "organizations_url": "https://api.github.com/users/7adidaz/orgs", "repos_url": "https://api.github.com/users/7adidaz/repos", "events_url": "https://api.github.com/users/7adidaz/events{/privacy}", "received_events_url": "https://api.github.com/users/7adidaz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 5, "created_at": "2024-03-15T11:45:27Z", "updated_at": "2024-03-27T15:26:26Z", "closed_at": "2024-03-20T11:05:05Z", "author_association": "NONE", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/10128", "html_url": "https://github.com/laurent22/joplin/pull/10128", "diff_url": "https://github.com/laurent22/joplin/pull/10128.diff", "patch_url": "https://github.com/laurent22/joplin/pull/10128.patch", "merged_at": null }, "body": "The problem arises during the conversion of a note to HTML, which is then used by `printToPDF()`. This conversion takes a note object and transforms it into HTML, including any attached files as raw data.\r\n\r\n2. Example of Embedded Link in a Note:\r\n \r\n ```MD\r\n [fileName.txt](:/xxx)\r\n ```\r\n converted to: \r\n ```html\r\n fileName.txt\r\n ```\r\n The `href` attribute contains data that, when executed in a new browser tab, opens the original file. This behavior causes issues when exporting to HTML or PDF with large attached files, resulting in very large output files.\r\n\r\nMy approach to addressing this is to remove the `href` attribute if it starts with `data:`, This won’t affect images since they are rendered using the `` tag.", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10128/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/10128/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1999486633", "html_url": "https://github.com/laurent22/joplin/pull/10128#issuecomment-1999486633", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10128", "id": 1999486633, "node_id": "IC_kwDOBLftOs53Lb6p", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-15T11:45:41Z", "updated_at": "2024-03-20T11:16:14Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1999486633/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1999489659", "html_url": "https://github.com/laurent22/joplin/pull/10128#issuecomment-1999489659", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10128", "id": 1999489659, "node_id": "IC_kwDOBLftOs53Lcp7", "user": { "login": "7adidaz", "id": 86894852, "node_id": "MDQ6VXNlcjg2ODk0ODUy", "avatar_url": "https://avatars.githubusercontent.com/u/86894852?v=4", "gravatar_id": "", "url": "https://api.github.com/users/7adidaz", "html_url": "https://github.com/7adidaz", "followers_url": "https://api.github.com/users/7adidaz/followers", "following_url": "https://api.github.com/users/7adidaz/following{/other_user}", "gists_url": "https://api.github.com/users/7adidaz/gists{/gist_id}", "starred_url": "https://api.github.com/users/7adidaz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/7adidaz/subscriptions", "organizations_url": "https://api.github.com/users/7adidaz/orgs", "repos_url": "https://api.github.com/users/7adidaz/repos", "events_url": "https://api.github.com/users/7adidaz/events{/privacy}", "received_events_url": "https://api.github.com/users/7adidaz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-15T11:47:50Z", "updated_at": "2024-03-15T11:47:50Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1999489659/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1999490153", "html_url": "https://github.com/laurent22/joplin/pull/10128#issuecomment-1999490153", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10128", "id": 1999490153, "node_id": "IC_kwDOBLftOs53Lcxp", "user": { "login": "7adidaz", "id": 86894852, "node_id": "MDQ6VXNlcjg2ODk0ODUy", "avatar_url": "https://avatars.githubusercontent.com/u/86894852?v=4", "gravatar_id": "", "url": "https://api.github.com/users/7adidaz", "html_url": "https://github.com/7adidaz", "followers_url": "https://api.github.com/users/7adidaz/followers", "following_url": "https://api.github.com/users/7adidaz/following{/other_user}", "gists_url": "https://api.github.com/users/7adidaz/gists{/gist_id}", "starred_url": "https://api.github.com/users/7adidaz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/7adidaz/subscriptions", "organizations_url": "https://api.github.com/users/7adidaz/orgs", "repos_url": "https://api.github.com/users/7adidaz/repos", "events_url": "https://api.github.com/users/7adidaz/events{/privacy}", "received_events_url": "https://api.github.com/users/7adidaz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-15T11:48:10Z", "updated_at": "2024-03-15T11:48:10Z", "author_association": "NONE", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1999490153/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2009312666", "html_url": "https://github.com/laurent22/joplin/pull/10128#issuecomment-2009312666", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10128", "id": 2009312666, "node_id": "IC_kwDOBLftOs53w62a", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-20T11:05:05Z", "updated_at": "2024-03-20T11:05:05Z", "author_association": "OWNER", "body": "I think this needs to be discussed further. There are various options and just disabling the link is not one of them", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2009312666/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2009942427", "html_url": "https://github.com/laurent22/joplin/pull/10128#issuecomment-2009942427", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10128", "id": 2009942427, "node_id": "IC_kwDOBLftOs53zUmb", "user": { "login": "7adidaz", "id": 86894852, "node_id": "MDQ6VXNlcjg2ODk0ODUy", "avatar_url": "https://avatars.githubusercontent.com/u/86894852?v=4", "gravatar_id": "", "url": "https://api.github.com/users/7adidaz", "html_url": "https://github.com/7adidaz", "followers_url": "https://api.github.com/users/7adidaz/followers", "following_url": "https://api.github.com/users/7adidaz/following{/other_user}", "gists_url": "https://api.github.com/users/7adidaz/gists{/gist_id}", "starred_url": "https://api.github.com/users/7adidaz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/7adidaz/subscriptions", "organizations_url": "https://api.github.com/users/7adidaz/orgs", "repos_url": "https://api.github.com/users/7adidaz/repos", "events_url": "https://api.github.com/users/7adidaz/events{/privacy}", "received_events_url": "https://api.github.com/users/7adidaz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-20T16:06:46Z", "updated_at": "2024-03-20T16:06:46Z", "author_association": "NONE", "body": "> discussed further\r\n\r\nI agree, Where should we discuss this more? \r\n\r\nI can implement the solution where note attachments appear as PDF attachments (not clickable like Adobe), the other approach seems non-trivial and only implemented by Adobe. ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2009942427/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }