{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11551", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11551/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11551/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11551/events", "html_url": "https://github.com/laurent22/joplin/pull/11551", "id": 2754360092, "node_id": "PR_kwDOBLftOs6F__Ty", "number": 11551, "title": "Desktop: Fixes #11538: Fixed Strikethrough text in markdown editor", "user": { "login": "ARYPROGRAMMER", "id": 75311742, "node_id": "MDQ6VXNlcjc1MzExNzQy", "avatar_url": "https://avatars.githubusercontent.com/u/75311742?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ARYPROGRAMMER", "html_url": "https://github.com/ARYPROGRAMMER", "followers_url": "https://api.github.com/users/ARYPROGRAMMER/followers", "following_url": "https://api.github.com/users/ARYPROGRAMMER/following{/other_user}", "gists_url": "https://api.github.com/users/ARYPROGRAMMER/gists{/gist_id}", "starred_url": "https://api.github.com/users/ARYPROGRAMMER/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ARYPROGRAMMER/subscriptions", "organizations_url": "https://api.github.com/users/ARYPROGRAMMER/orgs", "repos_url": "https://api.github.com/users/ARYPROGRAMMER/repos", "events_url": "https://api.github.com/users/ARYPROGRAMMER/events{/privacy}", "received_events_url": "https://api.github.com/users/ARYPROGRAMMER/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": true, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2024-12-21T20:57:25Z", "updated_at": "2024-12-21T23:45:09Z", "closed_at": "2024-12-21T23:44:57Z", "author_association": "NONE", "active_lock_reason": "off-topic", "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/11551", "html_url": "https://github.com/laurent22/joplin/pull/11551", "diff_url": "https://github.com/laurent22/joplin/pull/11551.diff", "patch_url": "https://github.com/laurent22/joplin/pull/11551.patch", "merged_at": null }, "body": "This PR attempts to solve #11538 and closes it.\r\n\r\nAdded support for strikethrough text preview in markdown editor , just like bold and italic previews. \r\nAdded shortcut key \"Alt-Shift-5\" for the same.\r\nAdded relevant docs to the needed files.", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11551/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11551/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558238920", "html_url": "https://github.com/laurent22/joplin/pull/11551#issuecomment-2558238920", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11551", "id": 2558238920, "node_id": "IC_kwDOBLftOs6Ye6DI", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-12-21T20:57:40Z", "updated_at": "2024-12-21T22:38:28Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558238920/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558239091", "html_url": "https://github.com/laurent22/joplin/pull/11551#issuecomment-2558239091", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11551", "id": 2558239091, "node_id": "IC_kwDOBLftOs6Ye6Fz", "user": { "login": "ARYPROGRAMMER", "id": 75311742, "node_id": "MDQ6VXNlcjc1MzExNzQy", "avatar_url": "https://avatars.githubusercontent.com/u/75311742?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ARYPROGRAMMER", "html_url": "https://github.com/ARYPROGRAMMER", "followers_url": "https://api.github.com/users/ARYPROGRAMMER/followers", "following_url": "https://api.github.com/users/ARYPROGRAMMER/following{/other_user}", "gists_url": "https://api.github.com/users/ARYPROGRAMMER/gists{/gist_id}", "starred_url": "https://api.github.com/users/ARYPROGRAMMER/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ARYPROGRAMMER/subscriptions", "organizations_url": "https://api.github.com/users/ARYPROGRAMMER/orgs", "repos_url": "https://api.github.com/users/ARYPROGRAMMER/repos", "events_url": "https://api.github.com/users/ARYPROGRAMMER/events{/privacy}", "received_events_url": "https://api.github.com/users/ARYPROGRAMMER/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-12-21T20:58:32Z", "updated_at": "2024-12-21T20:58:32Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558239091/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558239115", "html_url": "https://github.com/laurent22/joplin/pull/11551#issuecomment-2558239115", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11551", "id": 2558239115, "node_id": "IC_kwDOBLftOs6Ye6GL", "user": { "login": "ARYPROGRAMMER", "id": 75311742, "node_id": "MDQ6VXNlcjc1MzExNzQy", "avatar_url": "https://avatars.githubusercontent.com/u/75311742?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ARYPROGRAMMER", "html_url": "https://github.com/ARYPROGRAMMER", "followers_url": "https://api.github.com/users/ARYPROGRAMMER/followers", "following_url": "https://api.github.com/users/ARYPROGRAMMER/following{/other_user}", "gists_url": "https://api.github.com/users/ARYPROGRAMMER/gists{/gist_id}", "starred_url": "https://api.github.com/users/ARYPROGRAMMER/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ARYPROGRAMMER/subscriptions", "organizations_url": "https://api.github.com/users/ARYPROGRAMMER/orgs", "repos_url": "https://api.github.com/users/ARYPROGRAMMER/repos", "events_url": "https://api.github.com/users/ARYPROGRAMMER/events{/privacy}", "received_events_url": "https://api.github.com/users/ARYPROGRAMMER/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-12-21T20:58:41Z", "updated_at": "2024-12-21T20:58:41Z", "author_association": "NONE", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558239115/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558270005", "html_url": "https://github.com/laurent22/joplin/pull/11551#issuecomment-2558270005", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11551", "id": 2558270005, "node_id": "IC_kwDOBLftOs6YfBo1", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-12-21T23:44:57Z", "updated_at": "2024-12-21T23:44:57Z", "author_association": "OWNER", "body": "There was no discussion over what should be done for this issue, so it's too early for a pr", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2558270005/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }