{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10783", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/10783/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/10783/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/10783/events", "html_url": "https://github.com/laurent22/joplin/pull/10783", "id": 2429756225, "node_id": "PR_kwDOBLftOs52dFRB", "number": 10783, "title": "Desktop: Rich text editor: Mermaid diagram download button doesn't work", "user": { "login": "Aarya01Patil", "id": 147030857, "node_id": "U_kgDOCMODSQ", "avatar_url": "https://avatars.githubusercontent.com/u/147030857?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Aarya01Patil", "html_url": "https://github.com/Aarya01Patil", "followers_url": "https://api.github.com/users/Aarya01Patil/followers", "following_url": "https://api.github.com/users/Aarya01Patil/following{/other_user}", "gists_url": "https://api.github.com/users/Aarya01Patil/gists{/gist_id}", "starred_url": "https://api.github.com/users/Aarya01Patil/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Aarya01Patil/subscriptions", "organizations_url": "https://api.github.com/users/Aarya01Patil/orgs", "repos_url": "https://api.github.com/users/Aarya01Patil/repos", "events_url": "https://api.github.com/users/Aarya01Patil/events{/privacy}", "received_events_url": "https://api.github.com/users/Aarya01Patil/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 5, "created_at": "2024-07-25T11:45:53Z", "updated_at": "2024-07-28T13:52:50Z", "closed_at": "2024-07-28T13:52:36Z", "author_association": "NONE", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/10783", "html_url": "https://github.com/laurent22/joplin/pull/10783", "diff_url": "https://github.com/laurent22/joplin/pull/10783.diff", "patch_url": "https://github.com/laurent22/joplin/pull/10783.patch", "merged_at": null }, "body": "This PR fixes #9588 with Mermaid code blocks in the rich text editor where an unnecessary \"Download\" button appears when \r\n\r\nChanges Made:\r\n\r\nModified the Mermaid rendering rule in packages/renderer/MdToHtml/rules/mermaid.ts\r\nRemoved the code that adds the \"Download\" button to Mermaid diagrams\r\nEnsured that the graph still renders correctly without any visual artifacts\r\n\r\nTesting:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/96f2f186-447b-41df-8987-2a38ae9f4dd9\r\n\r\n\r\n\r\nSteps to Test:\r\n\r\nCreate a new note and switch to the rich text editor\r\nAdd a code block with language mermaid\r\nSet the following content:\r\n```\r\nCopygitGraph\r\n commit\r\n commit\r\n```\r\n\r\nClick \"Ok\" to render the graph\r\nHover over the graph and verify that no \"Download\" button appears\r\n let me know if any further changes or information are needed.", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10783/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/10783/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2250131897", "html_url": "https://github.com/laurent22/joplin/pull/10783#issuecomment-2250131897", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10783", "id": 2250131897, "node_id": "IC_kwDOBLftOs6GHkm5", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-07-25T11:46:06Z", "updated_at": "2024-07-28T13:52:50Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2250131897/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2250150103", "html_url": "https://github.com/laurent22/joplin/pull/10783#issuecomment-2250150103", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10783", "id": 2250150103, "node_id": "IC_kwDOBLftOs6GHpDX", "user": { "login": "Aarya01Patil", "id": 147030857, "node_id": "U_kgDOCMODSQ", "avatar_url": "https://avatars.githubusercontent.com/u/147030857?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Aarya01Patil", "html_url": "https://github.com/Aarya01Patil", "followers_url": "https://api.github.com/users/Aarya01Patil/followers", "following_url": "https://api.github.com/users/Aarya01Patil/following{/other_user}", "gists_url": "https://api.github.com/users/Aarya01Patil/gists{/gist_id}", "starred_url": "https://api.github.com/users/Aarya01Patil/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Aarya01Patil/subscriptions", "organizations_url": "https://api.github.com/users/Aarya01Patil/orgs", "repos_url": "https://api.github.com/users/Aarya01Patil/repos", "events_url": "https://api.github.com/users/Aarya01Patil/events{/privacy}", "received_events_url": "https://api.github.com/users/Aarya01Patil/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-07-25T11:57:20Z", "updated_at": "2024-07-25T11:57:20Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2250150103/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2250150830", "html_url": "https://github.com/laurent22/joplin/pull/10783#issuecomment-2250150830", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10783", "id": 2250150830, "node_id": "IC_kwDOBLftOs6GHpOu", "user": { "login": "Aarya01Patil", "id": 147030857, "node_id": "U_kgDOCMODSQ", "avatar_url": "https://avatars.githubusercontent.com/u/147030857?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Aarya01Patil", "html_url": "https://github.com/Aarya01Patil", "followers_url": "https://api.github.com/users/Aarya01Patil/followers", "following_url": "https://api.github.com/users/Aarya01Patil/following{/other_user}", "gists_url": "https://api.github.com/users/Aarya01Patil/gists{/gist_id}", "starred_url": "https://api.github.com/users/Aarya01Patil/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Aarya01Patil/subscriptions", "organizations_url": "https://api.github.com/users/Aarya01Patil/orgs", "repos_url": "https://api.github.com/users/Aarya01Patil/repos", "events_url": "https://api.github.com/users/Aarya01Patil/events{/privacy}", "received_events_url": "https://api.github.com/users/Aarya01Patil/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-07-25T11:57:44Z", "updated_at": "2024-07-25T11:57:44Z", "author_association": "NONE", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2250150830/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2250998165", "html_url": "https://github.com/laurent22/joplin/pull/10783#issuecomment-2250998165", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10783", "id": 2250998165, "node_id": "IC_kwDOBLftOs6GK4GV", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-07-25T17:06:26Z", "updated_at": "2024-07-25T17:06:26Z", "author_association": "COLLABORATOR", "body": "> Modified the Mermaid rendering rule in packages/renderer/MdToHtml/rules/mermaid.ts\r\n\r\nPlease make sure that you've pushed your changes! (The changes associated with this pull request are currently not related to mermaid diagrams).\r\n\r\n> testing:\r\n\r\nPlease also verify that the download button is still visible and functions in the markdown preview pane/read-only mode.\r\n\r\n\r\nThank you for working on this!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2250998165/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2254526951", "html_url": "https://github.com/laurent22/joplin/pull/10783#issuecomment-2254526951", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10783", "id": 2254526951, "node_id": "IC_kwDOBLftOs6GYVnn", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-07-28T13:52:36Z", "updated_at": "2024-07-28T13:52:36Z", "author_association": "OWNER", "body": "Closing for now. Please let us know if you'd like to complete the PR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2254526951/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }