{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10093", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/10093/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/10093/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/10093/events", "html_url": "https://github.com/laurent22/joplin/pull/10093", "id": 2176681357, "node_id": "PR_kwDOBLftOs5pHeIg", "number": 10093, "title": " #10060 : resolved new-note btn overflow problem because of stratup on trash notebook", "user": { "login": "AdarshSajwan2003", "id": 147631707, "node_id": "U_kgDOCMyuWw", "avatar_url": "https://avatars.githubusercontent.com/u/147631707?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AdarshSajwan2003", "html_url": "https://github.com/AdarshSajwan2003", "followers_url": "https://api.github.com/users/AdarshSajwan2003/followers", "following_url": "https://api.github.com/users/AdarshSajwan2003/following{/other_user}", "gists_url": "https://api.github.com/users/AdarshSajwan2003/gists{/gist_id}", "starred_url": "https://api.github.com/users/AdarshSajwan2003/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AdarshSajwan2003/subscriptions", "organizations_url": "https://api.github.com/users/AdarshSajwan2003/orgs", "repos_url": "https://api.github.com/users/AdarshSajwan2003/repos", "events_url": "https://api.github.com/users/AdarshSajwan2003/events{/privacy}", "received_events_url": "https://api.github.com/users/AdarshSajwan2003/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 2, "created_at": "2024-03-08T19:54:48Z", "updated_at": "2024-03-08T20:14:55Z", "closed_at": "2024-03-08T20:14:42Z", "author_association": "NONE", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/10093", "html_url": "https://github.com/laurent22/joplin/pull/10093", "diff_url": "https://github.com/laurent22/joplin/pull/10093.diff", "patch_url": "https://github.com/laurent22/joplin/pull/10093.patch", "merged_at": null }, "body": "So, I jumped in to fix an issue on Joplin's GitHub repository, which was causing some trouble with the breakpoints in the NoteListWrapper component. Basically, the problem was that the content was overflowing due to incorrect breakpoints being set.\r\n\r\nTo tackle this, I decided to use ReactState to directly handle the reference (Ref) of the note button. The root cause of the issue was that the useNoteListControlsBreakpoints() function in gui/NoteListWrapper/NoteListWrapper.tsx was using the previous reference value of the note button instead of the current one.\r\n\r\nTo solve this, I made sure to control the reference of the button right from the renderNewNoteButtons function during initialization. This way, I ensured that the correct reference value was being used, preventing any incorrect breakpoints and subsequent content overflow.", "closed_by": { "login": "AdarshSajwan2003", "id": 147631707, "node_id": "U_kgDOCMyuWw", "avatar_url": "https://avatars.githubusercontent.com/u/147631707?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AdarshSajwan2003", "html_url": "https://github.com/AdarshSajwan2003", "followers_url": "https://api.github.com/users/AdarshSajwan2003/followers", "following_url": "https://api.github.com/users/AdarshSajwan2003/following{/other_user}", "gists_url": "https://api.github.com/users/AdarshSajwan2003/gists{/gist_id}", "starred_url": "https://api.github.com/users/AdarshSajwan2003/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AdarshSajwan2003/subscriptions", "organizations_url": "https://api.github.com/users/AdarshSajwan2003/orgs", "repos_url": "https://api.github.com/users/AdarshSajwan2003/repos", "events_url": "https://api.github.com/users/AdarshSajwan2003/events{/privacy}", "received_events_url": "https://api.github.com/users/AdarshSajwan2003/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10093/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/10093/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1986332196", "html_url": "https://github.com/laurent22/joplin/pull/10093#issuecomment-1986332196", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10093", "id": 1986332196, "node_id": "IC_kwDOBLftOs52ZQYk", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-08T19:55:03Z", "updated_at": "2024-03-08T20:14:55Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1986332196/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1986338671", "html_url": "https://github.com/laurent22/joplin/pull/10093#issuecomment-1986338671", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10093", "id": 1986338671, "node_id": "IC_kwDOBLftOs52ZR9v", "user": { "login": "AdarshSajwan2003", "id": 147631707, "node_id": "U_kgDOCMyuWw", "avatar_url": "https://avatars.githubusercontent.com/u/147631707?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AdarshSajwan2003", "html_url": "https://github.com/AdarshSajwan2003", "followers_url": "https://api.github.com/users/AdarshSajwan2003/followers", "following_url": "https://api.github.com/users/AdarshSajwan2003/following{/other_user}", "gists_url": "https://api.github.com/users/AdarshSajwan2003/gists{/gist_id}", "starred_url": "https://api.github.com/users/AdarshSajwan2003/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AdarshSajwan2003/subscriptions", "organizations_url": "https://api.github.com/users/AdarshSajwan2003/orgs", "repos_url": "https://api.github.com/users/AdarshSajwan2003/repos", "events_url": "https://api.github.com/users/AdarshSajwan2003/events{/privacy}", "received_events_url": "https://api.github.com/users/AdarshSajwan2003/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-08T19:59:38Z", "updated_at": "2024-03-08T19:59:38Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1986338671/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }