{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14864", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14864/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14864/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14864/events", "html_url": "https://github.com/laurent22/joplin/pull/14864", "id": 4113001595, "node_id": "PR_kwDOBLftOs7MYECP", "number": 14864, "title": "Fix: upgrade react-native-popup-menu to remove deprecated SafeAreaView warning", "user": { "login": "Amirtha-yazhini", "id": 68894384, "node_id": "MDQ6VXNlcjY4ODk0Mzg0", "avatar_url": "https://avatars.githubusercontent.com/u/68894384?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Amirtha-yazhini", "html_url": "https://github.com/Amirtha-yazhini", "followers_url": "https://api.github.com/users/Amirtha-yazhini/followers", "following_url": "https://api.github.com/users/Amirtha-yazhini/following{/other_user}", "gists_url": "https://api.github.com/users/Amirtha-yazhini/gists{/gist_id}", "starred_url": "https://api.github.com/users/Amirtha-yazhini/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Amirtha-yazhini/subscriptions", "organizations_url": "https://api.github.com/users/Amirtha-yazhini/orgs", "repos_url": "https://api.github.com/users/Amirtha-yazhini/repos", "events_url": "https://api.github.com/users/Amirtha-yazhini/events{/privacy}", "received_events_url": "https://api.github.com/users/Amirtha-yazhini/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 1079605111, "node_id": "MDU6TGFiZWwxMDc5NjA1MTEx", "url": "https://api.github.com/repos/laurent22/joplin/labels/mobile", "name": "mobile", "color": "ffc274", "default": false, "description": "All mobile platforms" }, { "id": 3467743982, "node_id": "LA_kwDOBLftOs7OsZLu", "url": "https://api.github.com/repos/laurent22/joplin/labels/accessibility", "name": "accessibility", "color": "91ca55", "default": false, "description": "Related to accessibility" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 4, "created_at": "2026-03-21T16:37:19Z", "updated_at": "2026-03-22T09:38:27Z", "closed_at": "2026-03-22T09:38:15Z", "assignee": null, "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14864", "html_url": "https://github.com/laurent22/joplin/pull/14864", "diff_url": "https://github.com/laurent22/joplin/pull/14864.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14864.patch", "merged_at": null }, "body": "## What does this PR do?\r\n\r\nUpgrades `react-native-popup-menu` from `0.17.0` to `0.19.0` to fix \r\ndeprecated `` warnings logged during CI test runs.\r\n\r\n## Why?\r\n\r\nCloses #14835\r\n\r\nThe old version used the deprecated `` component from \r\n`react-native` core. The newer version removes this in favour of \r\n`react-native-safe-area-context`.\r\n\r\n## Changes\r\n\r\n- Upgraded `react-native-popup-menu` from `0.17.0` to `0.19.0`\r\n- Migrated the existing accessibility patch (which adds `closeButtonLabel` \r\n and `accessibilityRole` to the backdrop dismiss button) to the new version\r\n- Removed the old `0.17.0` patch file\r\n\r\n## How to test\r\n\r\n1. Run `yarn workspace @joplin/app-mobile jest --forceExit`\r\n2. Verify no `SafeAreaView has been deprecated` warnings appear in the output\r\n3. Verify all tests pass\r\n\r\n## Test results\r\nTest Suites: 2 passed, 2 total\r\nTests: 21 passed, 21 total\r\nNo SafeAreaView warnings in output.", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14864/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14864/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4103687171", "html_url": "https://github.com/laurent22/joplin/pull/14864#issuecomment-4103687171", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14864", "id": 4103687171, "node_id": "IC_kwDOBLftOs70mUwD", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-21T16:37:32Z", "updated_at": "2026-03-22T09:38:27Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ βœ…", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4103687171/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4103687502", "html_url": "https://github.com/laurent22/joplin/pull/14864#issuecomment-4103687502", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14864", "id": 4103687502, "node_id": "IC_kwDOBLftOs70mU1O", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-21T16:37:46Z", "updated_at": "2026-03-21T16:41:04Z", "body": "\nNo actionable comments were generated in the recent review. πŸŽ‰\n\n
\nℹ️ Recent review info\n\n
\nβš™οΈ Run configuration\n\n**Configuration used**: Path: .coderabbit.yaml\n\n**Review profile**: CHILL\n\n**Plan**: Pro\n\n**Run ID**: `c0264caf-4f93-4280-91fc-a25b63bcdfe6`\n\n
\n\n
\nπŸ“₯ Commits\n\nReviewing files that changed from the base of the PR and between 1f5b4269abcbb9e9d7a8889e4aea6f4833ff366f and 36ad82ceae96d9f39ff15c0b9ded3481d96709d3.\n\n
\n\n
\nβ›” Files ignored due to path filters (2)\n\n* `.yarn/patches/react-native-popup-menu-npm-0.19.0-c75418add4.patch` is excluded by `!**/.yarn/**`\n* `yarn.lock` is excluded by `!**/yarn.lock`, `!**/*.lock`\n\n
\n\n
\nπŸ“’ Files selected for processing (1)\n\n* `packages/app-mobile/package.json`\n\n
\n\n
\n\n---\n\n\n\n\n
\nπŸ“ Walkthrough\n\n## Walkthrough\n\nUpdated the `react-native-popup-menu` dependency in the mobile application package configuration from version 0.17.0 to 0.19.0, applying a local Yarn patch file. This addresses deprecation warnings related to the use of React Native's deprecated `` component.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Mobile dependency upgrade**
`packages/app-mobile/package.json`|Bumped `react-native-popup-menu` from 0.17.0 to 0.19.0 with a Yarn patch applied. The newer version replaces usage of deprecated `` with `react-native-safe-area-context`, eliminating associated test warnings.|\n\n## Suggested labels\n\n`mobile`, `accessibility`\n\n
\n\n\n\n\n\n\n
\nπŸš₯ Pre-merge checks | βœ… 6\n\n
\nβœ… Passed checks (6 passed)\n\n| Check name | Status | Explanation |\n| :-----------------------------------: | :------- | :--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Title check | βœ… Passed | The title accurately describes the main change: upgrading react-native-popup-menu to fix deprecated SafeAreaView warnings. |\n| Description check | βœ… Passed | The description clearly explains the upgrade purpose, changes made, and testing steps, all directly related to the changeset. |\n| Linked Issues check | βœ… Passed | The PR successfully addresses issue `#14835` by upgrading react-native-popup-menu to 0.19.0 and migrating the accessibility patch, eliminating SafeAreaView deprecation warnings. |\n| Out of Scope Changes check | βœ… Passed | All changes are scoped to the react-native-popup-menu dependency upgrade and related patch migration; no unrelated modifications are present. |\n| Docstring Coverage | βœ… Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n| Pr Description Must Follow Guidelines | βœ… Passed | PR description includes all three required sections: problem statement (deprecated SafeAreaView warnings), high-level solution (library upgrade with patch migration), and test verification with results. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing Touches\n\n
\nπŸ§ͺ Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n\n
\n\n
\n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14864)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n
\n❀️ Share\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n
\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n\n\n\n> [!TIP]\n>
\n> You can disable the changed files summary in the walkthrough.\n> \n> Disable the `reviews.changed_files_summary` setting to disable the changed files summary in the walkthrough.\n> \n>
\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4103687502/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes.Β \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code.Β The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issuesΒ \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4105149800", "html_url": "https://github.com/laurent22/joplin/pull/14864#issuecomment-4105149800", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14864", "id": 4105149800, "node_id": "IC_kwDOBLftOs70r51o", "user": { "login": "Amirtha-yazhini", "id": 68894384, "node_id": "MDQ6VXNlcjY4ODk0Mzg0", "avatar_url": "https://avatars.githubusercontent.com/u/68894384?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Amirtha-yazhini", "html_url": "https://github.com/Amirtha-yazhini", "followers_url": "https://api.github.com/users/Amirtha-yazhini/followers", "following_url": "https://api.github.com/users/Amirtha-yazhini/following{/other_user}", "gists_url": "https://api.github.com/users/Amirtha-yazhini/gists{/gist_id}", "starred_url": "https://api.github.com/users/Amirtha-yazhini/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Amirtha-yazhini/subscriptions", "organizations_url": "https://api.github.com/users/Amirtha-yazhini/orgs", "repos_url": "https://api.github.com/users/Amirtha-yazhini/repos", "events_url": "https://api.github.com/users/Amirtha-yazhini/events{/privacy}", "received_events_url": "https://api.github.com/users/Amirtha-yazhini/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-22T02:27:00Z", "updated_at": "2026-03-22T02:27:00Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4105149800/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4105897562", "html_url": "https://github.com/laurent22/joplin/pull/14864#issuecomment-4105897562", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14864", "id": 4105897562, "node_id": "IC_kwDOBLftOs70uwZa", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-22T09:38:15Z", "updated_at": "2026-03-22T09:38:15Z", "body": "Hello, please read the guidelines, you almost didn't do anything we ask for", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4105897562/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }