{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14673", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14673/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14673/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14673/events", "html_url": "https://github.com/laurent22/joplin/pull/14673", "id": 4050468865, "node_id": "PR_kwDOBLftOs7JUkTD", "number": 14673, "title": "Desktop: Fixes #14637: Add Cut and Copy options to link context menu", "user": { "login": "Arunava07M", "id": 225518570, "node_id": "U_kgDODXEj6g", "avatar_url": "https://avatars.githubusercontent.com/u/225518570?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Arunava07M", "html_url": "https://github.com/Arunava07M", "followers_url": "https://api.github.com/users/Arunava07M/followers", "following_url": "https://api.github.com/users/Arunava07M/following{/other_user}", "gists_url": "https://api.github.com/users/Arunava07M/gists{/gist_id}", "starred_url": "https://api.github.com/users/Arunava07M/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Arunava07M/subscriptions", "organizations_url": "https://api.github.com/users/Arunava07M/orgs", "repos_url": "https://api.github.com/users/Arunava07M/repos", "events_url": "https://api.github.com/users/Arunava07M/events{/privacy}", "received_events_url": "https://api.github.com/users/Arunava07M/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 519700741, "node_id": "MDU6TGFiZWw1MTk3MDA3NDE=", "url": "https://api.github.com/repos/laurent22/joplin/labels/bug", "name": "bug", "color": "cf353b", "default": true, "description": "It's a bug" }, { "id": 1080341216, "node_id": "MDU6TGFiZWwxMDgwMzQxMjE2", "url": "https://api.github.com/repos/laurent22/joplin/labels/desktop", "name": "desktop", "color": "ffc274", "default": false, "description": "All desktop platforms" }, { "id": 1366672371, "node_id": "MDU6TGFiZWwxMzY2NjcyMzcx", "url": "https://api.github.com/repos/laurent22/joplin/labels/editor", "name": "editor", "color": "91ca55", "default": false, "description": "" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 4, "created_at": "2026-03-10T09:17:55Z", "updated_at": "2026-03-10T15:05:52Z", "closed_at": "2026-03-10T12:21:24Z", "assignee": null, "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14673", "html_url": "https://github.com/laurent22/joplin/pull/14673", "diff_url": "https://github.com/laurent22/joplin/pull/14673.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14673.patch", "merged_at": null }, "body": "This PR addresses issue #14637. I noticed the \"Cut\" and \"Copy\" actions were missing from the context menu whenever a user right-clicked directly on a link or an internal NoteLink in the Desktop Markdown editor.\r\n\r\nTo resolve this, I updated `contextMenu.ts` to properly handle these elements. The menu's active state now checks if the target is a standard Link, an internal NoteLink, or if there is actively selected text. \r\n\r\nFor the clipboard functionality itself, the actions leverage the native Electron `bridge().activeWindow().webContents.cut()` and `copy()` methods. This guarantees the actions stay perfectly synced with the editor's native selection buffer and the OS clipboard.\r\n\r\nScreenshots\r\n\r\nBefore:\r\n\"Before\r\n\r\nAfter:\r\n\"After\r\n\r\nTesting done:\r\n* Confirmed the actions remain hidden when right-clicking empty space.\r\n* Verified they correctly appear on standard web links and internal Joplin note links.\r\n* Checked that the Cut action successfully removes the text and updates the clipboard.\r\n* Checked that the Copy action successfully copies the text to the OS clipboard.", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14673/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14673/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4029839483", "html_url": "https://github.com/laurent22/joplin/pull/14673#issuecomment-4029839483", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14673", "id": 4029839483, "node_id": "IC_kwDOBLftOs7wMnh7", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-10T09:18:07Z", "updated_at": "2026-03-10T15:05:52Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4029839483/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4029841150", "html_url": "https://github.com/laurent22/joplin/pull/14673#issuecomment-4029841150", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14673", "id": 4029841150, "node_id": "IC_kwDOBLftOs7wMn7-", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-10T09:18:25Z", "updated_at": "2026-03-10T10:25:29Z", "body": "\nNo actionable comments were generated in the recent review. 🎉\n\n
\nℹ️ Recent review info\n\n
\n⚙️ Run configuration\n\n**Configuration used**: Path: .coderabbit.yaml\n\n**Review profile**: CHILL\n\n**Plan**: Pro\n\n**Run ID**: `d0550534-c9cd-4d49-951a-a36f9327499a`\n\n
\n\n
\n📥 Commits\n\nReviewing files that changed from the base of the PR and between d448d51bee98fe007d40b6f548ed1f0632a5b1c3 and 832cb0e358c3dba1f8ff075b9c724af5763e3796.\n\n
\n\n
\n📒 Files selected for processing (1)\n\n* `packages/app-desktop/gui/NoteEditor/utils/contextMenu.ts`\n\n
\n\n
\n🚧 Files skipped from review as they are similar to previous changes (1)\n\n* packages/app-desktop/gui/NoteEditor/utils/contextMenu.ts\n\n
\n\n
\n\n---\n\n\n\n\n
\n📝 Walkthrough\n\n## Walkthrough\n\nAdded two link-specific context-menu items—`linkCut` and `linkCopy`—that invoke the renderer bridge's webContents cut/copy for Link and NoteLink item types. Adjusted the generic Cut action to delegate copy behaviour to the existing clipboard handler and to clear inserted content; menuItems now exposes the two new keys.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Context Menu — NoteEditor**
`packages/app-desktop/gui/NoteEditor/utils/contextMenu.ts`|Added `linkCut` and `linkCopy` ContextMenuItems active for `ContextMenuItemType.Link` and `ContextMenuItemType.NoteLink`, invoking `bridge().activeWindow().webContents.cut()`/`.copy()`. Modified generic `Cut` action to delegate copy to the clipboard handler and clear inserted content. `menuItems` now includes `linkCut` and `linkCopy` keys.|\n\n## Possibly related PRs\n\n- laurent22/joplin#14528 — Modifies the same `contextMenu.ts`, adding NoteLink handling and related context-menu item changes. \n- laurent22/joplin#14402 — Updates NoteEditor context-menu logic and ContextMenuItemType handling, touching the same area of menu visibility/dispatch.\n\n
\n\n\n\n\n\n\n
\n🚥 Pre-merge checks | ✅ 4\n\n
\n✅ Passed checks (4 passed)\n\n| Check name | Status | Explanation |\n| :-----------------------------------: | :------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |\n| Title check | ✅ Passed | The title clearly and specifically describes the main change: adding Cut and Copy options to the link context menu, with reference to the issue being fixed. |\n| Description check | ✅ Passed | The description is directly related to the changeset, providing clear context about the issue, the solution implemented, and testing performed with supporting screenshots. |\n| Docstring Coverage | ✅ Passed | Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. |\n| Pr Description Must Follow Guidelines | ✅ Passed | The pull request description includes all required sections: clear problem statement about missing Cut/Copy options on links, high-level solution explanation detailing menu state logic and Electron integration, and comprehensive test verification steps with before/after screenshots. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing Touches\n\n
\n🧪 Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n- [ ] Post copyable unit tests in a comment\n\n
\n\n
\n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14673)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n
\n❤️ Share\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n
\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4029841150/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4029885618", "html_url": "https://github.com/laurent22/joplin/pull/14673#issuecomment-4029885618", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14673", "id": 4029885618, "node_id": "IC_kwDOBLftOs7wMyyy", "user": { "login": "Arunava07M", "id": 225518570, "node_id": "U_kgDODXEj6g", "avatar_url": "https://avatars.githubusercontent.com/u/225518570?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Arunava07M", "html_url": "https://github.com/Arunava07M", "followers_url": "https://api.github.com/users/Arunava07M/followers", "following_url": "https://api.github.com/users/Arunava07M/following{/other_user}", "gists_url": "https://api.github.com/users/Arunava07M/gists{/gist_id}", "starred_url": "https://api.github.com/users/Arunava07M/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Arunava07M/subscriptions", "organizations_url": "https://api.github.com/users/Arunava07M/orgs", "repos_url": "https://api.github.com/users/Arunava07M/repos", "events_url": "https://api.github.com/users/Arunava07M/events{/privacy}", "received_events_url": "https://api.github.com/users/Arunava07M/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-10T09:26:28Z", "updated_at": "2026-03-10T09:26:28Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4029885618/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030988765", "html_url": "https://github.com/laurent22/joplin/pull/14673#issuecomment-4030988765", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14673", "id": 4030988765, "node_id": "IC_kwDOBLftOs7wRAHd", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-10T12:21:24Z", "updated_at": "2026-03-10T12:21:24Z", "body": "Hello, this has now been fixed in https://github.com/laurent22/joplin/pull/14638", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030988765/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }