{
"issue": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/14752",
"repository_url": "https://api.github.com/repos/laurent22/joplin",
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14752/labels{/name}",
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14752/comments",
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/14752/events",
"html_url": "https://github.com/laurent22/joplin/pull/14752",
"id": 4078511163,
"node_id": "PR_kwDOBLftOs7KumJs",
"number": 14752,
"title": "Desktop: Wrap hardcoded strings in MasterPasswordDialog with _() for i18n",
"user": {
"login": "Avanish-Gupta-CSE",
"id": 91612116,
"node_id": "U_kgDOBXXj1A",
"avatar_url": "https://avatars.githubusercontent.com/u/91612116?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Avanish-Gupta-CSE",
"html_url": "https://github.com/Avanish-Gupta-CSE",
"followers_url": "https://api.github.com/users/Avanish-Gupta-CSE/followers",
"following_url": "https://api.github.com/users/Avanish-Gupta-CSE/following{/other_user}",
"gists_url": "https://api.github.com/users/Avanish-Gupta-CSE/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Avanish-Gupta-CSE/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Avanish-Gupta-CSE/subscriptions",
"organizations_url": "https://api.github.com/users/Avanish-Gupta-CSE/orgs",
"repos_url": "https://api.github.com/users/Avanish-Gupta-CSE/repos",
"events_url": "https://api.github.com/users/Avanish-Gupta-CSE/events{/privacy}",
"received_events_url": "https://api.github.com/users/Avanish-Gupta-CSE/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [
{
"id": 1080341216,
"node_id": "MDU6TGFiZWwxMDgwMzQxMjE2",
"url": "https://api.github.com/repos/laurent22/joplin/labels/desktop",
"name": "desktop",
"color": "ffc274",
"default": false,
"description": "All desktop platforms"
},
{
"id": 1091621259,
"node_id": "MDU6TGFiZWwxMDkxNjIxMjU5",
"url": "https://api.github.com/repos/laurent22/joplin/labels/translation",
"name": "translation",
"color": "91ca55",
"default": false,
"description": "i18n and l10n"
}
],
"state": "closed",
"locked": false,
"assignees": [],
"milestone": null,
"comments": 3,
"created_at": "2026-03-15T14:41:48Z",
"updated_at": "2026-03-16T12:10:57Z",
"closed_at": "2026-03-16T12:10:45Z",
"assignee": null,
"author_association": "CONTRIBUTOR",
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/laurent22/joplin/pulls/14752",
"html_url": "https://github.com/laurent22/joplin/pull/14752",
"diff_url": "https://github.com/laurent22/joplin/pull/14752.diff",
"patch_url": "https://github.com/laurent22/joplin/pull/14752.patch",
"merged_at": "2026-03-16T12:10:45Z"
},
"body": "### Problem\n\nThe Master Password dialog is partially untranslatable for non-English Joplin users. Seven user-facing strings — including password entry labels, security warnings, and action links — are hardcoded in English rather than wrapped in the `_()` translation function. This means users who run Joplin in other languages see a mix of translated and untranslated text in this critical security dialog, which degrades the user experience and can cause confusion when managing encryption passwords.\n\nThe affected strings are:\n- \"Enter password\" / \"Enter new password\" labels\n- \"Reset master password\" and \"Change master password\" link text\n- The security warning about remembering passwords\n- The reset mode warning about data loss\n- The description explaining what the master password is used for\n- \"Master password status:\" label\n\n### Solution\n\nWrapped all 7 hardcoded strings with `_()` from `@joplin/lib/locale`, which is already imported and used for other strings in the same file (e.g., \"Current password\", \"Re-enter password\", dialog titles). This registers the strings for extraction by Joplin's translation tooling, enabling community translators to provide localized versions.\n\nThis is a text-only change with no functional impact — the English strings remain identical, and no control flow or logic is modified.\n\n### Test Plan\n\n1. Open **Tools → Manage master password**\n2. Verify all labels, warnings, and descriptions render correctly in English (identical to current behaviour)\n3. Click \"Reset master password\" link — verify reset mode text also renders correctly\n4. Switch Joplin locale to a non-English language — verify the strings are now available for translation (they appear in English until translations are contributed, but `_()` ensures they are picked up by the translation extraction tooling)",
"closed_by": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/14752/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14752/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comments": [
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063130543",
"html_url": "https://github.com/laurent22/joplin/pull/14752#issuecomment-4063130543",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14752",
"id": 4063130543,
"node_id": "IC_kwDOBLftOs7yLnOv",
"user": {
"login": "coderabbitai[bot]",
"id": 136622811,
"node_id": "BOT_kgDOCCSy2w",
"avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/coderabbitai%5Bbot%5D",
"html_url": "https://github.com/apps/coderabbitai",
"followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-15T14:42:20Z",
"updated_at": "2026-03-15T15:13:35Z",
"body": "\n\n\n\n📝 Walkthrough
\n\n## Walkthrough\n\nHard-coded UI strings in the MasterPasswordDialog component have been wrapped with a translation function to enable localisation support. All user-facing text in password reset, entry labels, informational content, and status messages are now translatable. No functional or control flow changes.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Master Password Dialog localisation**
`packages/app-desktop/gui/MasterPasswordDialog/Dialog.tsx`|All hard-coded UI strings wrapped with translation function (_) including password entry labels, informational text, status labels, and action link text. No functional changes or API modifications.|\n\n## Suggested labels\n\n`desktop`, `translation`\n\n## Suggested reviewers\n\n- mrjo118\n\n \n\n\n\n\n\n\n---\n\n\n> [!IMPORTANT]\n> ## Pre-merge checks failed\n> \n> Please resolve all errors before merging. Addressing warnings is optional.\n\n\n### ❌ Failed checks (1 error, 1 warning)\n\n| Check name | Status | Explanation | Resolution |\n| :-----------------------------------: | :--------- | :-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Pr Description Must Follow Guidelines | ❌ Error | The PR description is implementation-focused and does not clearly articulate the problem or user benefit being addressed, violating Joplin's guideline requirement for self-contained descriptions that explain why changes are needed. | Enhance the PR description to explicitly state the problem (hardcoded strings cannot be translated) and user benefit (enabling accessibility for non-English users) before technical implementation details. |\n| Docstring Coverage | ⚠️ Warning | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |\n\n\n✅ Passed checks (2 passed)
\n\n| Check name | Status | Explanation |\n| :---------------: | :------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |\n| Title check | ✅ Passed | The title accurately summarizes the main change: wrapping hardcoded strings in MasterPasswordDialog with the _() translation function for internationalization support. |\n| Description check | ✅ Passed | The pull request description clearly relates to the changeset, explaining the problem of untranslatable strings and the solution of wrapping them with the _() translation function, which matches the file changes summarised. |\n\n \n\n\n\n\n\n\n✨ Finishing Touches
\n\n\n🧪 Generate unit tests (beta)
\n\n- [ ] Create PR with unit tests\n- [ ] Post copyable unit tests in a comment\n\n \n\n \n\n\n\n\n\n\n📝 Coding Plan
\n\n- [ ] Generate coding plan for human review comments\n\n \n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14752)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n\n❤️ Share
\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n \n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063130543/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 347564,
"client_id": "Iv1.6aaafe4fe882736b",
"slug": "coderabbitai",
"node_id": "A_kwHOB96YWc4ABU2s",
"owner": {
"login": "coderabbitai",
"id": 132028505,
"node_id": "O_kgDOB96YWQ",
"avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/coderabbitai",
"html_url": "https://github.com/coderabbitai",
"followers_url": "https://api.github.com/users/coderabbitai/followers",
"following_url": "https://api.github.com/users/coderabbitai/following{/other_user}",
"gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions",
"organizations_url": "https://api.github.com/users/coderabbitai/orgs",
"repos_url": "https://api.github.com/users/coderabbitai/repos",
"events_url": "https://api.github.com/users/coderabbitai/events{/privacy}",
"received_events_url": "https://api.github.com/users/coderabbitai/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "coderabbitai",
"description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n",
"external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github",
"html_url": "https://github.com/apps/coderabbitai",
"created_at": "2023-06-14T15:47:27Z",
"updated_at": "2026-03-14T07:58:44Z",
"permissions": {
"actions": "read",
"checks": "write",
"contents": "write",
"discussions": "read",
"issues": "write",
"members": "read",
"metadata": "read",
"pull_requests": "write",
"statuses": "write"
},
"events": [
"issues",
"issue_comment",
"label",
"organization",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"pull_request_review_thread",
"release",
"repository"
]
}
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063196365",
"html_url": "https://github.com/laurent22/joplin/pull/14752#issuecomment-4063196365",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14752",
"id": 4063196365,
"node_id": "IC_kwDOBLftOs7yL3TN",
"user": {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-15T15:11:12Z",
"updated_at": "2026-03-16T12:10:57Z",
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063196365/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 15368,
"client_id": "Iv1.05c79e9ad1f6bdfa",
"slug": "github-actions",
"node_id": "MDM6QXBwMTUzNjg=",
"owner": {
"login": "github",
"id": 9919,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github",
"html_url": "https://github.com/github",
"followers_url": "https://api.github.com/users/github/followers",
"following_url": "https://api.github.com/users/github/following{/other_user}",
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
"organizations_url": "https://api.github.com/users/github/orgs",
"repos_url": "https://api.github.com/users/github/repos",
"events_url": "https://api.github.com/users/github/events{/privacy}",
"received_events_url": "https://api.github.com/users/github/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "GitHub Actions",
"description": "Automate your workflow from idea to production",
"external_url": "https://help.github.com/en/actions",
"html_url": "https://github.com/apps/github-actions",
"created_at": "2018-07-30T09:30:17Z",
"updated_at": "2026-05-05T14:51:38Z",
"permissions": {
"actions": "write",
"administration": "read",
"artifact_metadata": "write",
"attestations": "write",
"checks": "write",
"code_quality": "write",
"contents": "write",
"copilot_requests": "write",
"deployments": "write",
"discussions": "write",
"issues": "write",
"merge_queues": "write",
"metadata": "read",
"models": "read",
"packages": "write",
"pages": "write",
"pull_requests": "write",
"repository_hooks": "write",
"repository_projects": "write",
"security_events": "write",
"statuses": "write",
"vulnerability_alerts": "read"
},
"events": [
"branch_protection_rule",
"check_run",
"check_suite",
"create",
"delete",
"deployment",
"deployment_status",
"discussion",
"discussion_comment",
"fork",
"gollum",
"issues",
"issue_comment",
"label",
"merge_group",
"milestone",
"page_build",
"public",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"push",
"registry_package",
"release",
"repository",
"repository_dispatch",
"status",
"watch",
"workflow_dispatch",
"workflow_run"
]
}
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063200213",
"html_url": "https://github.com/laurent22/joplin/pull/14752#issuecomment-4063200213",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14752",
"id": 4063200213,
"node_id": "IC_kwDOBLftOs7yL4PV",
"user": {
"login": "Avanish-Gupta-CSE",
"id": 91612116,
"node_id": "U_kgDOBXXj1A",
"avatar_url": "https://avatars.githubusercontent.com/u/91612116?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/Avanish-Gupta-CSE",
"html_url": "https://github.com/Avanish-Gupta-CSE",
"followers_url": "https://api.github.com/users/Avanish-Gupta-CSE/followers",
"following_url": "https://api.github.com/users/Avanish-Gupta-CSE/following{/other_user}",
"gists_url": "https://api.github.com/users/Avanish-Gupta-CSE/gists{/gist_id}",
"starred_url": "https://api.github.com/users/Avanish-Gupta-CSE/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Avanish-Gupta-CSE/subscriptions",
"organizations_url": "https://api.github.com/users/Avanish-Gupta-CSE/orgs",
"repos_url": "https://api.github.com/users/Avanish-Gupta-CSE/repos",
"events_url": "https://api.github.com/users/Avanish-Gupta-CSE/events{/privacy}",
"received_events_url": "https://api.github.com/users/Avanish-Gupta-CSE/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-15T15:13:13Z",
"updated_at": "2026-03-15T15:13:13Z",
"body": "I have read the CLA Document and I hereby sign the CLA",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4063200213/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
}
]
}