{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10769", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/10769/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/10769/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/10769/events", "html_url": "https://github.com/laurent22/joplin/pull/10769", "id": 2420815953, "node_id": "PR_kwDOBLftOs51-9BQ", "number": 10769, "title": "Resolved #10755 HTML image height cannot be specified", "user": { "login": "BHAV0207", "id": 140875410, "node_id": "U_kgDOCGWWkg", "avatar_url": "https://avatars.githubusercontent.com/u/140875410?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BHAV0207", "html_url": "https://github.com/BHAV0207", "followers_url": "https://api.github.com/users/BHAV0207/followers", "following_url": "https://api.github.com/users/BHAV0207/following{/other_user}", "gists_url": "https://api.github.com/users/BHAV0207/gists{/gist_id}", "starred_url": "https://api.github.com/users/BHAV0207/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BHAV0207/subscriptions", "organizations_url": "https://api.github.com/users/BHAV0207/orgs", "repos_url": "https://api.github.com/users/BHAV0207/repos", "events_url": "https://api.github.com/users/BHAV0207/events{/privacy}", "received_events_url": "https://api.github.com/users/BHAV0207/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2024-07-20T10:43:10Z", "updated_at": "2024-07-20T13:32:46Z", "closed_at": "2024-07-20T13:32:33Z", "author_association": "NONE", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/10769", "html_url": "https://github.com/laurent22/joplin/pull/10769", "diff_url": "https://github.com/laurent22/joplin/pull/10769.diff", "patch_url": "https://github.com/laurent22/joplin/pull/10769.patch", "merged_at": null }, "body": "Changed the css property of the image tag in noteList.ts, where height was set to auto. Changed the height property to revert-layer.\r\n\r\nI have run the yarn test command and I , hereby, confirm that there are no errors due to this change.\r\n\r\nI have not written any additional tests for this change.\r\n\r\nHere is the screenshot of the resolved issue : \r\n\r\n![Screenshot_20240720_160920](https://github.com/user-attachments/assets/a6df7745-2e75-4a09-b201-9ec36b279fc5)\r\n\r\n\r\nResolves #10755 \r\n\r\nAND PLEASE READ THE GUIDE: https://github.com/laurent22/joplin/blob/dev/readme/dev/index.md", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10769/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/10769/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2241082151", "html_url": "https://github.com/laurent22/joplin/pull/10769#issuecomment-2241082151", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10769", "id": 2241082151, "node_id": "IC_kwDOBLftOs6FlDMn", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-07-20T10:43:22Z", "updated_at": "2024-07-20T13:32:46Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2241082151/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2241086910", "html_url": "https://github.com/laurent22/joplin/pull/10769#issuecomment-2241086910", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10769", "id": 2241086910, "node_id": "IC_kwDOBLftOs6FlEW-", "user": { "login": "BHAV0207", "id": 140875410, "node_id": "U_kgDOCGWWkg", "avatar_url": "https://avatars.githubusercontent.com/u/140875410?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BHAV0207", "html_url": "https://github.com/BHAV0207", "followers_url": "https://api.github.com/users/BHAV0207/followers", "following_url": "https://api.github.com/users/BHAV0207/following{/other_user}", "gists_url": "https://api.github.com/users/BHAV0207/gists{/gist_id}", "starred_url": "https://api.github.com/users/BHAV0207/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BHAV0207/subscriptions", "organizations_url": "https://api.github.com/users/BHAV0207/orgs", "repos_url": "https://api.github.com/users/BHAV0207/repos", "events_url": "https://api.github.com/users/BHAV0207/events{/privacy}", "received_events_url": "https://api.github.com/users/BHAV0207/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-07-20T10:59:28Z", "updated_at": "2024-07-20T10:59:28Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2241086910/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2241086969", "html_url": "https://github.com/laurent22/joplin/pull/10769#issuecomment-2241086969", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10769", "id": 2241086969, "node_id": "IC_kwDOBLftOs6FlEX5", "user": { "login": "BHAV0207", "id": 140875410, "node_id": "U_kgDOCGWWkg", "avatar_url": "https://avatars.githubusercontent.com/u/140875410?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BHAV0207", "html_url": "https://github.com/BHAV0207", "followers_url": "https://api.github.com/users/BHAV0207/followers", "following_url": "https://api.github.com/users/BHAV0207/following{/other_user}", "gists_url": "https://api.github.com/users/BHAV0207/gists{/gist_id}", "starred_url": "https://api.github.com/users/BHAV0207/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BHAV0207/subscriptions", "organizations_url": "https://api.github.com/users/BHAV0207/orgs", "repos_url": "https://api.github.com/users/BHAV0207/repos", "events_url": "https://api.github.com/users/BHAV0207/events{/privacy}", "received_events_url": "https://api.github.com/users/BHAV0207/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-07-20T10:59:42Z", "updated_at": "2024-07-20T10:59:42Z", "author_association": "NONE", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2241086969/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2241153640", "html_url": "https://github.com/laurent22/joplin/pull/10769#issuecomment-2241153640", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10769", "id": 2241153640, "node_id": "IC_kwDOBLftOs6FlUpo", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-07-20T13:32:33Z", "updated_at": "2024-07-20T13:32:33Z", "author_association": "OWNER", "body": "We need to evaluate the impact of such change, and that should be done on the issue", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2241153640/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }