{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/13588", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/13588/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/13588/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/13588/events", "html_url": "https://github.com/laurent22/joplin/pull/13588", "id": 3575729164, "node_id": "PR_kwDOBLftOs6w38KI", "number": 13588, "title": "Chore: Test: Add test for querying items with special character IDs", "user": { "login": "Bappoz", "id": 173080411, "node_id": "U_kgDOClD_Ww", "avatar_url": "https://avatars.githubusercontent.com/u/173080411?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Bappoz", "html_url": "https://github.com/Bappoz", "followers_url": "https://api.github.com/users/Bappoz/followers", "following_url": "https://api.github.com/users/Bappoz/following{/other_user}", "gists_url": "https://api.github.com/users/Bappoz/gists{/gist_id}", "starred_url": "https://api.github.com/users/Bappoz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Bappoz/subscriptions", "organizations_url": "https://api.github.com/users/Bappoz/orgs", "repos_url": "https://api.github.com/users/Bappoz/repos", "events_url": "https://api.github.com/users/Bappoz/events{/privacy}", "received_events_url": "https://api.github.com/users/Bappoz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 5, "created_at": "2025-10-31T17:01:42Z", "updated_at": "2025-11-29T10:53:30Z", "closed_at": "2025-11-29T10:53:29Z", "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/13588", "html_url": "https://github.com/laurent22/joplin/pull/13588", "diff_url": "https://github.com/laurent22/joplin/pull/13588.diff", "patch_url": "https://github.com/laurent22/joplin/pull/13588.patch", "merged_at": null }, "body": "This PR adds a unit test suite covering the static method isSystemPath(path) from the BaseItem class, based on the MC/DC (Modified Condition/Decision Coverage) criterion. The tests ensure that each individual condition independently affects the outcome of the decision logic.\nTest cases included\n- CT1: All conditions true → expected return: true\n- CT2: path is empty → expected return: false\n- CT3: path has no dot → expected return: false\n- CT4: name.length < 32 → expected return: false\n- CT5: ext !== 'md' → expected return: false\n\n\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/13588/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/13588/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3474024318", "html_url": "https://github.com/laurent22/joplin/pull/13588#issuecomment-3474024318", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13588", "id": 3474024318, "node_id": "IC_kwDOBLftOs7PEWd-", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2025-10-31T17:01:56Z", "updated_at": "2025-11-25T18:01:48Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3474024318/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-11-12T15:38:39Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3480015866", "html_url": "https://github.com/laurent22/joplin/pull/13588#issuecomment-3480015866", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13588", "id": 3480015866, "node_id": "IC_kwDOBLftOs7PbNP6", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-11-03T11:18:03Z", "updated_at": "2025-11-03T11:21:31Z", "body": "Hello, what is the reason for this PR? Is that part of a course or something?\r\n\r\nEdit: Also I see all the tests are in Portuguese - it goes without saying that it should be in English.", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3480015866/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3499359898", "html_url": "https://github.com/laurent22/joplin/pull/13588#issuecomment-3499359898", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13588", "id": 3499359898, "node_id": "IC_kwDOBLftOs7Qk_6a", "user": { "login": "Bappoz", "id": 173080411, "node_id": "U_kgDOClD_Ww", "avatar_url": "https://avatars.githubusercontent.com/u/173080411?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Bappoz", "html_url": "https://github.com/Bappoz", "followers_url": "https://api.github.com/users/Bappoz/followers", "following_url": "https://api.github.com/users/Bappoz/following{/other_user}", "gists_url": "https://api.github.com/users/Bappoz/gists{/gist_id}", "starred_url": "https://api.github.com/users/Bappoz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Bappoz/subscriptions", "organizations_url": "https://api.github.com/users/Bappoz/orgs", "repos_url": "https://api.github.com/users/Bappoz/repos", "events_url": "https://api.github.com/users/Bappoz/events{/privacy}", "received_events_url": "https://api.github.com/users/Bappoz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-11-06T20:55:46Z", "updated_at": "2025-11-06T20:55:46Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3499359898/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3499365450", "html_url": "https://github.com/laurent22/joplin/pull/13588#issuecomment-3499365450", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13588", "id": 3499365450, "node_id": "IC_kwDOBLftOs7QlBRK", "user": { "login": "Bappoz", "id": 173080411, "node_id": "U_kgDOClD_Ww", "avatar_url": "https://avatars.githubusercontent.com/u/173080411?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Bappoz", "html_url": "https://github.com/Bappoz", "followers_url": "https://api.github.com/users/Bappoz/followers", "following_url": "https://api.github.com/users/Bappoz/following{/other_user}", "gists_url": "https://api.github.com/users/Bappoz/gists{/gist_id}", "starred_url": "https://api.github.com/users/Bappoz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Bappoz/subscriptions", "organizations_url": "https://api.github.com/users/Bappoz/orgs", "repos_url": "https://api.github.com/users/Bappoz/repos", "events_url": "https://api.github.com/users/Bappoz/events{/privacy}", "received_events_url": "https://api.github.com/users/Bappoz/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-11-06T20:57:32Z", "updated_at": "2025-11-07T15:10:30Z", "body": "Hello Laurent22, sorry for delaying my response to much. \r\nAnswering your questing, yes, this is for a discipline for my course Software Engineering in University of Brasilia. ", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3499365450/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3591560361", "html_url": "https://github.com/laurent22/joplin/pull/13588#issuecomment-3591560361", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13588", "id": 3591560361, "node_id": "IC_kwDOBLftOs7WEtyp", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-11-29T10:53:29Z", "updated_at": "2025-11-29T10:53:29Z", "body": "Hello, thanks for giving it a try but there's now 251 changed files so it cannot be merged. I'm closing the PR now, but feel free to open a new one once you've sorted out the commits.", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3591560361/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }