{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/9273", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/9273/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/9273/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/9273/events", "html_url": "https://github.com/laurent22/joplin/pull/9273", "id": 1989023822, "node_id": "PR_kwDOBLftOs5fNzco", "number": 9273, "title": "Docs: Fix BUILD.md in contributing instructions", "user": { "login": "Daeraxa", "id": 58074586, "node_id": "MDQ6VXNlcjU4MDc0NTg2", "avatar_url": "https://avatars.githubusercontent.com/u/58074586?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Daeraxa", "html_url": "https://github.com/Daeraxa", "followers_url": "https://api.github.com/users/Daeraxa/followers", "following_url": "https://api.github.com/users/Daeraxa/following{/other_user}", "gists_url": "https://api.github.com/users/Daeraxa/gists{/gist_id}", "starred_url": "https://api.github.com/users/Daeraxa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Daeraxa/subscriptions", "organizations_url": "https://api.github.com/users/Daeraxa/orgs", "repos_url": "https://api.github.com/users/Daeraxa/repos", "events_url": "https://api.github.com/users/Daeraxa/events{/privacy}", "received_events_url": "https://api.github.com/users/Daeraxa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2023-11-11T16:17:28Z", "updated_at": "2023-11-11T17:21:45Z", "closed_at": "2023-11-11T17:17:46Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/9273", "html_url": "https://github.com/laurent22/joplin/pull/9273", "diff_url": "https://github.com/laurent22/joplin/pull/9273.diff", "patch_url": "https://github.com/laurent22/joplin/pull/9273.patch", "merged_at": "2023-11-11T17:17:46Z" }, "body": "The link on [this page](https://joplinapp.org/help/dev/#contributing-to-joplins-code) (in \"Building the apps is relatively easy - please [see the build instructions](https://github.com/laurent22/joplin/blob/dev/BUILD.md) for more details.\") to BUILD.md points to the old location in the root of the project.\r\n\r\nPotentially reported by a user on Discord that brought them to a 404 but they did not specify where it was.\r\n\r\nThis just repoints the link to the doc stored within the `readme/dev` dir.\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/9273/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/9273/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1806856067", "html_url": "https://github.com/laurent22/joplin/pull/9273#issuecomment-1806856067", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9273", "id": 1806856067, "node_id": "IC_kwDOBLftOs5rsm-D", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-11-11T16:17:39Z", "updated_at": "2023-11-11T17:21:45Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1806856067/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1806856159", "html_url": "https://github.com/laurent22/joplin/pull/9273#issuecomment-1806856159", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9273", "id": 1806856159, "node_id": "IC_kwDOBLftOs5rsm_f", "user": { "login": "Daeraxa", "id": 58074586, "node_id": "MDQ6VXNlcjU4MDc0NTg2", "avatar_url": "https://avatars.githubusercontent.com/u/58074586?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Daeraxa", "html_url": "https://github.com/Daeraxa", "followers_url": "https://api.github.com/users/Daeraxa/followers", "following_url": "https://api.github.com/users/Daeraxa/following{/other_user}", "gists_url": "https://api.github.com/users/Daeraxa/gists{/gist_id}", "starred_url": "https://api.github.com/users/Daeraxa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Daeraxa/subscriptions", "organizations_url": "https://api.github.com/users/Daeraxa/orgs", "repos_url": "https://api.github.com/users/Daeraxa/repos", "events_url": "https://api.github.com/users/Daeraxa/events{/privacy}", "received_events_url": "https://api.github.com/users/Daeraxa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-11-11T16:17:59Z", "updated_at": "2023-11-11T16:17:59Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1806856159/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1806856901", "html_url": "https://github.com/laurent22/joplin/pull/9273#issuecomment-1806856901", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9273", "id": 1806856901, "node_id": "IC_kwDOBLftOs5rsnLF", "user": { "login": "Daeraxa", "id": 58074586, "node_id": "MDQ6VXNlcjU4MDc0NTg2", "avatar_url": "https://avatars.githubusercontent.com/u/58074586?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Daeraxa", "html_url": "https://github.com/Daeraxa", "followers_url": "https://api.github.com/users/Daeraxa/followers", "following_url": "https://api.github.com/users/Daeraxa/following{/other_user}", "gists_url": "https://api.github.com/users/Daeraxa/gists{/gist_id}", "starred_url": "https://api.github.com/users/Daeraxa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Daeraxa/subscriptions", "organizations_url": "https://api.github.com/users/Daeraxa/orgs", "repos_url": "https://api.github.com/users/Daeraxa/repos", "events_url": "https://api.github.com/users/Daeraxa/events{/privacy}", "received_events_url": "https://api.github.com/users/Daeraxa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-11-11T16:21:05Z", "updated_at": "2023-11-11T16:23:33Z", "author_association": "CONTRIBUTOR", "body": "~~Actually thinking about it should this be linking to https://joplinapp.org/help/dev/BUILD instead rather than the GH doc link?~~ Pretty sure this gets converted on the fly.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1806856901/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1806869419", "html_url": "https://github.com/laurent22/joplin/pull/9273#issuecomment-1806869419", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9273", "id": 1806869419, "node_id": "IC_kwDOBLftOs5rsqOr", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-11-11T17:17:42Z", "updated_at": "2023-11-11T17:17:42Z", "author_association": "OWNER", "body": "Thanks for fixing this!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1806869419/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }