{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10298", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/10298/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/10298/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/10298/events", "html_url": "https://github.com/laurent22/joplin/pull/10298", "id": 2237556332, "node_id": "PR_kwDOBLftOs5sWfB5", "number": 10298, "title": "Desktop: Resolves #10151: make editor always have dynamic size", "user": { "login": "G0maa", "id": 12874707, "node_id": "MDQ6VXNlcjEyODc0NzA3", "avatar_url": "https://avatars.githubusercontent.com/u/12874707?v=4", "gravatar_id": "", "url": "https://api.github.com/users/G0maa", "html_url": "https://github.com/G0maa", "followers_url": "https://api.github.com/users/G0maa/followers", "following_url": "https://api.github.com/users/G0maa/following{/other_user}", "gists_url": "https://api.github.com/users/G0maa/gists{/gist_id}", "starred_url": "https://api.github.com/users/G0maa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/G0maa/subscriptions", "organizations_url": "https://api.github.com/users/G0maa/orgs", "repos_url": "https://api.github.com/users/G0maa/repos", "events_url": "https://api.github.com/users/G0maa/events{/privacy}", "received_events_url": "https://api.github.com/users/G0maa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 14, "created_at": "2024-04-11T11:56:29Z", "updated_at": "2024-06-04T09:04:19Z", "closed_at": "2024-06-04T08:57:00Z", "author_association": "NONE", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/10298", "html_url": "https://github.com/laurent22/joplin/pull/10298", "diff_url": "https://github.com/laurent22/joplin/pull/10298.diff", "patch_url": "https://github.com/laurent22/joplin/pull/10298.patch", "merged_at": null }, "body": "This resolves #10151.\r\n\r\nBy default all `layoutItem`s have a `resizeableRight` set as true if not last child.\r\n\r\nThis solution adds a `resizeableLeft` option in `LayoutItem` type.\r\nAnd sets if as `true` if the `editor` is before that element.\r\n\r\nThis change should be apparent only if there are elements after `editor`.", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10298/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/10298/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2049534230", "html_url": "https://github.com/laurent22/joplin/pull/10298#issuecomment-2049534230", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10298", "id": 2049534230, "node_id": "IC_kwDOBLftOs56KWkW", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-11T11:56:46Z", "updated_at": "2024-06-04T09:04:19Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2049534230/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2049534527", "html_url": "https://github.com/laurent22/joplin/pull/10298#issuecomment-2049534527", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10298", "id": 2049534527, "node_id": "IC_kwDOBLftOs56KWo_", "user": { "login": "G0maa", "id": 12874707, "node_id": "MDQ6VXNlcjEyODc0NzA3", "avatar_url": "https://avatars.githubusercontent.com/u/12874707?v=4", "gravatar_id": "", "url": "https://api.github.com/users/G0maa", "html_url": "https://github.com/G0maa", "followers_url": "https://api.github.com/users/G0maa/followers", "following_url": "https://api.github.com/users/G0maa/following{/other_user}", "gists_url": "https://api.github.com/users/G0maa/gists{/gist_id}", "starred_url": "https://api.github.com/users/G0maa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/G0maa/subscriptions", "organizations_url": "https://api.github.com/users/G0maa/orgs", "repos_url": "https://api.github.com/users/G0maa/repos", "events_url": "https://api.github.com/users/G0maa/events{/privacy}", "received_events_url": "https://api.github.com/users/G0maa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-11T11:56:57Z", "updated_at": "2024-04-11T11:56:57Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA\r\n\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2049534527/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2049534915", "html_url": "https://github.com/laurent22/joplin/pull/10298#issuecomment-2049534915", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10298", "id": 2049534915, "node_id": "IC_kwDOBLftOs56KWvD", "user": { "login": "G0maa", "id": 12874707, "node_id": "MDQ6VXNlcjEyODc0NzA3", "avatar_url": "https://avatars.githubusercontent.com/u/12874707?v=4", "gravatar_id": "", "url": "https://api.github.com/users/G0maa", "html_url": "https://github.com/G0maa", "followers_url": "https://api.github.com/users/G0maa/followers", "following_url": "https://api.github.com/users/G0maa/following{/other_user}", "gists_url": "https://api.github.com/users/G0maa/gists{/gist_id}", "starred_url": "https://api.github.com/users/G0maa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/G0maa/subscriptions", "organizations_url": "https://api.github.com/users/G0maa/orgs", "repos_url": "https://api.github.com/users/G0maa/repos", "events_url": "https://api.github.com/users/G0maa/events{/privacy}", "received_events_url": "https://api.github.com/users/G0maa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-11T11:57:13Z", "updated_at": "2024-04-11T11:57:13Z", "author_association": "NONE", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2049534915/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2053748920", "html_url": "https://github.com/laurent22/joplin/pull/10298#issuecomment-2053748920", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10298", "id": 2053748920, "node_id": "IC_kwDOBLftOs56abi4", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-13T20:17:54Z", "updated_at": "2024-04-13T20:17:54Z", "author_association": "OWNER", "body": "Could you provide a video showing how it work please? Basically when the editor is **not** in the last column, and you resize the whole window, only the editor should be resized. All other columns should keep their own size. I'm not sure if that's what the code does, but maybe it is.\r\n\r\nAlso we'll need some tests for it but first please provide a video.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2053748920/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2053939712", "html_url": "https://github.com/laurent22/joplin/pull/10298#issuecomment-2053939712", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10298", "id": 2053939712, "node_id": "IC_kwDOBLftOs56bKIA", "user": { "login": "G0maa", "id": 12874707, "node_id": "MDQ6VXNlcjEyODc0NzA3", "avatar_url": "https://avatars.githubusercontent.com/u/12874707?v=4", "gravatar_id": "", "url": "https://api.github.com/users/G0maa", "html_url": "https://github.com/G0maa", "followers_url": "https://api.github.com/users/G0maa/followers", "following_url": "https://api.github.com/users/G0maa/following{/other_user}", "gists_url": "https://api.github.com/users/G0maa/gists{/gist_id}", "starred_url": "https://api.github.com/users/G0maa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/G0maa/subscriptions", "organizations_url": "https://api.github.com/users/G0maa/orgs", "repos_url": "https://api.github.com/users/G0maa/repos", "events_url": "https://api.github.com/users/G0maa/events{/privacy}", "received_events_url": "https://api.github.com/users/G0maa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-14T07:08:12Z", "updated_at": "2024-04-14T07:10:47Z", "author_association": "NONE", "body": "Hello Laurent,\r\n\r\nI've just made it so you're resizing the `noteList` element not `editor` element. (or any element that comes after the `editor` directly)\r\n\r\nP.S. you can see at `0:24` the `Outline` element is dynamic too, this happens **only** when the layout is reset. When you resize `Outline` element, it works as expected.\r\n\r\nVideo as requested:\r\n\r\nhttps://github.com/laurent22/joplin/assets/12874707/0b9efbc4-cff3-41da-be99-4eb1364c3b32\r\n\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2053939712/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2054178651", "html_url": "https://github.com/laurent22/joplin/pull/10298#issuecomment-2054178651", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10298", "id": 2054178651, "node_id": "IC_kwDOBLftOs56cEdb", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-14T20:39:35Z", "updated_at": "2024-04-14T20:39:35Z", "author_association": "OWNER", "body": "Thank you, that indeed looks good. Would you mind adding tests for it? Perhaps in `useLayoutItemSizes.test.ts`, and one for `validateLayout.ts` too since this is what you're modifying.\r\n\r\n> P.S. you can see at 0:24 the Outline element is dynamic too, this happens only when the layout is reset. When you resize Outline element, it works as expected.\r\n\r\nIs there any way to fix this? It seems it starts working once you resize one of the panel, so maybe it means the \"width\" property needs to be set right away? Or maybe some rule that auto-size panels when the width is undefined needs to be removed?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2054178651/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2061289400", "html_url": "https://github.com/laurent22/joplin/pull/10298#issuecomment-2061289400", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10298", "id": 2061289400, "node_id": "IC_kwDOBLftOs563Me4", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-17T13:40:19Z", "updated_at": "2024-04-17T13:40:19Z", "author_association": "OWNER", "body": "Any update?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2061289400/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2061505089", "html_url": "https://github.com/laurent22/joplin/pull/10298#issuecomment-2061505089", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10298", "id": 2061505089, "node_id": "IC_kwDOBLftOs564BJB", "user": { "login": "G0maa", "id": 12874707, "node_id": "MDQ6VXNlcjEyODc0NzA3", "avatar_url": "https://avatars.githubusercontent.com/u/12874707?v=4", "gravatar_id": "", "url": "https://api.github.com/users/G0maa", "html_url": "https://github.com/G0maa", "followers_url": "https://api.github.com/users/G0maa/followers", "following_url": "https://api.github.com/users/G0maa/following{/other_user}", "gists_url": "https://api.github.com/users/G0maa/gists{/gist_id}", "starred_url": "https://api.github.com/users/G0maa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/G0maa/subscriptions", "organizations_url": "https://api.github.com/users/G0maa/orgs", "repos_url": "https://api.github.com/users/G0maa/repos", "events_url": "https://api.github.com/users/G0maa/events{/privacy}", "received_events_url": "https://api.github.com/users/G0maa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-17T15:11:37Z", "updated_at": "2024-04-17T15:11:37Z", "author_association": "NONE", "body": "Hello, Sorry for being late.\r\n\r\nI haven't started working on writing the tests yet. I'll do them in the weekend probably.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2061505089/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2063645567", "html_url": "https://github.com/laurent22/joplin/pull/10298#issuecomment-2063645567", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10298", "id": 2063645567, "node_id": "IC_kwDOBLftOs57ALt_", "user": { "login": "G0maa", "id": 12874707, "node_id": "MDQ6VXNlcjEyODc0NzA3", "avatar_url": "https://avatars.githubusercontent.com/u/12874707?v=4", "gravatar_id": "", "url": "https://api.github.com/users/G0maa", "html_url": "https://github.com/G0maa", "followers_url": "https://api.github.com/users/G0maa/followers", "following_url": "https://api.github.com/users/G0maa/following{/other_user}", "gists_url": "https://api.github.com/users/G0maa/gists{/gist_id}", "starred_url": "https://api.github.com/users/G0maa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/G0maa/subscriptions", "organizations_url": "https://api.github.com/users/G0maa/orgs", "repos_url": "https://api.github.com/users/G0maa/repos", "events_url": "https://api.github.com/users/G0maa/events{/privacy}", "received_events_url": "https://api.github.com/users/G0maa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-18T11:30:12Z", "updated_at": "2024-04-18T11:30:12Z", "author_association": "NONE", "body": "I've added two simple tests, I'm unsure if they're enough or not. It's implied that if an element has neither `resizeableRight` nor `resizeableLeft` then it can't have width (like `editor`). \r\n\r\n> Is there any way to fix this? It seems it starts working once you resize one of the panel, so maybe it means the \"width\" property needs to be set right away? Or maybe some rule that auto-size panels when the width is undefined needs to be removed?\r\n\r\nI can look into this, but I'm not sure if it's a good idea, as every new added element will have e.g. minimum width.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2063645567/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2075352076", "html_url": "https://github.com/laurent22/joplin/pull/10298#issuecomment-2075352076", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10298", "id": 2075352076, "node_id": "IC_kwDOBLftOs57s1wM", "user": { "login": "G0maa", "id": 12874707, "node_id": "MDQ6VXNlcjEyODc0NzA3", "avatar_url": "https://avatars.githubusercontent.com/u/12874707?v=4", "gravatar_id": "", "url": "https://api.github.com/users/G0maa", "html_url": "https://github.com/G0maa", "followers_url": "https://api.github.com/users/G0maa/followers", "following_url": "https://api.github.com/users/G0maa/following{/other_user}", "gists_url": "https://api.github.com/users/G0maa/gists{/gist_id}", "starred_url": "https://api.github.com/users/G0maa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/G0maa/subscriptions", "organizations_url": "https://api.github.com/users/G0maa/orgs", "repos_url": "https://api.github.com/users/G0maa/repos", "events_url": "https://api.github.com/users/G0maa/events{/privacy}", "received_events_url": "https://api.github.com/users/G0maa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-24T16:19:02Z", "updated_at": "2024-04-30T07:03:31Z", "author_association": "NONE", "body": "I noticed other bugs... it's kind of amusing. This solution probably needs more work since the only way for it to work is if you pretty much resize all panes after resetting layout (not practical).\r\n\r\nAwaiting your tips.\r\n\r\nhttps://github.com/laurent22/joplin/assets/12874707/f8eafb95-9cda-4452-af16-7d2980f343ec\r\n\r\nEdit: this one was already existent before my change.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2075352076/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2097748413", "html_url": "https://github.com/laurent22/joplin/pull/10298#issuecomment-2097748413", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10298", "id": 2097748413, "node_id": "IC_kwDOBLftOs59CRm9", "user": { "login": "G0maa", "id": 12874707, "node_id": "MDQ6VXNlcjEyODc0NzA3", "avatar_url": "https://avatars.githubusercontent.com/u/12874707?v=4", "gravatar_id": "", "url": "https://api.github.com/users/G0maa", "html_url": "https://github.com/G0maa", "followers_url": "https://api.github.com/users/G0maa/followers", "following_url": "https://api.github.com/users/G0maa/following{/other_user}", "gists_url": "https://api.github.com/users/G0maa/gists{/gist_id}", "starred_url": "https://api.github.com/users/G0maa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/G0maa/subscriptions", "organizations_url": "https://api.github.com/users/G0maa/orgs", "repos_url": "https://api.github.com/users/G0maa/repos", "events_url": "https://api.github.com/users/G0maa/events{/privacy}", "received_events_url": "https://api.github.com/users/G0maa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-05-07T08:33:48Z", "updated_at": "2024-05-07T08:33:48Z", "author_association": "NONE", "body": "Hello?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2097748413/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2124871919", "html_url": "https://github.com/laurent22/joplin/pull/10298#issuecomment-2124871919", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10298", "id": 2124871919, "node_id": "IC_kwDOBLftOs5-pvjv", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-05-22T13:58:52Z", "updated_at": "2024-05-22T13:58:52Z", "author_association": "OWNER", "body": "Hi @G0maa, this last issue you found indeed would need to be fixed. Please let me know if you still want to work on this", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2124871919/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2125304701", "html_url": "https://github.com/laurent22/joplin/pull/10298#issuecomment-2125304701", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10298", "id": 2125304701, "node_id": "IC_kwDOBLftOs5-rZN9", "user": { "login": "G0maa", "id": 12874707, "node_id": "MDQ6VXNlcjEyODc0NzA3", "avatar_url": "https://avatars.githubusercontent.com/u/12874707?v=4", "gravatar_id": "", "url": "https://api.github.com/users/G0maa", "html_url": "https://github.com/G0maa", "followers_url": "https://api.github.com/users/G0maa/followers", "following_url": "https://api.github.com/users/G0maa/following{/other_user}", "gists_url": "https://api.github.com/users/G0maa/gists{/gist_id}", "starred_url": "https://api.github.com/users/G0maa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/G0maa/subscriptions", "organizations_url": "https://api.github.com/users/G0maa/orgs", "repos_url": "https://api.github.com/users/G0maa/repos", "events_url": "https://api.github.com/users/G0maa/events{/privacy}", "received_events_url": "https://api.github.com/users/G0maa/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-05-22T16:53:44Z", "updated_at": "2024-05-22T16:53:44Z", "author_association": "NONE", "body": "@laurent22 I'm still here.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2125304701/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2146980005", "html_url": "https://github.com/laurent22/joplin/pull/10298#issuecomment-2146980005", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10298", "id": 2146980005, "node_id": "IC_kwDOBLftOs5_-FCl", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-06-04T08:57:00Z", "updated_at": "2024-06-04T08:57:00Z", "author_association": "OWNER", "body": "@G0maa, I will close the pull request for now as we try to keep only active pull requests open. If you'd like to keep working on it though please let me know", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2146980005/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }