{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/12060", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12060/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12060/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12060/events", "html_url": "https://github.com/laurent22/joplin/pull/12060", "id": 2974193049, "node_id": "PR_kwDOBLftOs6RgOYU", "number": 12060, "title": "Desktop: Fix #10403: size displayed wrong in attachements tab", "user": { "login": "GGpifas", "id": 103130352, "node_id": "U_kgDOBiWk8A", "avatar_url": "https://avatars.githubusercontent.com/u/103130352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/GGpifas", "html_url": "https://github.com/GGpifas", "followers_url": "https://api.github.com/users/GGpifas/followers", "following_url": "https://api.github.com/users/GGpifas/following{/other_user}", "gists_url": "https://api.github.com/users/GGpifas/gists{/gist_id}", "starred_url": "https://api.github.com/users/GGpifas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/GGpifas/subscriptions", "organizations_url": "https://api.github.com/users/GGpifas/orgs", "repos_url": "https://api.github.com/users/GGpifas/repos", "events_url": "https://api.github.com/users/GGpifas/events{/privacy}", "received_events_url": "https://api.github.com/users/GGpifas/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 6, "created_at": "2025-04-05T13:10:13Z", "updated_at": "2025-04-07T19:16:36Z", "closed_at": "2025-04-07T19:00:32Z", "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/12060", "html_url": "https://github.com/laurent22/joplin/pull/12060", "diff_url": "https://github.com/laurent22/joplin/pull/12060.diff", "patch_url": "https://github.com/laurent22/joplin/pull/12060.patch", "merged_at": null }, "body": "Whenever an attachment was modified and its size changes, the table and the database were not being updated. So the fix was to watch the resources who have been changed, immediately update the database and\r\nthe table. This assuming you are editing\r\nthe file while the app is open.\r\nIf you edit it while the app is closed,\r\ni made sure that when the table is loaded, it's updated.\r\n\r\nHere is a video for the fix:\r\nhttps://www.youtube.com/watch?v=LoLRCkLlxd4", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/12060/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12060/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780717352", "html_url": "https://github.com/laurent22/joplin/pull/12060#issuecomment-2780717352", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12060", "id": 2780717352, "node_id": "IC_kwDOBLftOs6lvmEo", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-05T13:10:24Z", "updated_at": "2025-04-07T19:02:28Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780717352/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780718340", "html_url": "https://github.com/laurent22/joplin/pull/12060#issuecomment-2780718340", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12060", "id": 2780718340, "node_id": "IC_kwDOBLftOs6lvmUE", "user": { "login": "GGpifas", "id": 103130352, "node_id": "U_kgDOBiWk8A", "avatar_url": "https://avatars.githubusercontent.com/u/103130352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/GGpifas", "html_url": "https://github.com/GGpifas", "followers_url": "https://api.github.com/users/GGpifas/followers", "following_url": "https://api.github.com/users/GGpifas/following{/other_user}", "gists_url": "https://api.github.com/users/GGpifas/gists{/gist_id}", "starred_url": "https://api.github.com/users/GGpifas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/GGpifas/subscriptions", "organizations_url": "https://api.github.com/users/GGpifas/orgs", "repos_url": "https://api.github.com/users/GGpifas/repos", "events_url": "https://api.github.com/users/GGpifas/events{/privacy}", "received_events_url": "https://api.github.com/users/GGpifas/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-05T13:12:43Z", "updated_at": "2025-04-05T13:12:43Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780718340/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780789035", "html_url": "https://github.com/laurent22/joplin/pull/12060#issuecomment-2780789035", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12060", "id": 2780789035, "node_id": "IC_kwDOBLftOs6lv3kr", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-05T14:49:59Z", "updated_at": "2025-04-05T14:49:59Z", "author_association": "OWNER", "body": "I think the file size should be updated whenever the resource itself is being updated? In `ResourceEditWatcher` it's already watching the resources", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2780789035/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784282716", "html_url": "https://github.com/laurent22/joplin/pull/12060#issuecomment-2784282716", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12060", "id": 2784282716, "node_id": "IC_kwDOBLftOs6l9Mhc", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-07T19:00:32Z", "updated_at": "2025-04-07T19:00:32Z", "author_association": "OWNER", "body": "Please see above comment. For now I'm closing the PR but feel free to let me know if you're willing to address the above issue", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784282716/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784332963", "html_url": "https://github.com/laurent22/joplin/pull/12060#issuecomment-2784332963", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12060", "id": 2784332963, "node_id": "IC_kwDOBLftOs6l9Yyj", "user": { "login": "GGpifas", "id": 103130352, "node_id": "U_kgDOBiWk8A", "avatar_url": "https://avatars.githubusercontent.com/u/103130352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/GGpifas", "html_url": "https://github.com/GGpifas", "followers_url": "https://api.github.com/users/GGpifas/followers", "following_url": "https://api.github.com/users/GGpifas/following{/other_user}", "gists_url": "https://api.github.com/users/GGpifas/gists{/gist_id}", "starred_url": "https://api.github.com/users/GGpifas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/GGpifas/subscriptions", "organizations_url": "https://api.github.com/users/GGpifas/orgs", "repos_url": "https://api.github.com/users/GGpifas/repos", "events_url": "https://api.github.com/users/GGpifas/events{/privacy}", "received_events_url": "https://api.github.com/users/GGpifas/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-07T19:13:47Z", "updated_at": "2025-04-07T19:13:47Z", "author_association": "NONE", "body": "I'm so sorry for the time it took me to reply. I intend to address the issue, i haven't been able to work on it these days, but i will come back to it. I tried to change it on ResourceEditWatcher but the size wasn't changing on the table so i opted to do it on when the table is created.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784332963/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784364496", "html_url": "https://github.com/laurent22/joplin/pull/12060#issuecomment-2784364496", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12060", "id": 2784364496, "node_id": "IC_kwDOBLftOs6l9gfQ", "user": { "login": "GGpifas", "id": 103130352, "node_id": "U_kgDOBiWk8A", "avatar_url": "https://avatars.githubusercontent.com/u/103130352?v=4", "gravatar_id": "", "url": "https://api.github.com/users/GGpifas", "html_url": "https://github.com/GGpifas", "followers_url": "https://api.github.com/users/GGpifas/followers", "following_url": "https://api.github.com/users/GGpifas/following{/other_user}", "gists_url": "https://api.github.com/users/GGpifas/gists{/gist_id}", "starred_url": "https://api.github.com/users/GGpifas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/GGpifas/subscriptions", "organizations_url": "https://api.github.com/users/GGpifas/orgs", "repos_url": "https://api.github.com/users/GGpifas/repos", "events_url": "https://api.github.com/users/GGpifas/events{/privacy}", "received_events_url": "https://api.github.com/users/GGpifas/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-07T19:16:35Z", "updated_at": "2025-04-07T19:16:35Z", "author_association": "NONE", "body": "I'm so sorry for the time it took me to reply, I intend to work on it, and\r\nI messaged you on the closed pull request.\r\nHave a good one\r\n\r\nLaurent Cozic ***@***.***> escreveu (segunda, 7/04/2025 à(s)\r\n20:00):\r\n\r\n> Please see above comment. For now I'm closing the PR but feel free to let\r\n> me know if you're willing to address the above issue\r\n>\r\n> —\r\n> Reply to this email directly, view it on GitHub\r\n> ,\r\n> or unsubscribe\r\n> \r\n> .\r\n> You are receiving this because you authored the thread.Message ID:\r\n> ***@***.***>\r\n> [image: laurent22]*laurent22* left a comment (laurent22/joplin#12060)\r\n> \r\n>\r\n> Please see above comment. For now I'm closing the PR but feel free to let\r\n> me know if you're willing to address the above issue\r\n>\r\n> —\r\n> Reply to this email directly, view it on GitHub\r\n> ,\r\n> or unsubscribe\r\n> \r\n> .\r\n> You are receiving this because you authored the thread.Message ID:\r\n> ***@***.***>\r\n>\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2784364496/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }