{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14161", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14161/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14161/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14161/events", "html_url": "https://github.com/laurent22/joplin/pull/14161", "id": 3832380667, "node_id": "PR_kwDOBLftOs6-JP83", "number": 14161, "title": "Mobile: Fixes #12839: Scale code block font size with base font setting in Rich Text Editor", "user": { "login": "GlobalStar117", "id": 146701565, "node_id": "U_kgDOCL58_Q", "avatar_url": "https://avatars.githubusercontent.com/u/146701565?v=4", "gravatar_id": "", "url": "https://api.github.com/users/GlobalStar117", "html_url": "https://github.com/GlobalStar117", "followers_url": "https://api.github.com/users/GlobalStar117/followers", "following_url": "https://api.github.com/users/GlobalStar117/following{/other_user}", "gists_url": "https://api.github.com/users/GlobalStar117/gists{/gist_id}", "starred_url": "https://api.github.com/users/GlobalStar117/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/GlobalStar117/subscriptions", "organizations_url": "https://api.github.com/users/GlobalStar117/orgs", "repos_url": "https://api.github.com/users/GlobalStar117/repos", "events_url": "https://api.github.com/users/GlobalStar117/events{/privacy}", "received_events_url": "https://api.github.com/users/GlobalStar117/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 2, "created_at": "2026-01-20T07:13:57Z", "updated_at": "2026-01-26T05:07:04Z", "closed_at": "2026-01-26T05:07:04Z", "assignee": null, "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14161", "html_url": "https://github.com/laurent22/joplin/pull/14161", "diff_url": "https://github.com/laurent22/joplin/pull/14161.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14161.patch", "merged_at": null }, "body": "## Summary\n\nThis PR fixes an issue where code blocks in the Rich Text Editor on mobile did not scale with the base font size setting.\n\n**Fixes:** #12839\n\n## Problem\n\nThe Rich Text Editor on mobile used a hardcoded font size (`13pt`) for the body element. Since code blocks use relative `em` units for their font size (inherited from the body), changing the base font size setting had no effect on code block text - only regular text would resize.\n\n## Solution\n\nUpdated `RichTextEditor.tsx` to use the font size from `editorSettings.themeData` instead of the hardcoded value. This ensures that:\n- The body font size matches the user's font size setting\n- Code blocks (which use `em` units) properly scale along with the body font\n- Inline code and code blocks now respond to font size changes consistently with regular text\n\n## Changes\n\n- Added `EditorSettings` import to `RichTextEditor.tsx`\n- Updated `useCss` function to accept `editorSettings` parameter\n- Replaced hardcoded `font-size: 13pt;` with the theme's configured font size\n- Updated the call site to pass `props.editorSettings`\n\n## Testing\n\n1. Open the mobile app and create a note with code blocks\n2. Go to Settings > Note Viewer Font Size and change the value\n3. Verify that both regular text and code blocks scale accordingly\n\n---\n\n[Gittensor contribution - GlobalStar117]", "closed_by": { "login": "GlobalStar117", "id": 146701565, "node_id": "U_kgDOCL58_Q", "avatar_url": "https://avatars.githubusercontent.com/u/146701565?v=4", "gravatar_id": "", "url": "https://api.github.com/users/GlobalStar117", "html_url": "https://github.com/GlobalStar117", "followers_url": "https://api.github.com/users/GlobalStar117/followers", "following_url": "https://api.github.com/users/GlobalStar117/following{/other_user}", "gists_url": "https://api.github.com/users/GlobalStar117/gists{/gist_id}", "starred_url": "https://api.github.com/users/GlobalStar117/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/GlobalStar117/subscriptions", "organizations_url": "https://api.github.com/users/GlobalStar117/orgs", "repos_url": "https://api.github.com/users/GlobalStar117/repos", "events_url": "https://api.github.com/users/GlobalStar117/events{/privacy}", "received_events_url": "https://api.github.com/users/GlobalStar117/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14161/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14161/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3771378119", "html_url": "https://github.com/laurent22/joplin/pull/14161#issuecomment-3771378119", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14161", "id": 3771378119, "node_id": "IC_kwDOBLftOs7gyqnH", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-01-20T07:14:09Z", "updated_at": "2026-01-20T07:16:40Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3771378119/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3771384104", "html_url": "https://github.com/laurent22/joplin/pull/14161#issuecomment-3771384104", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14161", "id": 3771384104, "node_id": "IC_kwDOBLftOs7gysEo", "user": { "login": "GlobalStar117", "id": 146701565, "node_id": "U_kgDOCL58_Q", "avatar_url": "https://avatars.githubusercontent.com/u/146701565?v=4", "gravatar_id": "", "url": "https://api.github.com/users/GlobalStar117", "html_url": "https://github.com/GlobalStar117", "followers_url": "https://api.github.com/users/GlobalStar117/followers", "following_url": "https://api.github.com/users/GlobalStar117/following{/other_user}", "gists_url": "https://api.github.com/users/GlobalStar117/gists{/gist_id}", "starred_url": "https://api.github.com/users/GlobalStar117/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/GlobalStar117/subscriptions", "organizations_url": "https://api.github.com/users/GlobalStar117/orgs", "repos_url": "https://api.github.com/users/GlobalStar117/repos", "events_url": "https://api.github.com/users/GlobalStar117/events{/privacy}", "received_events_url": "https://api.github.com/users/GlobalStar117/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-01-20T07:16:15Z", "updated_at": "2026-01-20T07:16:15Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3771384104/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }