{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10035", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/10035/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/10035/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/10035/events", "html_url": "https://github.com/laurent22/joplin/pull/10035", "id": 2164631228, "node_id": "PR_kwDOBLftOs5oeZTh", "number": 10035, "title": "Desktop: Fixes #9960: Modified setting to store profile languages", "user": { "login": "GuptTmay", "id": 138118622, "node_id": "U_kgDOCDuF3g", "avatar_url": "https://avatars.githubusercontent.com/u/138118622?v=4", "gravatar_id": "", "url": "https://api.github.com/users/GuptTmay", "html_url": "https://github.com/GuptTmay", "followers_url": "https://api.github.com/users/GuptTmay/followers", "following_url": "https://api.github.com/users/GuptTmay/following{/other_user}", "gists_url": "https://api.github.com/users/GuptTmay/gists{/gist_id}", "starred_url": "https://api.github.com/users/GuptTmay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/GuptTmay/subscriptions", "organizations_url": "https://api.github.com/users/GuptTmay/orgs", "repos_url": "https://api.github.com/users/GuptTmay/repos", "events_url": "https://api.github.com/users/GuptTmay/events{/privacy}", "received_events_url": "https://api.github.com/users/GuptTmay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 5, "created_at": "2024-03-02T06:19:58Z", "updated_at": "2024-03-02T12:05:29Z", "closed_at": "2024-03-02T10:57:48Z", "author_association": "NONE", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/10035", "html_url": "https://github.com/laurent22/joplin/pull/10035", "diff_url": "https://github.com/laurent22/joplin/pull/10035.diff", "patch_url": "https://github.com/laurent22/joplin/pull/10035.patch", "merged_at": null }, "body": " Hi, This pr fixes [#9960](https://github.com/laurent22/joplin/issues/9960)\r\n\r\nQuick summary of what I did:\r\n- Modified spellChecker.languages isGlobe settingItem so that it store/take its value from profile setting itself (not from global setting.json)\r\n- Modified SpellCheckerServices.ts to make default spellChecker language to set 'en-US' when profile is created for the first Time\r\n\r\nHere are the test for windows:\r\n![default](https://github.com/laurent22/joplin/assets/138118622/7eb3949b-5383-4162-a4ff-a6796b2f0d09)\r\n![existing](https://github.com/laurent22/joplin/assets/138118622/4692736c-01ce-484b-a82e-f9060b103b5b)\r\n![newProfile](https://github.com/laurent22/joplin/assets/138118622/f110a93d-6db9-431e-814e-cf65b1be5dda)\r\n\r\nHere is a test video if needed: \r\n\r\nhttps://github.com/laurent22/joplin/assets/138118622/b117fb2b-bb9b-4a15-8bd5-b10c2af7afd7\r\n\r\nI have tested this for windows.\r\nI will be giving tests for Android soon\r\n\r\n\r\n(P.S - This is my first PR so please guide me if anything is wrong)\r\n\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10035/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/10035/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1974385488", "html_url": "https://github.com/laurent22/joplin/pull/10035#issuecomment-1974385488", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10035", "id": 1974385488, "node_id": "IC_kwDOBLftOs51rrtQ", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-02T06:20:14Z", "updated_at": "2024-03-02T10:58:02Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1974385488/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1974394607", "html_url": "https://github.com/laurent22/joplin/pull/10035#issuecomment-1974394607", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10035", "id": 1974394607, "node_id": "IC_kwDOBLftOs51rt7v", "user": { "login": "GuptTmay", "id": 138118622, "node_id": "U_kgDOCDuF3g", "avatar_url": "https://avatars.githubusercontent.com/u/138118622?v=4", "gravatar_id": "", "url": "https://api.github.com/users/GuptTmay", "html_url": "https://github.com/GuptTmay", "followers_url": "https://api.github.com/users/GuptTmay/followers", "following_url": "https://api.github.com/users/GuptTmay/following{/other_user}", "gists_url": "https://api.github.com/users/GuptTmay/gists{/gist_id}", "starred_url": "https://api.github.com/users/GuptTmay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/GuptTmay/subscriptions", "organizations_url": "https://api.github.com/users/GuptTmay/orgs", "repos_url": "https://api.github.com/users/GuptTmay/repos", "events_url": "https://api.github.com/users/GuptTmay/events{/privacy}", "received_events_url": "https://api.github.com/users/GuptTmay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-02T06:25:00Z", "updated_at": "2024-03-02T06:25:00Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1974394607/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1974763343", "html_url": "https://github.com/laurent22/joplin/pull/10035#issuecomment-1974763343", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10035", "id": 1974763343, "node_id": "IC_kwDOBLftOs51tH9P", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-02T10:57:48Z", "updated_at": "2024-03-02T10:57:58Z", "author_association": "OWNER", "body": "Sorry you didn't understand the original issue. The author wasn't talking about the spellchecker languages but about the application locale, under General => Language", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1974763343/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1974774501", "html_url": "https://github.com/laurent22/joplin/pull/10035#issuecomment-1974774501", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10035", "id": 1974774501, "node_id": "IC_kwDOBLftOs51tKrl", "user": { "login": "GuptTmay", "id": 138118622, "node_id": "U_kgDOCDuF3g", "avatar_url": "https://avatars.githubusercontent.com/u/138118622?v=4", "gravatar_id": "", "url": "https://api.github.com/users/GuptTmay", "html_url": "https://github.com/GuptTmay", "followers_url": "https://api.github.com/users/GuptTmay/followers", "following_url": "https://api.github.com/users/GuptTmay/following{/other_user}", "gists_url": "https://api.github.com/users/GuptTmay/gists{/gist_id}", "starred_url": "https://api.github.com/users/GuptTmay/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/GuptTmay/subscriptions", "organizations_url": "https://api.github.com/users/GuptTmay/orgs", "repos_url": "https://api.github.com/users/GuptTmay/repos", "events_url": "https://api.github.com/users/GuptTmay/events{/privacy}", "received_events_url": "https://api.github.com/users/GuptTmay/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-02T11:48:21Z", "updated_at": "2024-03-02T11:48:21Z", "author_association": "NONE", "body": "Thanks for the feedback and sorry for the misunderstanding. I will look into it. Can I resubmit a new pr for this issue?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1974774501/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1974778342", "html_url": "https://github.com/laurent22/joplin/pull/10035#issuecomment-1974778342", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10035", "id": 1974778342, "node_id": "IC_kwDOBLftOs51tLnm", "user": { "login": "PackElend", "id": 3542031, "node_id": "MDQ6VXNlcjM1NDIwMzE=", "avatar_url": "https://avatars.githubusercontent.com/u/3542031?v=4", "gravatar_id": "", "url": "https://api.github.com/users/PackElend", "html_url": "https://github.com/PackElend", "followers_url": "https://api.github.com/users/PackElend/followers", "following_url": "https://api.github.com/users/PackElend/following{/other_user}", "gists_url": "https://api.github.com/users/PackElend/gists{/gist_id}", "starred_url": "https://api.github.com/users/PackElend/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/PackElend/subscriptions", "organizations_url": "https://api.github.com/users/PackElend/orgs", "repos_url": "https://api.github.com/users/PackElend/repos", "events_url": "https://api.github.com/users/PackElend/events{/privacy}", "received_events_url": "https://api.github.com/users/PackElend/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-02T12:05:28Z", "updated_at": "2024-03-02T12:05:28Z", "author_association": "CONTRIBUTOR", "body": "> Can I resubmit a new pr for this issue?\r\n\r\nSure ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1974778342/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }