{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/13994", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/13994/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/13994/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/13994/events", "html_url": "https://github.com/laurent22/joplin/pull/13994", "id": 3763884528, "node_id": "PR_kwDOBLftOs66p8_z", "number": 13994, "title": "Desktop, Mobile: Fixes #13229: Insert time command not respecting locale settings", "user": { "login": "Ahmed-Idani", "id": 159375940, "node_id": "U_kgDOCX_iRA", "avatar_url": "https://avatars.githubusercontent.com/u/159375940?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Ahmed-Idani", "html_url": "https://github.com/Ahmed-Idani", "followers_url": "https://api.github.com/users/Ahmed-Idani/followers", "following_url": "https://api.github.com/users/Ahmed-Idani/following{/other_user}", "gists_url": "https://api.github.com/users/Ahmed-Idani/gists{/gist_id}", "starred_url": "https://api.github.com/users/Ahmed-Idani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Ahmed-Idani/subscriptions", "organizations_url": "https://api.github.com/users/Ahmed-Idani/orgs", "repos_url": "https://api.github.com/users/Ahmed-Idani/repos", "events_url": "https://api.github.com/users/Ahmed-Idani/events{/privacy}", "received_events_url": "https://api.github.com/users/Ahmed-Idani/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 1079605111, "node_id": "MDU6TGFiZWwxMDc5NjA1MTEx", "url": "https://api.github.com/repos/laurent22/joplin/labels/mobile", "name": "mobile", "color": "ffc274", "default": false, "description": "All mobile platforms" }, { "id": 1080341216, "node_id": "MDU6TGFiZWwxMDgwMzQxMjE2", "url": "https://api.github.com/repos/laurent22/joplin/labels/desktop", "name": "desktop", "color": "ffc274", "default": false, "description": "All desktop platforms" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 6, "created_at": "2025-12-26T19:07:59Z", "updated_at": "2026-01-07T12:59:55Z", "closed_at": "2026-01-07T11:48:15Z", "assignee": null, "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/13994", "html_url": "https://github.com/laurent22/joplin/pull/13994", "diff_url": "https://github.com/laurent22/joplin/pull/13994.diff", "patch_url": "https://github.com/laurent22/joplin/pull/13994.patch", "merged_at": "2026-01-07T11:48:15Z" }, "body": "The \"Insert time\" command (Ctrl+Shift+T) was not respecting the user's locale settings. When a user set their locale to Spanish (es_ES) and used a date format like \"dddd YYYY-MM-DD\", the day name was displayed in English (e.g., \"Tuesday\") instead of the configured locale (e.g., \"Martes\").\r\n\r\nRoot cause:\r\n- The command was using `time.formatMsToLocal()` from `@joplin/lib/time` which uses moment.js but does not load locale data\r\n- moment.js requires explicit locale imports to display localized strings\r\n\r\nFix:\r\n- Switch to using `formatMsToLocal()` from `@joplin/utils/time` which uses dayjs with properly loaded locale data for all supported languages\r\n\r\nThis fix applies to both desktop and mobile apps.\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/13994/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/13994/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3693263819", "html_url": "https://github.com/laurent22/joplin/pull/13994#issuecomment-3693263819", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13994", "id": 3693263819, "node_id": "IC_kwDOBLftOs7cIrvL", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2025-12-26T19:19:36Z", "updated_at": "2026-01-07T12:59:55Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3693263819/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3693267506", "html_url": "https://github.com/laurent22/joplin/pull/13994#issuecomment-3693267506", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13994", "id": 3693267506, "node_id": "IC_kwDOBLftOs7cIsoy", "user": { "login": "Ahmed-Idani", "id": 159375940, "node_id": "U_kgDOCX_iRA", "avatar_url": "https://avatars.githubusercontent.com/u/159375940?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Ahmed-Idani", "html_url": "https://github.com/Ahmed-Idani", "followers_url": "https://api.github.com/users/Ahmed-Idani/followers", "following_url": "https://api.github.com/users/Ahmed-Idani/following{/other_user}", "gists_url": "https://api.github.com/users/Ahmed-Idani/gists{/gist_id}", "starred_url": "https://api.github.com/users/Ahmed-Idani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Ahmed-Idani/subscriptions", "organizations_url": "https://api.github.com/users/Ahmed-Idani/orgs", "repos_url": "https://api.github.com/users/Ahmed-Idani/repos", "events_url": "https://api.github.com/users/Ahmed-Idani/events{/privacy}", "received_events_url": "https://api.github.com/users/Ahmed-Idani/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-12-26T19:23:18Z", "updated_at": "2025-12-26T19:23:18Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3693267506/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3695117229", "html_url": "https://github.com/laurent22/joplin/pull/13994#issuecomment-3695117229", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13994", "id": 3695117229, "node_id": "IC_kwDOBLftOs7cPwOt", "user": { "login": "Ahmed-Idani", "id": 159375940, "node_id": "U_kgDOCX_iRA", "avatar_url": "https://avatars.githubusercontent.com/u/159375940?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Ahmed-Idani", "html_url": "https://github.com/Ahmed-Idani", "followers_url": "https://api.github.com/users/Ahmed-Idani/followers", "following_url": "https://api.github.com/users/Ahmed-Idani/following{/other_user}", "gists_url": "https://api.github.com/users/Ahmed-Idani/gists{/gist_id}", "starred_url": "https://api.github.com/users/Ahmed-Idani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Ahmed-Idani/subscriptions", "organizations_url": "https://api.github.com/users/Ahmed-Idani/orgs", "repos_url": "https://api.github.com/users/Ahmed-Idani/repos", "events_url": "https://api.github.com/users/Ahmed-Idani/events{/privacy}", "received_events_url": "https://api.github.com/users/Ahmed-Idani/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-12-28T23:00:48Z", "updated_at": "2025-12-28T23:00:48Z", "body": "@laurent22 shall it be merged?", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3695117229/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3695146447", "html_url": "https://github.com/laurent22/joplin/pull/13994#issuecomment-3695146447", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13994", "id": 3695146447, "node_id": "IC_kwDOBLftOs7cP3XP", "user": { "login": "mrjo118", "id": 6963004, "node_id": "MDQ6VXNlcjY5NjMwMDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/6963004?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mrjo118", "html_url": "https://github.com/mrjo118", "followers_url": "https://api.github.com/users/mrjo118/followers", "following_url": "https://api.github.com/users/mrjo118/following{/other_user}", "gists_url": "https://api.github.com/users/mrjo118/gists{/gist_id}", "starred_url": "https://api.github.com/users/mrjo118/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mrjo118/subscriptions", "organizations_url": "https://api.github.com/users/mrjo118/orgs", "repos_url": "https://api.github.com/users/mrjo118/repos", "events_url": "https://api.github.com/users/mrjo118/events{/privacy}", "received_events_url": "https://api.github.com/users/mrjo118/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-12-28T23:48:32Z", "updated_at": "2025-12-28T23:48:32Z", "body": "@HIJOdelIDANII PR's take time to review and there are many PRs created regularly for this project to be reviewed. Also bear in mind that depending on priority and the stage in the release cycle, a PR can sometimes be put on hold for some weeks before being looked at", "author_association": "COLLABORATOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3695146447/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3696383394", "html_url": "https://github.com/laurent22/joplin/pull/13994#issuecomment-3696383394", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13994", "id": 3696383394, "node_id": "IC_kwDOBLftOs7cUlWi", "user": { "login": "Ahmed-Idani", "id": 159375940, "node_id": "U_kgDOCX_iRA", "avatar_url": "https://avatars.githubusercontent.com/u/159375940?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Ahmed-Idani", "html_url": "https://github.com/Ahmed-Idani", "followers_url": "https://api.github.com/users/Ahmed-Idani/followers", "following_url": "https://api.github.com/users/Ahmed-Idani/following{/other_user}", "gists_url": "https://api.github.com/users/Ahmed-Idani/gists{/gist_id}", "starred_url": "https://api.github.com/users/Ahmed-Idani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Ahmed-Idani/subscriptions", "organizations_url": "https://api.github.com/users/Ahmed-Idani/orgs", "repos_url": "https://api.github.com/users/Ahmed-Idani/repos", "events_url": "https://api.github.com/users/Ahmed-Idani/events{/privacy}", "received_events_url": "https://api.github.com/users/Ahmed-Idani/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-12-29T12:23:10Z", "updated_at": "2025-12-29T12:23:10Z", "body": "@mrjo118 thanks for the clarification", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3696383394/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3697041129", "html_url": "https://github.com/laurent22/joplin/pull/13994#issuecomment-3697041129", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13994", "id": 3697041129, "node_id": "IC_kwDOBLftOs7cXF7p", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-12-29T17:00:23Z", "updated_at": "2025-12-29T17:00:23Z", "body": "I'm linking this to #13229.\r\n", "author_association": "COLLABORATOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3697041129/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }