{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/9457", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/9457/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/9457/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/9457/events", "html_url": "https://github.com/laurent22/joplin/pull/9457", "id": 2028933606, "node_id": "PR_kwDOBLftOs5hUz7u", "number": 9457, "title": "Desktop: Fixed color with higher contrast to enhance readability in oled dark theme", "user": { "login": "Harshiths1", "id": 136854105, "node_id": "U_kgDOCCg6WQ", "avatar_url": "https://avatars.githubusercontent.com/u/136854105?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Harshiths1", "html_url": "https://github.com/Harshiths1", "followers_url": "https://api.github.com/users/Harshiths1/followers", "following_url": "https://api.github.com/users/Harshiths1/following{/other_user}", "gists_url": "https://api.github.com/users/Harshiths1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Harshiths1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Harshiths1/subscriptions", "organizations_url": "https://api.github.com/users/Harshiths1/orgs", "repos_url": "https://api.github.com/users/Harshiths1/repos", "events_url": "https://api.github.com/users/Harshiths1/events{/privacy}", "received_events_url": "https://api.github.com/users/Harshiths1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 8, "created_at": "2023-12-06T16:25:01Z", "updated_at": "2023-12-08T14:59:59Z", "closed_at": "2023-12-08T14:45:41Z", "author_association": "NONE", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/9457", "html_url": "https://github.com/laurent22/joplin/pull/9457", "diff_url": "https://github.com/laurent22/joplin/pull/9457.diff", "patch_url": "https://github.com/laurent22/joplin/pull/9457.patch", "merged_at": null }, "body": "\r\n\r\nFixes : #9453 \r\nHigher contrast color is now used which is energy-efficient and won't emit as much light, helping to save battery life on OLED screens and enhance the readability.\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/9457/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/9457/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1843238200", "html_url": "https://github.com/laurent22/joplin/pull/9457#issuecomment-1843238200", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9457", "id": 1843238200, "node_id": "IC_kwDOBLftOs5t3ZU4", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-12-06T16:25:22Z", "updated_at": "2023-12-08T14:45:54Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1843238200/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1843239982", "html_url": "https://github.com/laurent22/joplin/pull/9457#issuecomment-1843239982", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9457", "id": 1843239982, "node_id": "IC_kwDOBLftOs5t3Zwu", "user": { "login": "Harshiths1", "id": 136854105, "node_id": "U_kgDOCCg6WQ", "avatar_url": "https://avatars.githubusercontent.com/u/136854105?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Harshiths1", "html_url": "https://github.com/Harshiths1", "followers_url": "https://api.github.com/users/Harshiths1/followers", "following_url": "https://api.github.com/users/Harshiths1/following{/other_user}", "gists_url": "https://api.github.com/users/Harshiths1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Harshiths1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Harshiths1/subscriptions", "organizations_url": "https://api.github.com/users/Harshiths1/orgs", "repos_url": "https://api.github.com/users/Harshiths1/repos", "events_url": "https://api.github.com/users/Harshiths1/events{/privacy}", "received_events_url": "https://api.github.com/users/Harshiths1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-12-06T16:26:23Z", "updated_at": "2023-12-06T16:26:23Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1843239982/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1843247271", "html_url": "https://github.com/laurent22/joplin/pull/9457#issuecomment-1843247271", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9457", "id": 1843247271, "node_id": "IC_kwDOBLftOs5t3bin", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-12-06T16:30:37Z", "updated_at": "2023-12-06T16:30:37Z", "author_association": "OWNER", "body": "Please provide a screenshot before / after the change", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1843247271/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1843272522", "html_url": "https://github.com/laurent22/joplin/pull/9457#issuecomment-1843272522", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9457", "id": 1843272522, "node_id": "IC_kwDOBLftOs5t3htK", "user": { "login": "Harshiths1", "id": 136854105, "node_id": "U_kgDOCCg6WQ", "avatar_url": "https://avatars.githubusercontent.com/u/136854105?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Harshiths1", "html_url": "https://github.com/Harshiths1", "followers_url": "https://api.github.com/users/Harshiths1/followers", "following_url": "https://api.github.com/users/Harshiths1/following{/other_user}", "gists_url": "https://api.github.com/users/Harshiths1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Harshiths1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Harshiths1/subscriptions", "organizations_url": "https://api.github.com/users/Harshiths1/orgs", "repos_url": "https://api.github.com/users/Harshiths1/repos", "events_url": "https://api.github.com/users/Harshiths1/events{/privacy}", "received_events_url": "https://api.github.com/users/Harshiths1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-12-06T16:45:29Z", "updated_at": "2023-12-06T16:45:29Z", "author_association": "NONE", "body": "> Please provide a screenshot before / after the change\r\nBefore\r\n![image](https://github.com/laurent22/joplin/assets/136854105/97964e4e-98af-4dda-b15e-b92e22468c60)\r\n\r\n\r\n\r\nAfter\r\n![image](https://github.com/laurent22/joplin/assets/136854105/829950ac-2325-41d9-8da5-4d47a19debad)\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1843272522/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1843548868", "html_url": "https://github.com/laurent22/joplin/pull/9457#issuecomment-1843548868", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9457", "id": 1843548868, "node_id": "IC_kwDOBLftOs5t4lLE", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-12-06T19:22:13Z", "updated_at": "2023-12-06T19:22:13Z", "author_association": "OWNER", "body": "I don't get how this works. `codeBorderColor` is not used for the note selection background?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1843548868/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1844321827", "html_url": "https://github.com/laurent22/joplin/pull/9457#issuecomment-1844321827", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9457", "id": 1844321827, "node_id": "IC_kwDOBLftOs5t7h4j", "user": { "login": "Harshiths1", "id": 136854105, "node_id": "U_kgDOCCg6WQ", "avatar_url": "https://avatars.githubusercontent.com/u/136854105?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Harshiths1", "html_url": "https://github.com/Harshiths1", "followers_url": "https://api.github.com/users/Harshiths1/followers", "following_url": "https://api.github.com/users/Harshiths1/following{/other_user}", "gists_url": "https://api.github.com/users/Harshiths1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Harshiths1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Harshiths1/subscriptions", "organizations_url": "https://api.github.com/users/Harshiths1/orgs", "repos_url": "https://api.github.com/users/Harshiths1/repos", "events_url": "https://api.github.com/users/Harshiths1/events{/privacy}", "received_events_url": "https://api.github.com/users/Harshiths1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-12-07T04:23:48Z", "updated_at": "2023-12-07T04:23:48Z", "author_association": "NONE", "body": "> I don't get how this works. `codeBorderColor` is not used for the note selection background?\r\n\r\nI know changing the selectedColor to '#B9B9B9' also works but i got to review why as to this too is working on my device", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1844321827/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1847305411", "html_url": "https://github.com/laurent22/joplin/pull/9457#issuecomment-1847305411", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9457", "id": 1847305411, "node_id": "IC_kwDOBLftOs5uG6TD", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-12-08T14:45:41Z", "updated_at": "2023-12-08T14:45:41Z", "author_association": "OWNER", "body": "There are too many issues for such a simple PR, so I'd rather close. We don't participate in GSoC by the way", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1847305411/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1847331232", "html_url": "https://github.com/laurent22/joplin/pull/9457#issuecomment-1847331232", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9457", "id": 1847331232, "node_id": "IC_kwDOBLftOs5uHAmg", "user": { "login": "Harshiths1", "id": 136854105, "node_id": "U_kgDOCCg6WQ", "avatar_url": "https://avatars.githubusercontent.com/u/136854105?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Harshiths1", "html_url": "https://github.com/Harshiths1", "followers_url": "https://api.github.com/users/Harshiths1/followers", "following_url": "https://api.github.com/users/Harshiths1/following{/other_user}", "gists_url": "https://api.github.com/users/Harshiths1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Harshiths1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Harshiths1/subscriptions", "organizations_url": "https://api.github.com/users/Harshiths1/orgs", "repos_url": "https://api.github.com/users/Harshiths1/repos", "events_url": "https://api.github.com/users/Harshiths1/events{/privacy}", "received_events_url": "https://api.github.com/users/Harshiths1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-12-08T14:59:58Z", "updated_at": "2023-12-08T14:59:58Z", "author_association": "NONE", "body": "Thank you anyway , this was my first ever PR so I did not expect much and purposely chose such a simple issue to familiarize. \r\nAppreciate that you gave inputs really helped .", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1847331232/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }