{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/15032", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/15032/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/15032/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/15032/events", "html_url": "https://github.com/laurent22/joplin/pull/15032", "id": 4211801350, "node_id": "PR_kwDOBLftOs7QNdN6", "number": 15032, "title": "Desktop: Remove libfuse2 dependency from AppImage by using modern runtime", "user": { "login": "JGCarroll", "id": 62413368, "node_id": "MDQ6VXNlcjYyNDEzMzY4", "avatar_url": "https://avatars.githubusercontent.com/u/62413368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JGCarroll", "html_url": "https://github.com/JGCarroll", "followers_url": "https://api.github.com/users/JGCarroll/followers", "following_url": "https://api.github.com/users/JGCarroll/following{/other_user}", "gists_url": "https://api.github.com/users/JGCarroll/gists{/gist_id}", "starred_url": "https://api.github.com/users/JGCarroll/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JGCarroll/subscriptions", "organizations_url": "https://api.github.com/users/JGCarroll/orgs", "repos_url": "https://api.github.com/users/JGCarroll/repos", "events_url": "https://api.github.com/users/JGCarroll/events{/privacy}", "received_events_url": "https://api.github.com/users/JGCarroll/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 1366673470, "node_id": "MDU6TGFiZWwxMzY2NjczNDcw", "url": "https://api.github.com/repos/laurent22/joplin/labels/windows", "name": "windows", "color": "bfd4f2", "default": false, "description": "" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 8, "created_at": "2026-04-06T13:08:25Z", "updated_at": "2026-04-06T16:54:18Z", "closed_at": "2026-04-06T16:54:07Z", "assignee": null, "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/15032", "html_url": "https://github.com/laurent22/joplin/pull/15032", "diff_url": "https://github.com/laurent22/joplin/pull/15032.diff", "patch_url": "https://github.com/laurent22/joplin/pull/15032.patch", "merged_at": null }, "body": "This PR:\r\n1) Upgrades Electron Builder to version 26.8\r\n2) Instructs Electron Builder to use modern AppImage runtimes which don't have a hard dependency on `libfuse2`, which is being removed entirely in e.g., Fedora 44. (I believe) - meaning supporting these systems would become impossible.\r\n3) Modifies the installation script to not check for libfuse2 when not required (the check could be removed entirely when/if this hits a stable release?)\r\n\r\n----\r\nRemoving the `libfuse2` requirement doesn't make this \"self-contained\" as people would call it, the requirement instead shifts elsewhere.\r\n\r\ne.g., running on Fedora 43 in WSL2:\r\n```\r\njames@James-Desktop:~$ ./Joplin-3.6.7.AppImage\r\nError: No suitable fusermount binary found on the $PATH\r\nError: $FUSERMOUNT_PROG not set\r\n\r\nCannot mount AppImage, please check your FUSE setup.\r\n```\r\nwhich was resolved with `sudo dnf install fuse fuse-libs` - this doesn't mean that `libfuse2` itself is being used however, the output above is distinctly different from the error messages before this commit (`dlopen` error on `libfuse2` as opposed to a requirement for a `fusermount` binary). These tools are essential for a wide variety of other ecosystems (e.g., Flatpak) so can be assumed to be nearly universal.\r\n\r\nMarking as draft to encourage some more rigorous testing and also because I need to figure out how to sign the SLA.", "closed_by": { "login": "JGCarroll", "id": 62413368, "node_id": "MDQ6VXNlcjYyNDEzMzY4", "avatar_url": "https://avatars.githubusercontent.com/u/62413368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JGCarroll", "html_url": "https://github.com/JGCarroll", "followers_url": "https://api.github.com/users/JGCarroll/followers", "following_url": "https://api.github.com/users/JGCarroll/following{/other_user}", "gists_url": "https://api.github.com/users/JGCarroll/gists{/gist_id}", "starred_url": "https://api.github.com/users/JGCarroll/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JGCarroll/subscriptions", "organizations_url": "https://api.github.com/users/JGCarroll/orgs", "repos_url": "https://api.github.com/users/JGCarroll/repos", "events_url": "https://api.github.com/users/JGCarroll/events{/privacy}", "received_events_url": "https://api.github.com/users/JGCarroll/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/15032/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/15032/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4192414259", "html_url": "https://github.com/laurent22/joplin/pull/15032#issuecomment-4192414259", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/15032", "id": 4192414259, "node_id": "IC_kwDOBLftOs754yoz", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-04-06T13:08:34Z", "updated_at": "2026-04-06T16:49:15Z", "body": "\n\n\n
\n📝 Walkthrough\n\n## Walkthrough\n\nFetch of RELEASE_VERSION moved earlier; the libfuse2 presence check in the install script is now conditional on the release version (runs only for releases >= 3.6.8). Removed older `depd` resolutions. Electron Builder config restructured and `electron-builder` bumped.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Installation Script Dependency Checking**
`Joplin_install_and_update.sh`|Fetches `RELEASE_VERSION` before dependency checks; the `libfuse.so.2` / `libfuse2` detection and error path are executed only when `RELEASE_VERSION >= 3.6.8`; otherwise the check and exit are skipped.|\n|**Dependency Resolution Cleanup**
`package.json`|Removed legacy `depd` resolutions for `~1.1.2`, `^1.1.2`, and `^1.1.0`; retained `depd` resolutions targeting 2.0.0 ranges.|\n|**Electron Builder Configuration Update**
`packages/app-desktop/package.json`|Moved Windows signing keys into `win.signtoolOptions` and Linux desktop metadata into `build.linux.desktop.entry`; added `build.toolsets.appimage: \"1.0.2\"` and upgraded `electron-builder` from `24.13.3` to `26.8.1`.|\n\n## Suggested labels\n\n`windows`\n\n
\n\n\n\n\n\n\n---\n\n\n> [!IMPORTANT]\n> ## Pre-merge checks failed\n> \n> Please resolve all errors before merging. Addressing warnings is optional.\n\n\n### ❌ Failed checks (1 error)\n\n| Check name | Status | Explanation | Resolution |\n| :-----------------------------------: | :------ | :-------------------------------------------------------------------------------------------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Pr Description Must Follow Guidelines | ❌ Error | PR description contains required components (problem, solution, test plan) but lacks explicit markdown section headers for clear delineation. | Restructure PR description with explicit markdown headings (## Problem, ## Solution, ## Test Plan) to clearly separate each required component for improved reviewer clarity. |\n\n
\n✅ Passed checks (3 passed)\n\n| Check name | Status | Explanation |\n| :----------------: | :------- | :---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Title check | ✅ Passed | The title clearly and specifically summarises the main objective: removing libfuse2 dependency from AppImage through upgraded runtimes. |\n| Description check | ✅ Passed | The description directly addresses the changeset, explaining the upgrade to Electron Builder, the modern AppImage runtime configuration, and the installation script modifications. |\n| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n\n
\n\n\n\n\n\n
\n✨ Finishing Touches\n\n
\n🧪 Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n\n
\n\n
\n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=15032)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n
\n❤️ Share\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n
\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4192414259/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4192414632", "html_url": "https://github.com/laurent22/joplin/pull/15032#issuecomment-4192414632", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/15032", "id": 4192414632, "node_id": "IC_kwDOBLftOs754yuo", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-04-06T13:08:39Z", "updated_at": "2026-04-06T16:54:19Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4192414632/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4192587414", "html_url": "https://github.com/laurent22/joplin/pull/15032#issuecomment-4192587414", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/15032", "id": 4192587414, "node_id": "IC_kwDOBLftOs755c6W", "user": { "login": "JGCarroll", "id": 62413368, "node_id": "MDQ6VXNlcjYyNDEzMzY4", "avatar_url": "https://avatars.githubusercontent.com/u/62413368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JGCarroll", "html_url": "https://github.com/JGCarroll", "followers_url": "https://api.github.com/users/JGCarroll/followers", "following_url": "https://api.github.com/users/JGCarroll/following{/other_user}", "gists_url": "https://api.github.com/users/JGCarroll/gists{/gist_id}", "starred_url": "https://api.github.com/users/JGCarroll/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JGCarroll/subscriptions", "organizations_url": "https://api.github.com/users/JGCarroll/orgs", "repos_url": "https://api.github.com/users/JGCarroll/repos", "events_url": "https://api.github.com/users/JGCarroll/events{/privacy}", "received_events_url": "https://api.github.com/users/JGCarroll/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-04-06T13:47:18Z", "updated_at": "2026-04-06T13:47:18Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4192587414/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4192681446", "html_url": "https://github.com/laurent22/joplin/pull/15032#issuecomment-4192681446", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/15032", "id": 4192681446, "node_id": "IC_kwDOBLftOs755z3m", "user": { "login": "JGCarroll", "id": 62413368, "node_id": "MDQ6VXNlcjYyNDEzMzY4", "avatar_url": "https://avatars.githubusercontent.com/u/62413368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JGCarroll", "html_url": "https://github.com/JGCarroll", "followers_url": "https://api.github.com/users/JGCarroll/followers", "following_url": "https://api.github.com/users/JGCarroll/following{/other_user}", "gists_url": "https://api.github.com/users/JGCarroll/gists{/gist_id}", "starred_url": "https://api.github.com/users/JGCarroll/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JGCarroll/subscriptions", "organizations_url": "https://api.github.com/users/JGCarroll/orgs", "repos_url": "https://api.github.com/users/JGCarroll/repos", "events_url": "https://api.github.com/users/JGCarroll/events{/privacy}", "received_events_url": "https://api.github.com/users/JGCarroll/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-04-06T14:07:30Z", "updated_at": "2026-04-06T14:07:30Z", "body": "Thanks both,\r\n\r\nI'll check the electron builder schema again locally since I'm seeing re-adding `sign:` has probably broken the CI and will have to find out where it now goes, plus doing some more direct checks on e.g., Fedora 44 beta itself in a proper full-fat VM, likely in the next day or two as I've been having \"fun\" with Copilot in the background and burnt myself out for today on it.\r\n\r\nHowever, the relative simplicitly in these changes has me optimistic :)", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4192681446/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4193413214", "html_url": "https://github.com/laurent22/joplin/pull/15032#issuecomment-4193413214", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/15032", "id": 4193413214, "node_id": "IC_kwDOBLftOs758mhe", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-04-06T16:15:45Z", "updated_at": "2026-04-06T16:15:45Z", "body": "> @[JGCarroll](https://github.com/JGCarroll) JGCarroll [force-pushed](https://github.com/laurent22/joplin/compare/9d67def50d40622b7cc526fe7c5acb7df42437bf..6d8ca0fa21f9911664cd313dd0daea629257be71) the modern-appimage branch from [9d67def](https://github.com/laurent22/joplin/commit/9d67def50d40622b7cc526fe7c5acb7df42437bf) to [6d8ca0f](https://github.com/laurent22/joplin/commit/6d8ca0fa21f9911664cd313dd0daea629257be71)\r\n\r\nBe aware that Joplin uses [commit squashing](https://github.blog/open-source/git/squash-your-commits/#enter-commit-squashing), so force-pushing shouldn't be necessary (force-pushing can make pull requests a bit harder to review).", "author_association": "COLLABORATOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4193413214/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4193420406", "html_url": "https://github.com/laurent22/joplin/pull/15032#issuecomment-4193420406", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/15032", "id": 4193420406, "node_id": "IC_kwDOBLftOs758oR2", "user": { "login": "JGCarroll", "id": 62413368, "node_id": "MDQ6VXNlcjYyNDEzMzY4", "avatar_url": "https://avatars.githubusercontent.com/u/62413368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JGCarroll", "html_url": "https://github.com/JGCarroll", "followers_url": "https://api.github.com/users/JGCarroll/followers", "following_url": "https://api.github.com/users/JGCarroll/following{/other_user}", "gists_url": "https://api.github.com/users/JGCarroll/gists{/gist_id}", "starred_url": "https://api.github.com/users/JGCarroll/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JGCarroll/subscriptions", "organizations_url": "https://api.github.com/users/JGCarroll/orgs", "repos_url": "https://api.github.com/users/JGCarroll/repos", "events_url": "https://api.github.com/users/JGCarroll/events{/privacy}", "received_events_url": "https://api.github.com/users/JGCarroll/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-04-06T16:17:14Z", "updated_at": "2026-04-06T16:17:14Z", "body": "> Be aware that Joplin uses [commit squashing](https://github.blog/open-source/git/squash-your-commits/#enter-commit-squashing), so force-pushing shouldn't be necessary (force-pushing can make pull requests a bit harder to review).\r\n\r\nCheers, good to know for the future :) - really this could have been two PR's with one updating Electron Builder and the other doing the AppImage change so thought it was best to have the option to revert one without the other\r\n\r\nIn any case, hopefully that's it for the commits and the rest is just proper testing", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4193420406/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4193598970", "html_url": "https://github.com/laurent22/joplin/pull/15032#issuecomment-4193598970", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/15032", "id": 4193598970, "node_id": "IC_kwDOBLftOs759T36", "user": { "login": "JGCarroll", "id": 62413368, "node_id": "MDQ6VXNlcjYyNDEzMzY4", "avatar_url": "https://avatars.githubusercontent.com/u/62413368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JGCarroll", "html_url": "https://github.com/JGCarroll", "followers_url": "https://api.github.com/users/JGCarroll/followers", "following_url": "https://api.github.com/users/JGCarroll/following{/other_user}", "gists_url": "https://api.github.com/users/JGCarroll/gists{/gist_id}", "starred_url": "https://api.github.com/users/JGCarroll/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JGCarroll/subscriptions", "organizations_url": "https://api.github.com/users/JGCarroll/orgs", "repos_url": "https://api.github.com/users/JGCarroll/repos", "events_url": "https://api.github.com/users/JGCarroll/events{/privacy}", "received_events_url": "https://api.github.com/users/JGCarroll/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-04-06T16:48:14Z", "updated_at": "2026-04-06T16:48:14Z", "body": "Wondering whether due to the noise I should just can this PR and open it in a new PR entirely\r\n\r\n(Sorry about this, you've actually caught me during a three day migraine and I wasn't expecting it to get noisy like it has done)", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4193598970/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4193644493", "html_url": "https://github.com/laurent22/joplin/pull/15032#issuecomment-4193644493", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/15032", "id": 4193644493, "node_id": "IC_kwDOBLftOs759e_N", "user": { "login": "JGCarroll", "id": 62413368, "node_id": "MDQ6VXNlcjYyNDEzMzY4", "avatar_url": "https://avatars.githubusercontent.com/u/62413368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JGCarroll", "html_url": "https://github.com/JGCarroll", "followers_url": "https://api.github.com/users/JGCarroll/followers", "following_url": "https://api.github.com/users/JGCarroll/following{/other_user}", "gists_url": "https://api.github.com/users/JGCarroll/gists{/gist_id}", "starred_url": "https://api.github.com/users/JGCarroll/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JGCarroll/subscriptions", "organizations_url": "https://api.github.com/users/JGCarroll/orgs", "repos_url": "https://api.github.com/users/JGCarroll/repos", "events_url": "https://api.github.com/users/JGCarroll/events{/privacy}", "received_events_url": "https://api.github.com/users/JGCarroll/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-04-06T16:54:07Z", "updated_at": "2026-04-06T16:54:07Z", "body": "I'll close this for now and open a second PR shortly with to reduce the amount of noise I've accidentally created with our AI overlords, hopefully in a state that's easier to follow, although with the `depd` issue outstanding (I won't pretend to understand it)", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4193644493/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }