{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10055", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/10055/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/10055/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/10055/events", "html_url": "https://github.com/laurent22/joplin/pull/10055", "id": 2168889327, "node_id": "PR_kwDOBLftOs5oswYM", "number": 10055, "title": "Desktop: Resolves #10025 Toggle external editing button overlaps with bold button fixes ", "user": { "login": "JanhaviAlekar", "id": 97527096, "node_id": "U_kgDOBdAlOA", "avatar_url": "https://avatars.githubusercontent.com/u/97527096?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JanhaviAlekar", "html_url": "https://github.com/JanhaviAlekar", "followers_url": "https://api.github.com/users/JanhaviAlekar/followers", "following_url": "https://api.github.com/users/JanhaviAlekar/following{/other_user}", "gists_url": "https://api.github.com/users/JanhaviAlekar/gists{/gist_id}", "starred_url": "https://api.github.com/users/JanhaviAlekar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JanhaviAlekar/subscriptions", "organizations_url": "https://api.github.com/users/JanhaviAlekar/orgs", "repos_url": "https://api.github.com/users/JanhaviAlekar/repos", "events_url": "https://api.github.com/users/JanhaviAlekar/events{/privacy}", "received_events_url": "https://api.github.com/users/JanhaviAlekar/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 6, "created_at": "2024-03-05T10:51:07Z", "updated_at": "2024-03-06T10:26:59Z", "closed_at": "2024-03-05T18:08:30Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/10055", "html_url": "https://github.com/laurent22/joplin/pull/10055", "diff_url": "https://github.com/laurent22/joplin/pull/10055.diff", "patch_url": "https://github.com/laurent22/joplin/pull/10055.patch", "merged_at": null }, "body": "Before Changes:\r\n[Screencast from 05-03-24 03:47:55 PM IST.webm](https://github.com/laurent22/joplin/assets/97527096/c8e65d15-f1c1-485f-8550-fdb2ad86e1af)\r\n\r\nAfter Changes:\r\n[Screencast from 05-03-24 03:51:28 PM IST.webm](https://github.com/laurent22/joplin/assets/97527096/b4c9aca5-eb72-4ef0-8a87-413c113303f6)\r\n\r\nfixes #10025 ", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10055/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/10055/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1978481194", "html_url": "https://github.com/laurent22/joplin/pull/10055#issuecomment-1978481194", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10055", "id": 1978481194, "node_id": "IC_kwDOBLftOs517Toq", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-05T10:51:19Z", "updated_at": "2024-03-05T18:08:50Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1978481194/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1978487184", "html_url": "https://github.com/laurent22/joplin/pull/10055#issuecomment-1978487184", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10055", "id": 1978487184, "node_id": "IC_kwDOBLftOs517VGQ", "user": { "login": "JanhaviAlekar", "id": 97527096, "node_id": "U_kgDOBdAlOA", "avatar_url": "https://avatars.githubusercontent.com/u/97527096?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JanhaviAlekar", "html_url": "https://github.com/JanhaviAlekar", "followers_url": "https://api.github.com/users/JanhaviAlekar/followers", "following_url": "https://api.github.com/users/JanhaviAlekar/following{/other_user}", "gists_url": "https://api.github.com/users/JanhaviAlekar/gists{/gist_id}", "starred_url": "https://api.github.com/users/JanhaviAlekar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JanhaviAlekar/subscriptions", "organizations_url": "https://api.github.com/users/JanhaviAlekar/orgs", "repos_url": "https://api.github.com/users/JanhaviAlekar/repos", "events_url": "https://api.github.com/users/JanhaviAlekar/events{/privacy}", "received_events_url": "https://api.github.com/users/JanhaviAlekar/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-05T10:54:27Z", "updated_at": "2024-03-05T10:54:27Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1978487184/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1978581425", "html_url": "https://github.com/laurent22/joplin/pull/10055#issuecomment-1978581425", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10055", "id": 1978581425, "node_id": "IC_kwDOBLftOs517sGx", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-05T11:48:47Z", "updated_at": "2024-03-05T11:48:47Z", "author_association": "OWNER", "body": "The reason this bug hasn't been fixed for a long time is that it's indeed hard to fix. Anybody can do what you've done and add a useless gap next to the button:\r\n\r\n\"image\"\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1978581425/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1979251907", "html_url": "https://github.com/laurent22/joplin/pull/10055#issuecomment-1979251907", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10055", "id": 1979251907, "node_id": "IC_kwDOBLftOs51-PzD", "user": { "login": "JanhaviAlekar", "id": 97527096, "node_id": "U_kgDOBdAlOA", "avatar_url": "https://avatars.githubusercontent.com/u/97527096?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JanhaviAlekar", "html_url": "https://github.com/JanhaviAlekar", "followers_url": "https://api.github.com/users/JanhaviAlekar/followers", "following_url": "https://api.github.com/users/JanhaviAlekar/following{/other_user}", "gists_url": "https://api.github.com/users/JanhaviAlekar/gists{/gist_id}", "starred_url": "https://api.github.com/users/JanhaviAlekar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JanhaviAlekar/subscriptions", "organizations_url": "https://api.github.com/users/JanhaviAlekar/orgs", "repos_url": "https://api.github.com/users/JanhaviAlekar/repos", "events_url": "https://api.github.com/users/JanhaviAlekar/events{/privacy}", "received_events_url": "https://api.github.com/users/JanhaviAlekar/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-05T17:11:59Z", "updated_at": "2024-03-05T17:11:59Z", "author_association": "CONTRIBUTOR", "body": "I'm sorry if I interpreted it wrong. But can you suggest how to move forward with it if this is not the way to fix it.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1979251907/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1979349861", "html_url": "https://github.com/laurent22/joplin/pull/10055#issuecomment-1979349861", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10055", "id": 1979349861, "node_id": "IC_kwDOBLftOs51-ntl", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-05T18:08:30Z", "updated_at": "2024-03-05T18:08:30Z", "author_association": "OWNER", "body": "No, sorry, I don't know. The button size needs to be dynamic - small when there's just an icon and large when there's the text+icon. I'm going to close the pull request for now but feel free to try again", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1979349861/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1979353270", "html_url": "https://github.com/laurent22/joplin/pull/10055#issuecomment-1979353270", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10055", "id": 1979353270, "node_id": "IC_kwDOBLftOs51-oi2", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-05T18:10:22Z", "updated_at": "2024-03-05T18:10:52Z", "author_association": "COLLABORATOR", "body": "> I'm sorry if I interpreted it wrong. But can you suggest how to move forward with it if this is not the way to fix it.\r\n\r\nOne way forward could be to adjust `styles.leftExtraToolbarContainer.width` in `packages/app-desktop/gui/NoteEditor/NoteBody/TinyMCE/styles/index.ts` based on the global state [`watchedNoteFiles`](https://github.com/laurent22/joplin/blob/be2f4d3d7967529f3898836f9d7862cf082fc4d8/packages/app-desktop/app.reducer.ts#L32). Note that `watchedNoteFiles` is what is currently used to [update the external editing button's title](https://github.com/laurent22/joplin/blob/be2f4d3d7967529f3898836f9d7862cf082fc4d8/packages/app-desktop/commands/toggleExternalEditing.ts#L28).\r\n\r\nNote that `NoteEditor` [already has access to `watchedNoteFiles`](https://github.com/laurent22/joplin/blob/be2f4d3d7967529f3898836f9d7862cf082fc4d8/packages/app-desktop/gui/NoteEditor/NoteEditor.tsx#L684), so one solution could be to pass it to TinyMCE by adding a property to [`NoteBodyEditorProps`](https://github.com/laurent22/joplin/blob/be2f4d3d7967529f3898836f9d7862cf082fc4d8/packages/app-desktop/gui/NoteEditor/utils/types.ts#L82).\r\n\r\n\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1979353270/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }