{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14546", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14546/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14546/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14546/events", "html_url": "https://github.com/laurent22/joplin/pull/14546", "id": 4018146908, "node_id": "PR_kwDOBLftOs7HrvjR", "number": 14546, "title": "Desktop: Fixes #14545 : Add password mismatch feedback in Master Password dialog", "user": { "login": "KEERTHIAANAND", "id": 190023726, "node_id": "U_kgDOC1OILg", "avatar_url": "https://avatars.githubusercontent.com/u/190023726?v=4", "gravatar_id": "", "url": "https://api.github.com/users/KEERTHIAANAND", "html_url": "https://github.com/KEERTHIAANAND", "followers_url": "https://api.github.com/users/KEERTHIAANAND/followers", "following_url": "https://api.github.com/users/KEERTHIAANAND/following{/other_user}", "gists_url": "https://api.github.com/users/KEERTHIAANAND/gists{/gist_id}", "starred_url": "https://api.github.com/users/KEERTHIAANAND/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KEERTHIAANAND/subscriptions", "organizations_url": "https://api.github.com/users/KEERTHIAANAND/orgs", "repos_url": "https://api.github.com/users/KEERTHIAANAND/repos", "events_url": "https://api.github.com/users/KEERTHIAANAND/events{/privacy}", "received_events_url": "https://api.github.com/users/KEERTHIAANAND/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 519700741, "node_id": "MDU6TGFiZWw1MTk3MDA3NDE=", "url": "https://api.github.com/repos/laurent22/joplin/labels/bug", "name": "bug", "color": "cf353b", "default": true, "description": "It's a bug" }, { "id": 1080341216, "node_id": "MDU6TGFiZWwxMDgwMzQxMjE2", "url": "https://api.github.com/repos/laurent22/joplin/labels/desktop", "name": "desktop", "color": "ffc274", "default": false, "description": "All desktop platforms" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 4, "created_at": "2026-03-03T18:31:56Z", "updated_at": "2026-03-05T09:59:15Z", "closed_at": "2026-03-05T09:17:25Z", "assignee": null, "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14546", "html_url": "https://github.com/laurent22/joplin/pull/14546", "diff_url": "https://github.com/laurent22/joplin/pull/14546.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14546.patch", "merged_at": null }, "body": "When setting or resetting the master password, if the user enters two different passwords in the \"Enter password\" and \"Re-enter password\" fields, the Save button is silently disabled without any feedback message explaining why.\r\n\r\nThis PR adds a red error message — \"Passwords do not match!\" — below the \"Re-enter password\" field when the two values differ. The message only appears when both fields have content and don't match.\r\n\r\n**Changes:**\r\n- File: [packages/app-desktop/gui/MasterPasswordDialog/Dialog.tsx](cci:7://file:///d:/GSoC%202026/joplin/packages/app-desktop/gui/MasterPasswordDialog/Dialog.tsx:0:0-0:0)\r\n- Used `var(--joplin-color-error)` for consistent error styling\r\n- Message wrapped in [_()](cci:1://file:///d:/GSoC%202026/joplin/packages/app-desktop/gui/NotePropertiesDialog.tsx:233:1-236:2) for translation support\r\n\r\n**Testing:**\r\n1. Type same password in both fields → No error, Save enabled\r\n2. Type different passwords → Red error appears, Save disabled\r\n3. Fix second field to match → Error disappears, Save enabled\r\n4. Leave second field empty → No error shown\r\n5. Test in Reset mode → Error works there too\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14546/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14546/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3992874926", "html_url": "https://github.com/laurent22/joplin/pull/14546#issuecomment-3992874926", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14546", "id": 3992874926, "node_id": "IC_kwDOBLftOs7t_m-u", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-03T18:36:06Z", "updated_at": "2026-03-03T18:40:42Z", "body": "\n\n\n
\n📝 Walkthrough\n\n## Walkthrough\n\nThis pull request enhances the master password dialogue with improved validation feedback. A single-file change adds a conditional error message that displays \"Passwords do not match!\" in red when the user enters two different passwords, alongside minor formatting adjustments to function signatures and component syntax.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Password validation feedback**
`packages/app-desktop/gui/MasterPasswordDialog/Dialog.tsx`|Added conditional error message rendering when re-entered password differs from initial password. Introduced fragment wrapper for multi-child JSX block. Applied minor function signature and component syntax formatting updates.|\n\n## Possibly related issues\n\n- **laurent22/joplin#14545**: The PR directly addresses the missing password mismatch feedback by implementing the \"Passwords do not match!\" error message in the password re-entry field validation logic.\n\n## Suggested labels\n\n`desktop`, `bug`\n\n
\n\n\n\n\n\n\n
\n🚥 Pre-merge checks | ✅ 4\n\n
\n✅ Passed checks (4 passed)\n\n| Check name | Status | Explanation |\n| :-----------------------------------: | :------- | :--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Title check | ✅ Passed | The title directly and clearly describes the main change: adding password mismatch feedback to the Master Password dialog, referencing the fixed issue `#14545`. |\n| Description check | ✅ Passed | The description is comprehensive and directly related to the changeset, explaining the problem, the solution with implementation details, and testing steps for the password mismatch feedback feature. |\n| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n| Pr Description Must Follow Guidelines | ✅ Passed | The pull request description follows required guidelines comprehensively with clear problem statement, solution explanation, and detailed test plan covering normal operation, error conditions, and edge cases. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing Touches\n\n
\n🧪 Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n- [ ] Post copyable unit tests in a comment\n\n
\n\n
\n\n\n\n\n\n> [!TIP]\n> Try [Coding Plans](https://www.coderabbit.ai/issue-planner). Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).\n> Share your feedback on [Discord](https://discord.com/invite/coderabbit).\n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14546)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n
\n❤️ Share\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n
\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3992874926/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3994361451", "html_url": "https://github.com/laurent22/joplin/pull/14546#issuecomment-3994361451", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14546", "id": 3994361451, "node_id": "IC_kwDOBLftOs7uFR5r", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-04T00:13:18Z", "updated_at": "2026-03-05T09:59:15Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3994361451/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3995677936", "html_url": "https://github.com/laurent22/joplin/pull/14546#issuecomment-3995677936", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14546", "id": 3995677936, "node_id": "IC_kwDOBLftOs7uKTTw", "user": { "login": "KEERTHIAANAND", "id": 190023726, "node_id": "U_kgDOC1OILg", "avatar_url": "https://avatars.githubusercontent.com/u/190023726?v=4", "gravatar_id": "", "url": "https://api.github.com/users/KEERTHIAANAND", "html_url": "https://github.com/KEERTHIAANAND", "followers_url": "https://api.github.com/users/KEERTHIAANAND/followers", "following_url": "https://api.github.com/users/KEERTHIAANAND/following{/other_user}", "gists_url": "https://api.github.com/users/KEERTHIAANAND/gists{/gist_id}", "starred_url": "https://api.github.com/users/KEERTHIAANAND/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KEERTHIAANAND/subscriptions", "organizations_url": "https://api.github.com/users/KEERTHIAANAND/orgs", "repos_url": "https://api.github.com/users/KEERTHIAANAND/repos", "events_url": "https://api.github.com/users/KEERTHIAANAND/events{/privacy}", "received_events_url": "https://api.github.com/users/KEERTHIAANAND/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-04T06:55:36Z", "updated_at": "2026-03-04T06:55:36Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3995677936/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4003554387", "html_url": "https://github.com/laurent22/joplin/pull/14546#issuecomment-4003554387", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14546", "id": 4003554387, "node_id": "IC_kwDOBLftOs7uoWRT", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-05T09:17:25Z", "updated_at": "2026-03-05T09:17:25Z", "body": "Hello, thank you but I believe that was already fixed as part of another PR", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4003554387/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }