{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14415", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14415/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14415/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14415/events", "html_url": "https://github.com/laurent22/joplin/pull/14415", "id": 3972277911, "node_id": "PR_kwDOBLftOs7FWfdl", "number": 14415, "title": "fix(build): prevent yarn install failure when rsync is unavailable", "user": { "login": "KanhaiyaPandey", "id": 109562285, "node_id": "U_kgDOBofJrQ", "avatar_url": "https://avatars.githubusercontent.com/u/109562285?v=4", "gravatar_id": "", "url": "https://api.github.com/users/KanhaiyaPandey", "html_url": "https://github.com/KanhaiyaPandey", "followers_url": "https://api.github.com/users/KanhaiyaPandey/followers", "following_url": "https://api.github.com/users/KanhaiyaPandey/following{/other_user}", "gists_url": "https://api.github.com/users/KanhaiyaPandey/gists{/gist_id}", "starred_url": "https://api.github.com/users/KanhaiyaPandey/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KanhaiyaPandey/subscriptions", "organizations_url": "https://api.github.com/users/KanhaiyaPandey/orgs", "repos_url": "https://api.github.com/users/KanhaiyaPandey/repos", "events_url": "https://api.github.com/users/KanhaiyaPandey/events{/privacy}", "received_events_url": "https://api.github.com/users/KanhaiyaPandey/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 519700741, "node_id": "MDU6TGFiZWw1MTk3MDA3NDE=", "url": "https://api.github.com/repos/laurent22/joplin/labels/bug", "name": "bug", "color": "cf353b", "default": true, "description": "It's a bug" }, { "id": 1366671832, "node_id": "MDU6TGFiZWwxMzY2NjcxODMy", "url": "https://api.github.com/repos/laurent22/joplin/labels/linux", "name": "linux", "color": "bfd4f2", "default": false, "description": "" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 5, "created_at": "2026-02-21T16:08:09Z", "updated_at": "2026-02-22T09:06:35Z", "closed_at": "2026-02-22T08:49:48Z", "assignee": null, "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14415", "html_url": "https://github.com/laurent22/joplin/pull/14415", "diff_url": "https://github.com/laurent22/joplin/pull/14415.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14415.patch", "merged_at": null }, "body": "Fixes #14361\r\n\r\n### Summary\r\n`yarn install` fails in clean Linux build environments where `rsync` is not installed. \r\nThis PR ensures the build process no longer fails when `rsync` is unavailable.\r\n\r\n### Changes\r\n- Handle missing `rsync` gracefully during build\r\n- Prevent yarn install from exiting with code 1\r\n- Improve compatibility with minimal Debian/Linux setups\r\n\r\n### Testing\r\n- Tested on clean Debian environment\r\n- Verified `yarn install` completes successfully without `rsync` preinstalled\r\n\r\nThis improves the developer experience when setting up the build environment from scratch.", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14415/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14415/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3939023880", "html_url": "https://github.com/laurent22/joplin/pull/14415#issuecomment-3939023880", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14415", "id": 3939023880, "node_id": "IC_kwDOBLftOs7qyLwI", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-21T16:08:20Z", "updated_at": "2026-02-22T08:49:59Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3939023880/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3939024288", "html_url": "https://github.com/laurent22/joplin/pull/14415#issuecomment-3939024288", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14415", "id": 3939024288, "node_id": "IC_kwDOBLftOs7qyL2g", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-21T16:08:36Z", "updated_at": "2026-02-21T16:14:23Z", "body": "\n\n\n
\n📝 Walkthrough\n\n## Walkthrough\n\nModified the Gulp utility to handle missing rsync gracefully. The tool now attempts rsync with dynamic exclude arguments; if rsync is unavailable, it falls back to a Node.js-based copy with comprehensive path filtering, including support for absolute paths, wildcards, and directory deletion when specified.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Rsync Fallback Implementation**
`packages/tools/gulp/utils.js`|Added hybrid copy strategy with rsync as primary method and Node.js fallback. Introduced `isExcluded` filter function supporting absolute paths, wildcards, relative path matching, and subpath checks. Preserved Windows Robocopy path and enhanced exclude/delete option handling across both strategies.|\n\n## Suggested labels\n\n`bug`, `linux`\n\n
\n\n\n\n\n\n\n
\n🚥 Pre-merge checks | ✅ 5\n\n
\n✅ Passed checks (5 passed)\n\n| Check name | Status | Explanation |\n| :------------------------: | :------- | :----------------------------------------------------------------------------------------------------------------------------------------- |\n| Title check | ✅ Passed | The title accurately summarises the main change: handling missing rsync gracefully during build to prevent yarn install failure. |\n| Description check | ✅ Passed | The description clearly relates to the changeset, explaining the issue with rsync unavailability and the improvements made. |\n| Linked Issues check | ✅ Passed | The PR successfully implements graceful rsync fallback handling as required by `#14361`, preventing build failure when rsync is unavailable. |\n| Out of Scope Changes check | ✅ Passed | All changes are directly scoped to addressing the rsync availability issue in the build process; no extraneous modifications detected. |\n| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing Touches\n\n- [ ] 📝 Generate docstrings (stacked PR)\n- [ ] 📝 Generate docstrings (commit on current branch)\n
\n🧪 Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n- [ ] Post copyable unit tests in a comment\n\n
\n\n
\n\n\n\n\n\n> [!TIP]\n> [Issue Planner](https://www.coderabbit.ai/issue-planner) is now in beta. Read the [docs](https://docs.coderabbit.ai/issues/planning) and try it out! Share your feedback on [Discord](https://discord.com/invite/coderabbit).\n\n\n\n\n\n---\n\n\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3939024288/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3939034941", "html_url": "https://github.com/laurent22/joplin/pull/14415#issuecomment-3939034941", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14415", "id": 3939034941, "node_id": "IC_kwDOBLftOs7qyOc9", "user": { "login": "KanhaiyaPandey", "id": 109562285, "node_id": "U_kgDOBofJrQ", "avatar_url": "https://avatars.githubusercontent.com/u/109562285?v=4", "gravatar_id": "", "url": "https://api.github.com/users/KanhaiyaPandey", "html_url": "https://github.com/KanhaiyaPandey", "followers_url": "https://api.github.com/users/KanhaiyaPandey/followers", "following_url": "https://api.github.com/users/KanhaiyaPandey/following{/other_user}", "gists_url": "https://api.github.com/users/KanhaiyaPandey/gists{/gist_id}", "starred_url": "https://api.github.com/users/KanhaiyaPandey/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/KanhaiyaPandey/subscriptions", "organizations_url": "https://api.github.com/users/KanhaiyaPandey/orgs", "repos_url": "https://api.github.com/users/KanhaiyaPandey/repos", "events_url": "https://api.github.com/users/KanhaiyaPandey/events{/privacy}", "received_events_url": "https://api.github.com/users/KanhaiyaPandey/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-21T16:15:23Z", "updated_at": "2026-02-21T16:15:23Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3939034941/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3939183653", "html_url": "https://github.com/laurent22/joplin/pull/14415#issuecomment-3939183653", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14415", "id": 3939183653, "node_id": "IC_kwDOBLftOs7qyywl", "user": { "login": "yugalkaushik", "id": 138966980, "node_id": "U_kgDOCEh3xA", "avatar_url": "https://avatars.githubusercontent.com/u/138966980?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yugalkaushik", "html_url": "https://github.com/yugalkaushik", "followers_url": "https://api.github.com/users/yugalkaushik/followers", "following_url": "https://api.github.com/users/yugalkaushik/following{/other_user}", "gists_url": "https://api.github.com/users/yugalkaushik/gists{/gist_id}", "starred_url": "https://api.github.com/users/yugalkaushik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yugalkaushik/subscriptions", "organizations_url": "https://api.github.com/users/yugalkaushik/orgs", "repos_url": "https://api.github.com/users/yugalkaushik/repos", "events_url": "https://api.github.com/users/yugalkaushik/events{/privacy}", "received_events_url": "https://api.github.com/users/yugalkaushik/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-21T18:07:01Z", "updated_at": "2026-02-21T18:07:01Z", "body": "@KanhaiyaPandey Thank you for the PR. Please make sure to review the [AI policy](https://github.com/joplin/gsoc/blob/master/ai_policy.md) and clearly mention the required details in the PR description so it aligns with the project guidelines.", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3939183653/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3940520347", "html_url": "https://github.com/laurent22/joplin/pull/14415#issuecomment-3940520347", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14415", "id": 3940520347, "node_id": "IC_kwDOBLftOs7q35Gb", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-22T08:49:48Z", "updated_at": "2026-02-22T08:49:48Z", "body": "Wow the things we can do these days with AI. I definitely wasn't expecting a re-implementation of rsync logic in TypeScript. But in any case we don't want this.\r\n\r\nThanks for the contribution. We’re closing this PR because it does not follow the project’s contribution policy: it is not based on a triaged, accepted issue and does not address a concrete problem agreed upon by maintainers.\r\n\r\nWhile the change itself is not necessarily incorrect, reviewing and maintaining such PRs takes time away from higher-priority work.\r\n\r\nPlease see our [Contribution Scope Policy](https://joplinapp.org/help/dev/#contribution-scope) for details on what kinds of contributions we accept.\r\n\r\nPlease make sure you read our guidelines: https://github.com/joplin/gsoc\r\n\r\nAnd our AI policy: https://github.com/joplin/gsoc/blob/master/ai_policy.md\r\n", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3940520347/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }