{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11345", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11345/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11345/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11345/events", "html_url": "https://github.com/laurent22/joplin/pull/11345", "id": 2644028682, "node_id": "PR_kwDOBLftOs6BUgzN", "number": 11345, "title": "Desktop: Fix drop cursor styling issue (#11336)", "user": { "login": "LEVIII007", "id": 132750919, "node_id": "U_kgDOB-meRw", "avatar_url": "https://avatars.githubusercontent.com/u/132750919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LEVIII007", "html_url": "https://github.com/LEVIII007", "followers_url": "https://api.github.com/users/LEVIII007/followers", "following_url": "https://api.github.com/users/LEVIII007/following{/other_user}", "gists_url": "https://api.github.com/users/LEVIII007/gists{/gist_id}", "starred_url": "https://api.github.com/users/LEVIII007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LEVIII007/subscriptions", "organizations_url": "https://api.github.com/users/LEVIII007/orgs", "repos_url": "https://api.github.com/users/LEVIII007/repos", "events_url": "https://api.github.com/users/LEVIII007/events{/privacy}", "received_events_url": "https://api.github.com/users/LEVIII007/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 6, "created_at": "2024-11-08T13:14:06Z", "updated_at": "2024-11-10T14:07:06Z", "closed_at": "2024-11-10T14:06:54Z", "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/11345", "html_url": "https://github.com/laurent22/joplin/pull/11345", "diff_url": "https://github.com/laurent22/joplin/pull/11345.diff", "patch_url": "https://github.com/laurent22/joplin/pull/11345.patch", "merged_at": "2024-11-10T14:06:54Z" }, "body": "# Summary\r\nThis pull request fixes the drop cursor styling issue in the desktop editor. Previously, the drop cursor's color was inconsistent and difficult to configure. This change ensures the drop cursor's color is directly customizable and aligns with the app's theme settings.\r\n\r\nFixes #11336\r\n \r\nNote\r\nThis pull request targets release-3.1.23\r\n\r\n\r\nDemo after change : \r\nScreenshot showing the drop cursor in white colour while dragging a file in dark mode: \r\n\r\nhttps://github.com/user-attachments/assets/1046bf18-2f3d-4d2d-a1e9-9e967469266e\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11345/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11345/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2464755597", "html_url": "https://github.com/laurent22/joplin/pull/11345#issuecomment-2464755597", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11345", "id": 2464755597, "node_id": "IC_kwDOBLftOs6S6S-N", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-11-08T13:20:41Z", "updated_at": "2024-11-10T14:07:06Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2464755597/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2464781840", "html_url": "https://github.com/laurent22/joplin/pull/11345#issuecomment-2464781840", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11345", "id": 2464781840, "node_id": "IC_kwDOBLftOs6S6ZYQ", "user": { "login": "LEVIII007", "id": 132750919, "node_id": "U_kgDOB-meRw", "avatar_url": "https://avatars.githubusercontent.com/u/132750919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LEVIII007", "html_url": "https://github.com/LEVIII007", "followers_url": "https://api.github.com/users/LEVIII007/followers", "following_url": "https://api.github.com/users/LEVIII007/following{/other_user}", "gists_url": "https://api.github.com/users/LEVIII007/gists{/gist_id}", "starred_url": "https://api.github.com/users/LEVIII007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LEVIII007/subscriptions", "organizations_url": "https://api.github.com/users/LEVIII007/orgs", "repos_url": "https://api.github.com/users/LEVIII007/repos", "events_url": "https://api.github.com/users/LEVIII007/events{/privacy}", "received_events_url": "https://api.github.com/users/LEVIII007/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-11-08T13:34:00Z", "updated_at": "2024-11-08T13:34:00Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2464781840/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2465058136", "html_url": "https://github.com/laurent22/joplin/pull/11345#issuecomment-2465058136", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11345", "id": 2465058136, "node_id": "IC_kwDOBLftOs6S7c1Y", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-11-08T15:35:01Z", "updated_at": "2024-11-08T15:35:01Z", "author_association": "OWNER", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2465058136/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2465521983", "html_url": "https://github.com/laurent22/joplin/pull/11345#issuecomment-2465521983", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11345", "id": 2465521983, "node_id": "IC_kwDOBLftOs6S9OE_", "user": { "login": "LEVIII007", "id": 132750919, "node_id": "U_kgDOB-meRw", "avatar_url": "https://avatars.githubusercontent.com/u/132750919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LEVIII007", "html_url": "https://github.com/LEVIII007", "followers_url": "https://api.github.com/users/LEVIII007/followers", "following_url": "https://api.github.com/users/LEVIII007/following{/other_user}", "gists_url": "https://api.github.com/users/LEVIII007/gists{/gist_id}", "starred_url": "https://api.github.com/users/LEVIII007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LEVIII007/subscriptions", "organizations_url": "https://api.github.com/users/LEVIII007/orgs", "repos_url": "https://api.github.com/users/LEVIII007/repos", "events_url": "https://api.github.com/users/LEVIII007/events{/privacy}", "received_events_url": "https://api.github.com/users/LEVIII007/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-11-08T18:46:36Z", "updated_at": "2024-11-08T18:46:36Z", "author_association": "NONE", "body": "@laurent22 It seems the action is unable to update the readme/cla_signatures.json file due to required status checks. All contributors, including myself, have signed the CLA as indicated in the comments, but this error is still blocking the checks.\r\n\r\nCould you please take a look or advise on how to resolve this?\r\n\r\nThank you for your time and help!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2465521983/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2466461432", "html_url": "https://github.com/laurent22/joplin/pull/11345#issuecomment-2466461432", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11345", "id": 2466461432, "node_id": "IC_kwDOBLftOs6TAzb4", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-11-09T21:12:52Z", "updated_at": "2024-11-09T21:12:52Z", "author_association": "OWNER", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2466461432/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2466750410", "html_url": "https://github.com/laurent22/joplin/pull/11345#issuecomment-2466750410", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11345", "id": 2466750410, "node_id": "IC_kwDOBLftOs6TB5_K", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-11-10T14:07:02Z", "updated_at": "2024-11-10T14:07:02Z", "author_association": "OWNER", "body": "Looks good, thanks for the fix", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2466750410/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }