{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/8029", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/8029/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/8029/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/8029/events", "html_url": "https://github.com/laurent22/joplin/pull/8029", "id": 1658619198, "node_id": "PR_kwDOBLftOs5N1CYD", "number": 8029, "title": "Mobile: Fixes #8027: Fixed link modal position on devices with notch", "user": { "login": "Letty", "id": 465678, "node_id": "MDQ6VXNlcjQ2NTY3OA==", "avatar_url": "https://avatars.githubusercontent.com/u/465678?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Letty", "html_url": "https://github.com/Letty", "followers_url": "https://api.github.com/users/Letty/followers", "following_url": "https://api.github.com/users/Letty/following{/other_user}", "gists_url": "https://api.github.com/users/Letty/gists{/gist_id}", "starred_url": "https://api.github.com/users/Letty/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Letty/subscriptions", "organizations_url": "https://api.github.com/users/Letty/orgs", "repos_url": "https://api.github.com/users/Letty/repos", "events_url": "https://api.github.com/users/Letty/events{/privacy}", "received_events_url": "https://api.github.com/users/Letty/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 1079605111, "node_id": "MDU6TGFiZWwxMDc5NjA1MTEx", "url": "https://api.github.com/repos/laurent22/joplin/labels/mobile", "name": "mobile", "color": "ffc274", "default": false, "description": "All mobile platforms" } ], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 12, "created_at": "2023-04-07T09:58:02Z", "updated_at": "2023-07-06T18:04:16Z", "closed_at": "2023-07-06T18:03:58Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/8029", "html_url": "https://github.com/laurent22/joplin/pull/8029", "diff_url": "https://github.com/laurent22/joplin/pull/8029.diff", "patch_url": "https://github.com/laurent22/joplin/pull/8029.patch", "merged_at": "2023-07-06T18:03:58Z" }, "body": "\r\n\r\nFixes #8027 \r\n\r\n**Problem:**\r\n\r\nEdit link modal was hidden by notch.\r\n\r\n**Solution:**\r\n\r\nAdded react-native-device-info package to detect if a device has a notch. Furthermore add a new custom element `Modal.tsx` for unified top and bottom margins in Modals. Other components can use this Modal instead of react native Modal.\r\nNotch margins for top are increased to `65px` and bottom to `35px`.\r\n\r\n**Testing**\r\n\r\nTested on iPhone with and without notch\r\n\r\n\r\n**Add Link:**\r\n![Screenshot 2023-04-07 at 11 24 53](https://user-images.githubusercontent.com/465678/230588727-6694ba53-9203-4db8-a696-2cd06349a890.png)\r\n\r\n**Insert Tags:**\r\n![Screenshot 2023-04-16 at 13 54 13](https://user-images.githubusercontent.com/465678/232308432-81ce2b73-fe42-4b19-a624-30fdc3ade6eb.png)\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/8029/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/8029/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1500137188", "html_url": "https://github.com/laurent22/joplin/pull/8029#issuecomment-1500137188", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8029", "id": 1500137188, "node_id": "IC_kwDOBLftOs5Zakbk", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-04-07T09:58:34Z", "updated_at": "2023-07-06T18:04:16Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1500137188/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1500142614", "html_url": "https://github.com/laurent22/joplin/pull/8029#issuecomment-1500142614", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8029", "id": 1500142614, "node_id": "IC_kwDOBLftOs5ZalwW", "user": { "login": "Letty", "id": 465678, "node_id": "MDQ6VXNlcjQ2NTY3OA==", "avatar_url": "https://avatars.githubusercontent.com/u/465678?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Letty", "html_url": "https://github.com/Letty", "followers_url": "https://api.github.com/users/Letty/followers", "following_url": "https://api.github.com/users/Letty/following{/other_user}", "gists_url": "https://api.github.com/users/Letty/gists{/gist_id}", "starred_url": "https://api.github.com/users/Letty/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Letty/subscriptions", "organizations_url": "https://api.github.com/users/Letty/orgs", "repos_url": "https://api.github.com/users/Letty/repos", "events_url": "https://api.github.com/users/Letty/events{/privacy}", "received_events_url": "https://api.github.com/users/Letty/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-04-07T10:04:51Z", "updated_at": "2023-04-07T10:04:51Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1500142614/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1500374597", "html_url": "https://github.com/laurent22/joplin/pull/8029#issuecomment-1500374597", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8029", "id": 1500374597, "node_id": "IC_kwDOBLftOs5ZbeZF", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-04-07T15:09:20Z", "updated_at": "2023-04-07T15:09:20Z", "author_association": "OWNER", "body": "Thanks for fixing this, but the drawback is that the fix will only work for that particular popup and not for others.\r\n\r\nBefore we tried to apply it to the \"Safe Area\" but we couldn't get it to work: https://github.com/laurent22/joplin/blob/dev/packages/app-mobile/components/SafeAreaView.js#L5\r\n\r\nWhat do you think of this approach?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1500374597/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1500426973", "html_url": "https://github.com/laurent22/joplin/pull/8029#issuecomment-1500426973", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8029", "id": 1500426973, "node_id": "IC_kwDOBLftOs5ZbrLd", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-04-07T16:12:41Z", "updated_at": "2023-04-07T16:12:41Z", "author_association": "OWNER", "body": "Also there are many errors on the CI. Probably don't convert the `require` to `import` because otherwise the types also need to be updated", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1500426973/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1500500511", "html_url": "https://github.com/laurent22/joplin/pull/8029#issuecomment-1500500511", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8029", "id": 1500500511, "node_id": "IC_kwDOBLftOs5Zb9If", "user": { "login": "Letty", "id": 465678, "node_id": "MDQ6VXNlcjQ2NTY3OA==", "avatar_url": "https://avatars.githubusercontent.com/u/465678?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Letty", "html_url": "https://github.com/Letty", "followers_url": "https://api.github.com/users/Letty/followers", "following_url": "https://api.github.com/users/Letty/following{/other_user}", "gists_url": "https://api.github.com/users/Letty/gists{/gist_id}", "starred_url": "https://api.github.com/users/Letty/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Letty/subscriptions", "organizations_url": "https://api.github.com/users/Letty/orgs", "repos_url": "https://api.github.com/users/Letty/repos", "events_url": "https://api.github.com/users/Letty/events{/privacy}", "received_events_url": "https://api.github.com/users/Letty/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-04-07T17:45:23Z", "updated_at": "2023-04-07T17:45:23Z", "author_association": "CONTRIBUTOR", "body": "> Thanks for fixing this, but the drawback is that the fix will only work for that particular popup and not for others.\r\n> \r\n> Before we tried to apply it to the \"Safe Area\" but we couldn't get it to work: https://github.com/laurent22/joplin/blob/dev/packages/app-mobile/components/SafeAreaView.js#L5\r\n> \r\n> What do you think of this approach?\r\n\r\nI never use `SafeAreaView` in any of my projects. By that point i have know idea which problems lead me to the decision, maybe the keyboard problems.\r\n\r\nSo the main issues here are all modals at the top: edit link and tags for sure and most likely the `Dropdown` component as well. You can see it in the language settings at `ConfigScreen`.\r\n\r\nWhat about a custom modal component? Just as a wrapper for the modal in general.\r\nPassing all props for the regular react-native modal and maybe some other if needed, child nodes and style it with the notch in mind.\r\nThis could be used for edit link, tags and everything what will may come later.\r\n\r\nI'm not sure what your styleguide for dropdowns is. If the only difference is the position, the modal component could have a prop like `isDropdown`. But maybe this issue should be tackled separately. ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1500500511/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1500510762", "html_url": "https://github.com/laurent22/joplin/pull/8029#issuecomment-1500510762", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8029", "id": 1500510762, "node_id": "IC_kwDOBLftOs5Zb_oq", "user": { "login": "Letty", "id": 465678, "node_id": "MDQ6VXNlcjQ2NTY3OA==", "avatar_url": "https://avatars.githubusercontent.com/u/465678?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Letty", "html_url": "https://github.com/Letty", "followers_url": "https://api.github.com/users/Letty/followers", "following_url": "https://api.github.com/users/Letty/following{/other_user}", "gists_url": "https://api.github.com/users/Letty/gists{/gist_id}", "starred_url": "https://api.github.com/users/Letty/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Letty/subscriptions", "organizations_url": "https://api.github.com/users/Letty/orgs", "repos_url": "https://api.github.com/users/Letty/repos", "events_url": "https://api.github.com/users/Letty/events{/privacy}", "received_events_url": "https://api.github.com/users/Letty/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-04-07T18:00:52Z", "updated_at": "2023-04-07T18:00:52Z", "author_association": "CONTRIBUTOR", "body": "> Also there are many errors on the CI. Probably don't convert the `require` to `import` because otherwise the types also need to be updated\r\n\r\nI changed it, hope that will fix it.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1500510762/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1510353131", "html_url": "https://github.com/laurent22/joplin/pull/8029#issuecomment-1510353131", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8029", "id": 1510353131, "node_id": "IC_kwDOBLftOs5aBijr", "user": { "login": "Letty", "id": 465678, "node_id": "MDQ6VXNlcjQ2NTY3OA==", "avatar_url": "https://avatars.githubusercontent.com/u/465678?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Letty", "html_url": "https://github.com/Letty", "followers_url": "https://api.github.com/users/Letty/followers", "following_url": "https://api.github.com/users/Letty/following{/other_user}", "gists_url": "https://api.github.com/users/Letty/gists{/gist_id}", "starred_url": "https://api.github.com/users/Letty/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Letty/subscriptions", "organizations_url": "https://api.github.com/users/Letty/orgs", "repos_url": "https://api.github.com/users/Letty/repos", "events_url": "https://api.github.com/users/Letty/events{/privacy}", "received_events_url": "https://api.github.com/users/Letty/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-04-16T12:03:23Z", "updated_at": "2023-04-16T12:03:23Z", "author_association": "CONTRIBUTOR", "body": "Hi @laurent22 i updated my PR to a custom modal. As expected the Dropdown unfortunately needs more work. But maybe this approach is a good starting point.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1510353131/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1566931032", "html_url": "https://github.com/laurent22/joplin/pull/8029#issuecomment-1566931032", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8029", "id": 1566931032, "node_id": "IC_kwDOBLftOs5dZXhY", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-29T10:25:44Z", "updated_at": "2023-05-29T10:25:44Z", "author_association": "OWNER", "body": "Thanks for the update @Letty.\r\n\r\n> As expected the Dropdown unfortunately needs more work. But maybe this approach is a good starting point.\r\n\r\nDo you mean it looks worse than before? Or that it just needs to be updated too? Any chance you could provide a screenshot?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1566931032/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1568933966", "html_url": "https://github.com/laurent22/joplin/pull/8029#issuecomment-1568933966", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8029", "id": 1568933966, "node_id": "IC_kwDOBLftOs5dhAhO", "user": { "login": "Letty", "id": 465678, "node_id": "MDQ6VXNlcjQ2NTY3OA==", "avatar_url": "https://avatars.githubusercontent.com/u/465678?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Letty", "html_url": "https://github.com/Letty", "followers_url": "https://api.github.com/users/Letty/followers", "following_url": "https://api.github.com/users/Letty/following{/other_user}", "gists_url": "https://api.github.com/users/Letty/gists{/gist_id}", "starred_url": "https://api.github.com/users/Letty/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Letty/subscriptions", "organizations_url": "https://api.github.com/users/Letty/orgs", "repos_url": "https://api.github.com/users/Letty/repos", "events_url": "https://api.github.com/users/Letty/events{/privacy}", "received_events_url": "https://api.github.com/users/Letty/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-30T19:05:09Z", "updated_at": "2023-05-30T19:05:09Z", "author_association": "CONTRIBUTOR", "body": "> Do you mean it looks worse than before? Or that it just needs to be updated too? Any chance you could provide a screenshot?\r\n\r\nThe changes don't effect the dropdown. So with this PR just the two modals in the screenshot will be fixed. \r\n\r\nI was checking, if this modal can be easily applied towards the dropdown, which is not the case. It was more a question if the PR should address the dropdown issue as well or make a separate issue and PR for that. I could look into that as well, if you like.\r\n\r\nUnfortunately i can't build Joplin for iOS at the minute, i have to check what is wrong with Xcode.\r\n\r\n\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1568933966/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1604171673", "html_url": "https://github.com/laurent22/joplin/pull/8029#issuecomment-1604171673", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8029", "id": 1604171673, "node_id": "IC_kwDOBLftOs5fnbeZ", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-06-23T11:50:47Z", "updated_at": "2023-06-23T11:50:47Z", "author_association": "OWNER", "body": "@Letty, thanks for clarifying. I think we can merge then, but could you just fix the conflicts please?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1604171673/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1610889118", "html_url": "https://github.com/laurent22/joplin/pull/8029#issuecomment-1610889118", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8029", "id": 1610889118, "node_id": "IC_kwDOBLftOs5gBDee", "user": { "login": "Letty", "id": 465678, "node_id": "MDQ6VXNlcjQ2NTY3OA==", "avatar_url": "https://avatars.githubusercontent.com/u/465678?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Letty", "html_url": "https://github.com/Letty", "followers_url": "https://api.github.com/users/Letty/followers", "following_url": "https://api.github.com/users/Letty/following{/other_user}", "gists_url": "https://api.github.com/users/Letty/gists{/gist_id}", "starred_url": "https://api.github.com/users/Letty/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Letty/subscriptions", "organizations_url": "https://api.github.com/users/Letty/orgs", "repos_url": "https://api.github.com/users/Letty/repos", "events_url": "https://api.github.com/users/Letty/events{/privacy}", "received_events_url": "https://api.github.com/users/Letty/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-06-28T07:10:56Z", "updated_at": "2023-06-28T07:10:56Z", "author_association": "CONTRIBUTOR", "body": "@laurent22 fixed them!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1610889118/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1624107176", "html_url": "https://github.com/laurent22/joplin/pull/8029#issuecomment-1624107176", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8029", "id": 1624107176, "node_id": "IC_kwDOBLftOs5gzeio", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-07-06T18:03:51Z", "updated_at": "2023-07-06T18:03:51Z", "author_association": "OWNER", "body": "All good now, thanks @Letty!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1624107176/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }