{
"issue": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/14879",
"repository_url": "https://api.github.com/repos/laurent22/joplin",
"labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14879/labels{/name}",
"comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14879/comments",
"events_url": "https://api.github.com/repos/laurent22/joplin/issues/14879/events",
"html_url": "https://github.com/laurent22/joplin/pull/14879",
"id": 4122472722,
"node_id": "PR_kwDOBLftOs7MwLOM",
"number": 14879,
"title": "Desktop: Fixes #14878: Prevent focusing undefined titleInputRef in dialog",
"user": {
"login": "MANVENDRA-github",
"id": 121653862,
"node_id": "U_kgDOB0BKZg",
"avatar_url": "https://avatars.githubusercontent.com/u/121653862?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MANVENDRA-github",
"html_url": "https://github.com/MANVENDRA-github",
"followers_url": "https://api.github.com/users/MANVENDRA-github/followers",
"following_url": "https://api.github.com/users/MANVENDRA-github/following{/other_user}",
"gists_url": "https://api.github.com/users/MANVENDRA-github/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MANVENDRA-github/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MANVENDRA-github/subscriptions",
"organizations_url": "https://api.github.com/users/MANVENDRA-github/orgs",
"repos_url": "https://api.github.com/users/MANVENDRA-github/repos",
"events_url": "https://api.github.com/users/MANVENDRA-github/events{/privacy}",
"received_events_url": "https://api.github.com/users/MANVENDRA-github/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"labels": [
{
"id": 519700741,
"node_id": "MDU6TGFiZWw1MTk3MDA3NDE=",
"url": "https://api.github.com/repos/laurent22/joplin/labels/bug",
"name": "bug",
"color": "cf353b",
"default": true,
"description": "It's a bug"
},
{
"id": 1080341216,
"node_id": "MDU6TGFiZWwxMDgwMzQxMjE2",
"url": "https://api.github.com/repos/laurent22/joplin/labels/desktop",
"name": "desktop",
"color": "ffc274",
"default": false,
"description": "All desktop platforms"
}
],
"state": "closed",
"locked": false,
"assignees": [],
"milestone": null,
"comments": 3,
"created_at": "2026-03-23T17:29:20Z",
"updated_at": "2026-03-27T14:54:38Z",
"closed_at": "2026-03-27T12:25:28Z",
"assignee": null,
"author_association": "CONTRIBUTOR",
"active_lock_reason": null,
"draft": false,
"pull_request": {
"url": "https://api.github.com/repos/laurent22/joplin/pulls/14879",
"html_url": "https://github.com/laurent22/joplin/pull/14879",
"diff_url": "https://github.com/laurent22/joplin/pull/14879.diff",
"patch_url": "https://github.com/laurent22/joplin/pull/14879.patch",
"merged_at": "2026-03-27T12:25:28Z"
},
"body": "Problem\r\nWhile working with the desktop app in development mode, I noticed a warning in the console when opening the “Edit notebook” dialog:\r\nfocusHandler: tried action \"focus\" on an undefined element: Dialog::titleInputRef\r\n\r\nit seems the dialog tries to focus the title input before the ref is actually available. This is reproducible consistently and is tracked in #14878\r\n\r\nSolution\r\nSo i just added:\r\n1. a simple guard to check that titleInputRef.current is defined before calling focus and \r\n2. also added a similar check before calling .select() to avoid any potential runtime errors\r\n\r\nI have also tested this after the change by opening the dialog multiple times creating a new notebook and adding an existing one\r\n\r\nImpact:\r\nthis change helped reduce noisy console warnings and prevents invalid focus calls\r\nthere are no functional changes to the UI or behavior",
"closed_by": {
"login": "laurent22",
"id": 1285584,
"node_id": "MDQ6VXNlcjEyODU1ODQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/laurent22",
"html_url": "https://github.com/laurent22",
"followers_url": "https://api.github.com/users/laurent22/followers",
"following_url": "https://api.github.com/users/laurent22/following{/other_user}",
"gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}",
"starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/laurent22/subscriptions",
"organizations_url": "https://api.github.com/users/laurent22/orgs",
"repos_url": "https://api.github.com/users/laurent22/repos",
"events_url": "https://api.github.com/users/laurent22/events{/privacy}",
"received_events_url": "https://api.github.com/users/laurent22/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/14879/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14879/timeline",
"performed_via_github_app": null,
"state_reason": null
},
"comments": [
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4112394048",
"html_url": "https://github.com/laurent22/joplin/pull/14879#issuecomment-4112394048",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14879",
"id": 4112394048,
"node_id": "IC_kwDOBLftOs71HidA",
"user": {
"login": "github-actions[bot]",
"id": 41898282,
"node_id": "MDM6Qm90NDE4OTgyODI=",
"avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github-actions%5Bbot%5D",
"html_url": "https://github.com/apps/github-actions",
"followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-23T17:29:33Z",
"updated_at": "2026-03-27T14:54:38Z",
"body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4112394048/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 15368,
"client_id": "Iv1.05c79e9ad1f6bdfa",
"slug": "github-actions",
"node_id": "MDM6QXBwMTUzNjg=",
"owner": {
"login": "github",
"id": 9919,
"node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/github",
"html_url": "https://github.com/github",
"followers_url": "https://api.github.com/users/github/followers",
"following_url": "https://api.github.com/users/github/following{/other_user}",
"gists_url": "https://api.github.com/users/github/gists{/gist_id}",
"starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/github/subscriptions",
"organizations_url": "https://api.github.com/users/github/orgs",
"repos_url": "https://api.github.com/users/github/repos",
"events_url": "https://api.github.com/users/github/events{/privacy}",
"received_events_url": "https://api.github.com/users/github/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "GitHub Actions",
"description": "Automate your workflow from idea to production",
"external_url": "https://help.github.com/en/actions",
"html_url": "https://github.com/apps/github-actions",
"created_at": "2018-07-30T09:30:17Z",
"updated_at": "2026-05-05T14:51:38Z",
"permissions": {
"actions": "write",
"administration": "read",
"artifact_metadata": "write",
"attestations": "write",
"checks": "write",
"code_quality": "write",
"contents": "write",
"copilot_requests": "write",
"deployments": "write",
"discussions": "write",
"issues": "write",
"merge_queues": "write",
"metadata": "read",
"models": "read",
"packages": "write",
"pages": "write",
"pull_requests": "write",
"repository_hooks": "write",
"repository_projects": "write",
"security_events": "write",
"statuses": "write",
"vulnerability_alerts": "read"
},
"events": [
"branch_protection_rule",
"check_run",
"check_suite",
"create",
"delete",
"deployment",
"deployment_status",
"discussion",
"discussion_comment",
"fork",
"gollum",
"issues",
"issue_comment",
"label",
"merge_group",
"milestone",
"page_build",
"public",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"push",
"registry_package",
"release",
"repository",
"repository_dispatch",
"status",
"watch",
"workflow_dispatch",
"workflow_run"
]
}
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4112396142",
"html_url": "https://github.com/laurent22/joplin/pull/14879#issuecomment-4112396142",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14879",
"id": 4112396142,
"node_id": "IC_kwDOBLftOs71Hi9u",
"user": {
"login": "coderabbitai[bot]",
"id": 136622811,
"node_id": "BOT_kgDOCCSy2w",
"avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/coderabbitai%5Bbot%5D",
"html_url": "https://github.com/apps/coderabbitai",
"followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers",
"following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}",
"gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}",
"starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions",
"organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs",
"repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos",
"events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}",
"received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events",
"type": "Bot",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-23T17:29:46Z",
"updated_at": "2026-03-23T17:33:01Z",
"body": "\nNo actionable comments were generated in the recent review. 🎉\n\n\nℹ️ Recent review info
\n\n\n⚙️ Run configuration
\n\n**Configuration used**: Path: .coderabbit.yaml\n\n**Review profile**: CHILL\n\n**Plan**: Pro\n\n**Run ID**: `b1d0b1f3-9d90-49e9-a37b-a5cb5e8abc37`\n\n \n\n\n📥 Commits
\n\nReviewing files that changed from the base of the PR and between 741e1b19e5254b5aeb414a104c79d3573c280b51 and 1c4c78edc75a6cc8bd0c609a7d96c847249b9de9.\n\n \n\n\n📒 Files selected for processing (1)
\n\n* `packages/app-desktop/gui/EditFolderDialog/Dialog.tsx`\n\n \n\n \n\n---\n\n\n\n\n\n📝 Walkthrough
\n\n## Walkthrough\n\nThe change adds defensive null checks in `Dialog.tsx` to prevent runtime errors when attempting to focus or select a title input ref that may not yet be initialised, addressing a potential race condition during component initialisation.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Ref Initialisation Safety**
`packages/app-desktop/gui/EditFolderDialog/Dialog.tsx`|Added conditional checks guarding `focus()` and `select()` calls on `titleInputRef.current` to prevent null reference errors during component initialisation.|\n\n## Possibly related issues\n\n- Issue `#14878` — Directly addresses the reported race condition where the dialog attempts to focus `titleInputRef` before it has been properly initialised.\n\n## Suggested labels\n\n`bug`, `desktop`\n\n## Suggested reviewers\n\n- mrjo118\n\n \n\n\n\n\n\n\n\n🚥 Pre-merge checks | ✅ 4
\n\n\n✅ Passed checks (4 passed)
\n\n| Check name | Status | Explanation |\n| :-----------------------------------: | :------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |\n| Title check | ✅ Passed | The title accurately reflects the main change: adding null-safety checks to prevent focusing an undefined titleInputRef in the dialog. |\n| Description check | ✅ Passed | The description clearly explains the problem, solution, and impact, all directly related to the changeset of adding defensive ref checks. |\n| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n| Pr Description Must Follow Guidelines | ✅ Passed | The pull request description includes all required sections: problem statement (console warning with null titleInputRef), solution explanation (defensive checks before focus/select), and test verification steps (multiple dialog opens and notebook operations). |\n\n \n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n \n\n\n\n\n\n\n✨ Finishing Touches
\n\n\n🧪 Generate unit tests (beta)
\n\n- [ ] Create PR with unit tests\n\n \n\n \n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14879)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n\n❤️ Share
\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n \n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4112396142/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": {
"id": 347564,
"client_id": "Iv1.6aaafe4fe882736b",
"slug": "coderabbitai",
"node_id": "A_kwHOB96YWc4ABU2s",
"owner": {
"login": "coderabbitai",
"id": 132028505,
"node_id": "O_kgDOB96YWQ",
"avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/coderabbitai",
"html_url": "https://github.com/coderabbitai",
"followers_url": "https://api.github.com/users/coderabbitai/followers",
"following_url": "https://api.github.com/users/coderabbitai/following{/other_user}",
"gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}",
"starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions",
"organizations_url": "https://api.github.com/users/coderabbitai/orgs",
"repos_url": "https://api.github.com/users/coderabbitai/repos",
"events_url": "https://api.github.com/users/coderabbitai/events{/privacy}",
"received_events_url": "https://api.github.com/users/coderabbitai/received_events",
"type": "Organization",
"user_view_type": "public",
"site_admin": false
},
"name": "coderabbitai",
"description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n",
"external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github",
"html_url": "https://github.com/apps/coderabbitai",
"created_at": "2023-06-14T15:47:27Z",
"updated_at": "2026-03-14T07:58:44Z",
"permissions": {
"actions": "read",
"checks": "write",
"contents": "write",
"discussions": "read",
"issues": "write",
"members": "read",
"metadata": "read",
"pull_requests": "write",
"statuses": "write"
},
"events": [
"issues",
"issue_comment",
"label",
"organization",
"pull_request",
"pull_request_review",
"pull_request_review_comment",
"pull_request_review_thread",
"release",
"repository"
]
}
},
{
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4112475731",
"html_url": "https://github.com/laurent22/joplin/pull/14879#issuecomment-4112475731",
"issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14879",
"id": 4112475731,
"node_id": "IC_kwDOBLftOs71H2ZT",
"user": {
"login": "MANVENDRA-github",
"id": 121653862,
"node_id": "U_kgDOB0BKZg",
"avatar_url": "https://avatars.githubusercontent.com/u/121653862?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MANVENDRA-github",
"html_url": "https://github.com/MANVENDRA-github",
"followers_url": "https://api.github.com/users/MANVENDRA-github/followers",
"following_url": "https://api.github.com/users/MANVENDRA-github/following{/other_user}",
"gists_url": "https://api.github.com/users/MANVENDRA-github/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MANVENDRA-github/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MANVENDRA-github/subscriptions",
"organizations_url": "https://api.github.com/users/MANVENDRA-github/orgs",
"repos_url": "https://api.github.com/users/MANVENDRA-github/repos",
"events_url": "https://api.github.com/users/MANVENDRA-github/events{/privacy}",
"received_events_url": "https://api.github.com/users/MANVENDRA-github/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
},
"created_at": "2026-03-23T17:37:34Z",
"updated_at": "2026-03-23T17:37:34Z",
"body": "I have read the CLA Document and I hereby sign the CLA",
"author_association": "CONTRIBUTOR",
"reactions": {
"url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4112475731/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
},
"performed_via_github_app": null
}
]
}