{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14489", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14489/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14489/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14489/events", "html_url": "https://github.com/laurent22/joplin/pull/14489", "id": 3999687202, "node_id": "PR_kwDOBLftOs7GwXsH", "number": 14489, "title": "Fix SMTP TLS mode mismatch on port 587 causing ESOCKET / wrong version number", "user": { "login": "Manik-Khajuria-5", "id": 186909428, "node_id": "U_kgDOCyQC9A", "avatar_url": "https://avatars.githubusercontent.com/u/186909428?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Manik-Khajuria-5", "html_url": "https://github.com/Manik-Khajuria-5", "followers_url": "https://api.github.com/users/Manik-Khajuria-5/followers", "following_url": "https://api.github.com/users/Manik-Khajuria-5/following{/other_user}", "gists_url": "https://api.github.com/users/Manik-Khajuria-5/gists{/gist_id}", "starred_url": "https://api.github.com/users/Manik-Khajuria-5/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Manik-Khajuria-5/subscriptions", "organizations_url": "https://api.github.com/users/Manik-Khajuria-5/orgs", "repos_url": "https://api.github.com/users/Manik-Khajuria-5/repos", "events_url": "https://api.github.com/users/Manik-Khajuria-5/events{/privacy}", "received_events_url": "https://api.github.com/users/Manik-Khajuria-5/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 519700741, "node_id": "MDU6TGFiZWw1MTk3MDA3NDE=", "url": "https://api.github.com/repos/laurent22/joplin/labels/bug", "name": "bug", "color": "cf353b", "default": true, "description": "It's a bug" }, { "id": 2676541710, "node_id": "MDU6TGFiZWwyNjc2NTQxNzEw", "url": "https://api.github.com/repos/laurent22/joplin/labels/server", "name": "server", "color": "ffc274", "default": false, "description": "Issues related to Joplin Server" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 5, "created_at": "2026-02-27T07:49:26Z", "updated_at": "2026-02-27T10:44:18Z", "closed_at": "2026-02-27T10:44:08Z", "assignee": null, "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14489", "html_url": "https://github.com/laurent22/joplin/pull/14489", "diff_url": "https://github.com/laurent22/joplin/pull/14489.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14489.patch", "merged_at": null }, "body": "---\r\n\r\n### Fixes #14487\r\n\r\n### Problem\r\n\r\nWhen configured with:\r\n\r\n* `MAILER_PORT=587`\r\n* `MAILER_SECURITY=tls`\r\n\r\nthe mailer failed with `ESOCKET` / `wrong version number` errors, preventing emails (e.g., password reset) from being sent.\r\n\r\n**Cause:** Port 587 uses STARTTLS, but `tls` enabled implicit TLS (`secure: true`), causing a protocol mismatch.\r\n\r\n---\r\n\r\n### Solution\r\n\r\nAuto-correct invalid port/security combinations:\r\n\r\n* 587 + `tls` → `starttls`\r\n* 465 + `starttls` → `tls`\r\n* Other combinations unchanged\r\n\r\nImplemented via `mailerSecurityForPort()` and applied in `mailerConfigFromEnv()`.\r\n\r\n---\r\n\r\n### Impact\r\n\r\n* Fixes Gmail/SMTP failures on port 587\r\n* Preserves existing valid configurations\r\n* Avoids guessing for non-standard ports\r\n\r\n---\r\n\r\n### Tests\r\n\r\n* Added unit tests for port/security correction logic\r\n* Manual test confirms emails send successfully with 587 \r\n\r\n---\r\n\r\nhttps://github.com/user-attachments/assets/7723bdba-8b64-4f64-93c1-180071a15f49\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14489/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14489/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3971371757", "html_url": "https://github.com/laurent22/joplin/pull/14489#issuecomment-3971371757", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14489", "id": 3971371757, "node_id": "IC_kwDOBLftOs7stlLt", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-27T07:49:34Z", "updated_at": "2026-02-27T09:52:28Z", "body": "\nNo actionable comments were generated in the recent review. 🎉\n\n
\nℹ️ Recent review info\n\n**Configuration used**: Path: .coderabbit.yaml\n\n**Review profile**: CHILL\n\n**Plan**: Pro\n\n
\n📥 Commits\n\nReviewing files that changed from the base of the PR and between 6b52e5d3baa4878648bd29d531b8c5a05775b6e1 and 7b9ff42c140fdbf14048e5007af57c1a157c1ac2.\n\n
\n\n
\n📒 Files selected for processing (1)\n\n* `packages/server/src/config.test.ts`\n\n
\n\n
\n🚧 Files skipped from review as they are similar to previous changes (1)\n\n* packages/server/src/config.test.ts\n\n
\n\n
\n\n---\n\n\n\n\n
\n📝 Walkthrough\n\n## Walkthrough\n\nAdds a helper function `mailerSecurityForPort` to determine mailer security from port and refactors `mailerConfigFromEnv` to use it; includes unit tests validating mappings for ports 587 and 465.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Mailer security configuration**
`packages/server/src/config.ts`, `packages/server/src/config.test.ts`|Added `mailerSecurityForPort(port, security)` to adjust mailer security based on port (587 <-> STARTTLS, 465 <-> TLS); refactored `mailerConfigFromEnv` to use the helper; added tests verifying expected mappings for ports 587 and 465.|\n\n## Suggested labels\n\n`server`, `bug`\n\n
\n\n\n\n\n\n\n
\n🚥 Pre-merge checks | ✅ 4 | ❌ 1\n\n### ❌ Failed checks (1 warning)\n\n| Check name | Status | Explanation | Resolution |\n| :----------------: | :--------- | :----------------------------------------------------------------------------------- | :--------------------------------------------------------------------------------- |\n| Docstring Coverage | ⚠️ Warning | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |\n\n
\n✅ Passed checks (4 passed)\n\n| Check name | Status | Explanation |\n| :------------------------: | :------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |\n| Title check | ✅ Passed | The title clearly and specifically describes the primary change: fixing SMTP TLS mode mismatch on port 587, directly addressing the main issue causing ESOCKET errors. |\n| Description check | ✅ Passed | The description is well-detailed and directly related to the changeset, explaining the problem, solution, impact, and tests for the SMTP port/security configuration fix. |\n| Linked Issues check | ✅ Passed | The pull request fully addresses the objectives from issue `#14487` by implementing automatic correction of port/security mismatches (587+tls→starttls, 465+starttls→tls) and includes unit tests for the correction logic. |\n| Out of Scope Changes check | ✅ Passed | All changes are directly in scope: the new mailerSecurityForPort function and its integration into mailerConfigFromEnv, plus corresponding unit tests, all align with fixing the port/security mismatch issue. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing Touches\n\n
\n🧪 Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n- [ ] Post copyable unit tests in a comment\n\n
\n\n
\n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14489)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n
\n❤️ Share\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n
\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3971371757/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3971371922", "html_url": "https://github.com/laurent22/joplin/pull/14489#issuecomment-3971371922", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14489", "id": 3971371922, "node_id": "IC_kwDOBLftOs7stlOS", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-27T07:49:37Z", "updated_at": "2026-02-27T10:44:18Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3971371922/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3971382974", "html_url": "https://github.com/laurent22/joplin/pull/14489#issuecomment-3971382974", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14489", "id": 3971382974, "node_id": "IC_kwDOBLftOs7stn6-", "user": { "login": "Manik-Khajuria-5", "id": 186909428, "node_id": "U_kgDOCyQC9A", "avatar_url": "https://avatars.githubusercontent.com/u/186909428?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Manik-Khajuria-5", "html_url": "https://github.com/Manik-Khajuria-5", "followers_url": "https://api.github.com/users/Manik-Khajuria-5/followers", "following_url": "https://api.github.com/users/Manik-Khajuria-5/following{/other_user}", "gists_url": "https://api.github.com/users/Manik-Khajuria-5/gists{/gist_id}", "starred_url": "https://api.github.com/users/Manik-Khajuria-5/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Manik-Khajuria-5/subscriptions", "organizations_url": "https://api.github.com/users/Manik-Khajuria-5/orgs", "repos_url": "https://api.github.com/users/Manik-Khajuria-5/repos", "events_url": "https://api.github.com/users/Manik-Khajuria-5/events{/privacy}", "received_events_url": "https://api.github.com/users/Manik-Khajuria-5/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-27T07:52:51Z", "updated_at": "2026-02-27T07:52:51Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3971382974/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3971383779", "html_url": "https://github.com/laurent22/joplin/pull/14489#issuecomment-3971383779", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14489", "id": 3971383779, "node_id": "IC_kwDOBLftOs7stoHj", "user": { "login": "Manik-Khajuria-5", "id": 186909428, "node_id": "U_kgDOCyQC9A", "avatar_url": "https://avatars.githubusercontent.com/u/186909428?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Manik-Khajuria-5", "html_url": "https://github.com/Manik-Khajuria-5", "followers_url": "https://api.github.com/users/Manik-Khajuria-5/followers", "following_url": "https://api.github.com/users/Manik-Khajuria-5/following{/other_user}", "gists_url": "https://api.github.com/users/Manik-Khajuria-5/gists{/gist_id}", "starred_url": "https://api.github.com/users/Manik-Khajuria-5/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Manik-Khajuria-5/subscriptions", "organizations_url": "https://api.github.com/users/Manik-Khajuria-5/orgs", "repos_url": "https://api.github.com/users/Manik-Khajuria-5/repos", "events_url": "https://api.github.com/users/Manik-Khajuria-5/events{/privacy}", "received_events_url": "https://api.github.com/users/Manik-Khajuria-5/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-27T07:53:05Z", "updated_at": "2026-02-27T07:53:05Z", "body": "recheck", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3971383779/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3972153136", "html_url": "https://github.com/laurent22/joplin/pull/14489#issuecomment-3972153136", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14489", "id": 3972153136, "node_id": "IC_kwDOBLftOs7swj8w", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-27T10:44:08Z", "updated_at": "2026-02-27T10:44:09Z", "body": "Thanks for the contribution. We’re closing this PR because it does not follow the project’s contribution policy: it is not based on a triaged, accepted issue and does not address a concrete problem agreed upon by maintainers.\r\n\r\nWhile the change itself is not necessarily incorrect, reviewing and maintaining such PRs takes time away from higher-priority work.\r\n\r\nPlease see our [Contribution Scope Policy](https://joplinapp.org/help/dev/#contribution-scope) for details on what kinds of contributions we accept.\r\n\r\nPlease make sure you read our guidelines: https://github.com/joplin/gsoc\r\n\r\nAnd our AI policy: https://github.com/joplin/gsoc/blob/master/ai_policy.md\r\n", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3972153136/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }