{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7591", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/7591/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/7591/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/7591/events", "html_url": "https://github.com/laurent22/joplin/pull/7591", "id": 1523906306, "node_id": "PR_kwDOBLftOs5G46OS", "number": 7591, "title": "Desktop: Partially fixes #7457: Dealing with dash in alarms in linux", "user": { "login": "Mighil31", "id": 47496035, "node_id": "MDQ6VXNlcjQ3NDk2MDM1", "avatar_url": "https://avatars.githubusercontent.com/u/47496035?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Mighil31", "html_url": "https://github.com/Mighil31", "followers_url": "https://api.github.com/users/Mighil31/followers", "following_url": "https://api.github.com/users/Mighil31/following{/other_user}", "gists_url": "https://api.github.com/users/Mighil31/gists{/gist_id}", "starred_url": "https://api.github.com/users/Mighil31/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Mighil31/subscriptions", "organizations_url": "https://api.github.com/users/Mighil31/orgs", "repos_url": "https://api.github.com/users/Mighil31/repos", "events_url": "https://api.github.com/users/Mighil31/events{/privacy}", "received_events_url": "https://api.github.com/users/Mighil31/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": true, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2023-01-07T15:14:51Z", "updated_at": "2023-01-08T06:11:27Z", "closed_at": "2023-01-07T15:43:55Z", "author_association": "NONE", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/7591", "html_url": "https://github.com/laurent22/joplin/pull/7591", "diff_url": "https://github.com/laurent22/joplin/pull/7591.diff", "patch_url": "https://github.com/laurent22/joplin/pull/7591.patch", "merged_at": null }, "body": "\r\n\r\n## Summary\r\nAdded functionality to deal with alarms in linux starting with a \"-\" symbol. This partially fixes [#7457 ](https://github.com/laurent22/joplin/issues/7457)\r\n\r\nI've added a function to escape the first \"-\" in the body of the alarm if one exists. \r\nFor the title, escaping the character did not seem to work as the \"\\\\\\\\\" was simply appended onto the string. Instead I've simply removed all leading dashes from the title.\r\n## Testing\r\nFor testing, the `displayDefaultNotification` function did not seem to return any values, regardless of whether the notification worked or not and hence I was not able to think of a good way to test it. Instead I've added tests for the above mentioned functions themselves, making sure that the dashes are correctly dealt with\r\n\r\n\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7591/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/7591/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1374512363", "html_url": "https://github.com/laurent22/joplin/pull/7591#issuecomment-1374512363", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7591", "id": 1374512363, "node_id": "IC_kwDOBLftOs5R7WTr", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-01-07T15:15:05Z", "updated_at": "2023-01-07T15:17:10Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1374512363/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1374512755", "html_url": "https://github.com/laurent22/joplin/pull/7591#issuecomment-1374512755", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7591", "id": 1374512755, "node_id": "IC_kwDOBLftOs5R7WZz", "user": { "login": "Mighil31", "id": 47496035, "node_id": "MDQ6VXNlcjQ3NDk2MDM1", "avatar_url": "https://avatars.githubusercontent.com/u/47496035?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Mighil31", "html_url": "https://github.com/Mighil31", "followers_url": "https://api.github.com/users/Mighil31/followers", "following_url": "https://api.github.com/users/Mighil31/following{/other_user}", "gists_url": "https://api.github.com/users/Mighil31/gists{/gist_id}", "starred_url": "https://api.github.com/users/Mighil31/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Mighil31/subscriptions", "organizations_url": "https://api.github.com/users/Mighil31/orgs", "repos_url": "https://api.github.com/users/Mighil31/repos", "events_url": "https://api.github.com/users/Mighil31/events{/privacy}", "received_events_url": "https://api.github.com/users/Mighil31/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-01-07T15:16:36Z", "updated_at": "2023-01-07T15:16:36Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1374512755/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1374520685", "html_url": "https://github.com/laurent22/joplin/pull/7591#issuecomment-1374520685", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7591", "id": 1374520685, "node_id": "IC_kwDOBLftOs5R7YVt", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-01-07T15:43:55Z", "updated_at": "2023-01-07T15:43:55Z", "author_association": "OWNER", "body": "Sorry I feel there's too much work to review all this so I prefer to close. It's just about a few dashes and I don't want to spend two weeks discussing this.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1374520685/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }