{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14436", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14436/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14436/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14436/events", "html_url": "https://github.com/laurent22/joplin/pull/14436", "id": 3978987867, "node_id": "PR_kwDOBLftOs7FsIy7", "number": 14436, "title": "fixes #14300", "user": { "login": "Nagmani001", "id": 163531400, "node_id": "U_kgDOCb9KiA", "avatar_url": "https://avatars.githubusercontent.com/u/163531400?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Nagmani001", "html_url": "https://github.com/Nagmani001", "followers_url": "https://api.github.com/users/Nagmani001/followers", "following_url": "https://api.github.com/users/Nagmani001/following{/other_user}", "gists_url": "https://api.github.com/users/Nagmani001/gists{/gist_id}", "starred_url": "https://api.github.com/users/Nagmani001/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Nagmani001/subscriptions", "organizations_url": "https://api.github.com/users/Nagmani001/orgs", "repos_url": "https://api.github.com/users/Nagmani001/repos", "events_url": "https://api.github.com/users/Nagmani001/events{/privacy}", "received_events_url": "https://api.github.com/users/Nagmani001/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 519700741, "node_id": "MDU6TGFiZWw1MTk3MDA3NDE=", "url": "https://api.github.com/repos/laurent22/joplin/labels/bug", "name": "bug", "color": "cf353b", "default": true, "description": "It's a bug" }, { "id": 6987126098, "node_id": "LA_kwDOBLftOs8AAAABoHcVUg", "url": "https://api.github.com/repos/laurent22/joplin/labels/export", "name": "export", "color": "7EDF94", "default": false, "description": "" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 4, "created_at": "2026-02-23T16:13:10Z", "updated_at": "2026-02-23T17:17:24Z", "closed_at": "2026-02-23T17:08:11Z", "assignee": null, "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14436", "html_url": "https://github.com/laurent22/joplin/pull/14436", "diff_url": "https://github.com/laurent22/joplin/pull/14436.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14436.patch", "merged_at": null }, "body": "Fixes #14300 \r\n\r\n## Summary\r\n - Removed `#` from the blacklisted characters in `friendlySafeFilename` so that filenames containing `#` (e.g. \"C#\") are preserved during notebook export\r\n - Added a test case to verify `#` is no longer stripped from filenames\r\n\r\n ## Test plan\r\n - [X] Export a notebook containing a note with `#` in the title (e.g. \"C# Notes\")\r\n - [X] Verify the exported filename preserves the `#` character\r\n - [X] Run `yarn jest packages/lib/pathUtils.test.js` and confirm tests pass", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14436/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14436/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3945750931", "html_url": "https://github.com/laurent22/joplin/pull/14436#issuecomment-3945750931", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14436", "id": 3945750931, "node_id": "IC_kwDOBLftOs7rL2GT", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-23T16:13:38Z", "updated_at": "2026-02-23T17:17:24Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3945750931/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3945751907", "html_url": "https://github.com/laurent22/joplin/pull/14436#issuecomment-3945751907", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14436", "id": 3945751907, "node_id": "IC_kwDOBLftOs7rL2Vj", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-23T16:13:49Z", "updated_at": "2026-02-23T16:52:53Z", "body": "\n\n\n
\n📝 Walkthrough\n\n## Walkthrough\n\nRemoved '#' from filename sanitisation blacklist so filenames like \"C#\" are preserved; added URL encoding/decoding for '#' in markdown link utilities and corresponding tests to ensure \"../C#/note.md\" becomes \"../C%23/note.md\" and back.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Filename sanitisation & tests**
`packages/lib/path-utils.ts`, `packages/lib/pathUtils.test.js`|Removed `#` from `friendlySafeFilename` blacklist so `#` is no longer replaced with `_`. Added a test case asserting `friendlySafeFilename('C#') === 'C#'`.|\n|**Markdown URL escaping & tests**
`packages/lib/markdownUtils.ts`, `packages/lib/markdownUtils2.test.ts`|Added encoding of `#` to `%23` in `escapeLinkUrl` and decoding `%23` to `#` in `unescapeLinkUrl`. Added a test asserting `../C#/note.md` is escaped to `../C%23/note.md`.|\n\n## Suggested labels\n\n`bug`, `export`, `encoding`\n\n
\n\n\n\n\n\n\n
\n🚥 Pre-merge checks | ✅ 3 | ❌ 2\n\n### ❌ Failed checks (1 warning, 1 inconclusive)\n\n| Check name | Status | Explanation | Resolution |\n| :------------------------: | :------------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | :-------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Out of Scope Changes check | ⚠️ Warning | Changes to markdownUtils.ts and markdownUtils2.test.ts add # encoding/decoding to URL escaping, which extends beyond the filename preservation scope specified in `#14300`. | Clarify whether URL encoding of # is required by `#14300` or remove these changes if they address a separate concern not covered in the linked issue. |\n| Title check | ❓ Inconclusive | The title 'fixes `#14300`' directly references the linked issue but lacks descriptive context about what change is being made. | Revise the title to describe the actual change, e.g., 'Preserve # character in filenames during notebook export' or similar. |\n\n
\n✅ Passed checks (3 passed)\n\n| Check name | Status | Explanation |\n| :-----------------: | :------- | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Description check | ✅ Passed | The description clearly explains the change (removing # from blacklist), provides a test plan, and aligns with the linked issue requirements. |\n| Linked Issues check | ✅ Passed | The PR addresses the core requirement from `#14300` by removing # from the blacklisted characters in friendlySafeFilename, preserving # in filenames during export as requested. |\n| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing Touches\n\n- [ ] 📝 Generate docstrings (stacked PR)\n- [ ] 📝 Generate docstrings (commit on current branch)\n
\n🧪 Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n- [ ] Post copyable unit tests in a comment\n\n
\n\n
\n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14436)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n
\n❤️ Share\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n
\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3945751907/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3945773420", "html_url": "https://github.com/laurent22/joplin/pull/14436#issuecomment-3945773420", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14436", "id": 3945773420, "node_id": "IC_kwDOBLftOs7rL7ls", "user": { "login": "Nagmani001", "id": 163531400, "node_id": "U_kgDOCb9KiA", "avatar_url": "https://avatars.githubusercontent.com/u/163531400?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Nagmani001", "html_url": "https://github.com/Nagmani001", "followers_url": "https://api.github.com/users/Nagmani001/followers", "following_url": "https://api.github.com/users/Nagmani001/following{/other_user}", "gists_url": "https://api.github.com/users/Nagmani001/gists{/gist_id}", "starred_url": "https://api.github.com/users/Nagmani001/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Nagmani001/subscriptions", "organizations_url": "https://api.github.com/users/Nagmani001/orgs", "repos_url": "https://api.github.com/users/Nagmani001/repos", "events_url": "https://api.github.com/users/Nagmani001/events{/privacy}", "received_events_url": "https://api.github.com/users/Nagmani001/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-23T16:17:59Z", "updated_at": "2026-02-23T16:17:59Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3945773420/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3946064747", "html_url": "https://github.com/laurent22/joplin/pull/14436#issuecomment-3946064747", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14436", "id": 3946064747, "node_id": "IC_kwDOBLftOs7rNCtr", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-23T17:08:11Z", "updated_at": "2026-02-23T17:08:11Z", "body": "Thanks for the contribution. We’re closing this PR because it does not follow the project’s contribution policy: it is not based on a triaged, accepted issue and does not address a concrete problem agreed upon by maintainers.\r\n\r\nWhile the change itself is not necessarily incorrect, reviewing and maintaining such PRs takes time away from higher-priority work.\r\n\r\nPlease see our [Contribution Scope Policy](https://joplinapp.org/help/dev/#contribution-scope) for details on what kinds of contributions we accept.\r\n\r\nPlease make sure you read our guidelines: https://github.com/joplin/gsoc\r\n\r\nAnd our AI policy: https://github.com/joplin/gsoc/blob/master/ai_policy.md\r\n", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3946064747/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }