{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11932", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11932/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11932/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11932/events", "html_url": "https://github.com/laurent22/joplin/pull/11932", "id": 2898302671, "node_id": "PR_kwDOBLftOs6NhuI7", "number": 11932, "title": "All : Fix for Share with Nobody : Added proper error message", "user": { "login": "Paramesh-T-S", "id": 42896229, "node_id": "MDQ6VXNlcjQyODk2MjI5", "avatar_url": "https://avatars.githubusercontent.com/u/42896229?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Paramesh-T-S", "html_url": "https://github.com/Paramesh-T-S", "followers_url": "https://api.github.com/users/Paramesh-T-S/followers", "following_url": "https://api.github.com/users/Paramesh-T-S/following{/other_user}", "gists_url": "https://api.github.com/users/Paramesh-T-S/gists{/gist_id}", "starred_url": "https://api.github.com/users/Paramesh-T-S/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Paramesh-T-S/subscriptions", "organizations_url": "https://api.github.com/users/Paramesh-T-S/orgs", "repos_url": "https://api.github.com/users/Paramesh-T-S/repos", "events_url": "https://api.github.com/users/Paramesh-T-S/events{/privacy}", "received_events_url": "https://api.github.com/users/Paramesh-T-S/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 5, "created_at": "2025-03-05T19:44:59Z", "updated_at": "2025-03-06T15:58:24Z", "closed_at": "2025-03-06T15:58:11Z", "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/11932", "html_url": "https://github.com/laurent22/joplin/pull/11932", "diff_url": "https://github.com/laurent22/joplin/pull/11932.diff", "patch_url": "https://github.com/laurent22/joplin/pull/11932.patch", "merged_at": "2025-03-06T15:58:11Z" }, "body": "**Summary :** \r\n\r\n- All: Resolves #11923 - Fix added with Proper error message - \"Kindly provide proper recipient address\"\r\n\r\nThis pull request contains fix which throws error with message \"Kindly provide proper recipient address\", so that user will know the issue and act accordingly. Added screenshots below.\r\n\r\n![image](https://github.com/user-attachments/assets/3d723d2d-83fb-4a26-87ba-6b418b8aee91)\r\n\r\nManual Test Process :\r\n1. Configure Synchronization target as Joplin server.\r\n2. Click and open \"Share notebook\" dialog under \"Notebook\" menu.\r\n3. Enter nothing under \"Add recipient\" Text box, Click share.\r\n4. You will see the proper message associated with it.\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11932/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11932/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2701906757", "html_url": "https://github.com/laurent22/joplin/pull/11932#issuecomment-2701906757", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11932", "id": 2701906757, "node_id": "IC_kwDOBLftOs6hC9NF", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-05T19:45:12Z", "updated_at": "2025-03-06T15:58:24Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2701906757/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2701911147", "html_url": "https://github.com/laurent22/joplin/pull/11932#issuecomment-2701911147", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11932", "id": 2701911147, "node_id": "IC_kwDOBLftOs6hC-Rr", "user": { "login": "Paramesh-T-S", "id": 42896229, "node_id": "MDQ6VXNlcjQyODk2MjI5", "avatar_url": "https://avatars.githubusercontent.com/u/42896229?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Paramesh-T-S", "html_url": "https://github.com/Paramesh-T-S", "followers_url": "https://api.github.com/users/Paramesh-T-S/followers", "following_url": "https://api.github.com/users/Paramesh-T-S/following{/other_user}", "gists_url": "https://api.github.com/users/Paramesh-T-S/gists{/gist_id}", "starred_url": "https://api.github.com/users/Paramesh-T-S/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Paramesh-T-S/subscriptions", "organizations_url": "https://api.github.com/users/Paramesh-T-S/orgs", "repos_url": "https://api.github.com/users/Paramesh-T-S/repos", "events_url": "https://api.github.com/users/Paramesh-T-S/events{/privacy}", "received_events_url": "https://api.github.com/users/Paramesh-T-S/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-05T19:47:18Z", "updated_at": "2025-03-05T19:47:18Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2701911147/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2701911737", "html_url": "https://github.com/laurent22/joplin/pull/11932#issuecomment-2701911737", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11932", "id": 2701911737, "node_id": "IC_kwDOBLftOs6hC-a5", "user": { "login": "Paramesh-T-S", "id": 42896229, "node_id": "MDQ6VXNlcjQyODk2MjI5", "avatar_url": "https://avatars.githubusercontent.com/u/42896229?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Paramesh-T-S", "html_url": "https://github.com/Paramesh-T-S", "followers_url": "https://api.github.com/users/Paramesh-T-S/followers", "following_url": "https://api.github.com/users/Paramesh-T-S/following{/other_user}", "gists_url": "https://api.github.com/users/Paramesh-T-S/gists{/gist_id}", "starred_url": "https://api.github.com/users/Paramesh-T-S/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Paramesh-T-S/subscriptions", "organizations_url": "https://api.github.com/users/Paramesh-T-S/orgs", "repos_url": "https://api.github.com/users/Paramesh-T-S/repos", "events_url": "https://api.github.com/users/Paramesh-T-S/events{/privacy}", "received_events_url": "https://api.github.com/users/Paramesh-T-S/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-05T19:47:36Z", "updated_at": "2025-03-05T19:47:36Z", "author_association": "CONTRIBUTOR", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2701911737/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2702184418", "html_url": "https://github.com/laurent22/joplin/pull/11932#issuecomment-2702184418", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11932", "id": 2702184418, "node_id": "IC_kwDOBLftOs6hEA_i", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-05T22:04:50Z", "updated_at": "2025-03-05T22:04:50Z", "author_association": "COLLABORATOR", "body": "Thank you for the pull request! Be sure to fix the linter errors (see [the relevant documentation on Joplin's website](https://joplinapp.org/help/dev/coding_style#enforcing-rules-using-eslint)).", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2702184418/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2703982395", "html_url": "https://github.com/laurent22/joplin/pull/11932#issuecomment-2703982395", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11932", "id": 2703982395, "node_id": "IC_kwDOBLftOs6hK387", "user": { "login": "Paramesh-T-S", "id": 42896229, "node_id": "MDQ6VXNlcjQyODk2MjI5", "avatar_url": "https://avatars.githubusercontent.com/u/42896229?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Paramesh-T-S", "html_url": "https://github.com/Paramesh-T-S", "followers_url": "https://api.github.com/users/Paramesh-T-S/followers", "following_url": "https://api.github.com/users/Paramesh-T-S/following{/other_user}", "gists_url": "https://api.github.com/users/Paramesh-T-S/gists{/gist_id}", "starred_url": "https://api.github.com/users/Paramesh-T-S/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Paramesh-T-S/subscriptions", "organizations_url": "https://api.github.com/users/Paramesh-T-S/orgs", "repos_url": "https://api.github.com/users/Paramesh-T-S/repos", "events_url": "https://api.github.com/users/Paramesh-T-S/events{/privacy}", "received_events_url": "https://api.github.com/users/Paramesh-T-S/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-06T14:17:49Z", "updated_at": "2025-03-06T14:22:59Z", "author_association": "CONTRIBUTOR", "body": "Kindly review this PR and let me if any know if any updation or changes have to be done.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2703982395/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }