{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14182", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14182/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14182/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14182/events", "html_url": "https://github.com/laurent22/joplin/pull/14182", "id": 3844910233, "node_id": "PR_kwDOBLftOs6-zN6s", "number": 14182, "title": "Fixes #14141: Left selection border cut off in Rich Text Editor", "user": { "login": "Pritam-Sing-2025", "id": 214441079, "node_id": "U_kgDODMgcdw", "avatar_url": "https://avatars.githubusercontent.com/u/214441079?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Pritam-Sing-2025", "html_url": "https://github.com/Pritam-Sing-2025", "followers_url": "https://api.github.com/users/Pritam-Sing-2025/followers", "following_url": "https://api.github.com/users/Pritam-Sing-2025/following{/other_user}", "gists_url": "https://api.github.com/users/Pritam-Sing-2025/gists{/gist_id}", "starred_url": "https://api.github.com/users/Pritam-Sing-2025/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Pritam-Sing-2025/subscriptions", "organizations_url": "https://api.github.com/users/Pritam-Sing-2025/orgs", "repos_url": "https://api.github.com/users/Pritam-Sing-2025/repos", "events_url": "https://api.github.com/users/Pritam-Sing-2025/events{/privacy}", "received_events_url": "https://api.github.com/users/Pritam-Sing-2025/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 6, "created_at": "2026-01-22T21:55:42Z", "updated_at": "2026-01-23T18:30:31Z", "closed_at": "2026-01-23T18:30:17Z", "assignee": null, "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14182", "html_url": "https://github.com/laurent22/joplin/pull/14182", "diff_url": "https://github.com/laurent22/joplin/pull/14182.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14182.patch", "merged_at": null }, "body": "This PR fixes an issue where the left selection border was cut off in the Rich Text Editor when selecting non-editable blocks such as code blocks.\r\n\r\nThe selection outline was clipped on the left side. This change adjusts the selection styling so the border is fully visible without overlapping the text.\r\n\r\nFixes #14141\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14182/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14182/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3786953592", "html_url": "https://github.com/laurent22/joplin/pull/14182#issuecomment-3786953592", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14182", "id": 3786953592, "node_id": "IC_kwDOBLftOs7huFN4", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-01-22T21:55:55Z", "updated_at": "2026-01-23T18:30:31Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3786953592/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3786969543", "html_url": "https://github.com/laurent22/joplin/pull/14182#issuecomment-3786969543", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14182", "id": 3786969543, "node_id": "IC_kwDOBLftOs7huJHH", "user": { "login": "Pritam-Sing-2025", "id": 214441079, "node_id": "U_kgDODMgcdw", "avatar_url": "https://avatars.githubusercontent.com/u/214441079?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Pritam-Sing-2025", "html_url": "https://github.com/Pritam-Sing-2025", "followers_url": "https://api.github.com/users/Pritam-Sing-2025/followers", "following_url": "https://api.github.com/users/Pritam-Sing-2025/following{/other_user}", "gists_url": "https://api.github.com/users/Pritam-Sing-2025/gists{/gist_id}", "starred_url": "https://api.github.com/users/Pritam-Sing-2025/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Pritam-Sing-2025/subscriptions", "organizations_url": "https://api.github.com/users/Pritam-Sing-2025/orgs", "repos_url": "https://api.github.com/users/Pritam-Sing-2025/repos", "events_url": "https://api.github.com/users/Pritam-Sing-2025/events{/privacy}", "received_events_url": "https://api.github.com/users/Pritam-Sing-2025/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-01-22T22:00:28Z", "updated_at": "2026-01-22T22:00:28Z", "body": "I have read the CLA Document and I hereby sign the CLA\r\n", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3786969543/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3786984767", "html_url": "https://github.com/laurent22/joplin/pull/14182#issuecomment-3786984767", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14182", "id": 3786984767, "node_id": "IC_kwDOBLftOs7huM0_", "user": { "login": "Pritam-Sing-2025", "id": 214441079, "node_id": "U_kgDODMgcdw", "avatar_url": "https://avatars.githubusercontent.com/u/214441079?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Pritam-Sing-2025", "html_url": "https://github.com/Pritam-Sing-2025", "followers_url": "https://api.github.com/users/Pritam-Sing-2025/followers", "following_url": "https://api.github.com/users/Pritam-Sing-2025/following{/other_user}", "gists_url": "https://api.github.com/users/Pritam-Sing-2025/gists{/gist_id}", "starred_url": "https://api.github.com/users/Pritam-Sing-2025/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Pritam-Sing-2025/subscriptions", "organizations_url": "https://api.github.com/users/Pritam-Sing-2025/orgs", "repos_url": "https://api.github.com/users/Pritam-Sing-2025/repos", "events_url": "https://api.github.com/users/Pritam-Sing-2025/events{/privacy}", "received_events_url": "https://api.github.com/users/Pritam-Sing-2025/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-01-22T22:05:14Z", "updated_at": "2026-01-22T22:05:14Z", "body": "recheck", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3786984767/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3789544796", "html_url": "https://github.com/laurent22/joplin/pull/14182#issuecomment-3789544796", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14182", "id": 3789544796, "node_id": "IC_kwDOBLftOs7h391c", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-01-23T10:24:09Z", "updated_at": "2026-01-23T10:24:09Z", "body": "Hello, how do we know this change did not break something else?", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3789544796/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3789912343", "html_url": "https://github.com/laurent22/joplin/pull/14182#issuecomment-3789912343", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14182", "id": 3789912343, "node_id": "IC_kwDOBLftOs7h5XkX", "user": { "login": "Pritam-Sing-2025", "id": 214441079, "node_id": "U_kgDODMgcdw", "avatar_url": "https://avatars.githubusercontent.com/u/214441079?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Pritam-Sing-2025", "html_url": "https://github.com/Pritam-Sing-2025", "followers_url": "https://api.github.com/users/Pritam-Sing-2025/followers", "following_url": "https://api.github.com/users/Pritam-Sing-2025/following{/other_user}", "gists_url": "https://api.github.com/users/Pritam-Sing-2025/gists{/gist_id}", "starred_url": "https://api.github.com/users/Pritam-Sing-2025/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Pritam-Sing-2025/subscriptions", "organizations_url": "https://api.github.com/users/Pritam-Sing-2025/orgs", "repos_url": "https://api.github.com/users/Pritam-Sing-2025/repos", "events_url": "https://api.github.com/users/Pritam-Sing-2025/events{/privacy}", "received_events_url": "https://api.github.com/users/Pritam-Sing-2025/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-01-23T11:57:26Z", "updated_at": "2026-01-23T11:57:26Z", "body": "Hi Laurent,\r\nThis change is only a small CSS adjustment for non-editable blocks in the Rich Text Editor.\r\nIt only affects the selection outline styling not the editor logic or editable content.\r\nI verified normal text editing and selection of code blocks, and everything was just fine.", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3789912343/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3791692494", "html_url": "https://github.com/laurent22/joplin/pull/14182#issuecomment-3791692494", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14182", "id": 3791692494, "node_id": "IC_kwDOBLftOs7iAKLO", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-01-23T18:30:17Z", "updated_at": "2026-01-23T18:30:18Z", "body": "Thanks for the submission.\r\n\r\nWhile this PR targets an existing issue, the proposed solution is not suitable for the project in its current form. Bringing it up to an acceptable standard would require significant redesign and guidance, which we’re not able to provide.\r\n\r\nFor future contributions, please ensure changes are well-aligned with the existing architecture and sufficiently tested.\r\n\r\nPlease do not open another PR for this issue.", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3791692494/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }