{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10246", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/10246/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/10246/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/10246/events", "html_url": "https://github.com/laurent22/joplin/pull/10246", "id": 2218863957, "node_id": "PR_kwDOBLftOs5rWXGu", "number": 10246, "title": "Desktop: FIX #10218: Create bulleted list hotkey not working in rich text editor", "user": { "login": "RafaR13", "id": 100279653, "node_id": "U_kgDOBfolZQ", "avatar_url": "https://avatars.githubusercontent.com/u/100279653?v=4", "gravatar_id": "", "url": "https://api.github.com/users/RafaR13", "html_url": "https://github.com/RafaR13", "followers_url": "https://api.github.com/users/RafaR13/followers", "following_url": "https://api.github.com/users/RafaR13/following{/other_user}", "gists_url": "https://api.github.com/users/RafaR13/gists{/gist_id}", "starred_url": "https://api.github.com/users/RafaR13/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/RafaR13/subscriptions", "organizations_url": "https://api.github.com/users/RafaR13/orgs", "repos_url": "https://api.github.com/users/RafaR13/repos", "events_url": "https://api.github.com/users/RafaR13/events{/privacy}", "received_events_url": "https://api.github.com/users/RafaR13/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2024-04-01T18:57:52Z", "updated_at": "2024-04-25T13:13:14Z", "closed_at": "2024-04-25T13:03:50Z", "author_association": "NONE", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/10246", "html_url": "https://github.com/laurent22/joplin/pull/10246", "diff_url": "https://github.com/laurent22/joplin/pull/10246.diff", "patch_url": "https://github.com/laurent22/joplin/pull/10246.patch", "merged_at": null }, "body": "Fixes: #10218 \r\nThe application's current behaviour is such that when one presses the hotkey to create a bulleted list (Ctrl+Alt+- by default), it doesn't work. I later realized that, if one changes the hotkey to a given command, instead of replacing it, the new hotkey is added and the default hotkey still works, although these hotkeys are handled differently while achieving the same result. Considering this and the fact that the bulleted list command isn't being handled at all, I added a verification in TinyMCE.tsx's onKeyDown function to verify if the default hotkey was being pressed, and if so, execute the command associated with the bulleted list directly. This provides a solution while the logic behind the treatment of hotkeys isn't fixed.\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10246/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/10246/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2030361197", "html_url": "https://github.com/laurent22/joplin/pull/10246#issuecomment-2030361197", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10246", "id": 2030361197, "node_id": "IC_kwDOBLftOs55BNpt", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-01T18:58:06Z", "updated_at": "2024-04-25T13:13:14Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2030361197/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2030362195", "html_url": "https://github.com/laurent22/joplin/pull/10246#issuecomment-2030362195", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10246", "id": 2030362195, "node_id": "IC_kwDOBLftOs55BN5T", "user": { "login": "RafaR13", "id": 100279653, "node_id": "U_kgDOBfolZQ", "avatar_url": "https://avatars.githubusercontent.com/u/100279653?v=4", "gravatar_id": "", "url": "https://api.github.com/users/RafaR13", "html_url": "https://github.com/RafaR13", "followers_url": "https://api.github.com/users/RafaR13/followers", "following_url": "https://api.github.com/users/RafaR13/following{/other_user}", "gists_url": "https://api.github.com/users/RafaR13/gists{/gist_id}", "starred_url": "https://api.github.com/users/RafaR13/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/RafaR13/subscriptions", "organizations_url": "https://api.github.com/users/RafaR13/orgs", "repos_url": "https://api.github.com/users/RafaR13/repos", "events_url": "https://api.github.com/users/RafaR13/events{/privacy}", "received_events_url": "https://api.github.com/users/RafaR13/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-01T18:58:50Z", "updated_at": "2024-04-01T18:58:50Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2030362195/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2077132315", "html_url": "https://github.com/laurent22/joplin/pull/10246#issuecomment-2077132315", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10246", "id": 2077132315, "node_id": "IC_kwDOBLftOs57zoYb", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-25T13:03:50Z", "updated_at": "2024-04-25T13:03:50Z", "author_association": "OWNER", "body": "@RafaR13, thanks for the pull request but I'm going to close it for now as I'm trying to clear our backlog. Feel free to let me me know if you'd like to continue working on it though and I'll re-open the PR, or you can create a new one.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2077132315/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }