{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/12666", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12666/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12666/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12666/events", "html_url": "https://github.com/laurent22/joplin/pull/12666", "id": 3198421394, "node_id": "PR_kwDOBLftOs6dN9kx", "number": 12666, "title": "Fix: Long URL in note properties no longer breaks the dialog layout (โ€ฆ", "user": { "login": "SAYAN02-DEV", "id": 212765994, "node_id": "U_kgDODK6NKg", "avatar_url": "https://avatars.githubusercontent.com/u/212765994?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SAYAN02-DEV", "html_url": "https://github.com/SAYAN02-DEV", "followers_url": "https://api.github.com/users/SAYAN02-DEV/followers", "following_url": "https://api.github.com/users/SAYAN02-DEV/following{/other_user}", "gists_url": "https://api.github.com/users/SAYAN02-DEV/gists{/gist_id}", "starred_url": "https://api.github.com/users/SAYAN02-DEV/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SAYAN02-DEV/subscriptions", "organizations_url": "https://api.github.com/users/SAYAN02-DEV/orgs", "repos_url": "https://api.github.com/users/SAYAN02-DEV/repos", "events_url": "https://api.github.com/users/SAYAN02-DEV/events{/privacy}", "received_events_url": "https://api.github.com/users/SAYAN02-DEV/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2025-07-03T07:49:47Z", "updated_at": "2025-07-03T18:21:13Z", "closed_at": "2025-07-03T18:21:00Z", "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/12666", "html_url": "https://github.com/laurent22/joplin/pull/12666", "diff_url": "https://github.com/laurent22/joplin/pull/12666.diff", "patch_url": "https://github.com/laurent22/joplin/pull/12666.patch", "merged_at": null }, "body": "Fixes #12643\r\n\r\n### ๐Ÿ› Problem\r\n\r\nOpening the Note Properties dialog with a very long URL in the `source_url` field caused the layout to overflow or become unreadable. This made it impossible to interact with or view other properties.\r\n\r\n---\r\n\r\n### โœ… Solution\r\n\r\nApplied a CSS fix using `word-break: break-all` to the URL field inside `NotePropertiesDialog.tsx`.\r\n\r\nThis ensures that very long URLs wrap within the available space and the dialog layout stays intact.\r\n\r\n---\r\n\r\n### ๐Ÿงช How I Tested\r\n\r\n- Added a long URL to a note's source_url (300+ characters)\r\n- Opened the Note Properties dialog on the Desktop app\r\n- Verified:\r\n - Dialog no longer breaks\r\n - URL is readable and wraps as expected\r\n - Dialog behaves normally for all other properties\r\n\r\n---\r\n\r\n### ๐Ÿ“ธ Screenshot (After Fix)\r\n\r\n![screenshot]()\r\n![image](https://github.com/user-attachments/assets/80594a44-f49a-4b8b-8d6f-2b551ae2d85c)\r\n\r\n\r\n---\r\n\r\n### ๐Ÿงฉ Files Updated\r\n\r\n- `packages/app-desktop/gui/NotePropertiesDialog.tsx`\r\n\r\n---\r\n\r\nThis is a small, focused UI bug fix for the Desktop app and does not affect backend logic or mobile functionality.\r\n", "closed_by": { "login": "SAYAN02-DEV", "id": 212765994, "node_id": "U_kgDODK6NKg", "avatar_url": "https://avatars.githubusercontent.com/u/212765994?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SAYAN02-DEV", "html_url": "https://github.com/SAYAN02-DEV", "followers_url": "https://api.github.com/users/SAYAN02-DEV/followers", "following_url": "https://api.github.com/users/SAYAN02-DEV/following{/other_user}", "gists_url": "https://api.github.com/users/SAYAN02-DEV/gists{/gist_id}", "starred_url": "https://api.github.com/users/SAYAN02-DEV/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SAYAN02-DEV/subscriptions", "organizations_url": "https://api.github.com/users/SAYAN02-DEV/orgs", "repos_url": "https://api.github.com/users/SAYAN02-DEV/repos", "events_url": "https://api.github.com/users/SAYAN02-DEV/events{/privacy}", "received_events_url": "https://api.github.com/users/SAYAN02-DEV/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/12666/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12666/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3031248168", "html_url": "https://github.com/laurent22/joplin/pull/12666#issuecomment-3031248168", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12666", "id": 3031248168, "node_id": "IC_kwDOBLftOs60rS0o", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2025-07-03T07:49:59Z", "updated_at": "2025-07-03T18:21:13Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA โœ๏ธ โœ…", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3031248168/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3031257207", "html_url": "https://github.com/laurent22/joplin/pull/12666#issuecomment-3031257207", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12666", "id": 3031257207, "node_id": "IC_kwDOBLftOs60rVB3", "user": { "login": "SAYAN02-DEV", "id": 212765994, "node_id": "U_kgDODK6NKg", "avatar_url": "https://avatars.githubusercontent.com/u/212765994?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SAYAN02-DEV", "html_url": "https://github.com/SAYAN02-DEV", "followers_url": "https://api.github.com/users/SAYAN02-DEV/followers", "following_url": "https://api.github.com/users/SAYAN02-DEV/following{/other_user}", "gists_url": "https://api.github.com/users/SAYAN02-DEV/gists{/gist_id}", "starred_url": "https://api.github.com/users/SAYAN02-DEV/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SAYAN02-DEV/subscriptions", "organizations_url": "https://api.github.com/users/SAYAN02-DEV/orgs", "repos_url": "https://api.github.com/users/SAYAN02-DEV/repos", "events_url": "https://api.github.com/users/SAYAN02-DEV/events{/privacy}", "received_events_url": "https://api.github.com/users/SAYAN02-DEV/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-07-03T07:52:59Z", "updated_at": "2025-07-03T07:52:59Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3031257207/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3031878214", "html_url": "https://github.com/laurent22/joplin/pull/12666#issuecomment-3031878214", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12666", "id": 3031878214, "node_id": "IC_kwDOBLftOs60tspG", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-07-03T11:12:23Z", "updated_at": "2025-07-03T11:12:23Z", "author_association": "OWNER", "body": "URL should not wrap but be cut. Why is the existing CSS not already doing this? `maxWidth: '180px', overflow: 'hidden', whiteSpace: 'nowrap', textOverflow: 'ellipsis`", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3031878214/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3031918610", "html_url": "https://github.com/laurent22/joplin/pull/12666#issuecomment-3031918610", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12666", "id": 3031918610, "node_id": "IC_kwDOBLftOs60t2gS", "user": { "login": "SAYAN02-DEV", "id": 212765994, "node_id": "U_kgDODK6NKg", "avatar_url": "https://avatars.githubusercontent.com/u/212765994?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SAYAN02-DEV", "html_url": "https://github.com/SAYAN02-DEV", "followers_url": "https://api.github.com/users/SAYAN02-DEV/followers", "following_url": "https://api.github.com/users/SAYAN02-DEV/following{/other_user}", "gists_url": "https://api.github.com/users/SAYAN02-DEV/gists{/gist_id}", "starred_url": "https://api.github.com/users/SAYAN02-DEV/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SAYAN02-DEV/subscriptions", "organizations_url": "https://api.github.com/users/SAYAN02-DEV/orgs", "repos_url": "https://api.github.com/users/SAYAN02-DEV/repos", "events_url": "https://api.github.com/users/SAYAN02-DEV/events{/privacy}", "received_events_url": "https://api.github.com/users/SAYAN02-DEV/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-07-03T11:27:26Z", "updated_at": "2025-07-03T11:27:26Z", "author_association": "CONTRIBUTOR", "body": "The existing CSS wasn't taking effect because the element is an inline element so we have to explicitly change their display to 'inline-block'.\r\nI understand that the URL should not wrap, but instead be visually truncated. I've applied display: 'inline-block' to ensure the URL is now properly cut with ellipsis.\r\n\r\nI've updated the PR with this fix โ€” could you please take a look?\r\n![image](https://github.com/user-attachments/assets/1f4d9f43-8e08-4cc3-99b6-93968cbad746)\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3031918610/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }