{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/12038", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/12038/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/12038/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/12038/events", "html_url": "https://github.com/laurent22/joplin/pull/12038", "id": 2960161050, "node_id": "PR_kwDOBLftOs6QwliI", "number": 12038, "title": "Desktop: Fixes #9291: A note scrolls to top if reached by following a link to a section", "user": { "login": "Schmeilen", "id": 114296635, "node_id": "U_kgDOBtAHOw", "avatar_url": "https://avatars.githubusercontent.com/u/114296635?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Schmeilen", "html_url": "https://github.com/Schmeilen", "followers_url": "https://api.github.com/users/Schmeilen/followers", "following_url": "https://api.github.com/users/Schmeilen/following{/other_user}", "gists_url": "https://api.github.com/users/Schmeilen/gists{/gist_id}", "starred_url": "https://api.github.com/users/Schmeilen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Schmeilen/subscriptions", "organizations_url": "https://api.github.com/users/Schmeilen/orgs", "repos_url": "https://api.github.com/users/Schmeilen/repos", "events_url": "https://api.github.com/users/Schmeilen/events{/privacy}", "received_events_url": "https://api.github.com/users/Schmeilen/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2025-03-31T10:54:49Z", "updated_at": "2025-04-02T09:22:47Z", "closed_at": "2025-04-02T09:22:33Z", "author_association": "CONTRIBUTOR", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/12038", "html_url": "https://github.com/laurent22/joplin/pull/12038", "diff_url": "https://github.com/laurent22/joplin/pull/12038.diff", "patch_url": "https://github.com/laurent22/joplin/pull/12038.patch", "merged_at": "2025-04-02T09:22:33Z" }, "body": "# Summary\r\nThis pull request should fix issue #9291 by changing the index.html file in note-viewer. In the code, there was another issue referenced, issue #7617, however, I've ran the test case indicated in the bug report and wasn't able to reproduce it, the behaviour of the application was the same before and after the changes. I've uploaded a video showing the fix so it's easier to detect any unwanted modifications to the application: https://youtu.be/ndEz3OySuTs.\r\n# Testing plan\r\n1. Open the markdown editor with text view next to it\r\n2. Create two notes\r\n3. Write some text to fill more than the length of the monitor\r\n4. Below that text, write a header (or sub-header)\r\n5. Include a reference to the target header in the other note\r\n6. On the note that doesn't include the header, click on the link to it\r\n7. Verify that the markdown editor now scrolls to the correct section and is synchronized with the text view instead of staying at the top of the note, disconnected from it", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/12038/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/12038/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2765869818", "html_url": "https://github.com/laurent22/joplin/pull/12038#issuecomment-2765869818", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12038", "id": 2765869818, "node_id": "IC_kwDOBLftOs6k29L6", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-31T10:55:00Z", "updated_at": "2025-04-02T09:22:46Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2765869818/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2765874538", "html_url": "https://github.com/laurent22/joplin/pull/12038#issuecomment-2765874538", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12038", "id": 2765874538, "node_id": "IC_kwDOBLftOs6k2-Vq", "user": { "login": "Schmeilen", "id": 114296635, "node_id": "U_kgDOBtAHOw", "avatar_url": "https://avatars.githubusercontent.com/u/114296635?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Schmeilen", "html_url": "https://github.com/Schmeilen", "followers_url": "https://api.github.com/users/Schmeilen/followers", "following_url": "https://api.github.com/users/Schmeilen/following{/other_user}", "gists_url": "https://api.github.com/users/Schmeilen/gists{/gist_id}", "starred_url": "https://api.github.com/users/Schmeilen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Schmeilen/subscriptions", "organizations_url": "https://api.github.com/users/Schmeilen/orgs", "repos_url": "https://api.github.com/users/Schmeilen/repos", "events_url": "https://api.github.com/users/Schmeilen/events{/privacy}", "received_events_url": "https://api.github.com/users/Schmeilen/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-03-31T10:57:31Z", "updated_at": "2025-03-31T10:57:31Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2765874538/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2771961410", "html_url": "https://github.com/laurent22/joplin/pull/12038#issuecomment-2771961410", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/12038", "id": 2771961410, "node_id": "IC_kwDOBLftOs6lOMZC", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-04-02T09:22:29Z", "updated_at": "2025-04-02T09:22:29Z", "author_association": "OWNER", "body": "Ok thank you, that seems reasonable.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2771961410/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }