{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/8197", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/8197/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/8197/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/8197/events", "html_url": "https://github.com/laurent22/joplin/pull/8197", "id": 1712756636, "node_id": "PR_kwDOBLftOs5Qp4Gh", "number": 8197, "title": "Update README.md", "user": { "login": "ScriptInfra", "id": 63025323, "node_id": "MDQ6VXNlcjYzMDI1MzIz", "avatar_url": "https://avatars.githubusercontent.com/u/63025323?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ScriptInfra", "html_url": "https://github.com/ScriptInfra", "followers_url": "https://api.github.com/users/ScriptInfra/followers", "following_url": "https://api.github.com/users/ScriptInfra/following{/other_user}", "gists_url": "https://api.github.com/users/ScriptInfra/gists{/gist_id}", "starred_url": "https://api.github.com/users/ScriptInfra/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ScriptInfra/subscriptions", "organizations_url": "https://api.github.com/users/ScriptInfra/orgs", "repos_url": "https://api.github.com/users/ScriptInfra/repos", "events_url": "https://api.github.com/users/ScriptInfra/events{/privacy}", "received_events_url": "https://api.github.com/users/ScriptInfra/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 1091233678, "node_id": "MDU6TGFiZWwxMDkxMjMzNjc4", "url": "https://api.github.com/repos/laurent22/joplin/labels/documentation", "name": "documentation", "color": "fef1bf", "default": true, "description": "Documentation, web site, README" } ], "state": "closed", "locked": true, "assignee": null, "assignees": [], "milestone": null, "comments": 6, "created_at": "2023-05-16T21:25:02Z", "updated_at": "2023-05-18T04:49:23Z", "closed_at": "2023-05-18T04:49:07Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/8197", "html_url": "https://github.com/laurent22/joplin/pull/8197", "diff_url": "https://github.com/laurent22/joplin/pull/8197.diff", "patch_url": "https://github.com/laurent22/joplin/pull/8197.patch", "merged_at": "2023-05-18T04:49:07Z" }, "body": "Request to explicitly define flags that are supported by the Joplin_install_and_update.sh script. I did not realize that there was an option to update to the prerelease version until seeing discord post https://discourse.joplinapp.org/t/joplin-cloud-not-syncing/30844/6. One could always review the contents of the script, however it would be great to be informed of the supported flag options during initial install on Linux.", "closed_by": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/8197/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/8197/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1550373752", "html_url": "https://github.com/laurent22/joplin/pull/8197#issuecomment-1550373752", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8197", "id": 1550373752, "node_id": "IC_kwDOBLftOs5caNN4", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-16T21:25:19Z", "updated_at": "2023-05-18T04:01:41Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1550373752/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1550377517", "html_url": "https://github.com/laurent22/joplin/pull/8197#issuecomment-1550377517", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8197", "id": 1550377517, "node_id": "IC_kwDOBLftOs5caOIt", "user": { "login": "ScriptInfra", "id": 63025323, "node_id": "MDQ6VXNlcjYzMDI1MzIz", "avatar_url": "https://avatars.githubusercontent.com/u/63025323?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ScriptInfra", "html_url": "https://github.com/ScriptInfra", "followers_url": "https://api.github.com/users/ScriptInfra/followers", "following_url": "https://api.github.com/users/ScriptInfra/following{/other_user}", "gists_url": "https://api.github.com/users/ScriptInfra/gists{/gist_id}", "starred_url": "https://api.github.com/users/ScriptInfra/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ScriptInfra/subscriptions", "organizations_url": "https://api.github.com/users/ScriptInfra/orgs", "repos_url": "https://api.github.com/users/ScriptInfra/repos", "events_url": "https://api.github.com/users/ScriptInfra/events{/privacy}", "received_events_url": "https://api.github.com/users/ScriptInfra/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-16T21:28:47Z", "updated_at": "2023-05-16T21:28:47Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1550377517/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1550572356", "html_url": "https://github.com/laurent22/joplin/pull/8197#issuecomment-1550572356", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8197", "id": 1550572356, "node_id": "IC_kwDOBLftOs5ca9tE", "user": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-17T01:51:37Z", "updated_at": "2023-05-17T01:51:37Z", "author_association": "COLLABORATOR", "body": "In theory not a bad change. However, someone who uses the commandline probbably would know to use `-h` or `--help` to get info about the arguments the script can take.\r\n\r\nThe only issue I have with this change is that we'll have to update the docs every time we add another flag. But on the other hand I think that this won't happen too often.\r\n\r\nLaurent, what do you think?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1550572356/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1550585148", "html_url": "https://github.com/laurent22/joplin/pull/8197#issuecomment-1550585148", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8197", "id": 1550585148, "node_id": "IC_kwDOBLftOs5cbA08", "user": { "login": "ScriptInfra", "id": 63025323, "node_id": "MDQ6VXNlcjYzMDI1MzIz", "avatar_url": "https://avatars.githubusercontent.com/u/63025323?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ScriptInfra", "html_url": "https://github.com/ScriptInfra", "followers_url": "https://api.github.com/users/ScriptInfra/followers", "following_url": "https://api.github.com/users/ScriptInfra/following{/other_user}", "gists_url": "https://api.github.com/users/ScriptInfra/gists{/gist_id}", "starred_url": "https://api.github.com/users/ScriptInfra/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ScriptInfra/subscriptions", "organizations_url": "https://api.github.com/users/ScriptInfra/orgs", "repos_url": "https://api.github.com/users/ScriptInfra/repos", "events_url": "https://api.github.com/users/ScriptInfra/events{/privacy}", "received_events_url": "https://api.github.com/users/ScriptInfra/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-17T02:09:19Z", "updated_at": "2023-05-17T02:09:19Z", "author_association": "CONTRIBUTOR", "body": "> In theory not a bad change. However, someone who uses the commandline probbably would know to use `-h` or `--help` to get info about the arguments the script can take.\r\n> \r\n> The only issue I have with this change is that we'll have to update the docs every time we add another flag. But on the other hand I think that this won't happen too often.\r\n> \r\n> Laurent, what do you think?\r\n\r\nAppreciate the feedback!\r\n\r\nI think it's fair to say that everyone using Linux is not necessarily familiar with the command line, and even if they are, may not necessarily be familiar with script flags.\r\n\r\nAdditionally, worst case, even if a flag is added and the cycles are not there to add the flag immediately to the documentation, the end user will at least have visibility to the fact that the flags exist. I think some documentation is better than none (in regards to the flags).\r\n\r\nI think it would be a net positive for the end user. Thanks for the consideration!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1550585148/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1550910247", "html_url": "https://github.com/laurent22/joplin/pull/8197#issuecomment-1550910247", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8197", "id": 1550910247, "node_id": "IC_kwDOBLftOs5ccQMn", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-17T07:44:07Z", "updated_at": "2023-05-17T07:44:07Z", "author_association": "OWNER", "body": "We don't want to add too much info in this part of the doc so that the download links remain more visible. I'd suggest adding a simple message like, \"The install and update script supports the [following flags](https://github.com/laurent22/joplin/blob/215434bb4f9c1033e217e4d5c5a04d077cf9bb18/Joplin_install_and_update.sh#L48)\", and directly link to the script so that we don't have to maintain the doc", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1550910247/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1550922651", "html_url": "https://github.com/laurent22/joplin/pull/8197#issuecomment-1550922651", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8197", "id": 1550922651, "node_id": "IC_kwDOBLftOs5ccTOb", "user": { "login": "ScriptInfra", "id": 63025323, "node_id": "MDQ6VXNlcjYzMDI1MzIz", "avatar_url": "https://avatars.githubusercontent.com/u/63025323?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ScriptInfra", "html_url": "https://github.com/ScriptInfra", "followers_url": "https://api.github.com/users/ScriptInfra/followers", "following_url": "https://api.github.com/users/ScriptInfra/following{/other_user}", "gists_url": "https://api.github.com/users/ScriptInfra/gists{/gist_id}", "starred_url": "https://api.github.com/users/ScriptInfra/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ScriptInfra/subscriptions", "organizations_url": "https://api.github.com/users/ScriptInfra/orgs", "repos_url": "https://api.github.com/users/ScriptInfra/repos", "events_url": "https://api.github.com/users/ScriptInfra/events{/privacy}", "received_events_url": "https://api.github.com/users/ScriptInfra/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-17T07:51:00Z", "updated_at": "2023-05-17T07:51:00Z", "author_association": "CONTRIBUTOR", "body": "Thanks @laurent22. This way at least folks will be made aware of the optional flags. I'll work on adding that simple message.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1550922651/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }