{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14471", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14471/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14471/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14471/events", "html_url": "https://github.com/laurent22/joplin/pull/14471", "id": 3991859127, "node_id": "PR_kwDOBLftOs7GWn7n", "number": 14471, "title": "Desktop: Restore macOS window on app re-activation after close", "user": { "login": "SinhaS12", "id": 203195422, "node_id": "U_kgDODByEHg", "avatar_url": "https://avatars.githubusercontent.com/u/203195422?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SinhaS12", "html_url": "https://github.com/SinhaS12", "followers_url": "https://api.github.com/users/SinhaS12/followers", "following_url": "https://api.github.com/users/SinhaS12/following{/other_user}", "gists_url": "https://api.github.com/users/SinhaS12/gists{/gist_id}", "starred_url": "https://api.github.com/users/SinhaS12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SinhaS12/subscriptions", "organizations_url": "https://api.github.com/users/SinhaS12/orgs", "repos_url": "https://api.github.com/users/SinhaS12/repos", "events_url": "https://api.github.com/users/SinhaS12/events{/privacy}", "received_events_url": "https://api.github.com/users/SinhaS12/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 519700741, "node_id": "MDU6TGFiZWw1MTk3MDA3NDE=", "url": "https://api.github.com/repos/laurent22/joplin/labels/bug", "name": "bug", "color": "cf353b", "default": true, "description": "It's a bug" }, { "id": 1080341216, "node_id": "MDU6TGFiZWwxMDgwMzQxMjE2", "url": "https://api.github.com/repos/laurent22/joplin/labels/desktop", "name": "desktop", "color": "ffc274", "default": false, "description": "All desktop platforms" }, { "id": 1366672588, "node_id": "MDU6TGFiZWwxMzY2NjcyNTg4", "url": "https://api.github.com/repos/laurent22/joplin/labels/macOS", "name": "macOS", "color": "bfd4f2", "default": false, "description": "" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 8, "created_at": "2026-02-25T21:13:57Z", "updated_at": "2026-02-26T04:16:38Z", "closed_at": "2026-02-25T21:23:45Z", "assignee": null, "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14471", "html_url": "https://github.com/laurent22/joplin/pull/14471", "diff_url": "https://github.com/laurent22/joplin/pull/14471.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14471.patch", "merged_at": null }, "body": "## Summary\r\n- Restore legacy macOS close behavior by hiding the app (not just the main window) when the main window is closed without quitting.\r\n- Add a shared main-window restore path and call it from both `activate` and `did-become-active` so Cmd+Tab reliably re-shows the main window.\r\n- Fixes #14169 where Joplin can stay windowless after `Cmd+W` then app switching.\r\n\r\n## Test plan\r\n- [x] On macOS, launch desktop app and confirm main window is visible.\r\n- [x] Press `Cmd+W` to close the main window while keeping app running.\r\n- [x] Switch away with `Cmd+Tab`, then switch back to Joplin with `Cmd+Tab`.\r\n- [x] Confirm the main window is restored and focused.\r\n- [x] Repeat the close/switch cycle 2-3 times to verify consistency.\r\n\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14471/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14471/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3962123503", "html_url": "https://github.com/laurent22/joplin/pull/14471#issuecomment-3962123503", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14471", "id": 3962123503, "node_id": "IC_kwDOBLftOs7sKTTv", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-25T21:14:33Z", "updated_at": "2026-02-25T21:17:40Z", "body": "\n\n\n
\n📝 Walkthrough\n\n## Walkthrough\n\nA refactoring that centralises main window display logic into a new private `showMainWindow_()` helper method, with Darwin-specific handling and window restoration, replacing direct show/focus calls across multiple lifecycle event handlers.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Main Window Display Logic Consolidation**
`packages/app-desktop/ElectronAppWrapper.ts`|Introduces private `showMainWindow_()` helper to centralise window show/restore/focus operations with platform-specific macOS handling. Refactors lifecycle event handlers (window close, app activation, did-become-active) to route window display through this single method instead of direct calls.|\n\n## Suggested labels\n\n`desktop`, `macOS`, `bug`\n\n
\n\n\n\n\n\n\n
\n🚥 Pre-merge checks | ✅ 5\n\n
\n✅ Passed checks (5 passed)\n\n| Check name | Status | Explanation |\n| :------------------------: | :------- | :--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Title check | ✅ Passed | The title accurately summarizes the main change: restoring macOS window on app re-activation after close, which directly addresses the core fix in the changeset. |\n| Description check | ✅ Passed | The description is clearly related to the changeset, explaining the legacy behaviour restoration and new shared restore path, with reference to the linked issue. |\n| Linked Issues check | ✅ Passed | The changes directly address issue `#14169` by introducing the showMainWindow_() helper and calling it from activate and did-become-active handlers to restore window visibility on app re-activation. |\n| Out of Scope Changes check | ✅ Passed | All changes in ElectronAppWrapper.ts are scoped to the main window restoration logic, with no unrelated modifications to other functionality. |\n| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing Touches\n\n
\n🧪 Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n- [ ] Post copyable unit tests in a comment\n\n
\n\n
\n\n\n\n\n\n> [!TIP]\n> Try [Coding Plans](https://www.coderabbit.ai/issue-planner). Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).\n> Share your feedback on [Discord](https://discord.com/invite/coderabbit).\n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14471)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n
\n❤️ Share\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n
\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3962123503/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3962173285", "html_url": "https://github.com/laurent22/joplin/pull/14471#issuecomment-3962173285", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14471", "id": 3962173285, "node_id": "IC_kwDOBLftOs7sKfdl", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-25T21:23:45Z", "updated_at": "2026-02-25T21:23:45Z", "body": "Thanks for the contribution. We’re closing this PR because it does not follow the project’s contribution policy: it is not based on a triaged, accepted issue and does not address a concrete problem agreed upon by maintainers.\r\n\r\nWhile the change itself is not necessarily incorrect, reviewing and maintaining such PRs takes time away from higher-priority work.\r\n\r\nPlease see our [Contribution Scope Policy](https://joplinapp.org/help/dev/#contribution-scope) for details on what kinds of contributions we accept.\r\n\r\nPlease make sure you read our guidelines: https://github.com/joplin/gsoc\r\n\r\nAnd our AI policy: https://github.com/joplin/gsoc/blob/master/ai_policy.md\r\n", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3962173285/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3962220117", "html_url": "https://github.com/laurent22/joplin/pull/14471#issuecomment-3962220117", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14471", "id": 3962220117, "node_id": "IC_kwDOBLftOs7sKq5V", "user": { "login": "SinhaS12", "id": 203195422, "node_id": "U_kgDODByEHg", "avatar_url": "https://avatars.githubusercontent.com/u/203195422?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SinhaS12", "html_url": "https://github.com/SinhaS12", "followers_url": "https://api.github.com/users/SinhaS12/followers", "following_url": "https://api.github.com/users/SinhaS12/following{/other_user}", "gists_url": "https://api.github.com/users/SinhaS12/gists{/gist_id}", "starred_url": "https://api.github.com/users/SinhaS12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SinhaS12/subscriptions", "organizations_url": "https://api.github.com/users/SinhaS12/orgs", "repos_url": "https://api.github.com/users/SinhaS12/repos", "events_url": "https://api.github.com/users/SinhaS12/events{/privacy}", "received_events_url": "https://api.github.com/users/SinhaS12/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-25T21:31:36Z", "updated_at": "2026-02-25T21:31:36Z", "body": "Thank you for the clarification, and I understand the PR closure.\r\n\r\nI’m sorry for the process miss — I’ll follow the contribution scope and AI policy more carefully going forward.\r\n\r\nCould you please guide me on how to identify issues that are explicitly accepted for contribution before I start coding? \r\nFor example, should I only work on issues with specific labels (such as high/medium/enhancement or good first issue), and confirm in a comment first before opening a PR?\r\n\r\nI spent a few hours on this one and want to avoid repeating the same mistake. \r\nI’d really appreciate a quick pointer to the right workflow so I can contribute in a way that is useful for maintainers.\r\n\r\nThank you.", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3962220117/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3962246916", "html_url": "https://github.com/laurent22/joplin/pull/14471#issuecomment-3962246916", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14471", "id": 3962246916, "node_id": "IC_kwDOBLftOs7sKxcE", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-25T21:37:15Z", "updated_at": "2026-02-25T22:01:40Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3962246916/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3962260952", "html_url": "https://github.com/laurent22/joplin/pull/14471#issuecomment-3962260952", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14471", "id": 3962260952, "node_id": "IC_kwDOBLftOs7sK03Y", "user": { "login": "SinhaS12", "id": 203195422, "node_id": "U_kgDODByEHg", "avatar_url": "https://avatars.githubusercontent.com/u/203195422?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SinhaS12", "html_url": "https://github.com/SinhaS12", "followers_url": "https://api.github.com/users/SinhaS12/followers", "following_url": "https://api.github.com/users/SinhaS12/following{/other_user}", "gists_url": "https://api.github.com/users/SinhaS12/gists{/gist_id}", "starred_url": "https://api.github.com/users/SinhaS12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SinhaS12/subscriptions", "organizations_url": "https://api.github.com/users/SinhaS12/orgs", "repos_url": "https://api.github.com/users/SinhaS12/repos", "events_url": "https://api.github.com/users/SinhaS12/events{/privacy}", "received_events_url": "https://api.github.com/users/SinhaS12/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-25T21:40:29Z", "updated_at": "2026-02-25T21:40:29Z", "body": "I have read the CLA Document and I hereby sign the CLA\r\n", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3962260952/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3962261391", "html_url": "https://github.com/laurent22/joplin/pull/14471#issuecomment-3962261391", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14471", "id": 3962261391, "node_id": "IC_kwDOBLftOs7sK0-P", "user": { "login": "SinhaS12", "id": 203195422, "node_id": "U_kgDODByEHg", "avatar_url": "https://avatars.githubusercontent.com/u/203195422?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SinhaS12", "html_url": "https://github.com/SinhaS12", "followers_url": "https://api.github.com/users/SinhaS12/followers", "following_url": "https://api.github.com/users/SinhaS12/following{/other_user}", "gists_url": "https://api.github.com/users/SinhaS12/gists{/gist_id}", "starred_url": "https://api.github.com/users/SinhaS12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SinhaS12/subscriptions", "organizations_url": "https://api.github.com/users/SinhaS12/orgs", "repos_url": "https://api.github.com/users/SinhaS12/repos", "events_url": "https://api.github.com/users/SinhaS12/events{/privacy}", "received_events_url": "https://api.github.com/users/SinhaS12/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-25T21:40:35Z", "updated_at": "2026-02-25T21:40:35Z", "body": "recheck", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3962261391/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3962567964", "html_url": "https://github.com/laurent22/joplin/pull/14471#issuecomment-3962567964", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14471", "id": 3962567964, "node_id": "IC_kwDOBLftOs7sL_0c", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-25T22:40:18Z", "updated_at": "2026-02-25T22:40:18Z", "body": "> Could you please guide me on how to identify issues that are explicitly accepted for contribution before I start coding? For example, should I only work on issues with specific labels (such as high/medium/enhancement or good first issue), and confirm in a comment first before opening a PR?\r\n\r\nThis is all in the guidelines we publish - it's important to read them and it should only take you a few minutes to read the essential", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3962567964/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3963864068", "html_url": "https://github.com/laurent22/joplin/pull/14471#issuecomment-3963864068", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14471", "id": 3963864068, "node_id": "IC_kwDOBLftOs7sQ8QE", "user": { "login": "SinhaS12", "id": 203195422, "node_id": "U_kgDODByEHg", "avatar_url": "https://avatars.githubusercontent.com/u/203195422?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SinhaS12", "html_url": "https://github.com/SinhaS12", "followers_url": "https://api.github.com/users/SinhaS12/followers", "following_url": "https://api.github.com/users/SinhaS12/following{/other_user}", "gists_url": "https://api.github.com/users/SinhaS12/gists{/gist_id}", "starred_url": "https://api.github.com/users/SinhaS12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SinhaS12/subscriptions", "organizations_url": "https://api.github.com/users/SinhaS12/orgs", "repos_url": "https://api.github.com/users/SinhaS12/repos", "events_url": "https://api.github.com/users/SinhaS12/events{/privacy}", "received_events_url": "https://api.github.com/users/SinhaS12/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-26T04:16:38Z", "updated_at": "2026-02-26T04:16:38Z", "body": "Understood — thank you for the reminder.\r\nI’ve now read the essential guidelines and AI policy, and I’ll make sure future contributions are based on triaged/accepted issues and aligned with your process before I start coding.\r\nAppreciate your time.", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3963864068/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }