{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7729", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/7729/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/7729/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/7729/events", "html_url": "https://github.com/laurent22/joplin/pull/7729", "id": 1571524739, "node_id": "PR_kwDOBLftOs5JSRBc", "number": 7729, "title": "All: Fixes #6956: set updated_time when a note's custom sort order is updated, so it syncs ", "user": { "login": "TaoK", "id": 531704, "node_id": "MDQ6VXNlcjUzMTcwNA==", "avatar_url": "https://avatars.githubusercontent.com/u/531704?v=4", "gravatar_id": "", "url": "https://api.github.com/users/TaoK", "html_url": "https://github.com/TaoK", "followers_url": "https://api.github.com/users/TaoK/followers", "following_url": "https://api.github.com/users/TaoK/following{/other_user}", "gists_url": "https://api.github.com/users/TaoK/gists{/gist_id}", "starred_url": "https://api.github.com/users/TaoK/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/TaoK/subscriptions", "organizations_url": "https://api.github.com/users/TaoK/orgs", "repos_url": "https://api.github.com/users/TaoK/repos", "events_url": "https://api.github.com/users/TaoK/events{/privacy}", "received_events_url": "https://api.github.com/users/TaoK/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": true, "assignee": null, "assignees": [], "milestone": null, "comments": 7, "created_at": "2023-02-05T17:05:38Z", "updated_at": "2023-02-13T16:42:11Z", "closed_at": "2023-02-13T16:41:56Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/7729", "html_url": "https://github.com/laurent22/joplin/pull/7729", "diff_url": "https://github.com/laurent22/joplin/pull/7729.diff", "patch_url": "https://github.com/laurent22/joplin/pull/7729.patch", "merged_at": "2023-02-13T16:41:56Z" }, "body": "As detailed in issue #6956, when you reorder notes according to a custom sort, and don't make any further updates to those notes, the sort order does not propagate to other synchronized clients.\r\n\r\nThis commit fixes this, by ensuring the update_time, used for synchronization,\r\n*is* updated even though the update is made with \"autoTimestamp: false\".\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7729/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/7729/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1418163776", "html_url": "https://github.com/laurent22/joplin/pull/7729#issuecomment-1418163776", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7729", "id": 1418163776, "node_id": "IC_kwDOBLftOs5Uh3ZA", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-05T17:05:54Z", "updated_at": "2023-02-10T08:34:19Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1418163776/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1418164148", "html_url": "https://github.com/laurent22/joplin/pull/7729#issuecomment-1418164148", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7729", "id": 1418164148, "node_id": "IC_kwDOBLftOs5Uh3e0", "user": { "login": "TaoK", "id": 531704, "node_id": "MDQ6VXNlcjUzMTcwNA==", "avatar_url": "https://avatars.githubusercontent.com/u/531704?v=4", "gravatar_id": "", "url": "https://api.github.com/users/TaoK", "html_url": "https://github.com/TaoK", "followers_url": "https://api.github.com/users/TaoK/followers", "following_url": "https://api.github.com/users/TaoK/following{/other_user}", "gists_url": "https://api.github.com/users/TaoK/gists{/gist_id}", "starred_url": "https://api.github.com/users/TaoK/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/TaoK/subscriptions", "organizations_url": "https://api.github.com/users/TaoK/orgs", "repos_url": "https://api.github.com/users/TaoK/repos", "events_url": "https://api.github.com/users/TaoK/events{/privacy}", "received_events_url": "https://api.github.com/users/TaoK/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-05T17:06:14Z", "updated_at": "2023-02-05T17:06:14Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1418164148/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1418203746", "html_url": "https://github.com/laurent22/joplin/pull/7729#issuecomment-1418203746", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7729", "id": 1418203746, "node_id": "IC_kwDOBLftOs5UiBJi", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-05T18:07:05Z", "updated_at": "2023-02-05T18:07:05Z", "author_association": "OWNER", "body": "updated_time is already updated in the save() call", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1418203746/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1420608850", "html_url": "https://github.com/laurent22/joplin/pull/7729#issuecomment-1420608850", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7729", "id": 1420608850, "node_id": "IC_kwDOBLftOs5UrMVS", "user": { "login": "TaoK", "id": 531704, "node_id": "MDQ6VXNlcjUzMTcwNA==", "avatar_url": "https://avatars.githubusercontent.com/u/531704?v=4", "gravatar_id": "", "url": "https://api.github.com/users/TaoK", "html_url": "https://github.com/TaoK", "followers_url": "https://api.github.com/users/TaoK/followers", "following_url": "https://api.github.com/users/TaoK/following{/other_user}", "gists_url": "https://api.github.com/users/TaoK/gists{/gist_id}", "starred_url": "https://api.github.com/users/TaoK/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/TaoK/subscriptions", "organizations_url": "https://api.github.com/users/TaoK/orgs", "repos_url": "https://api.github.com/users/TaoK/repos", "events_url": "https://api.github.com/users/TaoK/events{/privacy}", "received_events_url": "https://api.github.com/users/TaoK/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-07T11:17:28Z", "updated_at": "2023-02-07T11:17:28Z", "author_association": "CONTRIBUTOR", "body": "(moving comment to the pull request - I had previously put it in the issue)\r\n\r\nIn defense of this \"set updated_time\" change, a search for `autoTimestamp` in the codebase yields a reasonably even division between two types of usecases:\r\n\r\n* Places where we are trying to preserve user_updated_time, and we explicitly set updated_time as in this change:\r\n * `NotePropertiesDialog.jsx#closeDialog()`\r\n * `Note.ts#moveToFolder()`\r\n * `RevisionService.test.ts#'should preserve user update time'`\r\n * `notes.ts#POST`\r\n * `ShareService.ts#shareNote()`\r\n* Places where we are performing import-related activities, and explicitly want to preserve both `user_updated_time`, **and** `updated_time`\r\n\r\nSo it looks like not setting `updated_time` in `Note.ts#updateNoteOrder_()` was a simple oversight, and this change is a simple bugfix.\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1420608850/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1422696413", "html_url": "https://github.com/laurent22/joplin/pull/7729#issuecomment-1422696413", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7729", "id": 1422696413, "node_id": "IC_kwDOBLftOs5UzJ_d", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-08T14:35:53Z", "updated_at": "2023-02-08T14:35:53Z", "author_association": "OWNER", "body": "That looks like the right fix, thank you for looking into it. Could you add a test for it please?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1422696413/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1425415040", "html_url": "https://github.com/laurent22/joplin/pull/7729#issuecomment-1425415040", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7729", "id": 1425415040, "node_id": "IC_kwDOBLftOs5U9huA", "user": { "login": "TaoK", "id": 531704, "node_id": "MDQ6VXNlcjUzMTcwNA==", "avatar_url": "https://avatars.githubusercontent.com/u/531704?v=4", "gravatar_id": "", "url": "https://api.github.com/users/TaoK", "html_url": "https://github.com/TaoK", "followers_url": "https://api.github.com/users/TaoK/followers", "following_url": "https://api.github.com/users/TaoK/following{/other_user}", "gists_url": "https://api.github.com/users/TaoK/gists{/gist_id}", "starred_url": "https://api.github.com/users/TaoK/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/TaoK/subscriptions", "organizations_url": "https://api.github.com/users/TaoK/orgs", "repos_url": "https://api.github.com/users/TaoK/repos", "events_url": "https://api.github.com/users/TaoK/events{/privacy}", "received_events_url": "https://api.github.com/users/TaoK/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-10T08:34:59Z", "updated_at": "2023-02-10T08:34:59Z", "author_association": "CONTRIBUTOR", "body": "@laurent22 test added, thx!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1425415040/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1428265579", "html_url": "https://github.com/laurent22/joplin/pull/7729#issuecomment-1428265579", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7729", "id": 1428265579, "node_id": "IC_kwDOBLftOs5VIZpr", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-13T16:41:36Z", "updated_at": "2023-02-13T16:41:36Z", "author_association": "OWNER", "body": "Thanks for the fix @TaoK!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1428265579/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }