{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/13429", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/13429/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/13429/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/13429/events", "html_url": "https://github.com/laurent22/joplin/pull/13429", "id": 3506799139, "node_id": "PR_kwDOBLftOs6tStt_", "number": 13429, "title": "Fix: Prevent ResizableLayout crash when all children are invisible", "user": { "login": "WhiskerLogic", "id": 119903759, "node_id": "U_kgDOByWWDw", "avatar_url": "https://avatars.githubusercontent.com/u/119903759?v=4", "gravatar_id": "", "url": "https://api.github.com/users/WhiskerLogic", "html_url": "https://github.com/WhiskerLogic", "followers_url": "https://api.github.com/users/WhiskerLogic/followers", "following_url": "https://api.github.com/users/WhiskerLogic/following{/other_user}", "gists_url": "https://api.github.com/users/WhiskerLogic/gists{/gist_id}", "starred_url": "https://api.github.com/users/WhiskerLogic/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/WhiskerLogic/subscriptions", "organizations_url": "https://api.github.com/users/WhiskerLogic/orgs", "repos_url": "https://api.github.com/users/WhiskerLogic/repos", "events_url": "https://api.github.com/users/WhiskerLogic/events{/privacy}", "received_events_url": "https://api.github.com/users/WhiskerLogic/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2025-10-12T07:57:11Z", "updated_at": "2025-11-03T21:17:26Z", "closed_at": "2025-10-28T10:35:40Z", "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/13429", "html_url": "https://github.com/laurent22/joplin/pull/13429", "diff_url": "https://github.com/laurent22/joplin/pull/13429.diff", "patch_url": "https://github.com/laurent22/joplin/pull/13429.patch", "merged_at": null }, "body": "## Problem\r\nThe desktop app crashes with \"Cannot read properties of undefined (reading 'key')\" when ResizableLayout tries to process containers where all children have `visible: false`.\r\n\r\n## Root Cause\r\nIn `calculateChildrenSizes()`, the code assumed `item.children[0]` exists when selecting the widest/tallest child to resize, but didn't check if there were any visible children first.\r\n\r\n## Solution\r\n- Added null checks to find the first visible child before using it\r\n- Break out of resize loop if no visible children exist \r\n- Handle the case where `visible` property is undefined (treat as visible)\r\n\r\n## Testing\r\n- Added comprehensive tests to prevent regression\r\n- All existing tests continue to pass\r\n\r\nFixes #13396", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/13429/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/13429/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3394048987", "html_url": "https://github.com/laurent22/joplin/pull/13429#issuecomment-3394048987", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13429", "id": 3394048987, "node_id": "IC_kwDOBLftOs7KTRPb", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2025-10-12T07:57:22Z", "updated_at": "2025-10-28T11:17:23Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3394048987/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-11-12T15:38:39Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3394057588", "html_url": "https://github.com/laurent22/joplin/pull/13429#issuecomment-3394057588", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13429", "id": 3394057588, "node_id": "IC_kwDOBLftOs7KTTV0", "user": { "login": "WhiskerLogic", "id": 119903759, "node_id": "U_kgDOByWWDw", "avatar_url": "https://avatars.githubusercontent.com/u/119903759?v=4", "gravatar_id": "", "url": "https://api.github.com/users/WhiskerLogic", "html_url": "https://github.com/WhiskerLogic", "followers_url": "https://api.github.com/users/WhiskerLogic/followers", "following_url": "https://api.github.com/users/WhiskerLogic/following{/other_user}", "gists_url": "https://api.github.com/users/WhiskerLogic/gists{/gist_id}", "starred_url": "https://api.github.com/users/WhiskerLogic/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/WhiskerLogic/subscriptions", "organizations_url": "https://api.github.com/users/WhiskerLogic/orgs", "repos_url": "https://api.github.com/users/WhiskerLogic/repos", "events_url": "https://api.github.com/users/WhiskerLogic/events{/privacy}", "received_events_url": "https://api.github.com/users/WhiskerLogic/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-10-12T08:10:38Z", "updated_at": "2025-10-12T08:10:38Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3394057588/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3410349004", "html_url": "https://github.com/laurent22/joplin/pull/13429#issuecomment-3410349004", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13429", "id": 3410349004, "node_id": "IC_kwDOBLftOs7LRcvM", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-10-16T11:09:42Z", "updated_at": "2025-10-16T11:09:42Z", "body": "This change would prevent the crash, but in which state would the application be afterwards? It seems it won't display any panel at all?", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3410349004/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3482642511", "html_url": "https://github.com/laurent22/joplin/pull/13429#issuecomment-3482642511", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13429", "id": 3482642511, "node_id": "IC_kwDOBLftOs7PlOhP", "user": { "login": "WhiskerLogic", "id": 119903759, "node_id": "U_kgDOByWWDw", "avatar_url": "https://avatars.githubusercontent.com/u/119903759?v=4", "gravatar_id": "", "url": "https://api.github.com/users/WhiskerLogic", "html_url": "https://github.com/WhiskerLogic", "followers_url": "https://api.github.com/users/WhiskerLogic/followers", "following_url": "https://api.github.com/users/WhiskerLogic/following{/other_user}", "gists_url": "https://api.github.com/users/WhiskerLogic/gists{/gist_id}", "starred_url": "https://api.github.com/users/WhiskerLogic/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/WhiskerLogic/subscriptions", "organizations_url": "https://api.github.com/users/WhiskerLogic/orgs", "repos_url": "https://api.github.com/users/WhiskerLogic/repos", "events_url": "https://api.github.com/users/WhiskerLogic/events{/privacy}", "received_events_url": "https://api.github.com/users/WhiskerLogic/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-11-03T21:17:26Z", "updated_at": "2025-11-03T21:17:26Z", "body": "> This change would prevent the crash, but in which state would the application be afterwards? It seems it won't display any panel at all?\r\n\r\nYes, correct. I was only addressing the uncaught runtime error with a few lines of code.\r\nSorry for the huge delay here, I have my notifications fixed now.", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3482642511/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }