{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7709", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/7709/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/7709/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/7709/events", "html_url": "https://github.com/laurent22/joplin/pull/7709", "id": 1566491917, "node_id": "PR_kwDOBLftOs5JBzTl", "number": 7709, "title": "Desktop: Resolves #7662: Fixed ctrl-x behaviour when no text is selected", "user": { "login": "abhiippili", "id": 89311258, "node_id": "MDQ6VXNlcjg5MzExMjU4", "avatar_url": "https://avatars.githubusercontent.com/u/89311258?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhiippili", "html_url": "https://github.com/abhiippili", "followers_url": "https://api.github.com/users/abhiippili/followers", "following_url": "https://api.github.com/users/abhiippili/following{/other_user}", "gists_url": "https://api.github.com/users/abhiippili/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhiippili/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhiippili/subscriptions", "organizations_url": "https://api.github.com/users/abhiippili/orgs", "repos_url": "https://api.github.com/users/abhiippili/repos", "events_url": "https://api.github.com/users/abhiippili/events{/privacy}", "received_events_url": "https://api.github.com/users/abhiippili/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 1080341216, "node_id": "MDU6TGFiZWwxMDgwMzQxMjE2", "url": "https://api.github.com/repos/laurent22/joplin/labels/desktop", "name": "desktop", "color": "ffc274", "default": false, "description": "All desktop platforms" }, { "id": 1366672371, "node_id": "MDU6TGFiZWwxMzY2NjcyMzcx", "url": "https://api.github.com/repos/laurent22/joplin/labels/editor", "name": "editor", "color": "91ca55", "default": false, "description": "" } ], "state": "closed", "locked": true, "assignee": null, "assignees": [], "milestone": null, "comments": 9, "created_at": "2023-02-01T17:11:09Z", "updated_at": "2023-02-09T23:14:02Z", "closed_at": "2023-02-09T23:13:48Z", "author_association": "NONE", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/7709", "html_url": "https://github.com/laurent22/joplin/pull/7709", "diff_url": "https://github.com/laurent22/joplin/pull/7709.diff", "patch_url": "https://github.com/laurent22/joplin/pull/7709.patch", "merged_at": null }, "body": "Should fix the behaviour of ctrl + x when the cursor is placed at a line and no text is selected.\r\nThis would change the clipboard with the content of the line and also removes the line, essentially doing a cut operation like it would be on vscode. ", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7709/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/7709/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1412416399", "html_url": "https://github.com/laurent22/joplin/pull/7709#issuecomment-1412416399", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7709", "id": 1412416399, "node_id": "IC_kwDOBLftOs5UL8OP", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-01T17:11:28Z", "updated_at": "2023-02-03T15:48:07Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1412416399/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1412417388", "html_url": "https://github.com/laurent22/joplin/pull/7709#issuecomment-1412417388", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7709", "id": 1412417388, "node_id": "IC_kwDOBLftOs5UL8ds", "user": { "login": "abhiippili", "id": 89311258, "node_id": "MDQ6VXNlcjg5MzExMjU4", "avatar_url": "https://avatars.githubusercontent.com/u/89311258?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhiippili", "html_url": "https://github.com/abhiippili", "followers_url": "https://api.github.com/users/abhiippili/followers", "following_url": "https://api.github.com/users/abhiippili/following{/other_user}", "gists_url": "https://api.github.com/users/abhiippili/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhiippili/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhiippili/subscriptions", "organizations_url": "https://api.github.com/users/abhiippili/orgs", "repos_url": "https://api.github.com/users/abhiippili/repos", "events_url": "https://api.github.com/users/abhiippili/events{/privacy}", "received_events_url": "https://api.github.com/users/abhiippili/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-01T17:12:03Z", "updated_at": "2023-02-01T17:12:03Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1412417388/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1416081340", "html_url": "https://github.com/laurent22/joplin/pull/7709#issuecomment-1416081340", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7709", "id": 1416081340, "node_id": "IC_kwDOBLftOs5UZ6-8", "user": { "login": "abhiippili", "id": 89311258, "node_id": "MDQ6VXNlcjg5MzExMjU4", "avatar_url": "https://avatars.githubusercontent.com/u/89311258?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhiippili", "html_url": "https://github.com/abhiippili", "followers_url": "https://api.github.com/users/abhiippili/followers", "following_url": "https://api.github.com/users/abhiippili/following{/other_user}", "gists_url": "https://api.github.com/users/abhiippili/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhiippili/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhiippili/subscriptions", "organizations_url": "https://api.github.com/users/abhiippili/orgs", "repos_url": "https://api.github.com/users/abhiippili/repos", "events_url": "https://api.github.com/users/abhiippili/events{/privacy}", "received_events_url": "https://api.github.com/users/abhiippili/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-03T16:09:04Z", "updated_at": "2023-02-03T16:09:04Z", "author_association": "NONE", "body": "Can this PR be merged ?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1416081340/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1416101583", "html_url": "https://github.com/laurent22/joplin/pull/7709#issuecomment-1416101583", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7709", "id": 1416101583, "node_id": "IC_kwDOBLftOs5UZ_7P", "user": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-03T16:24:57Z", "updated_at": "2023-02-03T16:24:57Z", "author_association": "COLLABORATOR", "body": "Laurent merges PRs, so whenever he's got the time and deems this PR for ok, he'll do it. \r\n\r\nI am only supposed to merge PRs for translation and documentation. (And I think I am allowed to merge PRs for the install bash script.)", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1416101583/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1416151862", "html_url": "https://github.com/laurent22/joplin/pull/7709#issuecomment-1416151862", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7709", "id": 1416151862, "node_id": "IC_kwDOBLftOs5UaMM2", "user": { "login": "abhiippili", "id": 89311258, "node_id": "MDQ6VXNlcjg5MzExMjU4", "avatar_url": "https://avatars.githubusercontent.com/u/89311258?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhiippili", "html_url": "https://github.com/abhiippili", "followers_url": "https://api.github.com/users/abhiippili/followers", "following_url": "https://api.github.com/users/abhiippili/following{/other_user}", "gists_url": "https://api.github.com/users/abhiippili/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhiippili/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhiippili/subscriptions", "organizations_url": "https://api.github.com/users/abhiippili/orgs", "repos_url": "https://api.github.com/users/abhiippili/repos", "events_url": "https://api.github.com/users/abhiippili/events{/privacy}", "received_events_url": "https://api.github.com/users/abhiippili/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-03T17:03:28Z", "updated_at": "2023-02-03T17:03:28Z", "author_association": "NONE", "body": "Alright. Thanks!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1416151862/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1417609396", "html_url": "https://github.com/laurent22/joplin/pull/7709#issuecomment-1417609396", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7709", "id": 1417609396, "node_id": "IC_kwDOBLftOs5UfwC0", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-05T11:56:35Z", "updated_at": "2023-02-05T11:56:35Z", "author_association": "OWNER", "body": "Doesn't even pass the linter...", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1417609396/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1417667876", "html_url": "https://github.com/laurent22/joplin/pull/7709#issuecomment-1417667876", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7709", "id": 1417667876, "node_id": "IC_kwDOBLftOs5Uf-Uk", "user": { "login": "abhiippili", "id": 89311258, "node_id": "MDQ6VXNlcjg5MzExMjU4", "avatar_url": "https://avatars.githubusercontent.com/u/89311258?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhiippili", "html_url": "https://github.com/abhiippili", "followers_url": "https://api.github.com/users/abhiippili/followers", "following_url": "https://api.github.com/users/abhiippili/following{/other_user}", "gists_url": "https://api.github.com/users/abhiippili/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhiippili/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhiippili/subscriptions", "organizations_url": "https://api.github.com/users/abhiippili/orgs", "repos_url": "https://api.github.com/users/abhiippili/repos", "events_url": "https://api.github.com/users/abhiippili/events{/privacy}", "received_events_url": "https://api.github.com/users/abhiippili/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-05T12:18:03Z", "updated_at": "2023-02-05T12:18:03Z", "author_association": "NONE", "body": "Sorry about that. This is one of my first contributions. I'll try to fix where I went wrong", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1417667876/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1417684639", "html_url": "https://github.com/laurent22/joplin/pull/7709#issuecomment-1417684639", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7709", "id": 1417684639, "node_id": "IC_kwDOBLftOs5UgCaf", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-05T12:24:13Z", "updated_at": "2023-02-05T12:24:13Z", "author_association": "OWNER", "body": "It's on coding_style.md. But also that commit hook should run automatically. Is it not running for you? If there's any error or warning when committing please let us know, as we need this to be working. The point of a linter is that we don't need to deal with things like missing spaces or commas.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1417684639/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1422667950", "html_url": "https://github.com/laurent22/joplin/pull/7709#issuecomment-1422667950", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7709", "id": 1422667950, "node_id": "IC_kwDOBLftOs5UzDCu", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-08T14:16:40Z", "updated_at": "2023-02-08T14:16:40Z", "author_association": "OWNER", "body": "@abhiippili, are you still interested in implementing this or should we close the PR?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1422667950/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }