{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7824", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/7824/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/7824/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/7824/events", "html_url": "https://github.com/laurent22/joplin/pull/7824", "id": 1594855381, "node_id": "PR_kwDOBLftOs5KgEFd", "number": 7824, "title": "Desktop: Resolves #7767: Created a splash screen for when the application starts", "user": { "login": "adidevs", "id": 99022811, "node_id": "U_kgDOBeb32w", "avatar_url": "https://avatars.githubusercontent.com/u/99022811?v=4", "gravatar_id": "", "url": "https://api.github.com/users/adidevs", "html_url": "https://github.com/adidevs", "followers_url": "https://api.github.com/users/adidevs/followers", "following_url": "https://api.github.com/users/adidevs/following{/other_user}", "gists_url": "https://api.github.com/users/adidevs/gists{/gist_id}", "starred_url": "https://api.github.com/users/adidevs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/adidevs/subscriptions", "organizations_url": "https://api.github.com/users/adidevs/orgs", "repos_url": "https://api.github.com/users/adidevs/repos", "events_url": "https://api.github.com/users/adidevs/events{/privacy}", "received_events_url": "https://api.github.com/users/adidevs/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": true, "assignee": null, "assignees": [], "milestone": null, "comments": 4, "created_at": "2023-02-22T10:31:33Z", "updated_at": "2023-02-22T19:24:57Z", "closed_at": "2023-02-22T19:24:45Z", "author_association": "NONE", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/7824", "html_url": "https://github.com/laurent22/joplin/pull/7824", "diff_url": "https://github.com/laurent22/joplin/pull/7824.diff", "patch_url": "https://github.com/laurent22/joplin/pull/7824.patch", "merged_at": null }, "body": "Resolves #7767 \r\nThis PR creates a splash screen for the Joplin App on Desktop as per the issue #7767 .\r\n\r\nThe splash screen has been implemented by:\r\n\r\n1. Adding required code to the ElectronAppWrapper.ts\r\n2. Creating file 'splash.html' in the folder app-desktop, the nomenclature makes it easier to spot.\r\n3. The splash screen is an SVG file containing the Joplin Logo and Brand name and is animated.\r\n\r\nThe splash screen background colour is set to the same colour as the blue on the homepage of Joplin (joplinapp.org)\r\n\r\nhttps://user-images.githubusercontent.com/99022811/220593465-88c49eba-274d-4984-b388-84bec1ce71c9.mp4\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7824/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/7824/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1439783526", "html_url": "https://github.com/laurent22/joplin/pull/7824#issuecomment-1439783526", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7824", "id": 1439783526, "node_id": "IC_kwDOBLftOs5V0Vpm", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-22T10:31:49Z", "updated_at": "2023-02-22T19:08:45Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1439783526/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1439784273", "html_url": "https://github.com/laurent22/joplin/pull/7824#issuecomment-1439784273", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7824", "id": 1439784273, "node_id": "IC_kwDOBLftOs5V0V1R", "user": { "login": "adidevs", "id": 99022811, "node_id": "U_kgDOBeb32w", "avatar_url": "https://avatars.githubusercontent.com/u/99022811?v=4", "gravatar_id": "", "url": "https://api.github.com/users/adidevs", "html_url": "https://github.com/adidevs", "followers_url": "https://api.github.com/users/adidevs/followers", "following_url": "https://api.github.com/users/adidevs/following{/other_user}", "gists_url": "https://api.github.com/users/adidevs/gists{/gist_id}", "starred_url": "https://api.github.com/users/adidevs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/adidevs/subscriptions", "organizations_url": "https://api.github.com/users/adidevs/orgs", "repos_url": "https://api.github.com/users/adidevs/repos", "events_url": "https://api.github.com/users/adidevs/events{/privacy}", "received_events_url": "https://api.github.com/users/adidevs/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-22T10:32:21Z", "updated_at": "2023-02-22T10:32:21Z", "author_association": "NONE", "body": "\r\nI have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1439784273/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1439785639", "html_url": "https://github.com/laurent22/joplin/pull/7824#issuecomment-1439785639", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7824", "id": 1439785639, "node_id": "IC_kwDOBLftOs5V0WKn", "user": { "login": "adidevs", "id": 99022811, "node_id": "U_kgDOBeb32w", "avatar_url": "https://avatars.githubusercontent.com/u/99022811?v=4", "gravatar_id": "", "url": "https://api.github.com/users/adidevs", "html_url": "https://github.com/adidevs", "followers_url": "https://api.github.com/users/adidevs/followers", "following_url": "https://api.github.com/users/adidevs/following{/other_user}", "gists_url": "https://api.github.com/users/adidevs/gists{/gist_id}", "starred_url": "https://api.github.com/users/adidevs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/adidevs/subscriptions", "organizations_url": "https://api.github.com/users/adidevs/orgs", "repos_url": "https://api.github.com/users/adidevs/repos", "events_url": "https://api.github.com/users/adidevs/events{/privacy}", "received_events_url": "https://api.github.com/users/adidevs/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-22T10:33:19Z", "updated_at": "2023-02-22T10:33:19Z", "author_association": "NONE", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1439785639/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1440669986", "html_url": "https://github.com/laurent22/joplin/pull/7824#issuecomment-1440669986", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7824", "id": 1440669986, "node_id": "IC_kwDOBLftOs5V3uEi", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-02-22T19:24:45Z", "updated_at": "2023-02-22T19:24:45Z", "author_association": "OWNER", "body": "I'm going to close this, there's too many problems", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1440669986/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }