{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14366", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14366/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14366/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14366/events", "html_url": "https://github.com/laurent22/joplin/pull/14366", "id": 3954250723, "node_id": "PR_kwDOBLftOs7Eb4fR", "number": 14366, "title": "All: Fixes #14352: Only embed YouTube video when URL is standalone", "user": { "login": "adityaparghi", "id": 143249368, "node_id": "U_kgDOCInP2A", "avatar_url": "https://avatars.githubusercontent.com/u/143249368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/adityaparghi", "html_url": "https://github.com/adityaparghi", "followers_url": "https://api.github.com/users/adityaparghi/followers", "following_url": "https://api.github.com/users/adityaparghi/following{/other_user}", "gists_url": "https://api.github.com/users/adityaparghi/gists{/gist_id}", "starred_url": "https://api.github.com/users/adityaparghi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/adityaparghi/subscriptions", "organizations_url": "https://api.github.com/users/adityaparghi/orgs", "repos_url": "https://api.github.com/users/adityaparghi/repos", "events_url": "https://api.github.com/users/adityaparghi/events{/privacy}", "received_events_url": "https://api.github.com/users/adityaparghi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 4, "created_at": "2026-02-17T19:06:51Z", "updated_at": "2026-02-17T21:28:24Z", "closed_at": "2026-02-17T20:46:55Z", "assignee": null, "author_association": "FIRST_TIMER", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14366", "html_url": "https://github.com/laurent22/joplin/pull/14366", "diff_url": "https://github.com/laurent22/joplin/pull/14366.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14366.patch", "merged_at": null }, "body": "Fixes #14352\r\n\r\nEnsured YouTube videos are embedded only when the URL appears on its own line.\r\n\r\nInline URLs are rendered as normal links, while standalone URLs continue to embed correctly.\r\n\n\n\n\n## Summary by CodeRabbit\n\n* **Bug Fixes**\n * YouTube video embedding now only activates for standalone links, improving rendering accuracy.\n\n* **Chores**\n * Updated spell-check dictionary with additional entries.\n\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14366/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14366/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3916595726", "html_url": "https://github.com/laurent22/joplin/pull/14366#issuecomment-3916595726", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14366", "id": 3916595726, "node_id": "IC_kwDOBLftOs7pcoIO", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-17T19:07:06Z", "updated_at": "2026-02-17T21:28:24Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3916595726/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3916597298", "html_url": "https://github.com/laurent22/joplin/pull/14366#issuecomment-3916597298", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14366", "id": 3916597298, "node_id": "IC_kwDOBLftOs7pcogy", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-17T19:07:27Z", "updated_at": "2026-02-17T19:10:56Z", "body": "\n\n\n## Walkthrough\n\nChanges address a feature request to embed YouTube videos only when URLs appear on standalone lines rather than inline. A new helper function detects standalone link tokens and gates embed activation behind this check, preventing inline video embeds whilst preserving existing rendering behaviour for non-standalone links.\n\n## Changes\n\n| Cohort / File(s) | Summary |\n|---|---|\n| **External embed rules**
`packages/renderer/MdToHtml/rules/externalEmbed.ts` | Introduced `isStandaloneLink` function to analyse token sequences and restrict YouTube embed activation to standalone links only. Updated `extractVideoId` return type to `string \\| null` for explicit null handling, and wrapped embed logic within a standalone-link guard. |\n| **Spell-check dictionary**
`packages/tools/cspell/dictionary1.txt` | Added two new dictionary entries: \"hardbreak\" and \"softbreak\". |\n\n## Estimated code review effort\n\n🎯 3 (Moderate) | ⏱️ ~20 minutes\n\n\n\n\n\n\n
\n🚥 Pre-merge checks | ✅ 5\n\n
\n✅ Passed checks (5 passed)\n\n| Check name | Status | Explanation |\n| :------------------------: | :------- | :-------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |\n| Title check | ✅ Passed | The title accurately and concisely summarizes the main change: restricting YouTube video embedding to standalone URLs only. |\n| Linked Issues check | ✅ Passed | The code changes directly address issue `#14352` by implementing the isStandaloneLink check to embed videos only when URLs are standalone, not inline. |\n| Out of Scope Changes check | ✅ Passed | The dictionary file changes (adding 'hardbreak' and 'softbreak') appear to be supporting changes for the externalEmbed functionality and remain in scope. |\n| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing touches\n\n- [ ] 📝 Generate docstrings\n
\n🧪 Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n- [ ] Post copyable unit tests in a comment\n\n
\n\n
\n\n\n\n\n\n> [!TIP]\n> [Issue Planner](https://www.coderabbit.ai/issue-planner) is now in beta. Read the [docs](https://docs.coderabbit.ai/issues/planning) and try it out! Share your feedback on [Discord](https://discord.com/invite/coderabbit).\n\n\n\n\n\n---\n\n\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3916597298/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3916762285", "html_url": "https://github.com/laurent22/joplin/pull/14366#issuecomment-3916762285", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14366", "id": 3916762285, "node_id": "IC_kwDOBLftOs7pdQyt", "user": { "login": "adityaparghi", "id": 143249368, "node_id": "U_kgDOCInP2A", "avatar_url": "https://avatars.githubusercontent.com/u/143249368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/adityaparghi", "html_url": "https://github.com/adityaparghi", "followers_url": "https://api.github.com/users/adityaparghi/followers", "following_url": "https://api.github.com/users/adityaparghi/following{/other_user}", "gists_url": "https://api.github.com/users/adityaparghi/gists{/gist_id}", "starred_url": "https://api.github.com/users/adityaparghi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/adityaparghi/subscriptions", "organizations_url": "https://api.github.com/users/adityaparghi/orgs", "repos_url": "https://api.github.com/users/adityaparghi/repos", "events_url": "https://api.github.com/users/adityaparghi/events{/privacy}", "received_events_url": "https://api.github.com/users/adityaparghi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-17T19:49:33Z", "updated_at": "2026-02-17T19:49:33Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3916762285/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3917009734", "html_url": "https://github.com/laurent22/joplin/pull/14366#issuecomment-3917009734", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14366", "id": 3917009734, "node_id": "IC_kwDOBLftOs7peNNG", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-02-17T20:46:55Z", "updated_at": "2026-02-17T20:46:55Z", "body": "Thank you, but I'd prefer a simpler solution like this one: #14370", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3917009734/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }