{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14598", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/14598/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/14598/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/14598/events", "html_url": "https://github.com/laurent22/joplin/pull/14598", "id": 4033055531, "node_id": "PR_kwDOBLftOs7IcSlL", "number": 14598, "title": "All: Fixes #14540: Prevent duplicate tag creation when Tag.save() is called without id", "user": { "login": "arnavgogia20", "id": 242623817, "node_id": "U_kgDODnYlSQ", "avatar_url": "https://avatars.githubusercontent.com/u/242623817?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arnavgogia20", "html_url": "https://github.com/arnavgogia20", "followers_url": "https://api.github.com/users/arnavgogia20/followers", "following_url": "https://api.github.com/users/arnavgogia20/following{/other_user}", "gists_url": "https://api.github.com/users/arnavgogia20/gists{/gist_id}", "starred_url": "https://api.github.com/users/arnavgogia20/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arnavgogia20/subscriptions", "organizations_url": "https://api.github.com/users/arnavgogia20/orgs", "repos_url": "https://api.github.com/users/arnavgogia20/repos", "events_url": "https://api.github.com/users/arnavgogia20/events{/privacy}", "received_events_url": "https://api.github.com/users/arnavgogia20/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [ { "id": 519700741, "node_id": "MDU6TGFiZWw1MTk3MDA3NDE=", "url": "https://api.github.com/repos/laurent22/joplin/labels/bug", "name": "bug", "color": "cf353b", "default": true, "description": "It's a bug" }, { "id": 1367396396, "node_id": "MDU6TGFiZWwxMzY3Mzk2Mzk2", "url": "https://api.github.com/repos/laurent22/joplin/labels/tags", "name": "tags", "color": "91ca55", "default": false, "description": "tag related issue" } ], "state": "closed", "locked": false, "assignees": [], "milestone": null, "comments": 6, "created_at": "2026-03-06T08:58:47Z", "updated_at": "2026-03-10T11:19:16Z", "closed_at": "2026-03-10T11:04:57Z", "assignee": null, "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/14598", "html_url": "https://github.com/laurent22/joplin/pull/14598", "diff_url": "https://github.com/laurent22/joplin/pull/14598.diff", "patch_url": "https://github.com/laurent22/joplin/pull/14598.patch", "merged_at": null }, "body": "## AI Assistance Disclosure\r\n\r\nThis change was developed with AI assistance for analysis and initial drafting.\r\nAll code has been manually reviewed and fully understood before submission.\r\n\r\n---\r\n\r\nFixes #14540\r\n\r\n## Summary\r\n\r\nWhen `Tag.save()` is called without an `id` (new tag creation), there was no\r\nguard preventing a duplicate row from being inserted if a tag with the same\r\ntitle already existed.\r\n\r\nThis adds an unconditional check in `Tag.save()`: if a new tag (no `id`) has\r\na title matching an existing tag (case-insensitive), the existing tag's `id`\r\nis assigned to the object so the save proceeds as an update rather than an\r\ninsert. This preserves the full `BaseModel.save()` lifecycle (timestamps,\r\ndispatch, sync metadata).\r\n\r\n## Changes\r\n\r\n- `packages/lib/models/Tag.ts`: Added duplicate-prevention guard before `super.save()`\r\n- `packages/lib/models/Tag.test.ts`: Added 2 tests verifying no duplicate creation and intact tag-note association\r\n\r\n## Testing\r\n\r\nAll 12 Tag model tests pass. No existing tests were modified.\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/14598/reactions", "total_count": 1, "+1": 0, "-1": 1, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/14598/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4010450477", "html_url": "https://github.com/laurent22/joplin/pull/14598#issuecomment-4010450477", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14598", "id": 4010450477, "node_id": "IC_kwDOBLftOs7vCp4t", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-06T08:59:00Z", "updated_at": "2026-03-10T11:19:16Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4010450477/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2026-05-05T14:51:38Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "code_quality": "write", "contents": "write", "copilot_requests": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4010452314", "html_url": "https://github.com/laurent22/joplin/pull/14598#issuecomment-4010452314", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14598", "id": 4010452314, "node_id": "IC_kwDOBLftOs7vCqVa", "user": { "login": "coderabbitai[bot]", "id": 136622811, "node_id": "BOT_kgDOCCSy2w", "avatar_url": "https://avatars.githubusercontent.com/in/347564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai%5Bbot%5D", "html_url": "https://github.com/apps/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/followers", "following_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/repos", "events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-06T08:59:18Z", "updated_at": "2026-03-07T19:35:19Z", "body": "\n\n\n
\n📝 Walkthrough\n\n## Walkthrough\n\nThis pull request adds logic to the Tag model to prevent duplicate tag creation by reusing existing tags when a new tag with the same title is saved, complemented by comprehensive test coverage to verify the deduplication behaviour and note association.\n\n## Changes\n\n|Cohort / File(s)|Summary|\n|---|---|\n|**Test Coverage**
`packages/lib/models/Tag.test.ts`|Adds two tests verifying duplicate tag prevention: one confirming that saving a tag with an existing title reuses the original tag, and another validating that note associations remain correct when a tag is reused.|\n|**Deduplication Logic**
`packages/lib/models/Tag.ts`|Implements duplicate prevention in Tag.save by detecting existing tags with matching titles, reusing their IDs to convert creation into an update operation rather than inserting a new row.|\n\n## Suggested labels\n\n`bug`, `tags`\n\n
\n\n\n\n\n\n\n
\n🚥 Pre-merge checks | ✅ 5 | ❌ 1\n\n### ❌ Failed checks (1 warning)\n\n| Check name | Status | Explanation | Resolution |\n| :----------------: | :--------- | :------------------------------------------------------------------------------------ | :--------------------------------------------------------------------------------- |\n| Docstring Coverage | ⚠️ Warning | Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |\n\n
\n✅ Passed checks (5 passed)\n\n| Check name | Status | Explanation |\n| :-----------------------------------: | :------- | :-------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |\n| Title check | ✅ Passed | The title clearly and specifically summarises the main change: preventing duplicate tag creation in Tag.save() when called without an id. |\n| Description check | ✅ Passed | The description is directly related to the changeset, explaining the problem, solution, changes made, and testing performed. |\n| Linked Issues check | ✅ Passed | The pull request addresses issue `#14540` by implementing a duplicate-prevention guard in Tag.save() and adding comprehensive tests, meeting all stated objectives. |\n| Out of Scope Changes check | ✅ Passed | All changes are directly within scope: the duplicate-prevention logic in Tag.ts and supporting tests in Tag.test.ts align with the linked issue requirements. |\n| Pr Description Must Follow Guidelines | ✅ Passed | The pull request description fully satisfies requirements with clear Problem, Solution, and Test Plan sections detailing duplicate tag prevention and verification results. |\n\n
\n\n✏️ Tip: You can configure your own custom pre-merge checks in the settings.\n\n
\n\n\n\n\n\n
\n✨ Finishing Touches\n\n
\n🧪 Generate unit tests (beta)\n\n- [ ] Create PR with unit tests\n- [ ] Post copyable unit tests in a comment\n\n
\n\n
\n\n\n\n\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=laurent22/joplin&utm_content=14598)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n
\n❤️ Share\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n
\n\nComment `@coderabbitai help` to get the list of available commands and usage tips.\n\n\n\n\n\n\n\n\n", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4010452314/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 347564, "client_id": "Iv1.6aaafe4fe882736b", "slug": "coderabbitai", "node_id": "A_kwHOB96YWc4ABU2s", "owner": { "login": "coderabbitai", "id": 132028505, "node_id": "O_kgDOB96YWQ", "avatar_url": "https://avatars.githubusercontent.com/u/132028505?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coderabbitai", "html_url": "https://github.com/coderabbitai", "followers_url": "https://api.github.com/users/coderabbitai/followers", "following_url": "https://api.github.com/users/coderabbitai/following{/other_user}", "gists_url": "https://api.github.com/users/coderabbitai/gists{/gist_id}", "starred_url": "https://api.github.com/users/coderabbitai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coderabbitai/subscriptions", "organizations_url": "https://api.github.com/users/coderabbitai/orgs", "repos_url": "https://api.github.com/users/coderabbitai/repos", "events_url": "https://api.github.com/users/coderabbitai/events{/privacy}", "received_events_url": "https://api.github.com/users/coderabbitai/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "coderabbitai", "description": "# Transforming Code Reviews with AI\r\n\r\n## Features\r\n\r\n**Automated Reviews**: Continuous reviews of the pull requests including incremental commits. \r\n\r\n**Summarization**: Generates high-level summary and a technical walkthrough of the PR changes. \r\n\r\n**Line-by-line review**: Provides line-by-line suggestions committable with one click.\r\n\r\n**Codebase verification**: Verifies the impact on the overall codebase and identifies missing changes.\r\n\r\n**Insights into your code**: Ask any questions on your codebase within the pull request \r\n\r\n**Chat about your code** : Chat with the bot around your code. The more you chat, the smarter it gets.\r\n\r\n**Issue Validation**: Validates the PR against the linked issues and identifies other related issues \r\n\r\n\r\n\r\n", "external_url": "https://coderabbit.ai?utm_source=cr_app&utm_medium=github", "html_url": "https://github.com/apps/coderabbitai", "created_at": "2023-06-14T15:47:27Z", "updated_at": "2026-03-14T07:58:44Z", "permissions": { "actions": "read", "checks": "write", "contents": "write", "discussions": "read", "issues": "write", "members": "read", "metadata": "read", "pull_requests": "write", "statuses": "write" }, "events": [ "issues", "issue_comment", "label", "organization", "pull_request", "pull_request_review", "pull_request_review_comment", "pull_request_review_thread", "release", "repository" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4010491407", "html_url": "https://github.com/laurent22/joplin/pull/14598#issuecomment-4010491407", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14598", "id": 4010491407, "node_id": "IC_kwDOBLftOs7vCz4P", "user": { "login": "arnavgogia20", "id": 242623817, "node_id": "U_kgDODnYlSQ", "avatar_url": "https://avatars.githubusercontent.com/u/242623817?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arnavgogia20", "html_url": "https://github.com/arnavgogia20", "followers_url": "https://api.github.com/users/arnavgogia20/followers", "following_url": "https://api.github.com/users/arnavgogia20/following{/other_user}", "gists_url": "https://api.github.com/users/arnavgogia20/gists{/gist_id}", "starred_url": "https://api.github.com/users/arnavgogia20/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arnavgogia20/subscriptions", "organizations_url": "https://api.github.com/users/arnavgogia20/orgs", "repos_url": "https://api.github.com/users/arnavgogia20/repos", "events_url": "https://api.github.com/users/arnavgogia20/events{/privacy}", "received_events_url": "https://api.github.com/users/arnavgogia20/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-06T09:06:06Z", "updated_at": "2026-03-06T09:06:06Z", "body": "I have read the CLA Document and I hereby sign the CLA\r\n\r\n", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4010491407/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4010494583", "html_url": "https://github.com/laurent22/joplin/pull/14598#issuecomment-4010494583", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14598", "id": 4010494583, "node_id": "IC_kwDOBLftOs7vC0p3", "user": { "login": "arnavgogia20", "id": 242623817, "node_id": "U_kgDODnYlSQ", "avatar_url": "https://avatars.githubusercontent.com/u/242623817?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arnavgogia20", "html_url": "https://github.com/arnavgogia20", "followers_url": "https://api.github.com/users/arnavgogia20/followers", "following_url": "https://api.github.com/users/arnavgogia20/following{/other_user}", "gists_url": "https://api.github.com/users/arnavgogia20/gists{/gist_id}", "starred_url": "https://api.github.com/users/arnavgogia20/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arnavgogia20/subscriptions", "organizations_url": "https://api.github.com/users/arnavgogia20/orgs", "repos_url": "https://api.github.com/users/arnavgogia20/repos", "events_url": "https://api.github.com/users/arnavgogia20/events{/privacy}", "received_events_url": "https://api.github.com/users/arnavgogia20/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-06T09:06:44Z", "updated_at": "2026-03-06T09:06:44Z", "body": "recheck\r\n", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4010494583/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4025835394", "html_url": "https://github.com/laurent22/joplin/pull/14598#issuecomment-4025835394", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14598", "id": 4025835394, "node_id": "IC_kwDOBLftOs7v9V-C", "user": { "login": "arnavgogia20", "id": 242623817, "node_id": "U_kgDODnYlSQ", "avatar_url": "https://avatars.githubusercontent.com/u/242623817?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arnavgogia20", "html_url": "https://github.com/arnavgogia20", "followers_url": "https://api.github.com/users/arnavgogia20/followers", "following_url": "https://api.github.com/users/arnavgogia20/following{/other_user}", "gists_url": "https://api.github.com/users/arnavgogia20/gists{/gist_id}", "starred_url": "https://api.github.com/users/arnavgogia20/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arnavgogia20/subscriptions", "organizations_url": "https://api.github.com/users/arnavgogia20/orgs", "repos_url": "https://api.github.com/users/arnavgogia20/repos", "events_url": "https://api.github.com/users/arnavgogia20/events{/privacy}", "received_events_url": "https://api.github.com/users/arnavgogia20/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-09T18:20:55Z", "updated_at": "2026-03-09T18:20:55Z", "body": "Hii @personalizedrefrigerator , this PR is ready to be re-reviewed by you....thankyouu", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4025835394/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030572725", "html_url": "https://github.com/laurent22/joplin/pull/14598#issuecomment-4030572725", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/14598", "id": 4030572725, "node_id": "IC_kwDOBLftOs7wPai1", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2026-03-10T11:04:57Z", "updated_at": "2026-03-10T11:04:57Z", "body": "Sorry I don't think we should be addressing this for now. There are considerations that relates to sync and I feel it's a risky change for very little benefit. The whole thing should be reviewed in depth if we ever want to address this issue", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/4030572725/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }