{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/6845/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/6845/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/6845/events", "html_url": "https://github.com/laurent22/joplin/pull/6845", "id": 1371644802, "node_id": "PR_kwDOBLftOs4-4Asq", "number": 6845, "title": "PDF Viewer: Annotation Editing", "user": { "login": "asrient", "id": 44570278, "node_id": "MDQ6VXNlcjQ0NTcwMjc4", "avatar_url": "https://avatars.githubusercontent.com/u/44570278?v=4", "gravatar_id": "", "url": "https://api.github.com/users/asrient", "html_url": "https://github.com/asrient", "followers_url": "https://api.github.com/users/asrient/followers", "following_url": "https://api.github.com/users/asrient/following{/other_user}", "gists_url": "https://api.github.com/users/asrient/gists{/gist_id}", "starred_url": "https://api.github.com/users/asrient/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/asrient/subscriptions", "organizations_url": "https://api.github.com/users/asrient/orgs", "repos_url": "https://api.github.com/users/asrient/repos", "events_url": "https://api.github.com/users/asrient/events{/privacy}", "received_events_url": "https://api.github.com/users/asrient/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": true, "assignee": null, "assignees": [], "milestone": null, "comments": 18, "created_at": "2022-09-13T15:32:53Z", "updated_at": "2023-01-05T18:22:13Z", "closed_at": "2023-01-05T18:19:12Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/6845", "html_url": "https://github.com/laurent22/joplin/pull/6845", "diff_url": "https://github.com/laurent22/joplin/pull/6845.diff", "patch_url": "https://github.com/laurent22/joplin/pull/6845.patch", "merged_at": null }, "body": "Introduces a new feature to add and remove text based annotations.\r\n\r\n![Screen Shot 2022-09-13 at 9 02 08 PM](https://user-images.githubusercontent.com/44570278/189943954-241ee83d-5d50-4d12-baf4-960140c46540.png)\r\n\r\n![f0e9596903bed61f1430a5af81d568c092e58897_2_690x441](https://user-images.githubusercontent.com/44570278/189943007-3cc5657f-083c-4a4e-8ba7-61c974245067.jpeg)\r\n\r\nhttps://user-images.githubusercontent.com/44570278/189943146-9b5b8f9f-2a09-4f45-b701-2231915d4850.mov\r\n\r\n![f0e9596903bed61f1430a5af81d568c092e58897_2_690x441](https://user-images.githubusercontent.com/44570278/189943181-6d3fbd4b-679e-4464-a524-8b82193feaf9.jpeg)\r\n\r\n\r\nhttps://user-images.githubusercontent.com/44570278/189943133-f700ba77-9ed1-4d39-9f98-619eba60f4aa.mp4\r\n\r\n\r\n### Markup options\r\n- Highlight\r\n- Strike Out\r\n- Underline\r\n- Erase\r\n\r\n### Viewer\r\nFull-screen\r\n\r\n### How to use\r\nFirst enable the tool (disabled by default) then select text to apply or erase annotation according to the selected tool.\r\n\r\n### Limitations\r\n\r\nThe library used under the hood https://github.com/highkite/pdfAnnotate \r\ndoes not seem to work well with some kind of pdfs (compressed specially). For all the cases that the library fails, we show a message to the user indicating the action has failed. The library does not provide any way to determine from beforehand if a pdf is compatible or not.\r\n\r\npdfAnnotate and pdf.js being different projects does not provide any easy way to work well together. After adding an annotation we need to extract the updated pdf blob and feed it back to pdf.js and re-render the page. All this cause a performance penalty. Discussion: https://github.com/highkite/pdfAnnotate/issues/12.\r\n\r\nDuring first annotation addition, there is a known lag that happens when the file has more than 100 pages, but for subsequent addition the lag does not occur.\r\n\r\nI would not recommend using this feature with big pdfs over 300 pages since for each annotation change we are extracting the new pdf blob from pdfAnnotate library each time this might even cause the app to crash in certain cases. \r\n\r\n### Related pdfAnnotate issues\r\n\r\nhttps://github.com/highkite/pdfAnnotate/issues/63\r\nhttps://github.com/highkite/pdfAnnotate/issues/52\r\nhttps://github.com/highkite/pdfAnnotate/issues/12", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/6845/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/6845/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1246016836", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1246016836", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1246016836, "node_id": "IC_kwDOBLftOs5KRLVE", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-09-13T22:37:09Z", "updated_at": "2022-09-13T22:37:09Z", "author_association": "OWNER", "body": "How are the annotations saved?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1246016836/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1246750478", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1246750478", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1246750478, "node_id": "IC_kwDOBLftOs5KT-cO", "user": { "login": "asrient", "id": 44570278, "node_id": "MDQ6VXNlcjQ0NTcwMjc4", "avatar_url": "https://avatars.githubusercontent.com/u/44570278?v=4", "gravatar_id": "", "url": "https://api.github.com/users/asrient", "html_url": "https://github.com/asrient", "followers_url": "https://api.github.com/users/asrient/followers", "following_url": "https://api.github.com/users/asrient/following{/other_user}", "gists_url": "https://api.github.com/users/asrient/gists{/gist_id}", "starred_url": "https://api.github.com/users/asrient/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/asrient/subscriptions", "organizations_url": "https://api.github.com/users/asrient/orgs", "repos_url": "https://api.github.com/users/asrient/repos", "events_url": "https://api.github.com/users/asrient/events{/privacy}", "received_events_url": "https://api.github.com/users/asrient/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-09-14T13:16:08Z", "updated_at": "2022-09-14T13:21:07Z", "author_association": "CONTRIBUTOR", "body": "> How are the annotations saved?\r\n\r\nThey are saved in the pdf file itself. Annotations are a part of the pdf specification and the pdfAnnotate library provides us the updated pdf file after adding annotations and we when closing the viewer, we write the updated file to disk", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1246750478/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1246900622", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1246900622", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1246900622, "node_id": "IC_kwDOBLftOs5KUjGO", "user": { "login": "roman-r-m", "id": 995612, "node_id": "MDQ6VXNlcjk5NTYxMg==", "avatar_url": "https://avatars.githubusercontent.com/u/995612?v=4", "gravatar_id": "", "url": "https://api.github.com/users/roman-r-m", "html_url": "https://github.com/roman-r-m", "followers_url": "https://api.github.com/users/roman-r-m/followers", "following_url": "https://api.github.com/users/roman-r-m/following{/other_user}", "gists_url": "https://api.github.com/users/roman-r-m/gists{/gist_id}", "starred_url": "https://api.github.com/users/roman-r-m/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/roman-r-m/subscriptions", "organizations_url": "https://api.github.com/users/roman-r-m/orgs", "repos_url": "https://api.github.com/users/roman-r-m/repos", "events_url": "https://api.github.com/users/roman-r-m/events{/privacy}", "received_events_url": "https://api.github.com/users/roman-r-m/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-09-14T15:00:24Z", "updated_at": "2022-09-14T15:00:24Z", "author_association": "CONTRIBUTOR", "body": "> > How are the annotations saved?\n> \n> They are saved in the pdf file itself. Annotations are a part of the pdf specification and the pdfAnnotate library provides us the updated pdf file after adding annotations and we when closing the viewer, we write the updated file to disk\n\nWill the updated PDF be synced?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1246900622/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1248279723", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1248279723", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1248279723, "node_id": "IC_kwDOBLftOs5KZzyr", "user": { "login": "asrient", "id": 44570278, "node_id": "MDQ6VXNlcjQ0NTcwMjc4", "avatar_url": "https://avatars.githubusercontent.com/u/44570278?v=4", "gravatar_id": "", "url": "https://api.github.com/users/asrient", "html_url": "https://github.com/asrient", "followers_url": "https://api.github.com/users/asrient/followers", "following_url": "https://api.github.com/users/asrient/following{/other_user}", "gists_url": "https://api.github.com/users/asrient/gists{/gist_id}", "starred_url": "https://api.github.com/users/asrient/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/asrient/subscriptions", "organizations_url": "https://api.github.com/users/asrient/orgs", "repos_url": "https://api.github.com/users/asrient/repos", "events_url": "https://api.github.com/users/asrient/events{/privacy}", "received_events_url": "https://api.github.com/users/asrient/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-09-15T15:41:47Z", "updated_at": "2022-09-15T15:41:47Z", "author_association": "CONTRIBUTOR", "body": "> Will the updated PDF be synced?\n\nSyncing should work fine with this feature but I haven't checked that usecase yet. Will check and let you know, also make changes if necessary. ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1248279723/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1263751645", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1263751645", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1263751645, "node_id": "IC_kwDOBLftOs5LU1Hd", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-09-30T16:01:07Z", "updated_at": "2022-09-30T16:01:07Z", "author_association": "OWNER", "body": "> Syncing should work fine with this feature but I haven't checked that usecase yet. Will check and let you know, also make changes if necessary.\r\n\r\n@asrient, did you check?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1263751645/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1267230633", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1267230633", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1267230633, "node_id": "IC_kwDOBLftOs5LiGep", "user": { "login": "asrient", "id": 44570278, "node_id": "MDQ6VXNlcjQ0NTcwMjc4", "avatar_url": "https://avatars.githubusercontent.com/u/44570278?v=4", "gravatar_id": "", "url": "https://api.github.com/users/asrient", "html_url": "https://github.com/asrient", "followers_url": "https://api.github.com/users/asrient/followers", "following_url": "https://api.github.com/users/asrient/following{/other_user}", "gists_url": "https://api.github.com/users/asrient/gists{/gist_id}", "starred_url": "https://api.github.com/users/asrient/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/asrient/subscriptions", "organizations_url": "https://api.github.com/users/asrient/orgs", "repos_url": "https://api.github.com/users/asrient/repos", "events_url": "https://api.github.com/users/asrient/events{/privacy}", "received_events_url": "https://api.github.com/users/asrient/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-10-04T16:02:53Z", "updated_at": "2022-10-04T16:02:53Z", "author_association": "CONTRIBUTOR", "body": "> @asrient, did you check?\r\n\r\nIt doesn’t seem to work properly in certain cases, currently working on a fix. ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1267230633/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1279839244", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1279839244", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1279839244, "node_id": "IC_kwDOBLftOs5MSMwM", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-10-15T21:57:00Z", "updated_at": "2022-10-15T21:57:00Z", "author_association": "OWNER", "body": "> > @asrient, did you check?\r\n> \r\n> It doesn’t seem to work properly in certain cases, currently working on a fix.\r\n\r\nIn which cases does it not work? ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1279839244/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1279911784", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1279911784", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1279911784, "node_id": "IC_kwDOBLftOs5MSedo", "user": { "login": "asrient", "id": 44570278, "node_id": "MDQ6VXNlcjQ0NTcwMjc4", "avatar_url": "https://avatars.githubusercontent.com/u/44570278?v=4", "gravatar_id": "", "url": "https://api.github.com/users/asrient", "html_url": "https://github.com/asrient", "followers_url": "https://api.github.com/users/asrient/followers", "following_url": "https://api.github.com/users/asrient/following{/other_user}", "gists_url": "https://api.github.com/users/asrient/gists{/gist_id}", "starred_url": "https://api.github.com/users/asrient/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/asrient/subscriptions", "organizations_url": "https://api.github.com/users/asrient/orgs", "repos_url": "https://api.github.com/users/asrient/repos", "events_url": "https://api.github.com/users/asrient/events{/privacy}", "received_events_url": "https://api.github.com/users/asrient/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-10-16T07:29:49Z", "updated_at": "2022-10-16T07:30:43Z", "author_association": "CONTRIBUTOR", "body": "> In which cases does it not work?\r\n\r\nHi,\r\nLast time I checked, I did a mistake of comparing my dev build with the prod app on my phone. I used oneDrive and later on, on further inspection I observed there's a separate folder for dev on oneDrive and that's why it didn't sync to my phone but was syncing with another dev build on my computer. \r\nNow I think it works well as expected, sorry for the confusion. ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1279911784/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1298604985", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1298604985", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1298604985, "node_id": "IC_kwDOBLftOs5NZyO5", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-11-01T14:37:55Z", "updated_at": "2022-11-01T14:37:55Z", "author_association": "OWNER", "body": "@asrient, are you still interested in completing this PR? There's a minor issue that still needs to be solved", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1298604985/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1298765801", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1298765801", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1298765801, "node_id": "IC_kwDOBLftOs5NaZfp", "user": { "login": "asrient", "id": 44570278, "node_id": "MDQ6VXNlcjQ0NTcwMjc4", "avatar_url": "https://avatars.githubusercontent.com/u/44570278?v=4", "gravatar_id": "", "url": "https://api.github.com/users/asrient", "html_url": "https://github.com/asrient", "followers_url": "https://api.github.com/users/asrient/followers", "following_url": "https://api.github.com/users/asrient/following{/other_user}", "gists_url": "https://api.github.com/users/asrient/gists{/gist_id}", "starred_url": "https://api.github.com/users/asrient/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/asrient/subscriptions", "organizations_url": "https://api.github.com/users/asrient/orgs", "repos_url": "https://api.github.com/users/asrient/repos", "events_url": "https://api.github.com/users/asrient/events{/privacy}", "received_events_url": "https://api.github.com/users/asrient/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-11-01T16:07:56Z", "updated_at": "2022-11-01T16:07:56Z", "author_association": "CONTRIBUTOR", "body": "> @asrient, are you still interested in completing this PR? There's a minor issue that still needs to be solved\r\n\r\nHi, yeah I’m still interested. I’m bit busy with some work right now but will get it done. ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1298765801/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1361672880", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1361672880", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1361672880, "node_id": "IC_kwDOBLftOs5RKXqw", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-21T17:00:40Z", "updated_at": "2022-12-21T17:00:40Z", "author_association": "OWNER", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1361672880/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1361673199", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1361673199", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1361673199, "node_id": "IC_kwDOBLftOs5RKXvv", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-21T17:00:57Z", "updated_at": "2022-12-27T17:34:29Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1361673199/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1365953094", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1365953094", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1365953094, "node_id": "IC_kwDOBLftOs5RaspG", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-27T14:45:46Z", "updated_at": "2022-12-27T14:45:46Z", "author_association": "OWNER", "body": "@asrient, thanks for the update. Would you mind signing the CLA, as described [here](https://github.com/laurent22/joplin/pull/6845#issuecomment-1361673199)? There are also some minors conflicts. Once it's fixed we can merge", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1365953094/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366066282", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1366066282", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1366066282, "node_id": "IC_kwDOBLftOs5RbIRq", "user": { "login": "asrient", "id": 44570278, "node_id": "MDQ6VXNlcjQ0NTcwMjc4", "avatar_url": "https://avatars.githubusercontent.com/u/44570278?v=4", "gravatar_id": "", "url": "https://api.github.com/users/asrient", "html_url": "https://github.com/asrient", "followers_url": "https://api.github.com/users/asrient/followers", "following_url": "https://api.github.com/users/asrient/following{/other_user}", "gists_url": "https://api.github.com/users/asrient/gists{/gist_id}", "starred_url": "https://api.github.com/users/asrient/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/asrient/subscriptions", "organizations_url": "https://api.github.com/users/asrient/orgs", "repos_url": "https://api.github.com/users/asrient/repos", "events_url": "https://api.github.com/users/asrient/events{/privacy}", "received_events_url": "https://api.github.com/users/asrient/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-27T17:34:03Z", "updated_at": "2022-12-27T17:34:03Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366066282/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366066391", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1366066391", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1366066391, "node_id": "IC_kwDOBLftOs5RbITX", "user": { "login": "asrient", "id": 44570278, "node_id": "MDQ6VXNlcjQ0NTcwMjc4", "avatar_url": "https://avatars.githubusercontent.com/u/44570278?v=4", "gravatar_id": "", "url": "https://api.github.com/users/asrient", "html_url": "https://github.com/asrient", "followers_url": "https://api.github.com/users/asrient/followers", "following_url": "https://api.github.com/users/asrient/following{/other_user}", "gists_url": "https://api.github.com/users/asrient/gists{/gist_id}", "starred_url": "https://api.github.com/users/asrient/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/asrient/subscriptions", "organizations_url": "https://api.github.com/users/asrient/orgs", "repos_url": "https://api.github.com/users/asrient/repos", "events_url": "https://api.github.com/users/asrient/events{/privacy}", "received_events_url": "https://api.github.com/users/asrient/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-27T17:34:15Z", "updated_at": "2022-12-27T17:34:15Z", "author_association": "CONTRIBUTOR", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366066391/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366066967", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1366066967", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1366066967, "node_id": "IC_kwDOBLftOs5RbIcX", "user": { "login": "asrient", "id": 44570278, "node_id": "MDQ6VXNlcjQ0NTcwMjc4", "avatar_url": "https://avatars.githubusercontent.com/u/44570278?v=4", "gravatar_id": "", "url": "https://api.github.com/users/asrient", "html_url": "https://github.com/asrient", "followers_url": "https://api.github.com/users/asrient/followers", "following_url": "https://api.github.com/users/asrient/following{/other_user}", "gists_url": "https://api.github.com/users/asrient/gists{/gist_id}", "starred_url": "https://api.github.com/users/asrient/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/asrient/subscriptions", "organizations_url": "https://api.github.com/users/asrient/orgs", "repos_url": "https://api.github.com/users/asrient/repos", "events_url": "https://api.github.com/users/asrient/events{/privacy}", "received_events_url": "https://api.github.com/users/asrient/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-27T17:35:20Z", "updated_at": "2022-12-27T17:35:20Z", "author_association": "CONTRIBUTOR", "body": "fixing the conflicts in some time.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1366066967/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1372571704", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1372571704", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1372571704, "node_id": "IC_kwDOBLftOs5Rz8g4", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-01-05T18:19:12Z", "updated_at": "2023-01-05T18:19:12Z", "author_association": "OWNER", "body": "I just gave it a try but it doesn't work so well - many pdf files don't have the text in a nice layout, so underlining or highlighting doesn't work well (and in some cases, as you mentioned, it doesn't work at all).\r\n\r\nIt would be more useful to have annotation tools like what macOS Preview provide - a way to draw on top of the PDF, add text, etc. That way all can be done regardless of the PDF. In fact, for now it's much better to open the PDF as an external resource, make the annotations in Preview and close it.\r\n\r\nSo with this in mind I don't think we'll merge this for now. It could be used as a starting point if someone else wants to add proper annotation tools later on.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1372571704/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1372574958", "html_url": "https://github.com/laurent22/joplin/pull/6845#issuecomment-1372574958", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/6845", "id": 1372574958, "node_id": "IC_kwDOBLftOs5Rz9Tu", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-01-05T18:22:13Z", "updated_at": "2023-01-05T18:22:13Z", "author_association": "OWNER", "body": "In fact I wonder what are the benefits of the new PDF viewer compared to the built-in one? Is it just that the new one memorises the current page?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1372574958/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }