{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/9674", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/9674/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/9674/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/9674/events", "html_url": "https://github.com/laurent22/joplin/pull/9674", "id": 2068704181, "node_id": "PR_kwDOBLftOs5jYnWP", "number": 9674, "title": "Chore: turndown-plugin-gfm: Fix package name in README", "user": { "login": "awxiaoxian2020", "id": 69554233, "node_id": "MDQ6VXNlcjY5NTU0MjMz", "avatar_url": "https://avatars.githubusercontent.com/u/69554233?v=4", "gravatar_id": "", "url": "https://api.github.com/users/awxiaoxian2020", "html_url": "https://github.com/awxiaoxian2020", "followers_url": "https://api.github.com/users/awxiaoxian2020/followers", "following_url": "https://api.github.com/users/awxiaoxian2020/following{/other_user}", "gists_url": "https://api.github.com/users/awxiaoxian2020/gists{/gist_id}", "starred_url": "https://api.github.com/users/awxiaoxian2020/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/awxiaoxian2020/subscriptions", "organizations_url": "https://api.github.com/users/awxiaoxian2020/orgs", "repos_url": "https://api.github.com/users/awxiaoxian2020/repos", "events_url": "https://api.github.com/users/awxiaoxian2020/events{/privacy}", "received_events_url": "https://api.github.com/users/awxiaoxian2020/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 6, "created_at": "2024-01-06T16:12:16Z", "updated_at": "2024-01-08T11:56:22Z", "closed_at": "2024-01-08T11:56:09Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/9674", "html_url": "https://github.com/laurent22/joplin/pull/9674", "diff_url": "https://github.com/laurent22/joplin/pull/9674.diff", "patch_url": "https://github.com/laurent22/joplin/pull/9674.patch", "merged_at": "2024-01-08T11:56:09Z" }, "body": "\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/9674/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/9674/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1879741902", "html_url": "https://github.com/laurent22/joplin/pull/9674#issuecomment-1879741902", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9674", "id": 1879741902, "node_id": "IC_kwDOBLftOs5wCpXO", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-01-06T16:12:31Z", "updated_at": "2024-01-08T11:56:22Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1879741902/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1879743367", "html_url": "https://github.com/laurent22/joplin/pull/9674#issuecomment-1879743367", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9674", "id": 1879743367, "node_id": "IC_kwDOBLftOs5wCpuH", "user": { "login": "awxiaoxian2020", "id": 69554233, "node_id": "MDQ6VXNlcjY5NTU0MjMz", "avatar_url": "https://avatars.githubusercontent.com/u/69554233?v=4", "gravatar_id": "", "url": "https://api.github.com/users/awxiaoxian2020", "html_url": "https://github.com/awxiaoxian2020", "followers_url": "https://api.github.com/users/awxiaoxian2020/followers", "following_url": "https://api.github.com/users/awxiaoxian2020/following{/other_user}", "gists_url": "https://api.github.com/users/awxiaoxian2020/gists{/gist_id}", "starred_url": "https://api.github.com/users/awxiaoxian2020/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/awxiaoxian2020/subscriptions", "organizations_url": "https://api.github.com/users/awxiaoxian2020/orgs", "repos_url": "https://api.github.com/users/awxiaoxian2020/repos", "events_url": "https://api.github.com/users/awxiaoxian2020/events{/privacy}", "received_events_url": "https://api.github.com/users/awxiaoxian2020/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-01-06T16:18:06Z", "updated_at": "2024-01-06T16:18:06Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1879743367/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1879743437", "html_url": "https://github.com/laurent22/joplin/pull/9674#issuecomment-1879743437", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9674", "id": 1879743437, "node_id": "IC_kwDOBLftOs5wCpvN", "user": { "login": "awxiaoxian2020", "id": 69554233, "node_id": "MDQ6VXNlcjY5NTU0MjMz", "avatar_url": "https://avatars.githubusercontent.com/u/69554233?v=4", "gravatar_id": "", "url": "https://api.github.com/users/awxiaoxian2020", "html_url": "https://github.com/awxiaoxian2020", "followers_url": "https://api.github.com/users/awxiaoxian2020/followers", "following_url": "https://api.github.com/users/awxiaoxian2020/following{/other_user}", "gists_url": "https://api.github.com/users/awxiaoxian2020/gists{/gist_id}", "starred_url": "https://api.github.com/users/awxiaoxian2020/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/awxiaoxian2020/subscriptions", "organizations_url": "https://api.github.com/users/awxiaoxian2020/orgs", "repos_url": "https://api.github.com/users/awxiaoxian2020/repos", "events_url": "https://api.github.com/users/awxiaoxian2020/events{/privacy}", "received_events_url": "https://api.github.com/users/awxiaoxian2020/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-01-06T16:18:28Z", "updated_at": "2024-01-06T16:18:28Z", "author_association": "CONTRIBUTOR", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1879743437/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1879922160", "html_url": "https://github.com/laurent22/joplin/pull/9674#issuecomment-1879922160", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9674", "id": 1879922160, "node_id": "IC_kwDOBLftOs5wDVXw", "user": { "login": "awxiaoxian2020", "id": 69554233, "node_id": "MDQ6VXNlcjY5NTU0MjMz", "avatar_url": "https://avatars.githubusercontent.com/u/69554233?v=4", "gravatar_id": "", "url": "https://api.github.com/users/awxiaoxian2020", "html_url": "https://github.com/awxiaoxian2020", "followers_url": "https://api.github.com/users/awxiaoxian2020/followers", "following_url": "https://api.github.com/users/awxiaoxian2020/following{/other_user}", "gists_url": "https://api.github.com/users/awxiaoxian2020/gists{/gist_id}", "starred_url": "https://api.github.com/users/awxiaoxian2020/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/awxiaoxian2020/subscriptions", "organizations_url": "https://api.github.com/users/awxiaoxian2020/orgs", "repos_url": "https://api.github.com/users/awxiaoxian2020/repos", "events_url": "https://api.github.com/users/awxiaoxian2020/events{/privacy}", "received_events_url": "https://api.github.com/users/awxiaoxian2020/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-01-07T02:59:53Z", "updated_at": "2024-01-07T02:59:53Z", "author_association": "CONTRIBUTOR", "body": "> Thank you for the fix!\r\n> \r\n> Be aware that we have a [script that automatically generates release notes from commit titles](https://github.com/laurent22/joplin/blob/f8a25cb275a0beb9ba3ef9bf4271d38947449f42/packages/tools/git-changelog.ts#L358). As such, a better name for this pull request might be `Chore: turndown-plugin-gfm: Fix package name in README` (the `Chore:` part prevents it from showing up in Joplin's release notes).\r\n\r\nCould you update the contributing guide to give a tip for other contributors? :)", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1879922160/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1880860899", "html_url": "https://github.com/laurent22/joplin/pull/9674#issuecomment-1880860899", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9674", "id": 1880860899, "node_id": "IC_kwDOBLftOs5wG6jj", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-01-08T11:55:57Z", "updated_at": "2024-01-08T11:55:57Z", "author_association": "OWNER", "body": "> Could you update the contributing guide to give a tip for other contributors? :)\r\n\r\nIt's all in the pull request description, when you create it:\r\n\r\n> Please prefix the title with the platform you are targetting:\r\n> \r\n> Here are some examples of good titles:\r\n> \r\n> - Desktop: Resolves #123: Added new setting to change font\r\n> - Mobile, Desktop: Fixes #456: Fixed config screen error\r\n> - All: Resolves #777: Made synchronisation faster\r\n> \r\n> And here's an explanation of the title format:\r\n> \r\n> - \"Desktop\" for the Windows/macOS/Linux app (Electron app)\r\n> - \"Mobile\" for the mobile app (or \"Android\" / \"iOS\" if the pull request only applies to one of the mobile platforms)\r\n> - \"CLI\" for the CLI app\r\n> \r\n> If it's two platforms, separate them with commas - \"Desktop, Mobile\" or if it's for all platforms, prefix with \"All\".\r\n> \r\n> If it's not related to any platform (such as a translation, change to the documentation, etc.), simply don't add a platform.\r\n> \r\n> Then please append the issue that you've addressed or fixed. Use \"Resolves #123\" for new features or improvements and \"Fixes #123\" for > bug fixes.\r\n> \r\n> AND PLEASE READ THE GUIDE: https://github.com/laurent22/joplin/blob/dev/CONTRIBUTING.md", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1880860899/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1880861358", "html_url": "https://github.com/laurent22/joplin/pull/9674#issuecomment-1880861358", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9674", "id": 1880861358, "node_id": "IC_kwDOBLftOs5wG6qu", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-01-08T11:56:17Z", "updated_at": "2024-01-08T11:56:17Z", "author_association": "OWNER", "body": "Thanks for the fix!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1880861358/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }