{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7529", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/7529/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/7529/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/7529/events", "html_url": "https://github.com/laurent22/joplin/pull/7529", "id": 1509918444, "node_id": "PR_kwDOBLftOs5GJl4d", "number": 7529, "title": "Windows/macOS: Resolves #7520: Search field doesn't get focus when pressing Ctrl+F", "user": { "login": "betty-alagwu", "id": 94234459, "node_id": "U_kgDOBZ3nWw", "avatar_url": "https://avatars.githubusercontent.com/u/94234459?v=4", "gravatar_id": "", "url": "https://api.github.com/users/betty-alagwu", "html_url": "https://github.com/betty-alagwu", "followers_url": "https://api.github.com/users/betty-alagwu/followers", "following_url": "https://api.github.com/users/betty-alagwu/following{/other_user}", "gists_url": "https://api.github.com/users/betty-alagwu/gists{/gist_id}", "starred_url": "https://api.github.com/users/betty-alagwu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/betty-alagwu/subscriptions", "organizations_url": "https://api.github.com/users/betty-alagwu/orgs", "repos_url": "https://api.github.com/users/betty-alagwu/repos", "events_url": "https://api.github.com/users/betty-alagwu/events{/privacy}", "received_events_url": "https://api.github.com/users/betty-alagwu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": true, "assignee": null, "assignees": [], "milestone": null, "comments": 6, "created_at": "2022-12-24T03:07:51Z", "updated_at": "2022-12-30T23:54:24Z", "closed_at": "2022-12-30T23:54:04Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/7529", "html_url": "https://github.com/laurent22/joplin/pull/7529", "diff_url": "https://github.com/laurent22/joplin/pull/7529.diff", "patch_url": "https://github.com/laurent22/joplin/pull/7529.patch", "merged_at": "2022-12-30T23:54:04Z" }, "body": "Fixes #7520\r\n\r\n## Solution\r\n\r\nI fixed this by adding a `useEffect` that auto focuses the search input after it is opened from the command execution.\r\n\r\n\r\nhttps://user-images.githubusercontent.com/94234459/209419928-278502f9-bc53-4f38-bd7b-511363c6b1ca.mp4\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7529/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/7529/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1364448930", "html_url": "https://github.com/laurent22/joplin/pull/7529#issuecomment-1364448930", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7529", "id": 1364448930, "node_id": "IC_kwDOBLftOs5RU9ai", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-24T03:08:09Z", "updated_at": "2022-12-26T00:39:35Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1364448930/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1364449008", "html_url": "https://github.com/laurent22/joplin/pull/7529#issuecomment-1364449008", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7529", "id": 1364449008, "node_id": "IC_kwDOBLftOs5RU9bw", "user": { "login": "betty-alagwu", "id": 94234459, "node_id": "U_kgDOBZ3nWw", "avatar_url": "https://avatars.githubusercontent.com/u/94234459?v=4", "gravatar_id": "", "url": "https://api.github.com/users/betty-alagwu", "html_url": "https://github.com/betty-alagwu", "followers_url": "https://api.github.com/users/betty-alagwu/followers", "following_url": "https://api.github.com/users/betty-alagwu/following{/other_user}", "gists_url": "https://api.github.com/users/betty-alagwu/gists{/gist_id}", "starred_url": "https://api.github.com/users/betty-alagwu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/betty-alagwu/subscriptions", "organizations_url": "https://api.github.com/users/betty-alagwu/orgs", "repos_url": "https://api.github.com/users/betty-alagwu/repos", "events_url": "https://api.github.com/users/betty-alagwu/events{/privacy}", "received_events_url": "https://api.github.com/users/betty-alagwu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-24T03:08:45Z", "updated_at": "2022-12-24T03:08:45Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1364449008/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1364449028", "html_url": "https://github.com/laurent22/joplin/pull/7529#issuecomment-1364449028", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7529", "id": 1364449028, "node_id": "IC_kwDOBLftOs5RU9cE", "user": { "login": "betty-alagwu", "id": 94234459, "node_id": "U_kgDOBZ3nWw", "avatar_url": "https://avatars.githubusercontent.com/u/94234459?v=4", "gravatar_id": "", "url": "https://api.github.com/users/betty-alagwu", "html_url": "https://github.com/betty-alagwu", "followers_url": "https://api.github.com/users/betty-alagwu/followers", "following_url": "https://api.github.com/users/betty-alagwu/following{/other_user}", "gists_url": "https://api.github.com/users/betty-alagwu/gists{/gist_id}", "starred_url": "https://api.github.com/users/betty-alagwu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/betty-alagwu/subscriptions", "organizations_url": "https://api.github.com/users/betty-alagwu/orgs", "repos_url": "https://api.github.com/users/betty-alagwu/repos", "events_url": "https://api.github.com/users/betty-alagwu/events{/privacy}", "received_events_url": "https://api.github.com/users/betty-alagwu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-24T03:08:59Z", "updated_at": "2022-12-24T03:08:59Z", "author_association": "CONTRIBUTOR", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1364449028/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1364708122", "html_url": "https://github.com/laurent22/joplin/pull/7529#issuecomment-1364708122", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7529", "id": 1364708122, "node_id": "IC_kwDOBLftOs5RV8sa", "user": { "login": "sanskarfc", "id": 72058551, "node_id": "MDQ6VXNlcjcyMDU4NTUx", "avatar_url": "https://avatars.githubusercontent.com/u/72058551?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sanskarfc", "html_url": "https://github.com/sanskarfc", "followers_url": "https://api.github.com/users/sanskarfc/followers", "following_url": "https://api.github.com/users/sanskarfc/following{/other_user}", "gists_url": "https://api.github.com/users/sanskarfc/gists{/gist_id}", "starred_url": "https://api.github.com/users/sanskarfc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sanskarfc/subscriptions", "organizations_url": "https://api.github.com/users/sanskarfc/orgs", "repos_url": "https://api.github.com/users/sanskarfc/repos", "events_url": "https://api.github.com/users/sanskarfc/events{/privacy}", "received_events_url": "https://api.github.com/users/sanskarfc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-25T16:44:37Z", "updated_at": "2022-12-25T16:44:37Z", "author_association": "NONE", "body": "Just another caveat...\r\n\r\nAfter pressing Ctrl + F once, my cursor moves in the local search area, but if I move my cursor to the note and press Ctrl + F once again (while in note area with the local search already open), the cursor doesn't move back into the local search. ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1364708122/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1364767002", "html_url": "https://github.com/laurent22/joplin/pull/7529#issuecomment-1364767002", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7529", "id": 1364767002, "node_id": "IC_kwDOBLftOs5RWLEa", "user": { "login": "betty-alagwu", "id": 94234459, "node_id": "U_kgDOBZ3nWw", "avatar_url": "https://avatars.githubusercontent.com/u/94234459?v=4", "gravatar_id": "", "url": "https://api.github.com/users/betty-alagwu", "html_url": "https://github.com/betty-alagwu", "followers_url": "https://api.github.com/users/betty-alagwu/followers", "following_url": "https://api.github.com/users/betty-alagwu/following{/other_user}", "gists_url": "https://api.github.com/users/betty-alagwu/gists{/gist_id}", "starred_url": "https://api.github.com/users/betty-alagwu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/betty-alagwu/subscriptions", "organizations_url": "https://api.github.com/users/betty-alagwu/orgs", "repos_url": "https://api.github.com/users/betty-alagwu/repos", "events_url": "https://api.github.com/users/betty-alagwu/events{/privacy}", "received_events_url": "https://api.github.com/users/betty-alagwu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-26T00:39:55Z", "updated_at": "2022-12-26T00:39:55Z", "author_association": "CONTRIBUTOR", "body": "Thank you @sanskarfc . I pushed a change to address this. Thank you @laurent22 also for your review. Looking forward to any additional feedback.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1364767002/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368126469", "html_url": "https://github.com/laurent22/joplin/pull/7529#issuecomment-1368126469", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7529", "id": 1368126469, "node_id": "IC_kwDOBLftOs5Ri_QF", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2022-12-30T23:54:13Z", "updated_at": "2022-12-30T23:54:13Z", "author_association": "OWNER", "body": "Looks good now, thanks for fixing this!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1368126469/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }