{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/9210", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/9210/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/9210/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/9210/events", "html_url": "https://github.com/laurent22/joplin/pull/9210", "id": 1976987242, "node_id": "PR_kwDOBLftOs5elBoA", "number": 9210, "title": "Desktop: Add new setting to define install directory", "user": { "login": "brechsteiner", "id": 3897867, "node_id": "MDQ6VXNlcjM4OTc4Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/3897867?v=4", "gravatar_id": "", "url": "https://api.github.com/users/brechsteiner", "html_url": "https://github.com/brechsteiner", "followers_url": "https://api.github.com/users/brechsteiner/followers", "following_url": "https://api.github.com/users/brechsteiner/following{/other_user}", "gists_url": "https://api.github.com/users/brechsteiner/gists{/gist_id}", "starred_url": "https://api.github.com/users/brechsteiner/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/brechsteiner/subscriptions", "organizations_url": "https://api.github.com/users/brechsteiner/orgs", "repos_url": "https://api.github.com/users/brechsteiner/repos", "events_url": "https://api.github.com/users/brechsteiner/events{/privacy}", "received_events_url": "https://api.github.com/users/brechsteiner/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 7, "created_at": "2023-11-03T22:06:59Z", "updated_at": "2023-11-08T12:10:24Z", "closed_at": "2023-11-07T12:03:39Z", "author_association": "NONE", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/9210", "html_url": "https://github.com/laurent22/joplin/pull/9210", "diff_url": "https://github.com/laurent22/joplin/pull/9210.diff", "patch_url": "https://github.com/laurent22/joplin/pull/9210.patch", "merged_at": null }, "body": null, "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/9210/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/9210/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1793158090", "html_url": "https://github.com/laurent22/joplin/pull/9210#issuecomment-1793158090", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9210", "id": 1793158090, "node_id": "IC_kwDOBLftOs5q4WvK", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-11-03T22:07:14Z", "updated_at": "2023-11-07T12:30:09Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1793158090/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1793159105", "html_url": "https://github.com/laurent22/joplin/pull/9210#issuecomment-1793159105", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9210", "id": 1793159105, "node_id": "IC_kwDOBLftOs5q4W_B", "user": { "login": "brechsteiner", "id": 3897867, "node_id": "MDQ6VXNlcjM4OTc4Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/3897867?v=4", "gravatar_id": "", "url": "https://api.github.com/users/brechsteiner", "html_url": "https://github.com/brechsteiner", "followers_url": "https://api.github.com/users/brechsteiner/followers", "following_url": "https://api.github.com/users/brechsteiner/following{/other_user}", "gists_url": "https://api.github.com/users/brechsteiner/gists{/gist_id}", "starred_url": "https://api.github.com/users/brechsteiner/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/brechsteiner/subscriptions", "organizations_url": "https://api.github.com/users/brechsteiner/orgs", "repos_url": "https://api.github.com/users/brechsteiner/repos", "events_url": "https://api.github.com/users/brechsteiner/events{/privacy}", "received_events_url": "https://api.github.com/users/brechsteiner/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-11-03T22:08:37Z", "updated_at": "2023-11-03T22:08:37Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1793159105/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1793159335", "html_url": "https://github.com/laurent22/joplin/pull/9210#issuecomment-1793159335", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9210", "id": 1793159335, "node_id": "IC_kwDOBLftOs5q4XCn", "user": { "login": "brechsteiner", "id": 3897867, "node_id": "MDQ6VXNlcjM4OTc4Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/3897867?v=4", "gravatar_id": "", "url": "https://api.github.com/users/brechsteiner", "html_url": "https://github.com/brechsteiner", "followers_url": "https://api.github.com/users/brechsteiner/followers", "following_url": "https://api.github.com/users/brechsteiner/following{/other_user}", "gists_url": "https://api.github.com/users/brechsteiner/gists{/gist_id}", "starred_url": "https://api.github.com/users/brechsteiner/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/brechsteiner/subscriptions", "organizations_url": "https://api.github.com/users/brechsteiner/orgs", "repos_url": "https://api.github.com/users/brechsteiner/repos", "events_url": "https://api.github.com/users/brechsteiner/events{/privacy}", "received_events_url": "https://api.github.com/users/brechsteiner/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-11-03T22:08:54Z", "updated_at": "2023-11-03T22:08:54Z", "author_association": "NONE", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1793159335/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1793427734", "html_url": "https://github.com/laurent22/joplin/pull/9210#issuecomment-1793427734", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9210", "id": 1793427734, "node_id": "IC_kwDOBLftOs5q5YkW", "user": { "login": "brechsteiner", "id": 3897867, "node_id": "MDQ6VXNlcjM4OTc4Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/3897867?v=4", "gravatar_id": "", "url": "https://api.github.com/users/brechsteiner", "html_url": "https://github.com/brechsteiner", "followers_url": "https://api.github.com/users/brechsteiner/followers", "following_url": "https://api.github.com/users/brechsteiner/following{/other_user}", "gists_url": "https://api.github.com/users/brechsteiner/gists{/gist_id}", "starred_url": "https://api.github.com/users/brechsteiner/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/brechsteiner/subscriptions", "organizations_url": "https://api.github.com/users/brechsteiner/orgs", "repos_url": "https://api.github.com/users/brechsteiner/repos", "events_url": "https://api.github.com/users/brechsteiner/events{/privacy}", "received_events_url": "https://api.github.com/users/brechsteiner/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-11-04T12:16:48Z", "updated_at": "2023-11-04T12:16:48Z", "author_association": "NONE", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1793427734/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1793538501", "html_url": "https://github.com/laurent22/joplin/pull/9210#issuecomment-1793538501", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9210", "id": 1793538501, "node_id": "IC_kwDOBLftOs5q5znF", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-11-04T19:43:18Z", "updated_at": "2023-11-04T19:45:48Z", "author_association": "COLLABORATOR", "body": "This line [should also be changed](https://github.com/laurent22/joplin/pull/9210/files#diff-c0888183e544cf752c9e4670c6a49cde95133f607de421265bec602e28a13621R241) — without it, the `.desktop` file won't launch the AppImage:\r\n\r\n```\r\n241: Exec=${HOME}/.joplin/Joplin.AppImage ${SANDBOXPARAM} %u\r\n```\r\n\r\nAnother thing to consider is how the `--install-dir` option will be used (e.g. whether users will try to use it to install for another user or in a global location). Currently, icons and launchers are written to locations in the user's home folder (`~/.local/share/...`). As such, what are the intended use cases for customizing the `install-dir`? Does it make sense to provide this without also changing the location of icons/`.desktop` files?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1793538501/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1798370383", "html_url": "https://github.com/laurent22/joplin/pull/9210#issuecomment-1798370383", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9210", "id": 1798370383, "node_id": "IC_kwDOBLftOs5rMPRP", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-11-07T12:03:39Z", "updated_at": "2023-11-07T12:03:39Z", "author_association": "OWNER", "body": "I'd rather not merge this to be honest. Having a fixed install directory is not a major issue, and can easily be worked around with symlinks. In general I don't think the issue came up often enough to justify adding the option", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1798370383/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1801763546", "html_url": "https://github.com/laurent22/joplin/pull/9210#issuecomment-1801763546", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/9210", "id": 1801763546, "node_id": "IC_kwDOBLftOs5rZLra", "user": { "login": "brechsteiner", "id": 3897867, "node_id": "MDQ6VXNlcjM4OTc4Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/3897867?v=4", "gravatar_id": "", "url": "https://api.github.com/users/brechsteiner", "html_url": "https://github.com/brechsteiner", "followers_url": "https://api.github.com/users/brechsteiner/followers", "following_url": "https://api.github.com/users/brechsteiner/following{/other_user}", "gists_url": "https://api.github.com/users/brechsteiner/gists{/gist_id}", "starred_url": "https://api.github.com/users/brechsteiner/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/brechsteiner/subscriptions", "organizations_url": "https://api.github.com/users/brechsteiner/orgs", "repos_url": "https://api.github.com/users/brechsteiner/repos", "events_url": "https://api.github.com/users/brechsteiner/events{/privacy}", "received_events_url": "https://api.github.com/users/brechsteiner/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-11-08T12:10:24Z", "updated_at": "2023-11-08T12:10:24Z", "author_association": "NONE", "body": "@laurent22 the reason for option is that we have several user accounts on one computer and instead of everyone having their own installation in their home dir, you can use the option to install the client centrally (in my case under /opt) ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1801763546/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }