{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/13281", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/13281/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/13281/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/13281/events", "html_url": "https://github.com/laurent22/joplin/pull/13281", "id": 3446301688, "node_id": "PR_kwDOBLftOs6qIClU", "number": 13281, "title": "Desktop: Fixes #13274: Build Assets for Mermaid", "user": { "login": "bsavant", "id": 209364, "node_id": "MDQ6VXNlcjIwOTM2NA==", "avatar_url": "https://avatars.githubusercontent.com/u/209364?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bsavant", "html_url": "https://github.com/bsavant", "followers_url": "https://api.github.com/users/bsavant/followers", "following_url": "https://api.github.com/users/bsavant/following{/other_user}", "gists_url": "https://api.github.com/users/bsavant/gists{/gist_id}", "starred_url": "https://api.github.com/users/bsavant/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bsavant/subscriptions", "organizations_url": "https://api.github.com/users/bsavant/orgs", "repos_url": "https://api.github.com/users/bsavant/repos", "events_url": "https://api.github.com/users/bsavant/events{/privacy}", "received_events_url": "https://api.github.com/users/bsavant/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 6, "created_at": "2025-09-23T18:39:48Z", "updated_at": "2025-09-26T00:41:35Z", "closed_at": "2025-09-26T00:12:51Z", "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/13281", "html_url": "https://github.com/laurent22/joplin/pull/13281", "diff_url": "https://github.com/laurent22/joplin/pull/13281.diff", "patch_url": "https://github.com/laurent22/joplin/pull/13281.patch", "merged_at": null }, "body": "Fixes #13274 by building the Assets needed for Mermaid. These do not appear to have been built when #12775 was merged.", "closed_by": { "login": "bsavant", "id": 209364, "node_id": "MDQ6VXNlcjIwOTM2NA==", "avatar_url": "https://avatars.githubusercontent.com/u/209364?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bsavant", "html_url": "https://github.com/bsavant", "followers_url": "https://api.github.com/users/bsavant/followers", "following_url": "https://api.github.com/users/bsavant/following{/other_user}", "gists_url": "https://api.github.com/users/bsavant/gists{/gist_id}", "starred_url": "https://api.github.com/users/bsavant/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bsavant/subscriptions", "organizations_url": "https://api.github.com/users/bsavant/orgs", "repos_url": "https://api.github.com/users/bsavant/repos", "events_url": "https://api.github.com/users/bsavant/events{/privacy}", "received_events_url": "https://api.github.com/users/bsavant/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/13281/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/13281/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3325141259", "html_url": "https://github.com/laurent22/joplin/pull/13281#issuecomment-3325141259", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13281", "id": 3325141259, "node_id": "IC_kwDOBLftOs7GMaEL", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2025-09-23T18:40:00Z", "updated_at": "2025-09-26T00:41:35Z", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "author_association": "CONTRIBUTOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3325141259/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-11-12T15:38:39Z", "permissions": { "actions": "write", "administration": "read", "artifact_metadata": "write", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3325142584", "html_url": "https://github.com/laurent22/joplin/pull/13281#issuecomment-3325142584", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13281", "id": 3325142584, "node_id": "IC_kwDOBLftOs7GMaY4", "user": { "login": "bsavant", "id": 209364, "node_id": "MDQ6VXNlcjIwOTM2NA==", "avatar_url": "https://avatars.githubusercontent.com/u/209364?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bsavant", "html_url": "https://github.com/bsavant", "followers_url": "https://api.github.com/users/bsavant/followers", "following_url": "https://api.github.com/users/bsavant/following{/other_user}", "gists_url": "https://api.github.com/users/bsavant/gists{/gist_id}", "starred_url": "https://api.github.com/users/bsavant/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bsavant/subscriptions", "organizations_url": "https://api.github.com/users/bsavant/orgs", "repos_url": "https://api.github.com/users/bsavant/repos", "events_url": "https://api.github.com/users/bsavant/events{/privacy}", "received_events_url": "https://api.github.com/users/bsavant/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-09-23T18:40:31Z", "updated_at": "2025-09-23T18:40:31Z", "body": "I have read the CLA Document and I hereby sign the CLA", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3325142584/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3327602984", "html_url": "https://github.com/laurent22/joplin/pull/13281#issuecomment-3327602984", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13281", "id": 3327602984, "node_id": "IC_kwDOBLftOs7GVzEo", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-09-24T10:13:38Z", "updated_at": "2025-09-24T10:13:38Z", "body": "How was it built? I thought there should be more files than this?", "author_association": "OWNER", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3327602984/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3327924337", "html_url": "https://github.com/laurent22/joplin/pull/13281#issuecomment-3327924337", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13281", "id": 3327924337, "node_id": "IC_kwDOBLftOs7GXBhx", "user": { "login": "bsavant", "id": 209364, "node_id": "MDQ6VXNlcjIwOTM2NA==", "avatar_url": "https://avatars.githubusercontent.com/u/209364?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bsavant", "html_url": "https://github.com/bsavant", "followers_url": "https://api.github.com/users/bsavant/followers", "following_url": "https://api.github.com/users/bsavant/following{/other_user}", "gists_url": "https://api.github.com/users/bsavant/gists{/gist_id}", "starred_url": "https://api.github.com/users/bsavant/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bsavant/subscriptions", "organizations_url": "https://api.github.com/users/bsavant/orgs", "repos_url": "https://api.github.com/users/bsavant/repos", "events_url": "https://api.github.com/users/bsavant/events{/privacy}", "received_events_url": "https://api.github.com/users/bsavant/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-09-24T11:22:53Z", "updated_at": "2025-09-24T11:22:53Z", "body": "I thought it was strange too. I ran `node packages/renderer/tools/buildAssets.js`. If I leave the mermaid version alone, it only builds that one file. \r\n\r\nIf I upgrade mermaid to the latest (11.12.0), and build the assets the same way it does build a handful more files. But I didn't want to submit both the version upgrade and fix in the same PR since the issue didn't appear to stem from the version difference.", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3327924337/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3336215775", "html_url": "https://github.com/laurent22/joplin/pull/13281#issuecomment-3336215775", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13281", "id": 3336215775, "node_id": "IC_kwDOBLftOs7G2pzf", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-09-25T23:19:29Z", "updated_at": "2025-09-25T23:24:49Z", "body": "> These do not appear to have been built when https://github.com/laurent22/joplin/pull/12775 was merged.\r\n\r\nThe mermaid assets should have been updated in https://github.com/laurent22/joplin/commit/f541618ed4a93b75bf7adfd27c097e1bf61aa102#diff-f67f704ddf3880d2cac1b392a775a58efcfb4fe74969023f223916f9c585270b. For me, when I run `yarn buildAssets` locally from `packages/renderer`, `mermaid.min.js` is unchanged. Is it possible that `node packages/renderer/tools/buildAssets.js` is using a cached newer version of mermaid (does re-running `yarn install`, then `yarn buildAssets` change the file content)?", "author_association": "COLLABORATOR", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3336215775/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3336309349", "html_url": "https://github.com/laurent22/joplin/pull/13281#issuecomment-3336309349", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/13281", "id": 3336309349, "node_id": "IC_kwDOBLftOs7G3Apl", "user": { "login": "bsavant", "id": 209364, "node_id": "MDQ6VXNlcjIwOTM2NA==", "avatar_url": "https://avatars.githubusercontent.com/u/209364?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bsavant", "html_url": "https://github.com/bsavant", "followers_url": "https://api.github.com/users/bsavant/followers", "following_url": "https://api.github.com/users/bsavant/following{/other_user}", "gists_url": "https://api.github.com/users/bsavant/gists{/gist_id}", "starred_url": "https://api.github.com/users/bsavant/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bsavant/subscriptions", "organizations_url": "https://api.github.com/users/bsavant/orgs", "repos_url": "https://api.github.com/users/bsavant/repos", "events_url": "https://api.github.com/users/bsavant/events{/privacy}", "received_events_url": "https://api.github.com/users/bsavant/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2025-09-26T00:12:51Z", "updated_at": "2025-09-26T00:12:51Z", "body": ">Is it possible that `node packages/renderer/tools/buildAssets.js` is using a cached newer version of mermaid (does re-running `yarn install`, then `yarn buildAssets` change the file content)?\r\n\r\nYou're right, this was building 11.12.0!\r\n", "author_association": "NONE", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/3336309349/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }