{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10003", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/10003/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/10003/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/10003/events", "html_url": "https://github.com/laurent22/joplin/pull/10003", "id": 2154273202, "node_id": "PR_kwDOBLftOs5n67RQ", "number": 10003, "title": "Desktop: Resolves #9980: Support Ctrl+Enter keyboard shortcut (Cmd+Enter on MacOS)", "user": { "login": "cagnusmarlsen", "id": 91818868, "node_id": "U_kgDOBXkLdA", "avatar_url": "https://avatars.githubusercontent.com/u/91818868?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cagnusmarlsen", "html_url": "https://github.com/cagnusmarlsen", "followers_url": "https://api.github.com/users/cagnusmarlsen/followers", "following_url": "https://api.github.com/users/cagnusmarlsen/following{/other_user}", "gists_url": "https://api.github.com/users/cagnusmarlsen/gists{/gist_id}", "starred_url": "https://api.github.com/users/cagnusmarlsen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cagnusmarlsen/subscriptions", "organizations_url": "https://api.github.com/users/cagnusmarlsen/orgs", "repos_url": "https://api.github.com/users/cagnusmarlsen/repos", "events_url": "https://api.github.com/users/cagnusmarlsen/events{/privacy}", "received_events_url": "https://api.github.com/users/cagnusmarlsen/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 5, "created_at": "2024-02-26T14:08:10Z", "updated_at": "2024-03-02T15:53:07Z", "closed_at": "2024-03-02T15:52:55Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/10003", "html_url": "https://github.com/laurent22/joplin/pull/10003", "diff_url": "https://github.com/laurent22/joplin/pull/10003.diff", "patch_url": "https://github.com/laurent22/joplin/pull/10003.patch", "merged_at": "2024-03-02T15:52:55Z" }, "body": "Fixes #9980 by adding key bindings for Ctrl+Enter on Windows/Linux and Cmd+Enter on macOS. This adds functionality to add a new line after the line where the cursor currently is.\r\n\r\n### Testing\r\n\r\nThis has been tested successfully on Windows 11 and Ubuntu.\r\n\r\n\r\nhttps://github.com/laurent22/joplin/assets/91818868/585a8f92-7337-4c13-915e-72100f23cb69\r\n\r\n", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10003/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/10003/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1964231920", "html_url": "https://github.com/laurent22/joplin/pull/10003#issuecomment-1964231920", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10003", "id": 1964231920, "node_id": "IC_kwDOBLftOs51E8zw", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-02-26T14:08:28Z", "updated_at": "2024-03-02T15:53:07Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1964231920/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1964235517", "html_url": "https://github.com/laurent22/joplin/pull/10003#issuecomment-1964235517", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10003", "id": 1964235517, "node_id": "IC_kwDOBLftOs51E9r9", "user": { "login": "cagnusmarlsen", "id": 91818868, "node_id": "U_kgDOBXkLdA", "avatar_url": "https://avatars.githubusercontent.com/u/91818868?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cagnusmarlsen", "html_url": "https://github.com/cagnusmarlsen", "followers_url": "https://api.github.com/users/cagnusmarlsen/followers", "following_url": "https://api.github.com/users/cagnusmarlsen/following{/other_user}", "gists_url": "https://api.github.com/users/cagnusmarlsen/gists{/gist_id}", "starred_url": "https://api.github.com/users/cagnusmarlsen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cagnusmarlsen/subscriptions", "organizations_url": "https://api.github.com/users/cagnusmarlsen/orgs", "repos_url": "https://api.github.com/users/cagnusmarlsen/repos", "events_url": "https://api.github.com/users/cagnusmarlsen/events{/privacy}", "received_events_url": "https://api.github.com/users/cagnusmarlsen/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-02-26T14:10:07Z", "updated_at": "2024-02-26T14:10:07Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1964235517/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1967589904", "html_url": "https://github.com/laurent22/joplin/pull/10003#issuecomment-1967589904", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10003", "id": 1967589904, "node_id": "IC_kwDOBLftOs51RwoQ", "user": { "login": "personalizedrefrigerator", "id": 46334387, "node_id": "MDQ6VXNlcjQ2MzM0Mzg3", "avatar_url": "https://avatars.githubusercontent.com/u/46334387?v=4", "gravatar_id": "", "url": "https://api.github.com/users/personalizedrefrigerator", "html_url": "https://github.com/personalizedrefrigerator", "followers_url": "https://api.github.com/users/personalizedrefrigerator/followers", "following_url": "https://api.github.com/users/personalizedrefrigerator/following{/other_user}", "gists_url": "https://api.github.com/users/personalizedrefrigerator/gists{/gist_id}", "starred_url": "https://api.github.com/users/personalizedrefrigerator/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/personalizedrefrigerator/subscriptions", "organizations_url": "https://api.github.com/users/personalizedrefrigerator/orgs", "repos_url": "https://api.github.com/users/personalizedrefrigerator/repos", "events_url": "https://api.github.com/users/personalizedrefrigerator/events{/privacy}", "received_events_url": "https://api.github.com/users/personalizedrefrigerator/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-02-27T21:07:08Z", "updated_at": "2024-02-27T21:08:28Z", "author_association": "COLLABORATOR", "body": "While this fixes the issue in the legacy CodeMirror 5-based markdown editor, the issue is still present in the CodeMirror 6-based editor.\r\n\r\nTo make this work, I suspect that additional command declarations will have to be added here:\r\n\r\nhttps://github.com/laurent22/joplin/blob/40ae03c4389f024347dfb5066b60faf3be85dc6d/packages/editor/CodeMirror/editorCommands/editorCommands.ts#L15\r\n\r\nAlternatively, to also support mobile, the beta editor keyboard shortcuts could be added here:\r\n\r\nhttps://github.com/laurent22/joplin/blob/40ae03c4389f024347dfb5066b60faf3be85dc6d/packages/editor/CodeMirror/createEditor.ts#L263\r\n\r\nThank you for working on this!", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1967589904/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1969043021", "html_url": "https://github.com/laurent22/joplin/pull/10003#issuecomment-1969043021", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10003", "id": 1969043021, "node_id": "IC_kwDOBLftOs51XTZN", "user": { "login": "cagnusmarlsen", "id": 91818868, "node_id": "U_kgDOBXkLdA", "avatar_url": "https://avatars.githubusercontent.com/u/91818868?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cagnusmarlsen", "html_url": "https://github.com/cagnusmarlsen", "followers_url": "https://api.github.com/users/cagnusmarlsen/followers", "following_url": "https://api.github.com/users/cagnusmarlsen/following{/other_user}", "gists_url": "https://api.github.com/users/cagnusmarlsen/gists{/gist_id}", "starred_url": "https://api.github.com/users/cagnusmarlsen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cagnusmarlsen/subscriptions", "organizations_url": "https://api.github.com/users/cagnusmarlsen/orgs", "repos_url": "https://api.github.com/users/cagnusmarlsen/repos", "events_url": "https://api.github.com/users/cagnusmarlsen/events{/privacy}", "received_events_url": "https://api.github.com/users/cagnusmarlsen/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-02-28T13:58:28Z", "updated_at": "2024-02-28T13:58:28Z", "author_association": "CONTRIBUTOR", "body": "Thank you for the help. I've added the necessary shortcut to [joplin/packages/editor/CodeMirror/createEditor.ts](https://github.com/laurent22/joplin/blob/40ae03c4389f024347dfb5066b60faf3be85dc6d/packages/editor/CodeMirror/createEditor.ts#L263). Now works for both the editors.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1969043021/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1973027572", "html_url": "https://github.com/laurent22/joplin/pull/10003#issuecomment-1973027572", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10003", "id": 1973027572, "node_id": "IC_kwDOBLftOs51mgL0", "user": { "login": "cagnusmarlsen", "id": 91818868, "node_id": "U_kgDOBXkLdA", "avatar_url": "https://avatars.githubusercontent.com/u/91818868?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cagnusmarlsen", "html_url": "https://github.com/cagnusmarlsen", "followers_url": "https://api.github.com/users/cagnusmarlsen/followers", "following_url": "https://api.github.com/users/cagnusmarlsen/following{/other_user}", "gists_url": "https://api.github.com/users/cagnusmarlsen/gists{/gist_id}", "starred_url": "https://api.github.com/users/cagnusmarlsen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cagnusmarlsen/subscriptions", "organizations_url": "https://api.github.com/users/cagnusmarlsen/orgs", "repos_url": "https://api.github.com/users/cagnusmarlsen/repos", "events_url": "https://api.github.com/users/cagnusmarlsen/events{/privacy}", "received_events_url": "https://api.github.com/users/cagnusmarlsen/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-01T11:34:42Z", "updated_at": "2024-03-01T11:36:26Z", "author_association": "CONTRIBUTOR", "body": "@PackElend label me please\r\n\r\nLink to introduction - https://discourse.joplinapp.org/t/introducing-marlsen/36358", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1973027572/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }