{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/8126", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/8126/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/8126/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/8126/events", "html_url": "https://github.com/laurent22/joplin/pull/8126", "id": 1695523855, "node_id": "PR_kwDOBLftOs5PwGWz", "number": 8126, "title": "Desktop: Improve sidebar workaround for Linux w/Intel GPU", "user": { "login": "cas--", "id": 606038, "node_id": "MDQ6VXNlcjYwNjAzOA==", "avatar_url": "https://avatars.githubusercontent.com/u/606038?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cas--", "html_url": "https://github.com/cas--", "followers_url": "https://api.github.com/users/cas--/followers", "following_url": "https://api.github.com/users/cas--/following{/other_user}", "gists_url": "https://api.github.com/users/cas--/gists{/gist_id}", "starred_url": "https://api.github.com/users/cas--/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cas--/subscriptions", "organizations_url": "https://api.github.com/users/cas--/orgs", "repos_url": "https://api.github.com/users/cas--/repos", "events_url": "https://api.github.com/users/cas--/events{/privacy}", "received_events_url": "https://api.github.com/users/cas--/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": true, "assignee": null, "assignees": [], "milestone": null, "comments": 8, "created_at": "2023-05-04T08:34:26Z", "updated_at": "2023-05-29T10:20:24Z", "closed_at": "2023-05-29T10:20:13Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/8126", "html_url": "https://github.com/laurent22/joplin/pull/8126", "diff_url": "https://github.com/laurent22/joplin/pull/8126.diff", "patch_url": "https://github.com/laurent22/joplin/pull/8126.patch", "merged_at": "2023-05-29T10:20:13Z" }, "body": "Previous fixes set an opacity value of 1 which affects the sidebar styling for Linux users.\r\n\r\nThe problem of corrupted text in the sidebar seems to be related to stacking contexts therefore using `position: relative` to create a new one for affected text elements is an alternative workaround that has no effect on styling.\r\n\r\nRef: https://github.com/laurent22/joplin/issues/7506\r\nRef: https://github.com/laurent22/joplin/issues/8000", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/8126/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/8126/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1534302644", "html_url": "https://github.com/laurent22/joplin/pull/8126#issuecomment-1534302644", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8126", "id": 1534302644, "node_id": "IC_kwDOBLftOs5bc5m0", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-04T08:34:40Z", "updated_at": "2023-05-04T08:44:37Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1534302644/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1534317297", "html_url": "https://github.com/laurent22/joplin/pull/8126#issuecomment-1534317297", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8126", "id": 1534317297, "node_id": "IC_kwDOBLftOs5bc9Lx", "user": { "login": "cas--", "id": 606038, "node_id": "MDQ6VXNlcjYwNjAzOA==", "avatar_url": "https://avatars.githubusercontent.com/u/606038?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cas--", "html_url": "https://github.com/cas--", "followers_url": "https://api.github.com/users/cas--/followers", "following_url": "https://api.github.com/users/cas--/following{/other_user}", "gists_url": "https://api.github.com/users/cas--/gists{/gist_id}", "starred_url": "https://api.github.com/users/cas--/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cas--/subscriptions", "organizations_url": "https://api.github.com/users/cas--/orgs", "repos_url": "https://api.github.com/users/cas--/repos", "events_url": "https://api.github.com/users/cas--/events{/privacy}", "received_events_url": "https://api.github.com/users/cas--/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-04T08:41:49Z", "updated_at": "2023-05-04T08:41:49Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1534317297/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1534317632", "html_url": "https://github.com/laurent22/joplin/pull/8126#issuecomment-1534317632", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8126", "id": 1534317632, "node_id": "IC_kwDOBLftOs5bc9RA", "user": { "login": "cas--", "id": 606038, "node_id": "MDQ6VXNlcjYwNjAzOA==", "avatar_url": "https://avatars.githubusercontent.com/u/606038?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cas--", "html_url": "https://github.com/cas--", "followers_url": "https://api.github.com/users/cas--/followers", "following_url": "https://api.github.com/users/cas--/following{/other_user}", "gists_url": "https://api.github.com/users/cas--/gists{/gist_id}", "starred_url": "https://api.github.com/users/cas--/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cas--/subscriptions", "organizations_url": "https://api.github.com/users/cas--/orgs", "repos_url": "https://api.github.com/users/cas--/repos", "events_url": "https://api.github.com/users/cas--/events{/privacy}", "received_events_url": "https://api.github.com/users/cas--/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-04T08:42:05Z", "updated_at": "2023-05-04T08:42:05Z", "author_association": "CONTRIBUTOR", "body": "recheck", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1534317632/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1534398985", "html_url": "https://github.com/laurent22/joplin/pull/8126#issuecomment-1534398985", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8126", "id": 1534398985, "node_id": "IC_kwDOBLftOs5bdRIJ", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-04T09:30:54Z", "updated_at": "2023-05-04T09:30:54Z", "author_association": "OWNER", "body": "Are you sure that would fix the issue of corrupted text?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1534398985/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1534435739", "html_url": "https://github.com/laurent22/joplin/pull/8126#issuecomment-1534435739", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8126", "id": 1534435739, "node_id": "IC_kwDOBLftOs5bdaGb", "user": { "login": "cas--", "id": 606038, "node_id": "MDQ6VXNlcjYwNjAzOA==", "avatar_url": "https://avatars.githubusercontent.com/u/606038?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cas--", "html_url": "https://github.com/cas--", "followers_url": "https://api.github.com/users/cas--/followers", "following_url": "https://api.github.com/users/cas--/following{/other_user}", "gists_url": "https://api.github.com/users/cas--/gists{/gist_id}", "starred_url": "https://api.github.com/users/cas--/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cas--/subscriptions", "organizations_url": "https://api.github.com/users/cas--/orgs", "repos_url": "https://api.github.com/users/cas--/repos", "events_url": "https://api.github.com/users/cas--/events{/privacy}", "received_events_url": "https://api.github.com/users/cas--/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-04T09:48:30Z", "updated_at": "2023-05-04T09:48:30Z", "author_association": "CONTRIBUTOR", "body": "Absolutely this fixes the issue, replicated it here and faced the same problem with Logseq (https://github.com/logseq/logseq/pull/9286) where I initially started with changing opacity until we found that any stacking context change would resolve it. \r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1534435739/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1549438625", "html_url": "https://github.com/laurent22/joplin/pull/8126#issuecomment-1549438625", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8126", "id": 1549438625, "node_id": "IC_kwDOBLftOs5cWo6h", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-16T10:54:58Z", "updated_at": "2023-05-16T10:54:58Z", "author_association": "OWNER", "body": "Based on this comment it looks like there's a simpler fix?\r\n\r\nhttps://github.com/laurent22/joplin/issues/7506#issuecomment-1537829206\r\n\r\nAre you able to confirm that it fixes the issue on your computer?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1549438625/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1549517893", "html_url": "https://github.com/laurent22/joplin/pull/8126#issuecomment-1549517893", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8126", "id": 1549517893, "node_id": "IC_kwDOBLftOs5cW8RF", "user": { "login": "cas--", "id": 606038, "node_id": "MDQ6VXNlcjYwNjAzOA==", "avatar_url": "https://avatars.githubusercontent.com/u/606038?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cas--", "html_url": "https://github.com/cas--", "followers_url": "https://api.github.com/users/cas--/followers", "following_url": "https://api.github.com/users/cas--/following{/other_user}", "gists_url": "https://api.github.com/users/cas--/gists{/gist_id}", "starred_url": "https://api.github.com/users/cas--/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cas--/subscriptions", "organizations_url": "https://api.github.com/users/cas--/orgs", "repos_url": "https://api.github.com/users/cas--/repos", "events_url": "https://api.github.com/users/cas--/events{/privacy}", "received_events_url": "https://api.github.com/users/cas--/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-16T11:53:13Z", "updated_at": "2023-05-16T11:53:13Z", "author_association": "CONTRIBUTOR", "body": "> Based on this comment it looks like there's a simpler fix?\r\n\r\nAs I already explained, everyone trying to use opacity 1 are degrading the intended opacity of menu items for Linux users vs other OS users.\r\n\r\nMy changes are intended to keep the opacity 0.9 and only apply to those elements that actually are affected.\r\n", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1549517893/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1566919734", "html_url": "https://github.com/laurent22/joplin/pull/8126#issuecomment-1566919734", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/8126", "id": 1566919734, "node_id": "IC_kwDOBLftOs5dZUw2", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-05-29T10:19:51Z", "updated_at": "2023-05-29T10:19:51Z", "author_association": "OWNER", "body": "Ok let's merge as it seems to be a complex issue on Chromium and/or Electron and not clear when it will be fixed (and when we'll upgrade).", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1566919734/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }