{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10137", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/10137/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/10137/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/10137/events", "html_url": "https://github.com/laurent22/joplin/pull/10137", "id": 2189818663, "node_id": "PR_kwDOBLftOs5p0S2m", "number": 10137, "title": "Desktop: Fixes #10108: Fixed focus not setting correctly on body", "user": { "login": "chaNcharge", "id": 11594018, "node_id": "MDQ6VXNlcjExNTk0MDE4", "avatar_url": "https://avatars.githubusercontent.com/u/11594018?v=4", "gravatar_id": "", "url": "https://api.github.com/users/chaNcharge", "html_url": "https://github.com/chaNcharge", "followers_url": "https://api.github.com/users/chaNcharge/followers", "following_url": "https://api.github.com/users/chaNcharge/following{/other_user}", "gists_url": "https://api.github.com/users/chaNcharge/gists{/gist_id}", "starred_url": "https://api.github.com/users/chaNcharge/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chaNcharge/subscriptions", "organizations_url": "https://api.github.com/users/chaNcharge/orgs", "repos_url": "https://api.github.com/users/chaNcharge/repos", "events_url": "https://api.github.com/users/chaNcharge/events{/privacy}", "received_events_url": "https://api.github.com/users/chaNcharge/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 6, "created_at": "2024-03-16T06:36:24Z", "updated_at": "2024-04-01T20:56:41Z", "closed_at": "2024-04-01T15:52:42Z", "author_association": "CONTRIBUTOR", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/10137", "html_url": "https://github.com/laurent22/joplin/pull/10137", "diff_url": "https://github.com/laurent22/joplin/pull/10137.diff", "patch_url": "https://github.com/laurent22/joplin/pull/10137.patch", "merged_at": null }, "body": "\r\n\r\nThis fixes the issue #10108 regarding focus not setting correctly when a new note or todo is created. After further testing, I concluded that the issue only occurs when a todo or note is set to focus on the body in Settings, and only when it is the first note in an empty notebook. This was caused by the editorRef being undefined due to CodeMirror not being rendered at the time of note creation. However, a comment stated that this also occurs when the new todo or new note button is clicked twice, but I'm unsure if this was intentional or not, so this was not considered in this PR. Apologies if the solution is a little messy, feedback on code quality would be appreciated if it could be improved. ", "closed_by": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/10137/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/10137/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2001858261", "html_url": "https://github.com/laurent22/joplin/pull/10137#issuecomment-2001858261", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10137", "id": 2001858261, "node_id": "IC_kwDOBLftOs53Ue7V", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-16T06:36:37Z", "updated_at": "2024-04-01T15:52:59Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2001858261/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2001859079", "html_url": "https://github.com/laurent22/joplin/pull/10137#issuecomment-2001859079", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10137", "id": 2001859079, "node_id": "IC_kwDOBLftOs53UfIH", "user": { "login": "chaNcharge", "id": 11594018, "node_id": "MDQ6VXNlcjExNTk0MDE4", "avatar_url": "https://avatars.githubusercontent.com/u/11594018?v=4", "gravatar_id": "", "url": "https://api.github.com/users/chaNcharge", "html_url": "https://github.com/chaNcharge", "followers_url": "https://api.github.com/users/chaNcharge/followers", "following_url": "https://api.github.com/users/chaNcharge/following{/other_user}", "gists_url": "https://api.github.com/users/chaNcharge/gists{/gist_id}", "starred_url": "https://api.github.com/users/chaNcharge/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chaNcharge/subscriptions", "organizations_url": "https://api.github.com/users/chaNcharge/orgs", "repos_url": "https://api.github.com/users/chaNcharge/repos", "events_url": "https://api.github.com/users/chaNcharge/events{/privacy}", "received_events_url": "https://api.github.com/users/chaNcharge/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-16T06:37:08Z", "updated_at": "2024-03-16T06:37:08Z", "author_association": "CONTRIBUTOR", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2001859079/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2001861564", "html_url": "https://github.com/laurent22/joplin/pull/10137#issuecomment-2001861564", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10137", "id": 2001861564, "node_id": "IC_kwDOBLftOs53Ufu8", "user": { "login": "chaNcharge", "id": 11594018, "node_id": "MDQ6VXNlcjExNTk0MDE4", "avatar_url": "https://avatars.githubusercontent.com/u/11594018?v=4", "gravatar_id": "", "url": "https://api.github.com/users/chaNcharge", "html_url": "https://github.com/chaNcharge", "followers_url": "https://api.github.com/users/chaNcharge/followers", "following_url": "https://api.github.com/users/chaNcharge/following{/other_user}", "gists_url": "https://api.github.com/users/chaNcharge/gists{/gist_id}", "starred_url": "https://api.github.com/users/chaNcharge/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chaNcharge/subscriptions", "organizations_url": "https://api.github.com/users/chaNcharge/orgs", "repos_url": "https://api.github.com/users/chaNcharge/repos", "events_url": "https://api.github.com/users/chaNcharge/events{/privacy}", "received_events_url": "https://api.github.com/users/chaNcharge/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-16T06:38:30Z", "updated_at": "2024-03-16T06:38:30Z", "author_association": "CONTRIBUTOR", "body": "Please add the GSOC-2024 label on this PR as well. My name is Ethan, and you can read my introduction [here](https://discourse.joplinapp.org/t/introducing-ethan/36755)", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2001861564/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2028030118", "html_url": "https://github.com/laurent22/joplin/pull/10137#issuecomment-2028030118", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10137", "id": 2028030118, "node_id": "IC_kwDOBLftOs544Uim", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-30T12:08:06Z", "updated_at": "2024-03-30T12:08:06Z", "author_association": "OWNER", "body": "Just to be sure: do you want to keep working on this or should I close the pull request?", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2028030118/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2028486008", "html_url": "https://github.com/laurent22/joplin/pull/10137#issuecomment-2028486008", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10137", "id": 2028486008, "node_id": "IC_kwDOBLftOs546D14", "user": { "login": "chaNcharge", "id": 11594018, "node_id": "MDQ6VXNlcjExNTk0MDE4", "avatar_url": "https://avatars.githubusercontent.com/u/11594018?v=4", "gravatar_id": "", "url": "https://api.github.com/users/chaNcharge", "html_url": "https://github.com/chaNcharge", "followers_url": "https://api.github.com/users/chaNcharge/followers", "following_url": "https://api.github.com/users/chaNcharge/following{/other_user}", "gists_url": "https://api.github.com/users/chaNcharge/gists{/gist_id}", "starred_url": "https://api.github.com/users/chaNcharge/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chaNcharge/subscriptions", "organizations_url": "https://api.github.com/users/chaNcharge/orgs", "repos_url": "https://api.github.com/users/chaNcharge/repos", "events_url": "https://api.github.com/users/chaNcharge/events{/privacy}", "received_events_url": "https://api.github.com/users/chaNcharge/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-03-30T22:37:57Z", "updated_at": "2024-03-30T22:37:57Z", "author_association": "CONTRIBUTOR", "body": "I think I will keep working on this for up to another week or so before I close it myself to see if I can find anything but if you find something before I do, feel free to share it and close this. ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2028486008/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2030039660", "html_url": "https://github.com/laurent22/joplin/pull/10137#issuecomment-2030039660", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/10137", "id": 2030039660, "node_id": "IC_kwDOBLftOs54__Js", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-04-01T15:52:43Z", "updated_at": "2024-04-01T15:52:43Z", "author_association": "OWNER", "body": "This has now been fixed in f60e105d7749f77f2ecc501a60c7d0c79033b96a", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2030039660/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }