{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7955", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/7955/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/7955/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/7955/events", "html_url": "https://github.com/laurent22/joplin/pull/7955", "id": 1635391615, "node_id": "PR_kwDOBLftOs5Mn55_", "number": 7955, "title": "Desktop: Add note toolbar button to trigger editor full screen", "user": { "login": "chenqy9", "id": 10264688, "node_id": "MDQ6VXNlcjEwMjY0Njg4", "avatar_url": "https://avatars.githubusercontent.com/u/10264688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/chenqy9", "html_url": "https://github.com/chenqy9", "followers_url": "https://api.github.com/users/chenqy9/followers", "following_url": "https://api.github.com/users/chenqy9/following{/other_user}", "gists_url": "https://api.github.com/users/chenqy9/gists{/gist_id}", "starred_url": "https://api.github.com/users/chenqy9/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chenqy9/subscriptions", "organizations_url": "https://api.github.com/users/chenqy9/orgs", "repos_url": "https://api.github.com/users/chenqy9/repos", "events_url": "https://api.github.com/users/chenqy9/events{/privacy}", "received_events_url": "https://api.github.com/users/chenqy9/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": true, "assignee": null, "assignees": [], "milestone": null, "comments": 3, "created_at": "2023-03-22T09:36:17Z", "updated_at": "2023-03-23T07:55:18Z", "closed_at": "2023-03-23T07:11:38Z", "author_association": "NONE", "sub_issues_summary": { "total": 0, "completed": 0, "percent_completed": 0 }, "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/7955", "html_url": "https://github.com/laurent22/joplin/pull/7955", "diff_url": "https://github.com/laurent22/joplin/pull/7955.diff", "patch_url": "https://github.com/laurent22/joplin/pull/7955.patch", "merged_at": null }, "body": null, "closed_by": { "login": "chenqy9", "id": 10264688, "node_id": "MDQ6VXNlcjEwMjY0Njg4", "avatar_url": "https://avatars.githubusercontent.com/u/10264688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/chenqy9", "html_url": "https://github.com/chenqy9", "followers_url": "https://api.github.com/users/chenqy9/followers", "following_url": "https://api.github.com/users/chenqy9/following{/other_user}", "gists_url": "https://api.github.com/users/chenqy9/gists{/gist_id}", "starred_url": "https://api.github.com/users/chenqy9/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chenqy9/subscriptions", "organizations_url": "https://api.github.com/users/chenqy9/orgs", "repos_url": "https://api.github.com/users/chenqy9/repos", "events_url": "https://api.github.com/users/chenqy9/events{/privacy}", "received_events_url": "https://api.github.com/users/chenqy9/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/7955/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/7955/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1479213462", "html_url": "https://github.com/laurent22/joplin/pull/7955#issuecomment-1479213462", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7955", "id": 1479213462, "node_id": "IC_kwDOBLftOs5YKwGW", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2023-03-22T09:36:34Z", "updated_at": "2023-03-23T07:04:31Z", "author_association": "CONTRIBUTOR", "body": "**CLA Assistant Lite bot:**
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our [Contributor License Agreement](https://github.com/laurent22/joplin/blob/dev/readme/cla.md) before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.
\n - - -\n I have read the CLA Document and I hereby sign the CLA\n - - -\n **1** out of **2** committers have signed the CLA.
:white_check_mark: @chenqy9
:x: @qingyaochen
**qingyaochen** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).
You can retrigger this bot by commenting **recheck** in this Pull Request", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1479213462/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1480112062", "html_url": "https://github.com/laurent22/joplin/pull/7955#issuecomment-1480112062", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7955", "id": 1480112062, "node_id": "IC_kwDOBLftOs5YOLe-", "user": { "login": "laurent22", "id": 1285584, "node_id": "MDQ6VXNlcjEyODU1ODQ=", "avatar_url": "https://avatars.githubusercontent.com/u/1285584?v=4", "gravatar_id": "", "url": "https://api.github.com/users/laurent22", "html_url": "https://github.com/laurent22", "followers_url": "https://api.github.com/users/laurent22/followers", "following_url": "https://api.github.com/users/laurent22/following{/other_user}", "gists_url": "https://api.github.com/users/laurent22/gists{/gist_id}", "starred_url": "https://api.github.com/users/laurent22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/laurent22/subscriptions", "organizations_url": "https://api.github.com/users/laurent22/orgs", "repos_url": "https://api.github.com/users/laurent22/repos", "events_url": "https://api.github.com/users/laurent22/events{/privacy}", "received_events_url": "https://api.github.com/users/laurent22/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-03-22T19:04:32Z", "updated_at": "2023-03-22T19:04:32Z", "author_association": "OWNER", "body": "@chenqy9, you need to sign the CLA. And I think you need to sign with your two usernames because you've used two for this commit", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1480112062/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1480694759", "html_url": "https://github.com/laurent22/joplin/pull/7955#issuecomment-1480694759", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/7955", "id": 1480694759, "node_id": "IC_kwDOBLftOs5YQZvn", "user": { "login": "chenqy9", "id": 10264688, "node_id": "MDQ6VXNlcjEwMjY0Njg4", "avatar_url": "https://avatars.githubusercontent.com/u/10264688?v=4", "gravatar_id": "", "url": "https://api.github.com/users/chenqy9", "html_url": "https://github.com/chenqy9", "followers_url": "https://api.github.com/users/chenqy9/followers", "following_url": "https://api.github.com/users/chenqy9/following{/other_user}", "gists_url": "https://api.github.com/users/chenqy9/gists{/gist_id}", "starred_url": "https://api.github.com/users/chenqy9/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chenqy9/subscriptions", "organizations_url": "https://api.github.com/users/chenqy9/orgs", "repos_url": "https://api.github.com/users/chenqy9/repos", "events_url": "https://api.github.com/users/chenqy9/events{/privacy}", "received_events_url": "https://api.github.com/users/chenqy9/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2023-03-23T07:04:15Z", "updated_at": "2023-03-23T07:04:15Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/1480694759/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }