{ "issue": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11559", "repository_url": "https://api.github.com/repos/laurent22/joplin", "labels_url": "https://api.github.com/repos/laurent22/joplin/issues/11559/labels{/name}", "comments_url": "https://api.github.com/repos/laurent22/joplin/issues/11559/comments", "events_url": "https://api.github.com/repos/laurent22/joplin/issues/11559/events", "html_url": "https://github.com/laurent22/joplin/pull/11559", "id": 2759078266, "node_id": "PR_kwDOBLftOs6GOCDM", "number": 11559, "title": "Mobile, Desktop: Ukrainian translation", "user": { "login": "click0", "id": 396824, "node_id": "MDQ6VXNlcjM5NjgyNA==", "avatar_url": "https://avatars.githubusercontent.com/u/396824?v=4", "gravatar_id": "", "url": "https://api.github.com/users/click0", "html_url": "https://github.com/click0", "followers_url": "https://api.github.com/users/click0/followers", "following_url": "https://api.github.com/users/click0/following{/other_user}", "gists_url": "https://api.github.com/users/click0/gists{/gist_id}", "starred_url": "https://api.github.com/users/click0/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/click0/subscriptions", "organizations_url": "https://api.github.com/users/click0/orgs", "repos_url": "https://api.github.com/users/click0/repos", "events_url": "https://api.github.com/users/click0/events{/privacy}", "received_events_url": "https://api.github.com/users/click0/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "labels": [], "state": "closed", "locked": false, "assignee": null, "assignees": [], "milestone": null, "comments": 6, "created_at": "2024-12-25T20:08:21Z", "updated_at": "2024-12-30T16:07:05Z", "closed_at": "2024-12-30T16:06:51Z", "author_association": "NONE", "active_lock_reason": null, "draft": false, "pull_request": { "url": "https://api.github.com/repos/laurent22/joplin/pulls/11559", "html_url": "https://github.com/laurent22/joplin/pull/11559", "diff_url": "https://github.com/laurent22/joplin/pull/11559.diff", "patch_url": "https://github.com/laurent22/joplin/pull/11559.patch", "merged_at": null }, "body": "1. Minor translation errors have been fixed.\r\n2. Added missing translation phrases.\r\n3. Added translation for Android application.\r\n", "closed_by": { "login": "click0", "id": 396824, "node_id": "MDQ6VXNlcjM5NjgyNA==", "avatar_url": "https://avatars.githubusercontent.com/u/396824?v=4", "gravatar_id": "", "url": "https://api.github.com/users/click0", "html_url": "https://github.com/click0", "followers_url": "https://api.github.com/users/click0/followers", "following_url": "https://api.github.com/users/click0/following{/other_user}", "gists_url": "https://api.github.com/users/click0/gists{/gist_id}", "starred_url": "https://api.github.com/users/click0/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/click0/subscriptions", "organizations_url": "https://api.github.com/users/click0/orgs", "repos_url": "https://api.github.com/users/click0/repos", "events_url": "https://api.github.com/users/click0/events{/privacy}", "received_events_url": "https://api.github.com/users/click0/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/11559/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "timeline_url": "https://api.github.com/repos/laurent22/joplin/issues/11559/timeline", "performed_via_github_app": null, "state_reason": null }, "comments": [ { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2561990382", "html_url": "https://github.com/laurent22/joplin/pull/11559#issuecomment-2561990382", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11559", "id": 2561990382, "node_id": "IC_kwDOBLftOs6YtN7u", "user": { "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }, "created_at": "2024-12-25T20:08:35Z", "updated_at": "2024-12-30T16:07:05Z", "author_association": "CONTRIBUTOR", "body": "****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2561990382/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": { "id": 15368, "client_id": "Iv1.05c79e9ad1f6bdfa", "slug": "github-actions", "node_id": "MDM6QXBwMTUzNjg=", "owner": { "login": "github", "id": 9919, "node_id": "MDEyOk9yZ2FuaXphdGlvbjk5MTk=", "avatar_url": "https://avatars.githubusercontent.com/u/9919?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github", "html_url": "https://github.com/github", "followers_url": "https://api.github.com/users/github/followers", "following_url": "https://api.github.com/users/github/following{/other_user}", "gists_url": "https://api.github.com/users/github/gists{/gist_id}", "starred_url": "https://api.github.com/users/github/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github/subscriptions", "organizations_url": "https://api.github.com/users/github/orgs", "repos_url": "https://api.github.com/users/github/repos", "events_url": "https://api.github.com/users/github/events{/privacy}", "received_events_url": "https://api.github.com/users/github/received_events", "type": "Organization", "user_view_type": "public", "site_admin": false }, "name": "GitHub Actions", "description": "Automate your workflow from idea to production", "external_url": "https://help.github.com/en/actions", "html_url": "https://github.com/apps/github-actions", "created_at": "2018-07-30T09:30:17Z", "updated_at": "2025-03-07T16:35:00Z", "permissions": { "actions": "write", "administration": "read", "attestations": "write", "checks": "write", "contents": "write", "deployments": "write", "discussions": "write", "issues": "write", "merge_queues": "write", "metadata": "read", "models": "read", "packages": "write", "pages": "write", "pull_requests": "write", "repository_hooks": "write", "repository_projects": "write", "security_events": "write", "statuses": "write", "vulnerability_alerts": "read" }, "events": [ "branch_protection_rule", "check_run", "check_suite", "create", "delete", "deployment", "deployment_status", "discussion", "discussion_comment", "fork", "gollum", "issues", "issue_comment", "label", "merge_group", "milestone", "page_build", "project", "project_card", "project_column", "public", "pull_request", "pull_request_review", "pull_request_review_comment", "push", "registry_package", "release", "repository", "repository_dispatch", "status", "watch", "workflow_dispatch", "workflow_run" ] } }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2561991202", "html_url": "https://github.com/laurent22/joplin/pull/11559#issuecomment-2561991202", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11559", "id": 2561991202, "node_id": "IC_kwDOBLftOs6YtOIi", "user": { "login": "click0", "id": 396824, "node_id": "MDQ6VXNlcjM5NjgyNA==", "avatar_url": "https://avatars.githubusercontent.com/u/396824?v=4", "gravatar_id": "", "url": "https://api.github.com/users/click0", "html_url": "https://github.com/click0", "followers_url": "https://api.github.com/users/click0/followers", "following_url": "https://api.github.com/users/click0/following{/other_user}", "gists_url": "https://api.github.com/users/click0/gists{/gist_id}", "starred_url": "https://api.github.com/users/click0/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/click0/subscriptions", "organizations_url": "https://api.github.com/users/click0/orgs", "repos_url": "https://api.github.com/users/click0/repos", "events_url": "https://api.github.com/users/click0/events{/privacy}", "received_events_url": "https://api.github.com/users/click0/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-12-25T20:13:09Z", "updated_at": "2024-12-25T20:13:09Z", "author_association": "NONE", "body": "I have read the CLA Document and I hereby sign the CLA", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2561991202/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2564694764", "html_url": "https://github.com/laurent22/joplin/pull/11559#issuecomment-2564694764", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11559", "id": 2564694764, "node_id": "IC_kwDOBLftOs6Y3iLs", "user": { "login": "click0", "id": 396824, "node_id": "MDQ6VXNlcjM5NjgyNA==", "avatar_url": "https://avatars.githubusercontent.com/u/396824?v=4", "gravatar_id": "", "url": "https://api.github.com/users/click0", "html_url": "https://github.com/click0", "followers_url": "https://api.github.com/users/click0/followers", "following_url": "https://api.github.com/users/click0/following{/other_user}", "gists_url": "https://api.github.com/users/click0/gists{/gist_id}", "starred_url": "https://api.github.com/users/click0/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/click0/subscriptions", "organizations_url": "https://api.github.com/users/click0/orgs", "repos_url": "https://api.github.com/users/click0/repos", "events_url": "https://api.github.com/users/click0/events{/privacy}", "received_events_url": "https://api.github.com/users/click0/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-12-29T11:32:05Z", "updated_at": "2024-12-29T11:32:05Z", "author_association": "NONE", "body": "> As explained in the docs https://joplinapp.org/help/dev/localisation the .po file has to be changed with Poedit.\r\n> \r\n> The json files are generated and thus must not be edited.\r\n\r\nToo bad.\r\nWe'll have to convert the data from .json to .po ...", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2564694764/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2564832904", "html_url": "https://github.com/laurent22/joplin/pull/11559#issuecomment-2564832904", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11559", "id": 2564832904, "node_id": "IC_kwDOBLftOs6Y4D6I", "user": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-12-29T20:36:07Z", "updated_at": "2024-12-29T20:37:12Z", "author_association": "COLLABORATOR", "body": "I am also not so sure about the 2 text files. I have never seen them added by a translation PR. Did you talk to Laurent or clarify that in the forum?\r\n\r\nYou can have a look at previous translation PRs: https://github.com/laurent22/joplin/pulls?q=is%3Apr+label%3Atranslation+is%3Aclosed", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2564832904/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2564856022", "html_url": "https://github.com/laurent22/joplin/pull/11559#issuecomment-2564856022", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11559", "id": 2564856022, "node_id": "IC_kwDOBLftOs6Y4JjW", "user": { "login": "click0", "id": 396824, "node_id": "MDQ6VXNlcjM5NjgyNA==", "avatar_url": "https://avatars.githubusercontent.com/u/396824?v=4", "gravatar_id": "", "url": "https://api.github.com/users/click0", "html_url": "https://github.com/click0", "followers_url": "https://api.github.com/users/click0/followers", "following_url": "https://api.github.com/users/click0/following{/other_user}", "gists_url": "https://api.github.com/users/click0/gists{/gist_id}", "starred_url": "https://api.github.com/users/click0/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/click0/subscriptions", "organizations_url": "https://api.github.com/users/click0/orgs", "repos_url": "https://api.github.com/users/click0/repos", "events_url": "https://api.github.com/users/click0/events{/privacy}", "received_events_url": "https://api.github.com/users/click0/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-12-29T22:37:28Z", "updated_at": "2024-12-29T22:37:28Z", "author_association": "NONE", "body": "I still see discrepancies in the original phrases between the .json and .po files. \r\nIt seems that they were not added to the .po files.\r\n\r\n> Did you talk to Laurent or clarify that in the forum?\r\nI try not to communicate on forums.\r\n\r\nP.S. I switched to other projects for translation.", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2564856022/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null }, { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2564861376", "html_url": "https://github.com/laurent22/joplin/pull/11559#issuecomment-2564861376", "issue_url": "https://api.github.com/repos/laurent22/joplin/issues/11559", "id": 2564861376, "node_id": "IC_kwDOBLftOs6Y4K3A", "user": { "login": "tessus", "id": 223439, "node_id": "MDQ6VXNlcjIyMzQzOQ==", "avatar_url": "https://avatars.githubusercontent.com/u/223439?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tessus", "html_url": "https://github.com/tessus", "followers_url": "https://api.github.com/users/tessus/followers", "following_url": "https://api.github.com/users/tessus/following{/other_user}", "gists_url": "https://api.github.com/users/tessus/gists{/gist_id}", "starred_url": "https://api.github.com/users/tessus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tessus/subscriptions", "organizations_url": "https://api.github.com/users/tessus/orgs", "repos_url": "https://api.github.com/users/tessus/repos", "events_url": "https://api.github.com/users/tessus/events{/privacy}", "received_events_url": "https://api.github.com/users/tessus/received_events", "type": "User", "user_view_type": "public", "site_admin": false }, "created_at": "2024-12-29T23:06:07Z", "updated_at": "2024-12-29T23:06:07Z", "author_association": "COLLABORATOR", "body": "> I still see discrepancies in the original phrases between the .json and .po files.\r\n> It seems that they were not added to the .po files.\r\n\r\nI think you got it backwards. The .po files are the source. The json files are generated from the .po files. If there are phrases in the json files that are not in the .po file, iy means those have been removed in newer code. ", "reactions": { "url": "https://api.github.com/repos/laurent22/joplin/issues/comments/2564861376/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }, "performed_via_github_app": null } ] }